GitLab

Display the name of the domain for which enrollment is recovered and
restart the browser after enrollment recovery to avoid login screen
breakage.

BUG=389481

Review URL: https://codereview.chromium.org/387403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283763 0039d316-1c4b-4281-b951-d872f2087c98

With gcc, ObserverList expands to 6-700 bytes every time it is 
iterated. By not trying to force OberservListBase to be inline
that shrinks some. clang already ignores the hints to inline 
the code and actually doesn't change a single bit in the generated
program with this change.

raw data:
Total change: -90875 bytes
==========================
  262 added, totalling +39188 bytes across 2 sources
  49 removed, totalling -27573 bytes across 16 sources
  23 grown, for a net change of +3600 bytes (34968 bytes before, 38568 bytes after) across 8 sources
  228 shrunk, for a net change of -106090 bytes (239819 bytes before, 133729 bytes after) across 53 sources

The additions is about 2-300 different flavours of ObserverListBase, 100-300 bytes each.

The savings are 200-600 bytes each every time an observer list is used. For example:

-870: content::RenderFrameImpl::didFailLoad(blink::WebLocalFrame*, blink::WebURLError const&) type=t, (was 1635 bytes, 
now 765 bytes)
-895: content::RenderFrameImpl::didFinishLoad(blink::WebLocalFrame*) type=t, (was 1646 bytes, now 751 bytes)
-583: content::WebContentsImpl::DidFailProvisionalLoadWithError(content::RenderFrameHostImpl*, FrameHostMsg_DidFailProvisionalLoadWithError_Params const&) type=t, (was 768 bytes, now 185 bytes)
-611: content::WebContentsImpl::DidStartProvisionalLoad(content::RenderFrameHostImpl*, GURL const&, bool, bool) type=t, (was 895 bytes, now 284 bytes)

BUG=394311

Review URL: https://codereview.chromium.org/396473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283762 0039d316-1c4b-4281-b951-d872f2087c98

When setting the navigationStart recorded on the browser side for
browser-initiated navigations, we need to ensure the time is lower than
the time of starting the load on the renderer side. Otherwise with heavy
clock differences between processes and particularly fast navigation
start-ups we could end up pushing the navigationStart *forward* and
hitting an assert that is being deployed in
https://codereview.chromium.org/379873002/ .

BUG=376004

Review URL: https://codereview.chromium.org/384503009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394390

Review URL: https://codereview.chromium.org/391393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283760 0039d316-1c4b-4281-b951-d872f2087c98

It is assumed that no indexes exist before.

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDiskTest.*"

Review URL: https://codereview.chromium.org/391623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283759 0039d316-1c4b-4281-b951-d872f2087c98

This mirrors a similar change to WindowTreeHostOzone.

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran with egltest

Review URL: https://codereview.chromium.org/390493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283758 0039d316-1c4b-4281-b951-d872f2087c98

The media browser tests (content and chrome) load data from media/test/data.

BUG=379314

Review URL: https://codereview.chromium.org/399693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283757 0039d316-1c4b-4281-b951-d872f2087c98

This CL should fix a memory corruption in a unit_tests which is recently introduced.
That is caused by sync task invocation after SyncFileSystemService::Shutdown.

BUG=394460
TEST=unit_tests --gtest_filter='SyncFileSystemServiceTest.*'

Review URL: https://codereview.chromium.org/395333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283756 0039d316-1c4b-4281-b951-d872f2087c98

Checks whether background is defined in IME extension manifest. And also move KeyEventDone logic from InputMethodEngine to input_ime_api.cc.

BUG=394682, 394420
TEST=Verified on linux_chromeos and Pixel device.

Review URL: https://codereview.chromium.org/400523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283755 0039d316-1c4b-4281-b951-d872f2087c98

This change fixes the SourceBufferStream unit tests so that they always
provide valid durations for buffers that it passes to SourceBufferStream.
I've also added code to SoureBufferStream to verify that it always gets
buffers with valid durations.

Minor tweaks to test expectations were needed to compensate for the
SourceBufferStream behaving differently when it got actual durations instead
of using the durations it made up. In most cases I just used the duration
the SourceBufferStream was ultimately using. In a few cases the duration
the SourceBufferStream was generating didn't make any sense so I simply
changed the expectations to match the new behavior.

This is an attempt to reland https://codereview.chromium.org/379693002/ with
appropriate crash fixes.

Review URL: https://codereview.chromium.org/393403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393815
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/393903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382301
TEST=Panel interactive_ui_tests pass

Review URL: https://codereview.chromium.org/368163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283752 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283751 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72612,370496

Review URL: https://codereview.chromium.org/397183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283750 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff titzer@chromium.org in case of problems.

TBR=titzer@chromium.org

Review URL: https://codereview.chromium.org/399043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283749 0039d316-1c4b-4281-b951-d872f2087c98

When the InterceptDownloadResourceThrottle intercepts the download request, the response might not have been received yet.
As a result, we are not sure about the mime type and and other file informations.
Using android Download Manager at this stage is premature and risky.
This change bypasses android download manager in this case.

BUG=394092

Review URL: https://codereview.chromium.org/394993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283748 0039d316-1c4b-4281-b951-d872f2087c98

chrome_template_url_service_client.cc should include
chrome/browser/history/history_notifications.h as it's using
history::URLVisitedDetails declared there.

Review URL: https://codereview.chromium.org/396313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283747 0039d316-1c4b-4281-b951-d872f2087c98

There is no direct way to copy image url through context menu by
which user can copy image url. Added an option in context menu
for image to copy image url.

BUG=394314

Review URL: https://codereview.chromium.org/398803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283746 0039d316-1c4b-4281-b951-d872f2087c98

This would be essentially harmless, but setting 'nacl arch'
in StartPageHandler means allowing embed of the hotword plugin,
which consumes memory and CPU. Because it communicates with
the hotword extension directly, this plugin is unused at all.

BUG=393321
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/395963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283745 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283744 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/3944a1d2374d2de8622b0192aa080dba6fb92c76..9d7321c9d0412779a29c4b09962e7ce12936bbc4

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/392423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283743 0039d316-1c4b-4281-b951-d872f2087c98

Adds Java version of DomDistillerService and 
DistilledPagePrefs with support for setting and retrieving
the current Theme.

The DomDistillerService can be retrieved by using the
DomDistillerServiceFactory, which maps a profile to an
instance of the service.

BUG=383630

Review URL: https://codereview.chromium.org/340403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283742 0039d316-1c4b-4281-b951-d872f2087c98

Wrapper class is currently located in the unittest file and is a friend of touch_exploration_controller.

BUG=377040

Review URL: https://codereview.chromium.org/386043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283741 0039d316-1c4b-4281-b951-d872f2087c98

Removing the include of Xlib.h makes selection_requestor.h more easily
testable. In particular, the definition of None in X.h conflicts with
that in gtest-type-util.h

This CL also adds XAtom to x11_types.h so that it does not need to be forward declared everywhere.

BUG=None
TEST=None
R=derat,danakj
TBR=dcheng (for trivial change to clipboard_aurax11.cc)

Review URL: https://codereview.chromium.org/392153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283740 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes the naming of several existing IDs.

BUG=365411

Review URL: https://codereview.chromium.org/392053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283739 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/398933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283738 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346958

Review URL: https://codereview.chromium.org/395893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283737 0039d316-1c4b-4281-b951-d872f2087c98

Where it reads = it should read |= so it keep the blacklisting mark.

TBR=tommi@chromium.org

BUG=347371

Review URL: https://codereview.chromium.org/398093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283736 0039d316-1c4b-4281-b951-d872f2087c98

> deep_memory_profiler: Replace 'WebCore' with 'blink'.
> 
> TBR=abarth@chromium.org
> 
> Review URL: https://codereview.chromium.org/400563003

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/402603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283735 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283734 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178302:178334&mode=html
TBR=falken@chromium.org,abarth@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/400523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283733 0039d316-1c4b-4281-b951-d872f2087c98

File paths can be very slow to access because finding a file by path requires
O(N) metadata access to figure out which file id corresponds to a given name.

BUG=385307

Review URL: https://codereview.chromium.org/377383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283732 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267773

Review URL: https://codereview.chromium.org/386053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283731 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove the profile service that was only used by the network
service because it couldn't access the path service on android.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/395163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283730 0039d316-1c4b-4281-b951-d872f2087c98

SelectiveAck was over confirming due to unsigned in misuse. This adds a test
that exercises the confirm logic used by SelectiveAck.

BUG=392664

Review URL: https://codereview.chromium.org/383993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283729 0039d316-1c4b-4281-b951-d872f2087c98

Unlike the other kinds of errors which are detected earlier in navigation
(SSL certs, etc), when the Blink reflected XSS filter encounters an
XSS and the page needs to be blocked (per the server's request), we 
already are have a commited navigation, and are well past the point
where interstitials and the like would do us any good.

Consequently, blink just aborts the load, and schedules a navigation to
data:, with history replacement enabled, so that the offending entry
is lost (note https://codereview.chromium.org/301163006/ changes this
behaviour blink-side to add to the back-forward list).

This is less than ideal when a webmaster would like to do a view-source on
the offending page so as to diagnose the cause, so what I've done is to set
up a way to flag the offending entry when the reflection is detected. 
I'd really like to just continue with navigating to data:, rather than
trying to deal with the UX issue -- there's nothing to be done, and 
screaming about XSS isn't helpful to the user -- and we aren't going
to ever add a "revisit the page with protection disabled" option neither.

So, when a block is detected, we make an IPC call to flag the current entry
in the navigation controller.  The navigation then continues to data:,. 

When we encounter a view-source on the data:, page URL, we check if the 
previous page was explicitly flagged prior to the block. If so, show its
source instead.

Review URL: https://codereview.chromium.org/304313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283728 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow up of https://codereview.chromium.org/392063002/

BUG=none
TBR=viettrungluu@chromium.org
TEST=none

Review URL: https://codereview.chromium.org/397063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283727 0039d316-1c4b-4281-b951-d872f2087c98

Create a separate RenderWidgetResizeHelper to handle intercepting 
and early-processing of IPCs that need to be run during an active 
resize. This functionality was previously handled in 
RenderWidgetHelper. 

The only functional changes made to RenderWidgetResizeHelper during 
its excision is that it is a single global structure, as compared with
the per-RenderProcessImpl RenderWidgetHelper. It will execute any IPCs
from any renderer or the GPU processes that are forwarded to it. This is
preferable, as that makes it so that live resize in one window does 
not destroy performance in other windows. 

Because RenderWidgetResizeHelper can handle GPU process IPCs, we can 
tear out the bizarre behavior where we'd translate GPU IPCs to synthetic 
renderer IPCs get them to channel through RenderWidgetHelper (this is 
all of the deleted ViewHostMsg_CompositorSurfaceBuffersSwapped code). 

Mark this entire structure as Mac-only, and put it in Mac-only files,
since it doesn't get used on other platforms.

Future changes will make RenderWidgetResizeHelper have a TaskRunner, 
which we will pass to the compositor, so that we can pump new frames 
while inside -[RenderWidgetHostViewMac setFrameSize:].

BUG=392031

Review URL: https://codereview.chromium.org/396483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283726 0039d316-1c4b-4281-b951-d872f2087c98

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/400563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283725 0039d316-1c4b-4281-b951-d872f2087c98

This CL brought to you by the commands 'grep', 'xargs', and 'sed'.

    grep -r -l "WebCore" ./tools/valgrind | xargs -L1 sed -i '' -e 's/WebCore/blink/g'
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/398303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283723 0039d316-1c4b-4281-b951-d872f2087c98