- 22 Aug, 2019 40 commits
-
-
Morten Stenshorne authored
If there's no content inside a multicol container, there should be no columns. Change-Id: Idf4feb5b782a79e6c9b79f96baafa3ed34257cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766070Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#689712}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ec4ea59c6d52..659a8ea9f3a9 git log ec4ea59c6d52..659a8ea9f3a9 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 9856269+sarahM0@users.noreply.github.com spvc: Add option to inject code to enforce robust-buffer-access Created with: gclient setdep -r src/third_party/shaderc/src@659a8ea9f3a9 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Iedf19f674638896474120e69a05740d2512fe67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766450Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689711}
-
David Benjamin authored
This provides some bounds checks and avoids a potential mishap if OnPaint were ever called twice in a row somehow. Also spans are fun. Bug: none Change-Id: Ibc6043099c99e41f67f3f3a2132b01766b8353dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766252 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#689710}
-
Matt Reynolds authored
In NintendoDataFetcher::GetGamepadData we call GetPadState to get a pointer to an unused PadState slot. This pointer may be null if there are no more unused slots (Chrome supports at most four connected gamepads). This CL adds a null check so we don't try to dereference the null PadState and crash. BUG=996052 Change-Id: I48cb1611b1c557e5eaa1a5791bf68d5acf8841ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762603 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#689709}
-
oysteine authored
This reverts commit d246e65b. Reason for revert: Speculatively revert to see if this helps https://crbug.com/996866 Original change's description: > perfetto: Add some CHECKs to help debug crbug.com/983307 > > Bug: 983307 > Change-Id: I7976df41d85268287757afd86af6f9bc4c52e814 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758065 > Commit-Queue: oysteine <oysteine@chromium.org> > Auto-Submit: Eric Seckler <eseckler@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687703} TBR=oysteine@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983307 Change-Id: I6981dd299a33612c7bd37c3ff74afad60268a169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764276Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#689708}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/243997ac5d09..e7151f77dda5 git log 243997ac5d09..e7151f77dda5 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 capn@google.com Fix mapping NaN inputs for E5B9G9R9 to 0 Created with: gclient setdep -r src/third_party/swiftshader@e7151f77dda5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/138944025 Change-Id: I2033eb6dea496e520b6d9b5912f5d7e6ae5f5f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766290 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for MenuItemView::MenuPosition enum class is more type safety. Bug: 940736 Change-Id: Ia49dbb2a7b3134b2394251546cc365dfc58c0e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765053 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#689706}
-
Brian Geffon authored
BUG=chromium:973963 Change-Id: I188109ac02a2af1c9a6f870cc60c5c8b63e3ad24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765332Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#689705}
-
Vadim Atlygin authored
CI/try builders migrated: - Cast Android (dbg) / cast_shell_android - Cast Audio Linux / cast_shell_audio_linux - Cast Linux / cast_shell_linux R=bpastene@chromium.org, goma-sre@google.com, jpwilson@chromium.org, tikuta@chromium.org Bug: 950413 Change-Id: Id282a7087282947bbda6f6538d0d9a3c0ad64e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752269Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Vadim Atlygin <vava@google.com> Cr-Commit-Position: refs/heads/master@{#689704}
-
Takumi Fujimoto authored
This CL fixes a regression where we started using viz::GpuClient on the UI thread instead of the IO thread, causing a DCHECK failure. Also, it makes sure that content::CreateGpuClient() calls viz::GpuClient::Add() on the right task runner, in case content::CreateGpuClient() itself is not called on it. Bug: 995592 Change-Id: I779017d324b3ecaa28d276e05a7b2cbbdddfc886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761258Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#689703}
-
Nandhini authored
When active this option will replace existing reverse image search logic but is dependent on a) a feature flag b) the user using google as their default search browser and c) evidence that the user device has lens installed Bug: 994301 Change-Id: Ieae041a1b4c8e0c841cb5e2101eca7157cd5e2b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765994 Commit-Queue: Nandhini Raman <nraman@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Nandhini Raman <nraman@google.com> Cr-Commit-Position: refs/heads/master@{#689702}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3336a66fbd9d..dc09555d284e Created with: gclient setdep -r src-internal@dc09555d284e The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:959880,chromium:987962,chromium:990406,chromium: Change-Id: Ibb60a37ab82a386cbe6276f5fb3dc15480ce9f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762466Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689701}
-
Morten Stenshorne authored
Change-Id: I5b009b895bff89f7e648183ce94490be6b107c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766388Reviewed-by:
-
Matt Reynolds authored
When the gamepad service is shut down, vibration effects may still be active. Chrome tries to stop all vibration on the gamepad before disconnecting from the device. However, this was not done for XInput gamepads on Windows. This could allow haptic effects to continue for a few seconds after the gamepad is disconnected. It also causes a DCHECK failure in AbstractHapticGamepad which checks that the Shutdown method was called before the gamepad is destroyed. This CL ensures that the Shutdown method is called when the data fetcher is destroyed. BUG=996038 Change-Id: Ib62566ca2a81c2e68a0d15830250a7f529f396d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762952Reviewed-by:
-
Sean Gilhuly authored
images/color-profile-image-filter-all.html, images/yuv-decode-eligible/color-profile-filter.html, and images/yuv-decode-eligible/color-profile-layer-filter.html have minor visual differences due to blur, so add them to crbug.com/972621. Some of the tests have minor visual differences due to sharpness; rebaseline and enable them as per the discussion in crbug.com/972637. Bug: 954328 Change-Id: I31b597899190269ab09130aaf5bbd2cdb7d9caf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757264Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#689698}
-
Charlene Yan authored
Bug: 994501 Change-Id: Ic41a4f1f4a314e6343dc3bb21bd929e96a83e5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763302Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689697}
-
Peter Kasting authored
No functional change, just an API tweak for shorter code. Bug: 709130 Change-Id: I042e2b3c2bb295d4d045cdc21bc907b25d17f318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764257Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#689696}
-
chrome-devtools://*Yann Dago authored
Bug: 992711 Change-Id: I1ffd1948ce606d8c37630a38659db4bf8eedc1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764469 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689695}
-
Xianzhu Wang authored
- LayerTreeHostCommonTestWithLayerLists: test class for future tests in layer list mode in layer_tree_host_common_unittest.cc - GetXXXNode() for easy getting existing property nodes from layers - Bug fixes and improvements of property_tree_test_utils Bug: 994361 Change-Id: Icfca2ffae847ce97ba4b2dfaa831d6241783e867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766100Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689694}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7f90416c08be..c13c5f67a13f git log 7f90416c08be..c13c5f67a13f --date=short --no-merges --format='%ad %ae %s' 2019-08-22 ehmaldonado@chromium.org depot_tools: Ignore python3 files generated by windows bootstrap. Created with: gclient setdep -r src/third_party/depot_tools@c13c5f67a13f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I0e150cfb4cc2eaa7d08ceea7e20bd1c391f8b517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764907 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Jon Mann authored
This keeps track of changes to the local network stack while waiting for Shill to save them. These pending changes are persisted to disk in a pref so they can be retried on the next login if needed. Bug: 966270 Change-Id: If3cf00873a4fc142b755e005da561a3cbb78a73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761434Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#689692}
-
Sophie Chang authored
This is needed for the OptGuideKeyedService implementation to come where it needs to sort of check the existence of the hint before proceeding via CanApplyOptimization which takes in a nav handle Bug: 969558 Change-Id: Idd4abf9e6b2d8b9ddb5ccb2e304aa9e5defe5011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766094 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#689691}
-
Findit authored
This reverts commit 1e76b45f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 689646 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFlNzZiNDVmYmE0MWZmMTQ5MDRiZjVkZmM5OWEyODk1YTBiZmQ0YjAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/43203 Sample Failed Step: content_unittests Original change's description: > [scheduler] Registering the executor in TLS. > > Bug: 968047 > Change-Id: Idaf9c72f13419ac29804a91e54be86d71ff9b7f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751251 > Commit-Queue: Karolina Soltys <ksolt@chromium.org> > Reviewed-by: Karolina Soltys <ksolt@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Auto-Submit: Karolina Soltys <ksolt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689646} Change-Id: I80b73e5cb9b57e3ffa6d766497a7fdaa89d4d1a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766782 Cr-Commit-Position: refs/heads/master@{#689690}
-
Zhongyi Shi authored
ConnectivityProbingManager::OnConnectivityProbingReceived is actually called on every single packet received, even if the packet is not a connectivity probe. Renamed to OnPacketReceived to reflect the fact correctly. Bug: 996419 Change-Id: Icb01b5d96864bc0dd331509964f1527b52b48db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764263 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#689689}
-
Drake Lei authored
Issue: The confirm infob bar will contain an invisible link when there is no actual link. NVDA focus is going to invisible links in the info bars. This change includes a fix to set the accessibility role of link to kIgnored when it's empty and invisible. Bug: 993608 Change-Id: I14d6149ec494353cb26fbebfaffa0dd9d51d1f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752116 Commit-Queue: Drake Lei <jilei1@microsoft.com> Reviewed-by:
-
Peter Kasting authored
This also avoids collapsing whitespace between words when pasting into the find box. We still trim leading/trailing whitespace since it's often unintentional. This fails to find newlines due to block boundaries, e.g. foo<br>bar; it only finds newlines in the actual text strings, e.g. foo\nbar. Finding the former will require more substantial changes to the find code. Bug: 973253 Change-Id: Ife0388658cd23950ba958d74d38e0d8036f99e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764889 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689687}
-
Andrew Lee authored
Fixed clobber bots failure by specifying all domains in the protocol config file. Without this change, builds that build from scratch will fail to generate the domain output files and will fail (clobber builds). This is a reland of 591bf020 Original change's description: > UI_DevTools: Backend for ui_devtools performance panel. > > The goal is to enable and create the performance tool for ui_devtools. > The performance panel will record and show metrics such as FPS, CPU time utilization > for Aura/Views UI. This CL is for the backend only. The TracingAgent is very similar > to the TracingHandler from > https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/tracing_handler.cc. > > Bug: 989052 > Change-Id: Ic696e09f700e93bcd0842fdbda575ef1f54af63a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726651 > Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dana Fried <dfried@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689296} Bug: 989052 Change-Id: I6392c40d5babcd74558186c80ebc618c22aa4d7b This is a reland CL and the only file difference is components/ui_devtools/inspector_protocol_config.json, which has been reviewed by ui_devtools OWNER lgrey@. TBR=rockot@google.com,oysteine@chromium.org,dfried@chromium.org Change-Id: I6392c40d5babcd74558186c80ebc618c22aa4d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765005 Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689686}
-
Caleb Rouleau authored
"Speed tracks" was confusing to me. I think these are really just domain areas of expertise. Also, add Bruce as primary contact for power domain. Also, clarify difference between end user metrics and lab metrics. Also, rename waterfall from chromium.perf to chrome.perf. Bug: 949246 Change-Id: I0739912ef38a6c9381d19d265cb02675932e636c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763097 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#689685}
-
John Lee authored
The dimensions are still not finalized, but these are at least closer to the mocks and look more polished. Bug: 989131 Change-Id: I0b347f57bc654011af3b0d1087c908b0d911da4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766350 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b39cbe8619a..2a5954140b49 git log 2b39cbe8619a..2a5954140b49 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 egdaniel@google.com Merge GrOpList and GrRTOpList and rename to GrOpsTask. 2019-08-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-22 fmalita@chromium.org [svgcanvas] Named colors support 2019-08-22 egdaniel@google.com Delete unused GrTextureOpList. 2019-08-22 fmalita@chromium.org [canvaskit] Optimize CK builds for size 2019-08-22 csmartdalton@google.com Don't perform dst reads on MSAA targets that require manual resolve Created with: gclient setdep -r src/third_party/skia@2a5954140b49 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I8a33c7324d23bfb3ca800239ac57d5c1e42bae86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765112Reviewed-by:
-
manuk authored
Previously, we had compiled a set of regexes to handle doc URL patterns we had encountered. In order to reduce the likelihood of error, this CL instead uses the same regex used in the google3 codebase. Change-Id: I00bde49c67d99592bc085d6d0d1a90324cb7f84c Bug: 888093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700333 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#689682}
-
Nate Fischer authored
No change to product, only OWNERS changes. I'm proposing myself for ownership of: * Markdown files: I've been owning aw/docs/ for a while, and feel comfortable owning markdown files outside of that folder as well * Build files: I'm fairly comfortable with GN, and would like to help facilitate the project in crbug.com/934152. Bug: 918221, 934152 Test: N/A Change-Id: Ib42d76763764ab4ef37ce93ca2eebbf94eeb9954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764828Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689681}
-
Chris Harrelson authored
This is a revert of https://chromium-review.googlesource.com/c/chromium/src/+/1340875. This is possible now that BGPT is launched. Bug: 900602,909036 Change-Id: I750deb202dd9fd2478e955ea243f85b14c59dde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763335 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This was a (rather childish) attempt at resetting the fragment builder sufficiently if the column fragments we had created had to be discarded, because of column balancing. This approach won't work once we add support for column-span:all, because we'll then perform individual column balancing for each column row (between or around the spanners). Change-Id: Idaa1f702c4bba688cec222d76dabc3e12214f5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766069Reviewed-by:
-
Danan S authored
Bug: 996469 Change-Id: I002033132524ed862df8b99c11cf147de0d1a2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764754Reviewed-by:
-
Aaron Leventhal authored
Navigation with the VO cursor should not visit hidden elements. This had regressed because we started including hidden elements in the accessible object hierarchy on purpose, so that when a page accidentally overused aria-hidden, that users would still hear something useful when tabbing to focusable items. With this CL, users will not generally be able to accidentally navigate to aria-hidden items, but if they manage to actually focus one with the keyboard, it will still announce what it is. Bug: 982408 Change-Id: I19d5fe4947e5fb1c7493f0e67d7fe8e13d9a255e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761717Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#689677}
-
Daniel Rubery authored
For scans that return synchronously, the verdicts will be present in the initial upload response. This CL checks that response for verdicts and adds a test for this behavior. Bug: 980784 Change-Id: I3f7c17f293d66f6aa410819f453b4a24f337e3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764408 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689676}
-
kylechar authored
The VizDisplayCompositor is default enabled and can't be disabled on Android. Remove the entry in fieldtrial_testing_config.json and remove from chrome://flags. Bug: 936425 Change-Id: Iaf8539c36e3d30789cbcf2031c07c25f3bb8bb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761558 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#689675}
-
Mei Liang authored
Change-Id: I392609674b2c2b624a247e9c7bc2c19651f13692 Bug: 987160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766004Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689674}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/0b20fdfd4bea..c8c02a5f788c $ git log 0b20fdfd4..c8c02a5f7 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 renjietang Make sure QPACK stream types are sent along with SETTINGS in one packet. 2019-08-22 renjietang Optimize code in handling wrong HTTP/3 frames. 2019-08-22 bnc Remove QpackProgressiveDecoderTests. 2019-08-22 bnc Signal error on duplicate SETTINGS identifiers. 2019-08-22 bnc Make QpackEncoder::EncodeHeaderList() and FirstPassEncode() take header_list by const ref. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ie9e7cef88064b1bef449835089555449f61ef1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765999 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#689673}
-
