GitLab

As per SVG2, SVGLength.value setter should set the
SVGLength's value to a <number> whose value is value.
https://svgwg.org/svg2-draft/types.html#__svg__SVGLength__value

This patch is supportive patch for calc() support for SVGLength.

BUG=558304

Review-Url: https://codereview.chromium.org/2113943003
Cr-Commit-Position: refs/heads/master@{#403440}

Chrome will start sync prefs on mobile. It's not desired behaviour for
the default_search_provider.synced_guid pref.

BUG=622620
TBR=stevet@chromium.org

Review-Url: https://codereview.chromium.org/2091763002
Cr-Commit-Position: refs/heads/master@{#403439}

R=pfeldman@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2084343002
Cr-Commit-Position: refs/heads/master@{#403438}

These tests should be disabled until the EventLog functionality is updated to use the upcoming new API.

BUG=webrtc:4741

Review-Url: https://codereview.chromium.org/2115503002
Cr-Commit-Position: refs/heads/master@{#403437}

Chrome will start sync prefs to mobile. It's not desired behaviour for
the session.startup_urls and the session.urls_to_restore_on_startup prefs.

BUG=622620

Review-Url: https://codereview.chromium.org/2114923002
Cr-Commit-Position: refs/heads/master@{#403436}

When running video_encode_accelerator_unittest :

../../media/gpu/video_encode_accelerator_unittest.cc:301: Failure
Value of: 0
Expected: reinterpret_cast<off_t>(&test_stream->aligned_in_file_data[0]) & 63
Which is: 32
File should be mapped at a 64 byte boundary

Also reuse base::bits::Align.

BUG=624254
TEST=video_encode_accelerator_unittest

Review-Url: https://codereview.chromium.org/2110063002
Cr-Commit-Position: refs/heads/master@{#403435}

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2115833002
Cr-Commit-Position: refs/heads/master@{#403434}

This enable us to test creating new selection.

TEST=LayoutTests/editing/assert_selection.html

Review-Url: https://codereview.chromium.org/2114903002
Cr-Commit-Position: refs/heads/master@{#403433}

This CL fixes the following failures in request_track.py:
 - Data protocol are known to have encodedDataLength == 0
 - Some request_id might be duplicated and this CL just ignore the
   duplicated errors.

BUG=623966

Review-Url: https://codereview.chromium.org/2115553002
Cr-Commit-Position: refs/heads/master@{#403432}

In chrome://flags, one can now choose among predefined variation
parameters for a feature. Such parameters are registered on startup
with a predefined trial and group name. This causes a crash when the
same trial is specified in Finch config.

This CL skips dealing with a Finch trial where a group is already
selected and this group is not mentioned in the Finch config.

BUG=624807

Review-Url: https://codereview.chromium.org/2119713002
Cr-Commit-Position: refs/heads/master@{#403431}

Removes extra v8 snapshot and natives validation on Windows. All platforms
have the same validation henceforth.

BUG=501799

Review-Url: https://codereview.chromium.org/2103903002
Cr-Commit-Position: refs/heads/master@{#403430}

BUG=624712
TBR=sadrul

Review-Url: https://codereview.chromium.org/2117733002
Cr-Commit-Position: refs/heads/master@{#403429}

Note: The original CL was reverted because of breaking Win8 build:
https://codereview.chromium.org/2109973002/

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html

Review-Url: https://codereview.chromium.org/2117663002
Cr-Commit-Position: refs/heads/master@{#403428}

Cherry picking HarfBuzz commit 46809dee30232d4 into HarfBuzz in order to address
the incompatibility with third-party font management software and Type 1
versions of Helvetica.

BUG=132252
R=kojii,eae,behdad

Review-Url: https://codereview.chromium.org/2114883002
Cr-Commit-Position: refs/heads/master@{#403427}

Provides more informative test failure messages.

Review-Url: https://codereview.chromium.org/2111093002
Cr-Commit-Position: refs/heads/master@{#403426}

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2115823002
Cr-Commit-Position: refs/heads/master@{#403425}

Remove duplicate code.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2006923006
Cr-Commit-Position: refs/heads/master@{#403424}

Fallback to the current time if the timestamp from the encoder
callback is 0.

BUG=chromium:620565
TEST=Run apprtc loopback on oak.

Review-Url: https://codereview.chromium.org/2105683002
Cr-Commit-Position: refs/heads/master@{#403423}

Some old headers are temporary left as they are used in downstream code.

BUG=524467

Review-Url: https://codereview.chromium.org/2116673002
Cr-Commit-Position: refs/heads/master@{#403422}

Fuzzers generate pointless overhead using these test-only methods from
frame-detached contexts. Add required nullchecks throughout.

Simple test case for each of these entry points (w/ --run-layout-test):

 <a href="javascript:'replaced'" id=anchor>click</a>
 <script>
 anchor.click();
 internals.someMethod();
 console.log('no crash');
 </script>

R=
BUG=624549

Review-Url: https://codereview.chromium.org/2109613007
Cr-Commit-Position: refs/heads/master@{#403421}

BUG=622590
TEST=./out/Debug/unit_tests --gtest_filter=LowDiskNotificationTest.*

Review-Url: https://codereview.chromium.org/2115793002
Cr-Commit-Position: refs/heads/master@{#403420}

On current history page, history items with bookmarks will show a bookmark
star, and it's unclickable.

Remove the url's bookmark when clicking bookmark star.

BUG=618580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2097003002
Cr-Commit-Position: refs/heads/master@{#403419}

And use them when creating a eglImageKHR for a EGL_LINUX_DMA_BUF_EXT target.

BUG=chromium:478339
TEST=none
Signed-off-by: Vince Hsu <vince.h@nvidia.com>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/29292a32f6f429a790e8663ce09bf67d165f49e9
Review-Url: https://codereview.chromium.org/2039813002
Cr-Original-Commit-Position: refs/heads/master@{#402656}
Cr-Commit-Position: refs/heads/master@{#403418}

WebView gets callback 'onDragEvent' when something is dragged into the WebView.
This CL extracts the texts (if any) and location from the DragEvent and creates
DropData which is Chromium's internal representation of dragged data.

The event plumbing path is WebView#onDragEvent --> AwContents#onDragEvent -->
ContentViewCore --> WebContentsViewAndroid.

This CL also uses a new blink::WebView API that performs dropping with DropData,
because on Android, the DropData is only available when the drop is performed,
not when the drag is started.

BUG=584789

Review-Url: https://codereview.chromium.org/1728193002
Cr-Commit-Position: refs/heads/master@{#403417}

This is a follow-up of crrev.com/403093.

- Replace a TODO comment with an explanation, and add a test to reproduce the
  scenario.

- Fix a possible crash by m_listItems.remove(WTF::kNotFound) just in case.
  We don't find a reproduction.

BUG=625050

Review-Url: https://codereview.chromium.org/2103663006
Cr-Commit-Position: refs/heads/master@{#403416}

Added test coverage with device BACK key.

BUG=

Review-Url: https://codereview.chromium.org/2090633002
Cr-Commit-Position: refs/heads/master@{#403415}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/53f132d..ff05380

BUG=
TBR=kbr@chromium.org
TEST=bots
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2116493004
Cr-Commit-Position: refs/heads/master@{#403414}

`Runnable` concept was useful when bind_internal.h was a huge generated
file. However, it's an unneeded layer these days.
This CL removes `Runnable` from bind_internal.h to simplify its impl.
After this CL, BindState holds the bound Functor directly in its internal
storage.

This CL contains:
 * Merge bind_internal_win.h into bind_internal.h
 * Move typechecks in Bind() into MakeBindStateType.
 * Remove no longer used HasIsMethodTag in bind_helper.h.
 * Remove InvokeHelper specialization for IgnoreResult.
 * Merge assertion-only InvokeHelper specialization into another
   specialization.
 * Factor out the type setup in BindState into MakeBindStateType.

BUG=554299

Review-Url: https://codereview.chromium.org/2106773002
Cr-Commit-Position: refs/heads/master@{#403413}

BUG=610757,625038
TBR=megjablon

Review-Url: https://codereview.chromium.org/2116743002
Cr-Commit-Position: refs/heads/master@{#403412}

Cleaning up video-canvas* and video-capture* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2112003002
Cr-Commit-Position: refs/heads/master@{#403411}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fd47e24b0e09..7a603e4b1a71

$ git log fd47e24b0..7a603e4b1 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2117603003
Cr-Commit-Position: refs/heads/master@{#403410}

BUG=594309,553838
TBR=cbiesinger

Review-Url: https://codereview.chromium.org/2115773002
Cr-Commit-Position: refs/heads/master@{#403409}

The special path for doing substring additions only made sense when we
shared StringImpls for substrings, now that we don't there's no reason
to keep it. The code was dead either way with nothing calling it
anymore.

I also removed constructors for AtomicString that no one used and
switched to using lengthOfNullTerminatedString directly in AtomicString
instead of having a separate code path in AtomicStringTable for finding
the length of UChar* strings.

Finally I simplified AtomicStringTable::remove which was using a find
codepath designed to find a string that may not exist in the table
without actually allocating a new string. This doesn't make sense since
remove is only ever called from StringImpl's destructor on a string we
already know to be atomic so it must be in the table and must have a
hash so we can just do m_table.remove on it.

Review-Url: https://codereview.chromium.org/2111653004
Cr-Commit-Position: refs/heads/master@{#403408}

StringBuilder has an optimization to just store the first String object
you append to avoid a copy in cases where you only append one String
and then call toString(), for example if there's onlyone Text child
and you do element.textContent.

When appending the second string we then allocate a Vector buffer and
copy the first string (m_string) into it. We weren't allocating extra
space for the bytes we were about to append in the second string
though, which meant we always did an extra copy immediately following
the the buffer creation:

String first;
String second;

StringBuilder builder;
// No copy, just stores a pointer to first.
builder.append(first);
// 1. Creates a Vector
// 2. Copies first into it.
// 3. Appends second to the Vector which causes a Vector resize.
builder.append(second);

We solve this by calling reserveInitialCapacity with m_length + the
number of bytes we're about to append when we created the buffer. We
also inflate the number of bytes to be at least the inline capacity
size so that doing:

builder.append(first);
builder.append('1');
builder.append('2');

doesn't require an immediate resize for appending '2' by ensuring we
always overallocate the Vector by at least the inline capacity size so
even when appending a String you get 16 chars of extra space to insert
something else.

BUG=624642

Review-Url: https://codereview.chromium.org/2106283004
Cr-Commit-Position: refs/heads/master@{#403407}

https://chromium.googlesource.com/chromium/src/+/0e94f26e8

BUG=621221
TBR=bsep@chromium.org

Review URL: https://codereview.chromium.org/2112203002 .

Cr-Commit-Position: refs/heads/master@{#403406}

BUG=625020
TBR=wangxianzhu,bokan

Review-Url: https://codereview.chromium.org/2116733002
Cr-Commit-Position: refs/heads/master@{#403405}

  In order to roll GN cadaad43..ac799c2f (r402556:r403392) and pick up
  the following changes:

  4c75ba48 Fix dependencies rules for create_bundle and bundle_data ninja steps.

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2113143003
Cr-Commit-Position: refs/heads/master@{#403404}

This CL implements disabling and enabling audio and video streams via
Javascript media tracks API. When a media track is disabled, the
corresponding DemuxerStream generates an EOS notification, thus ending
further decoding/rendering of that stream. When a media track is
enabled, the corresponding DemuxerStream is seeked to the current
playback position and we notify the renderers to resume reading from
the demuxer stream and rendering its contents.

BUG=249427

Review-Url: https://codereview.chromium.org/1935873002
Cr-Commit-Position: refs/heads/master@{#403403}

Only EventWithLatencyInfo uses [Can]Coalesce() from WebInputEventTraits.
WebInputEventTraits gets used for IPC stuff so is kinda sensitive, but
EventWithLatencyInfo isn't involved with IPC. So, coupling these
together also makes refactoring unnecessarily difficult.

E.g. the coupling means that if we want to move EventWithLatencyInfo to
a component, then WebInputEventTraits and a bunch of dependencies that
EventWithLatencyInfo doesn't care about need to come as well.

To decouple, the guts of [Can]Coalesce() moves to a new .cc file for
EventWithLatencyInfo. The types are known, so we get some added type
safety versus WebInputEventTraits which isn't templatized in the .h. The
instantiations in the .cc become a bit simpler and the runtime type
checks and static casts behind in web_input_event_trait.cc's Apply(..)
are not required.

BUG=615948
TBR=jochen@chromium.org (iwyu)

Review-Url: https://codereview.chromium.org/2111593003
Cr-Commit-Position: refs/heads/master@{#403402}

They are unused because they are used by magic.
They are missing translations to save file size
(see http://crbug.com/450548)

BUG=621771

Review-Url: https://codereview.chromium.org/2102183003
Cr-Commit-Position: refs/heads/master@{#403401}