GitLab

This flag was really only for development while we weren't sure how to
handle VR Intents. With Chrome VR browsing already shipped, there's no
reason not to allow Intents to launch it.

Change-Id: Ibbc7e5ea41668c073a4a04340ec45bfe40025b0f
Reviewed-on: https://chromium-review.googlesource.com/959051
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542508}

 -- In preparation for introducing ScopedU2fVirtualDiscoveryFactory, create a
    base class ScopedU2fDiscoveryFactory and let ScopedU2fFakeDiscoveryFactory
    derive from that.
 -- In preparation for a wider adoption of FakeU2fDiscovery in tests that could
    not care less about when a discovery starts, add a version of the fake
    discovery where SimulateStarted()/SimulateStopped() is called automatically.

Bug: 785955
Change-Id: I4b1c9bd962c6e225be45971bbb0d5aad3b05a68a
Reviewed-on: https://chromium-review.googlesource.com/959001
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542507}

This reverts commit 9dd1ef42.

Reason for revert: Latest canary data did not have expected recovery on Omnibox.CharTypedToRepaintLatency and had a regression on Omnibox.CharTypedToRepaintLatency.ToPaint. Reverting to see if that movement is related to this CL or whether there were other changes in the meanwhile.

Original change's description:
> Cache brand code on Windows.
> 
> Querying the registry is expensive and contributes to start up time,
> omnibox query time and idle. Since the brand code is not expected to
> change on Windows during the course of a session, this CL caches
> the value, so that future queries are free.
> 
> This should restore the Omnibox perf that regressed by
> https://chromium-review.googlesource.com/c/chromium/src/+/824363
> and also improve perf elsewhere since the caching is now done at
> a lower level than that change. Since this is expensive only on
> Windows, the caching is done in the Windows codepath only.
> 
> Bug: 816698, 806130
> Change-Id: I458fad29f18b1b1ff2d55b9334ae733fa448eec9
> Reviewed-on: https://chromium-review.googlesource.com/947522
> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541009}

TBR=pkasting@chromium.org,asvitkine@chromium.org,grt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 816698, 806130
Change-Id: I09e12c17011f72f25ecb369ca3075e2067013f8a
Reviewed-on: https://chromium-review.googlesource.com/958012Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542506}

We're just about to destroy said object, and since this is only issuing
"local" (client-only, no ancestors) invalidations they will have no
effect.

Bug: 769774
Change-Id: Ib8d0afecb65a80bd89990906940e792cadcc2dcb
Reviewed-on: https://chromium-review.googlesource.com/958903Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#542505}

Bug: 805636
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I38c1003c7bf4935bbc1071efad166fb113ba471b
Reviewed-on: https://chromium-review.googlesource.com/957915Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542504}

This fixes a problem on iOS where <select> elements with negative tabindex
values are not being filled. This is because on iOS they are considered
non-focusable and autofill manager does not autofill nonfocusable fields.

This doesn't change the behavior on other platforms since filling
non-focusable <select> elements is already allowed:
https://cs.chromium.org/chromium/src/components/autofill/content/renderer/form_autofill_util.cc?l=881

Bug: 820618
Change-Id: Ie01f2611362dcaadf4ec22c39f645cfe51652d04
Reviewed-on: https://chromium-review.googlesource.com/959106
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542503}

Also added finch experiment to fieldtrial_testing_config.json

Bug: 804490,818559
Change-Id: I70b0bfdaf7d59ca91f27d634363221b5f3cdb403
Reviewed-on: https://chromium-review.googlesource.com/942308
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542502}

This CL has no behavior changes.

Bug: 770603
Change-Id: I86da709fa40b3540322c7cacf51975bd00397821
Reviewed-on: https://chromium-review.googlesource.com/958746Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542501}

https://skia.googlesource.com/skia.git/+log/947326638a25..689d02d4b480

$ git log 947326638..689d02d4b --date=short --no-merges --format='%ad %ae %s'
2018-03-09 caryclark harden pathmeasure and fix empty case
2018-03-09 fmalita Extend SkTrimPathEffect semantics
2018-03-09 reed remove unused ConvertRadiusToSigma from SkBlurMaskFilter
2018-03-12 borenet Fix binary size analysis
2018-03-12 caryclark fail on mdout error

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I4223618e68c8ba6cd24f83bbaaf3da087e3c5c18
Reviewed-on: https://chromium-review.googlesource.com/959043
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542500}

Currently, the color of the search icon is changed to white by setting
a ColorFilter. Because the loaded Drawable is a reference to a static
resource, this means all activities using the same resource would apply
the same filter.
By calling |mutate| on the drawable, we receive a copy of the resource
and ensure the recoloring remains local.

Bug: 820038
Change-Id: I09719b05bf65e0701a0cf0e6e66b3a6322d1c515
Reviewed-on: https://chromium-review.googlesource.com/956133Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542499}

https://webrtc.googlesource.com/src.git/+log/0f1c0bd3265d..b619936dee28

$ git log 0f1c0bd32..b619936de --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7a94738b719d2b3ef3b0edc3055f73c762cfda80
Reviewed-on: https://chromium-review.googlesource.com/957756
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542498}

- Moves RecentTabs behind Phase1 flag.
- Renames RecentTabsFlag to Collections and moves it to feature_flags.


Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I93b9ed6b0b63f28639a10d67f5890333dacb0b58
Reviewed-on: https://chromium-review.googlesource.com/956092Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542497}

This is a reland of ebe5bdf8

Original change's description:
> 🤝 Use Origin class for canonically representing origins.
>
> Constructing origins manually and storing them in Urls is error-prone
> (eg the port could be missed out) and there are discrepancies in how
> the origin could be formed (eg GURLUtils has a trailing '/' while
> current manually formed origins don't). This is especially important as
> origins are critical to security.
>
> This CL creats an Origin class that offloads all the heavy lifting to
> the well tested native origin class and allows the type system to
> prevent the errors listed above.
>
> Bug: 800422
> Change-Id: I87759ea12a87f2b57bbdf40994d35ec468a43cff
> Reviewed-on: https://chromium-review.googlesource.com/934289
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540825}

Bug: 800422
Change-Id: I60a9531afa1cbfb0bda9b1ef4553c46c39f07f75
TBR: bauerb@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/958962Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542496}

Some field trial params implement things like csv or json within a
particular param value. If some control characters are not %-encoded,
it can lead to confusing error messages. This CL adds a hint in the
error message for an invalid --force-fieldtrial-param.

Bug: 783943
Change-Id: I0247e6ebf6d43c39e4002760d8bcbb053ba3f49a
Reviewed-on: https://chromium-review.googlesource.com/957913Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542495}

https://pdfium.googlesource.com/pdfium.git/+log/073b99d51c7a..0e2e8db7e6e8

$ git log 073b99d51..0e2e8db7e --date=short --no-merges --format='%ad %ae %s'
2018-03-12 brianosman Stop excluding SkDumpCanvas from Skia. It no longer exists.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ice072ad842d984317fe902469aa579c015ec9251
Reviewed-on: https://chromium-review.googlesource.com/957759Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542494}

Bug: 820993
Change-Id: I12fe9b0a899152802d8d3e509fb8513f0356c51a
Reviewed-on: https://chromium-review.googlesource.com/959048Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542493}

Bug: b/73160522
Change-Id: Ifc93354e3f71d55ab6d5808cf0778cb06fe6efdd
Reviewed-on: https://chromium-review.googlesource.com/959007Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542492}

Bug: 815161
Change-Id: I1c55ee5d540faab02d8383776c041dad76317f1e
Reviewed-on: https://chromium-review.googlesource.com/958209Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542491}

Bug: 816026
Change-Id: I28fb2575e76f9f3a0dd55e8373b6909abb156f4a
Reviewed-on: https://chromium-review.googlesource.com/959117
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542490}

It hits flaky renderer crashes.

Bug: chromium:820934
Change-Id: I7d379fb5a4bfb5e50caf6109632756d7fb03b7ee
Reviewed-on: https://chromium-review.googlesource.com/958519
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542489}

It was bumped down by f99c4ade, but the
newly intervening shouldDisableThreadChecking() call doesn't actually
have anything to do with the data directory. Move the comment back to
its original location, for clarity.

Change-Id: I83495386fe11cf78acd186369cd791f1962dae0d
Reviewed-on: https://chromium-review.googlesource.com/958098Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542488}

Change-Id: I9ce1985082125ab6099f3576d6742aaed73d21d7
Reviewed-on: https://chromium-review.googlesource.com/958165Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#542487}

This call got removed in my last CL by mistake:
https://chromium-review.googlesource.com/c/chromium/src/+/890738

Bug: 808801, 820936, 820769, 820830, 820827
Change-Id: I6c6efb3d40d43bc564e18b013ddf5d5d3b09e1eb
Reviewed-on: https://chromium-review.googlesource.com/958218
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542486}

This is a reland of 83931b97

Original change's description:
> [vr] Add compatibility to component 1.y, check integrity of WAV files
>
> Bug: 811987
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4
> Reviewed-on: https://chromium-review.googlesource.com/956251
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542128}

TBR=waffles@chromium.org,cjgrant@chromium.org

Bug: 811987
Change-Id: I806e84ff18a771fda9ea38f2bfe435b0cdba84f2
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/958008Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542485}

Currently the exception is not thrown until after serialization.
This makes us consistent with Gecko and WebKit, which throw before serialization.

This fixes the second test case in https://github.com/w3c/web-platform-tests/pull/9672
(not yet pushed to upstream WPT).

Bug: 816447
Change-Id: I30b798b5d21dc8d6f2a40d049ced6aa7f60dd090
Reviewed-on: https://chromium-review.googlesource.com/956254Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542484}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/42dd0fcc..7e11bad4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ibf93d6f4568d856119cda3dfcac30fb2468a938b
Reviewed-on: https://chromium-review.googlesource.com/957910Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542483}

Using wpt-import in Chromium a9778699.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13763

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=foolip

No-Export: true
Change-Id: Ibe2f1dba251ca56dc114b86bba342d232950b3dc
Reviewed-on: https://chromium-review.googlesource.com/957909
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542482}

Bug: 819302
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I218c03a6a308afa265468876db28ff710a09399b
Reviewed-on: https://chromium-review.googlesource.com/957126
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542481}

These lists are scanned for scheme matches hundreds of times per page
load. Since most resource requests are https now, we should make sure
that the first check is a match more frequently.

This patch also does the same with ws/wss, though we don't really have
metrics backing up the decision.

Bug: None
Change-Id: I7fc9bebdafe8cb2b6ca5ede6998b8fa693b08584
Reviewed-on: https://chromium-review.googlesource.com/955730
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542480}

This reverts commit 12ac6f19.

Reason for revert: Test is flaky

Original change's description:
> Unskip acid3/numbered-tests.html
>
> Looks like crbug.com/807627 has been fixed by the recent roll of wpt tools,
> in which case this test won't be flaky any more.
>
> Bug: 805463
> Change-Id: I184560ed406a082c661f313047830d79d5d152d1
> Reviewed-on: https://chromium-review.googlesource.com/957223
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542263}

TBR=foolip@chromium.org,robertma@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 805463
Change-Id: Iec79614a2dfa66353bf4900d95ac7defc3b7a0bf
Reviewed-on: https://chromium-review.googlesource.com/959062
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542479}

This CL adds a dummy refresh token (kInvalidRefreshToken) that can
be passed to UpdateCredentials in order to revoke the existing token
and put the account in a authentication error state, without doing a
full signout.

This new functionality is used on Dice web signout for the main
account.

Bug: 810860
Change-Id: I706b28f91401a8be8108a0d40fbf19d7a5b493cb
Reviewed-on: https://chromium-review.googlesource.com/952964
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542478}

Disable ContentSettingsTest.BasicCookies and BasicCookiesHttps
because they are flaky in network_service_browser_tests.

TBR=jam@chromium.org

Bug: 820969
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I99e73d50942b04f680750abf0ad40e5dd21b6913
Reviewed-on: https://chromium-review.googlesource.com/958909Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542477}

This CL adds the possibility to trigger side swipe for tab by swiping
on the bottom toolbar.

Bug: 814735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I94556de2237fc67ffd41f58a29c3df75f3a7130e
Reviewed-on: https://chromium-review.googlesource.com/957185
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542476}

https://skia.googlesource.com/skia.git/+log/ef9b79338675..947326638a25

$ git log ef9b79338..947326638 --date=short --no-merges --format='%ad %ae %s'
2018-03-12 caryclark add SkDebugCanvas to undocumented

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: Idce74e35e77a3080a6bc3a657c20f028b1ae30fb
Reviewed-on: https://chromium-review.googlesource.com/957751Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542475}

This reverts commit e23bd4d7.

Reason for revert: The change broke compilation on https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/63827

Original change's description:
> Don't have two copies of //device/fido.
> 
> Prior to this change, both libcontents.so and content_unittests would
> each have a copy of //device/fido because the test_support code would
> pull in a copy directly. This caused there two be two copies of
> |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> one by the code that's used for actual processing. That obviously breaks
> things.
> 
> This CL makes //device/fido a `component` instead of a `source_set`,
> which, however, necessitates adding COMPONENT_EXPORT annotations to all
> exported classes/functions/constants.
> 
> The CL also cleans up the components by:
>  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
>  -- moving dependencies included in public headers into `public_deps`.
> 
> Bug: 785955, 820441
> Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> Reviewed-on: https://chromium-review.googlesource.com/955698
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542472}

TBR=agl@chromium.org,engedy@chromium.org,jdoerrie@chromium.org

Change-Id: I39770f2cd99eafabe50501ad3d90a6442cb3c343
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785955, 820441
Reviewed-on: https://chromium-review.googlesource.com/959061Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542474}

If a place holder is scheduled to be displayed, do not allow
capturing a snapshot. This prevents calling WebState::GetView
before WebState::NavigationManager::LoadIfNecessary and thus
prevents bumping into issue crbug.com/820484.

Bug: 820111
Change-Id: I9d326a0fdccd7b6ea22b1b5477e79b7b7b82a586
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/956188Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542473}

Prior to this change, both libcontents.so and content_unittests would
each have a copy of //device/fido because the test_support code would
pull in a copy directly. This caused there two be two copies of
|U2fDiscovery::g_factory_func_| – one used by the test_support code and
one by the code that's used for actual processing. That obviously breaks
things.

This CL makes //device/fido a `component` instead of a `source_set`,
which, however, necessitates adding COMPONENT_EXPORT annotations to all
exported classes/functions/constants.

The CL also cleans up the components by:
 -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
 -- moving dependencies included in public headers into `public_deps`.

Bug: 785955, 820441
Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
Reviewed-on: https://chromium-review.googlesource.com/955698
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542472}

Something introduced a lot of flakiness to viz_browser_tests on Windows. So I'm
disabling them until we can isolate the cause.

TBR=dprank@chromium.org
TEST=viz_browser_tests

Bug: 820963
Change-Id: I8fc4929ffa7499115928101badbc96f2a7c4dd72
Reviewed-on: https://chromium-review.googlesource.com/957757Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542471}

RecalcStyleForReattach would compute style for slot elements even
though they were not part of the flat tree before SlotInFlatTree runtime
flag was introduced.

Moved SetNonAttachedStyle(nullptr) to Element to make sure we only ever
set or clear non-attached style on Elements, and added DCHECKs to
support that and the fact that we only set non-attached style on
elements which are part of the flat tree.

This was partly the regression for 792080, but will not have an effect
for the performance tests on master since SlotInFlatTree is enabled.

Bug: 792080
Change-Id: I47659300dea9cf4411a4e06f574dbad15c29fdfb
Reviewed-on: https://chromium-review.googlesource.com/958465Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542470}

Bug: 814776
Change-Id: If68e4015c54a0b60f9a68b7941fb3e5d14b58502
Reviewed-on: https://chromium-review.googlesource.com/958466Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#542469}