GitLab

https://chromium.googlesource.com/chromiumos/chromite.git/+log/86a2ffa02e46..45e7b57c0467


git log 86a2ffa02e46..45e7b57c0467 --date=short --no-merges --format='%ad %ae %s'
2018-08-29 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@45e7b57c0467

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I555179fe4eed0c0a66b6e1e29ff77f67f42cbcbd
Reviewed-on: https://chromium-review.googlesource.com/1195055Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587188}

SelectionModifierCharacter's main function, TraverseInternal, contains
two nested loops without clear loop variable or terminate condition,
making it very hard to understand.

This patch refactors it so that:

1. Introduce an InlineBoxPosition loop variable that is modified only
at the end of each iteration of the outer loop, so that it becomes
clear what we are working on in each iteration.

2. Changes the inner loop to have exactly one iteration, which has in
fact flattened the inner loop. This patch intentionally keeps the loop
statement to minimize changes and emphasize that this patch is pure
refactoring.

Regarding correctness of 2: Without patch, each iteration of the inner
loop has three possibilities, depending on the initial value of the
(box, offset) pair:

I. Returns directly, which remains the same with patch.

II. Changes value of (box, offset) and continues. With patch, it sets
the value of (next_box, next_offset), and then sets |can_create_position|
to false to instruct the outer loop to change the loop variable value
without any extra work.

III. Changes value of (box, offset) and breaks, which ends up
- Creating a Position |p| and test if it can be returned
- If not, use |p| to create next iteration's (box, offset) value
With patch, it sets |can_create_position| to true so that the same
|p| is created and tested, and if |p| is not the return value, also
uses |p| to set up the value of next iteration's |box_position|.

Bug: 877263
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iad30a37b1ef209170ed6dd770862c13e40320f86
Reviewed-on: https://chromium-review.googlesource.com/1194964Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587187}

Specs:
https://screenshot.googleplex.com/6gGm7iDdKmB

Bug: 878520,878162
Change-Id: I0bd9673232cd0036422ecdb71410151db476290b
Reviewed-on: https://chromium-review.googlesource.com/1194340Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587186}

Bug: 878389
Change-Id: I5c226325dbbfc2f0f044986e03943e08ff4330e3
Reviewed-on: https://chromium-review.googlesource.com/1195672Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587185}

This reverts commit 7456855a.

Reason for revert: Causing at least one, potentially two issues. Will fix and reland to new branch instead.

Original change's description:
> Android horizontal tab switcher entrance/focus animation improvements
> 
> This adds a non-overlapping specific animation where each card is moving
> directly back to its place in the stack, rather than doing the slightly
> curving motion that is needed for an overlapping stack. It gets rid of the
> final remaining issues aroudn horizontal tab switcher enter/exit animations
> 
> 
> 
> Change-Id: I3e4ff3adbab67e7e6a970cbd5eac59f1b703a667
> Bug: 846166
> Reviewed-on: https://chromium-review.googlesource.com/1118751
> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584836}

TBR=yusufo@chromium.org,mdjones@chromium.org,rlanday@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 846166, 876685
Change-Id: Ib1f06123b10936fb0d71909c6f40a255963c8817
Reviewed-on: https://chromium-review.googlesource.com/1195668Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587184}

Route calls to handle keyboard events through BridgedNativeWidgetHost,
instead of calling into the views::View, which will exist only in the
browser process. The event handling functions need to "know" if the
event was handled, so make the calls synchronous and return whether or
not the event was handled.

Add similar routing for menu dispatching.

Also add the method GetIsFocusedViewTextual to BridgedNativeWidgetHost,
since it is nearby and similar.

Bug: 859152
Change-Id: I67b21dbd736fc4ccbb5c5216707dd3a1667d6ef5
Reviewed-on: https://chromium-review.googlesource.com/1192267
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587183}

Change-Id: I42730027ac84ccec1a03dd9034d0090036e72149
Reviewed-on: https://chromium-review.googlesource.com/1195433Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587182}

Bug: 878535
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib533d391f818054defe9284804e230edfbffdfb3
Reviewed-on: https://chromium-review.googlesource.com/1194963
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587181}

When hit testing with an iframe element as stop node, the hit test
should not descend into the iframe's content document.

BUG=827639
R=chrishtr@chromium.org

Change-Id: I3723d83486f8b733d7354c9112496aff1e43afe4
Reviewed-on: https://chromium-review.googlesource.com/1194977Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587180}

In Android Page Load Metrics (PLM) observer, use network
quality tracker (NQT) instead of Network Quality Estimator (NQE).

Change-Id: I63931acb6842b01ae135a0f96de64c52d7e146d7
Bug: 878844
Reviewed-on: https://chromium-review.googlesource.com/1189707Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587179}

I want to change the bottom bits of a few terms in
https://skia-review.googlesource.com/c/skia/+/150130 to match skcms,
but there will be a dozen or so imperceptible layout test diffs.

While here, clean up a few defines that do nothing, and fix spelling.

Bug: skia:8278
Change-Id: I0c68e8ac5e68e1cab2f61b8b9be01a7fdc7e6206
Reviewed-on: https://chromium-review.googlesource.com/1194960Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587178}

Bug: 840367
Change-Id: I34fc6971149872c00ef5c79c91857311d1341e24
Reviewed-on: https://chromium-review.googlesource.com/1178304Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587177}

It would be useful for the SafeBrowsing backend team to be able to
know if a download is encrypted, since some UwS campaigns download
an encrypted ZIP and provide the password separately. This CL takes
the is_encrypted field from ZipReader and puts it into the
ClientDownloadRequest to be send to the SB backend

Bug: 874621
Change-Id: I3c369b8753baf619a2b18af5cb168f98a3d208cc
Reviewed-on: https://chromium-review.googlesource.com/1186034
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587176}

Mojo messages to the renderer are queued in the browser process if the
target renderer is not yet launched or dead and not respawned yet. This
can lead to memory leaks when the renderer doesn't come back.

This CL avoids such a memory leak in
TabSpecificContentSettings::OnContentSettingChanged by only posting a
message to the renderer if RenderProcessHost::IsInitializedAndNotDead
returns true. When the renderer is recreated,
RendererUpdater::InitializeRenderer should pass the current content
settings rules down so they are immediately available again.

BUG=875937

Change-Id: I230961e469f0b354e191293b00035f7604c2add2
Reviewed-on: https://chromium-review.googlesource.com/1194542
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587175}

Change-Id: I60521b36cb903ca18d59fe88caa1a9c7b1aa9e87
Reviewed-on: https://chromium-review.googlesource.com/1182377Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587174}

Bug: 878356
Change-Id: I19972d5ae7c4be89328e2040c8a436ef6ae55fb9
Reviewed-on: https://chromium-review.googlesource.com/1194076
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587173}

Bug: 863927
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
Change-Id: I54338519ca436c176356bb9f7f50cf1f648a316f
Reviewed-on: https://chromium-review.googlesource.com/1180432
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587172}

Bug: 850409
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
Change-Id: I045e7cd4e8aa68e578245ca90aefca264158013b
Reviewed-on: https://chromium-review.googlesource.com/1186156
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587171}

Since fullscreenchange event is sent by the rAF event loop it is possible
that the fullscreenElement might change and not be observed at the time
you read the event. Fix the tests so they are robust.

Fix the ordering of which fullscreen elements are handled in pending
frames. Otherwise we might end up with incorrect ordering.

BUG=874444

Change-Id: I00c228e0aea7794564e522a3883573ea359235f1
Reviewed-on: https://chromium-review.googlesource.com/1194726
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587170}

Zircon for ARM64 has different kernel images for QEMU versus physical
devices, at present.  Fix the runner script to use the correct kernel
image for QEMU, when targeting ARM64.

Bug: 877194
Change-Id: I5131177e4299bcb4f505a90a356c0b2cdf14d283
Reviewed-on: https://chromium-review.googlesource.com/1195102
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587169}

We don't need to create SnippetsBridge and its native counterpart for
the Feed NTP.

Bug: 870929
Change-Id: If0551db89f5d87468dd1cff8f7af495b017328ce
Reviewed-on: https://chromium-review.googlesource.com/1195047Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587168}

1. TestUrlRequestCallback had a race between destruction and
   operations performed after SignalDone().  SignalDone() can
   cause the TestUrlRequestCallback to be deleted by the test,
   so doing anything that references the "this" pointer after
   SignalDone() is risking a use-after-free.
2. When Cronet_UrlRequest_Read() is called on a UrlRequest in
   the "done" state it returns success, but doesn't free the
   buffer passed in even though it should take ownership the
   buffer. This fixes a ASAN failure when direct executors
   are used.

Bug: 869402
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I544a40fceb3f40c753045f617f6cf7ba937fe556
Reviewed-on: https://chromium-review.googlesource.com/1194955Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587167}

https://android.googlesource.com/platform/external/perfetto.git/+log/6129aae39217..2d795663ffcc


git log 6129aae39217..2d795663ffcc --date=short --no-merges --format='%ad %ae %s'
2018-08-29 hjd@google.com perfetto: add trace processor library for internal consumption


Created with:
  gclient setdep -r src/third_party/perfetto@2d795663ffcc

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I2a2084c6618c190f30ceab55458d359a2159bcf6
Reviewed-on: https://chromium-review.googlesource.com/1195052Reviewed-by: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587166}

This is a pretty-much direct port of the existing logic within
ToolbarModel.java for Query In Omnibox.

It's meant to eventually be used cross-platform on both Desktop as well
as on Android.

For now this CL just adds the native implementation with a test.

Bug: 874592
Change-Id: I27da02126d52d963b2e4c56d10b9cd1c16b0c8b5
Reviewed-on: https://chromium-review.googlesource.com/1188598Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587165}

NOTRY=true

Bug: none
Change-Id: I537911a70fd851015fd231563642a3b7506a9659
TBR: katie@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1195658Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587164}

Animate windows when they are released. Also change HomeLauncherGesture
so its lifetime is not controlled by tablet mode on off.

Test: manual
Bug: 872319
Change-Id: Ia99ea6409f7187f7f62a13ddfb3f54b679fdd0be
Reviewed-on: https://chromium-review.googlesource.com/1194969
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587163}

This change removes some of the extension secondary UI (there turns out to be
quite a lot...) and cleans up the build files.

Bug: 832676
Change-Id: Ie78071a8247f36f39839450a6cf50edda7294653
Reviewed-on: https://chromium-review.googlesource.com/1194957Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587162}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/11dd0afb3809..86a2ffa02e46


git log 11dd0afb3809..86a2ffa02e46 --date=short --no-merges --format='%ad %ae %s'
2018-08-29 xixuan@chromium.org Revert "cbuildbot: Move reef to skylab and non-important."


Created with:
  gclient setdep -r src/third_party/chromite@86a2ffa02e46

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I82e48248f0b666b2556e87367244df368f6e811b
Reviewed-on: https://chromium-review.googlesource.com/1195051Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587161}

In TouchActionFilter::ReportTouchAction, we still have the temporary
which sets touch actions to Auto if there is no |scrolling_touch_action_|.
We do not need this anymore, so this CL removes it.

TBR=dtapuska@chromium.org

Bug: None
Change-Id: Ibd5b5210d411399eb8691df0076b72d371a14c33
Reviewed-on: https://chromium-review.googlesource.com/1195437Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587160}

Fixes PaymentRequestShowEGTest.testBuyWithRejectingPromise on device by
manually waiting for the payment screen to show as EG synchronization is
disabled.

Fixes and re-enables PaymentRequestShowEGTest.testBuyWithResolvingPromise
by dismissing the error page in the previous test (needed when all tests
in the suite are run) and thus resetting the PaymentRequestManager state.

Bug: 833562,871680
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id48ee49d89da2aedacbe23d6a6e9e2b97aa51f11
Reviewed-on: https://chromium-review.googlesource.com/1191794Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587159}

This fixes a class of bugs where the shelf widget (and its delegate
view) weren't always made aware of the shelf background changes and
thus weren't changing the shelf's shape as necessary.

One example is opening and closing the app list when a window is
maximized (the shelf widget wouldn't be aware of the change of state
after the app list disappears and the rounded corners would remain).

Bug: 878599
Change-Id: I60db4a9a2be5e20ea4a45df833fc4136ca7f3666
Reviewed-on: https://chromium-review.googlesource.com/1194506Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587158}

This CL updates LocalInputMonitor so it can be initialized and started
in separate calls.  This allows an instance to be created with the
appropriate task runners and then passed into a different class which
can set the callbacks for each input type.

This change makes usage of the monitor simpler for classes, like the
disconnect window, which do not have knowledge of task runners.  It
also decouples the mouse/keyboard input monitors from
ClientSessionControl and allows them to be used for other purposes.

Change-Id: I6c05acd84090cb4210b81863c09d243412c1bd87
BUG: 877176
Reviewed-on: https://chromium-review.googlesource.com/1187015
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587157}

Revert "[Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland)."

This patch reverts:
- https://crrev.com/586836 - [Base] Support ::GetThreadPriority() returning THREAD_PRIORITY_IDLE.
- https://crrev.com/586311 - [Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland).

The https://crrev.com/586836 is reverted since it is atop of the https://crrev.com/586311.

TBR=gab@chromium.org

R=fdoray, gab

Bug: 878779
Change-Id: If13da0992065eed1b5cc4f39c26e5339454d9230
Reviewed-on: https://chromium-review.googlesource.com/1194035
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587156}

The callback form base::Closure is deprecated. Since attaching callback
is invoked at most once, the type should be base::OnceClosure.

Bug: None
Change-Id: I6684bef45d511218dea21d8a7847e7608420af4e
Reviewed-on: https://chromium-review.googlesource.com/1187267Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587155}

And use it to simplify and speed up code in LayoutNGBlockFlow

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I56c486b66376497fc89b5c18ee5bbdf910573eb1
Reviewed-on: https://chromium-review.googlesource.com/1195502
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587154}

If user is under advanced protection, refresh OAuth2 id token every 24 hours to
determine if they are still in this program.
If user's status is unknown when initiating AdvancedProtectionStatusManager,
refresh OAuth2 token right away (a.k.a in a minute).

(If user is known to NOT in advanced protection, no need to
refresh. This is because the enrollment of advance protection will
trigger reauth in every active sessions.)

Change-Id: Iec2eaffc603d9a909e0e5d1d6a5ea6b959f9960a
Bug: 866620
Reviewed-on: https://chromium-review.googlesource.com/1178979Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587153}

Clock has 3dip padding on the left and the right. Old System Tray had
3dip padding on the right, because clock was on the left. In Unified,
clock is on the right, so we should swap the horizontal padding.

TEST=manual
BUG=860796

Change-Id: I6b21f8cc27228f83500adc4062564a83211fbdcc
Reviewed-on: https://chromium-review.googlesource.com/1192565Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587152}

Bug: 865565
Change-Id: I13eb0ff3798c75705c8e6e5f0420722c4205787f
Reviewed-on: https://chromium-review.googlesource.com/1185533
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587151}

Users of MediaLog have to be careful about the lifetime of the
object, since it's passed around as a raw ptr.  For things like
VdaVideoDecoder, which operate on multiple threads, it requires
special care that the log isn't used after VdaVideoDecoder is
no longer allowed to use it.

ChildMediaLog wraps a MediaLog, and provides an atomic way to
prevent access to the underlying MediaLog.  For example,
VdaVideoDecoder can do this when it's Destroy()ed, which is when it
must stop using the MediaLog that it was given.  Additional calls
to ChildMediaLog will do nothing.

The ChildMediaLog itself can be kept around until the other thread
is definitely done using it.

This also fixes es_parser_mpeg1audio_fuzzer, which caused a revert
of https://chromium-review.googlesource.com/1139219 .

TBR=sandersd

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I317e7877feacbacf2d949d3e5ee9348742e2a572
Reviewed-on: https://chromium-review.googlesource.com/1194786Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587150}

In case of the very unlikely event of disabling user consent recording via the separate sync data type UserConsentSpecifics, this fallback logic kicks in and records the consent via the event logger.

Bug: 867919
Change-Id: Ie10fc2ba374f47a914796e175c4e34f9921a976d
Reviewed-on: https://chromium-review.googlesource.com/1193892
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587149}