GitLab

R=hugo.holgersson@sonymobile.com,lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/835163003

Cr-Commit-Position: refs/heads/master@{#310172}

stream where available.

BUG=403138

Review URL: https://codereview.chromium.org/816193003

Cr-Commit-Position: refs/heads/master@{#310171}

This is one of the top 20 histogram by used data
size, but is unowned (thus doesn't show up on
the dashboard by default) and the data for it
has 99% of of samples fall under 3ms.

BUG=387734

Review URL: https://codereview.chromium.org/836233002

Cr-Commit-Position: refs/heads/master@{#310170}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2ad2a0a..4cdbe42

TBR=dglazkov@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/839643002

Cr-Commit-Position: refs/heads/master@{#310169}

The rotation lock tray was in an incorrect position within the system tray. This change moves it to be above the Settings item.

TEST=Have a device in maximize mode, open the system tray.
BUG=443654

Review URL: https://codereview.chromium.org/813353004

Cr-Commit-Position: refs/heads/master@{#310168}

BUG=444957

Review URL: https://codereview.chromium.org/831283002

Cr-Commit-Position: refs/heads/master@{#310167}

These events have been enabled during the M-41 dev cycle and are ready
to be enabled for M-41 stable.

BUG=442543

Review URL: https://codereview.chromium.org/835993003

Cr-Commit-Position: refs/heads/master@{#310166}

BUG=442514

Review URL: https://codereview.chromium.org/821693003

Cr-Commit-Position: refs/heads/master@{#310165}

The deleting of the temporary accent character will cause the pending accent
to be cleared so we have to keep it around for the keypress and separately
record what the new pending-accent will be once we're done.

BUG=230921

Review URL: https://codereview.chromium.org/834293002

Cr-Commit-Position: refs/heads/master@{#310164}

BUG=396626
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/835423002

Cr-Commit-Position: refs/heads/master@{#310163}

AutofillAgent::FrameDetached is no longer necessary because form_cache_ only holds the forms for a single frame.
AutofillAgent::FrameWillClose is only called on the actual closing frame (which might be a parent frame).
AutofillAgent::FrameDetached can't take the place of AutofillAgent::FrameWillClose because the RenderFrame disables sending IPCs during detachment.

Therefore, move the automatic closing of rAc from the renderer (autofill_agent.cc) to the browser (chrome_autofill_client.cc).

For PasswordAutofillAgent, add FrameDetached to RenderFrameHost.

BUG=433486

Review URL: https://codereview.chromium.org/796493004

Cr-Commit-Position: refs/heads/master@{#310162}

It's not enough to know what version of the shared module is installed, we
also need to know the language, since the web store splits up crxs by
language/platform tuples. The only way to find out which language is
installed is by looking at what files are available. In our case,
looking at the contents of the _platform_specific directory.

Review URL: https://codereview.chromium.org/804193003

Cr-Commit-Position: refs/heads/master@{#310161}

RenderWidgetHost::GetView() may return NULL, e.g. if the renderer has
crashed. MessageService::OpenChannelToNativeApp() wasn't handling this
case properly.

BUG=374778

Review URL: https://codereview.chromium.org/787253009

Cr-Commit-Position: refs/heads/master@{#310160}

BUG=428729

Review URL: https://codereview.chromium.org/833403002

Cr-Commit-Position: refs/heads/master@{#310159}

This bring in:
a48ead9 Re-enable pdfium_unittests.
dd132d8 Update externs in unicodenormalization.cpp to not have array sizes.
c5f520c Get rid of g_timeMap global object.
f964049 Fix an array size mismatch.
286ea1d Remove run-time calculation of hash constants in pdfium.
a975cfa Get rid of fifteen copies of m_sTimeMap and their initializers.
2638428 Clean up bookmark related codes.
17b5cf4 Remove static declared SymbolDictCache.
07f10ae In windows printing, convert src bitmap to dest bitmap using CompositeBitmap.
d66051b Remove g_NaN global variable and its constructor.
659a56b Get rid of FX_LPCSTR cast.
3fc36e8 Revert build of pdfium_unittests.
831e138 Fix pdfium buildbot build breakage from 336991d.
336991d Create pdfium_unittests binary.
6c06469 Refactor some code in CPDF_TextPage::ProcessTextObject().
59dffb6 Fix new third_party/BUILD.gn to use the right build configuration.
06b087a Set the freetype options missing in the recent update.
b3a3230 Add the license back to ftmodule.h after the freetype 2.5.4 upgrade.
a09d50d Transform font size to user space for valid text size comparison.
e4fc5ce Update freetype to 2.5.4.

Review URL: https://codereview.chromium.org/789613007

Cr-Commit-Position: refs/heads/master@{#310158}

This patch sets up DevicePermissionsPrompt::Prompt as a
UsbService::Observer so that the UI is updated whenever a device
is connected or disconnected.

BUG=411715

Review URL: https://codereview.chromium.org/839453002

Cr-Commit-Position: refs/heads/master@{#310157}

Based on the latest revelations:
440919 WindowImpl::WndProc2 = 90 jph.
Since the internals of OnWndProc are instrumented, this strangely indicates that it's GetWindowUserData who is responsible for this jank. Instrumenting it.

440919 <<MessagePumpForUI::ProcessNextWindowsMessage>> = 46 jph and
440919 MessagePumpForUI::ProcessMessageHelper = 39 jph
This means that with instrumenting MessagePumpForUI::ProcessMessageHelper, we've divided MessagePumpForUI::ProcessNextWindowsMessage into 2 roughly equal parts: everything that happens inside MessagePumpForUI::ProcessMessageHelper, and everything outside (GetQueueStatus and PeekMessage).
Adding in instrumentation to separate GetQueueStatus from PeekMessage.
Also instrumenting internals of MessagePumpForUI::ProcessMessageHelper.

BUG=440919

Review URL: https://codereview.chromium.org/835183002

Cr-Commit-Position: refs/heads/master@{#310156}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f48415c..2ad2a0a

TBR=dglazkov@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/841573002

Cr-Commit-Position: refs/heads/master@{#310155}

This CL adds the chrome.bluetoothPrivate.disconnectAll function, which can
be used by whitelisted extensions to teardown all connected data bearers
to a remote Bluetooth device.

BUG=441058

Review URL: https://codereview.chromium.org/819713002

Cr-Commit-Position: refs/heads/master@{#310154}

This makes SHMEM implementation of discardable memory preferred
over EMULATED implementation. This effectively makes SHMEM the
implementation used by default on Linux, CrOS and Windows.

SHMEM implementation of discardable memory gives the browser
process control over the total amount of discardable memory used
and allows us to enforce a global limit of 512MB across all
renderers.

BUG=429415,429416

Review URL: https://codereview.chromium.org/793443003

Cr-Commit-Position: refs/heads/master@{#310153}

ChromeOS doesn't have toggleable num lock; it is always considered
enabled. Always set num lock in the xkb modifier mask.

BUG=34920
TEST=numpad on link_freon generates numbers

Review URL: https://codereview.chromium.org/834373002

Cr-Commit-Position: refs/heads/master@{#310152}

This is used downstream for a more specific permissions check.

BUG=434128

Review URL: https://codereview.chromium.org/836913003

Cr-Commit-Position: refs/heads/master@{#310151}

BUG=466575
TBR=nasko@chromium.org

Review URL: https://codereview.chromium.org/834423002

Cr-Commit-Position: refs/heads/master@{#310150}

This CL adds support for a native confirmation dialog shown after the
user presses "Share" on the webapp but before an access code is
generated. It also includes a ChromeOS (Aura) implementation.
Implementation for other platforms will soon follow.

More details
============

It2MeConfirmationDialog is an interface for the confirmation dialog.
Implementations can assume they will be called only on the UI thread.

It2MeConfirmationDialogFactory is used to create platform specific
implementations of the dialog.

It2MeConfirmationDialogChromeOS is the dialog's ChromeOS implementation.

It2MeConfirmationDialogProxy is a helper class that allows the caller
(in this case, It2MeHost) to use the dialog outside of the UI thread.

BUG=444216

Review URL: https://codereview.chromium.org/816903002

Cr-Commit-Position: refs/heads/master@{#310149}

Change the PhaseBegan to not cause a vertical scroll.

Deltas for PhaseBegan events are incorrectly
ignored by ScrollElasticityController. The PhaseBegan deltas are not
ignored by impl-side scrolling, which causes the test to fail. If
ScrollElasticityController is corrected to not ignore PhaseBegan deltas,
the test fails as well.

By changing the delta for PhaseBegan, the test passes both with
impl-side scrolling and with the corrected ScrollElasticityController.

BUG=133097

Review URL: https://codereview.chromium.org/811383003

Cr-Commit-Position: refs/heads/master@{#310148}

BUG=none
TEST=compiled locally with clang
NOTRY=true

Review URL: https://codereview.chromium.org/835383003

Cr-Commit-Position: refs/heads/master@{#310147}

Revert of Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/824063002/)

Reason for revert:
The reason for the revert was resolved: crbug.com/445051

Original issue's description:
> Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/818443002/)
>
> Reason for revert:
> Breaks devtools highlight on hidpi screens. See crbug.com/445051.
>
> Original issue's description:
> > Enable display list 2D canvas by default
> >
> > With this change, display list 2D canvas will become enabled by
> > default in Chrome. Content shell with --dump-render-tree will
> > continue to have display lists disabled by default.
> > Currently, having display lists enabled in blink means
> > that display lists will be used whenever 2d canvases would
> > not be GPU-accelerated.
> >
> > BUG=386601
> >
> > Committed: https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae
> > Cr-Commit-Position: refs/heads/master@{#309453}
>
> TBR=avi@chromium.org,junov@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=386601
>
> Committed: https://crrev.com/5b6f044b9bc14af9b265746d31db547be18d9dbb
> Cr-Commit-Position: refs/heads/master@{#309635}

TBR=avi@chromium.org,pfeldman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=386601

Review URL: https://codereview.chromium.org/837773003

Cr-Commit-Position: refs/heads/master@{#310146}

Revert of Special check on Supervised User creation flow added to prevent misleading shelf alignment. (patchset #3 id:40001 of https://codereview.chromium.org/783663003/)

Reason for revert:
Appears to have caused bug 446212

Original issue's description:
> Special check on Supervised User creation flow added to prevent misleading shelf alignment.
>
> BUG=405361
>
> Committed: https://crrev.com/e2b59c4c229ec214150f522f4b3f6b02d9cefaee
> Cr-Commit-Position: refs/heads/master@{#309555}

TBR=dzhioev@chromium.org,skuhne@chromium.org,merkulova@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405361

Review URL: https://codereview.chromium.org/830393004

Cr-Commit-Position: refs/heads/master@{#310145}

This is https://codereview.chromium.org/835193005 rolled a little further and
with some additional changes:

It fixes the FallbackSCSV tests to no longer be a no-op. It also accounts for
BoringSSL's handling of a handshake_failure in response to a ClientHello to
match NSS's behavior and our test expectations. See https://crbug.com/446505
for details.

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/306e520..aac2f6a

BUG=446505

Review URL: https://codereview.chromium.org/834313002

Cr-Commit-Position: refs/heads/master@{#310144}

Although the sub-pictures already have the layer hoisting
data, Skia cannot access it unless the wrapping picture has
also gone through the hoisting analysis. Fortunately or
unfortunately, this is piggy-backed upon BBH creation (so
providing the kComputeSaveLayerInfo_RecordFlag by itself
is not sufficient).

BUG=383085

Review URL: https://codereview.chromium.org/797793005

Cr-Commit-Position: refs/heads/master@{#310143}

Interstitial pages are loaded via data url and cannot access
chrome://text_default.css. Until the way they're loaded is changed,
we have to use the old way.

While I'm at it, I made supervised_user_block_interstitial.html use
IDS_WEB_FONT_FAMILY instead of the hard-coded fonts in the corresponding
css. This change is for bug 303849.

BUG=443203,303849
TEST=See comment 4 in the bug 443203. See also http://crbug.com/444698

Review URL: https://codereview.chromium.org/808753006

Cr-Commit-Position: refs/heads/master@{#310142}

Linux Zygote sandboxing code keeps an fd for /proc while starting the
BPF sandbox (but ensures that it is closed later). This moves the
responsibility to the caller to ensure that no directory fds are present
after sandboxing is enabled.

Also adds WARN_UNUSED_RESULT to some important functions that return a
bool indicating success or failure.

BUG=312380

Review URL: https://codereview.chromium.org/835623005

Cr-Commit-Position: refs/heads/master@{#310141}

On platforms where libusb supports hotplug events this observer interface
allows clients of UsbService to be notified when devices are added and
removed from the system. When hotplug events are not available these
events are only generated in response to an explicit enumeration request.

The UsbDevice::Observer interface has been removed so that UsbDevice can
be a truly thread-safe object.

BUG=411715

Review URL: https://codereview.chromium.org/809743006

Cr-Commit-Position: refs/heads/master@{#310140}

In order to allow Vsync to be toggled by dev tools we need to both set the swap
interval to 0 on systems that support it and prevent the scheduler from
throttling frames.

BUG=437172

Review URL: https://codereview.chromium.org/811523002

Cr-Commit-Position: refs/heads/master@{#310139}

BUG=none

Review URL: https://codereview.chromium.org/819683002

Cr-Commit-Position: refs/heads/master@{#310138}

BUG=None

Review URL: https://codereview.chromium.org/836203002

Cr-Commit-Position: refs/heads/master@{#310137}

https://codereview.chromium.org/831863003 has enabled strict checks
for {virtual,override,final} on Linux. This CL fixes build issues
for Ozone on Linux.

BUG=417463

Review URL: https://codereview.chromium.org/825783003

Cr-Commit-Position: refs/heads/master@{#310136}

On the bots the rsync technique to download packages (see bug for more details)
takes too long. It takes almost 30 seconds even when the package is already on
the bot. Instead always download the zip and unzip it.

BUG=350151

Review URL: https://codereview.chromium.org/799673003

Cr-Commit-Position: refs/heads/master@{#310135}

BUG=446332

Review URL: https://codereview.chromium.org/815573004

Cr-Commit-Position: refs/heads/master@{#310134}

The checkbox controlling syncing of WiFi credentials should
be labeled "Wi-Fi networks", since that's easier for users
to understand. This CL makes it so.

BUG=chromium:436916
TEST=manual (open chrome://settings/syncSetup, verify text)

Review URL: https://codereview.chromium.org/838523002

Cr-Commit-Position: refs/heads/master@{#310133}