- 26 Sep, 2018 40 commits
-
-
Manas Verma authored
Before, the promo title would be different depending on whether or not the user is signed in — "...sign in and turn on sync." vs "...turn on sync." Now with the new DICe UI, promo titles will not include "sign in and ". So regardless of whether the user is signed-in, the promo title will now be "To use your cards on all devices, turn on sync." Bug: 872825 Change-Id: I5de9061ac8ad5771f803ba4f66969338746256a1 Reviewed-on: https://chromium-review.googlesource.com/1246363Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#594493}
-
Khushal authored
This trace event was removed in [1] but is needed by telemetry scripts to measure the decode time for images in perf tests. NOTE TO PERF SHERRIFS A regression in blink_perf.image_decoder benchmark is expected from this change since it restores this benchmark. R=chrishtr@chromium.org Bug: 881192 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I100082d30f2ebed4c8d7efa91a22c4670d4c2492 Reviewed-on: https://chromium-review.googlesource.com/1246272Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#594492}
-
Paul Miller authored
This reverts commit ef70c85e. Reason for revert: WebView now supports permanent-consistency. BUG=866722 Original change's description: > WebView: Ignore permanent-consistency experiments > > Android WebView currently treats permanent-consistency experiments > (which are intended to retain their group assignments across runs) as > session-consistency (which are intended to be randomly assigned on each > run). It's safer to not apply permanent-consistency experiments to > WebView at all, to avoid mistakes. > > BUG=866722 > > Change-Id: I9d501437718d934c2a59b95335c787302ce758e7 > Reviewed-on: https://chromium-review.googlesource.com/1148991 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Paul Miller <paulmiller@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578070} TBR=changwan@chromium.org,holte@chromium.org,paulmiller@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866722 Change-Id: Ifd00450fbba1afc1db619109cf918ef75cbcf84f Reviewed-on: https://chromium-review.googlesource.com/1237244Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594491}
-
Sarah Hu authored
use password/PIN to unlock. Bug: 879297 Change-Id: Ia4518584977f24af1b7f7f2a849d1dc598e5fc95 Reviewed-on: https://chromium-review.googlesource.com/1211804Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#594490}
-
Clark DuVall authored
This is a speculative fix for http://crbug.com/884638. What I believe is happening is the RenderFrame is being destroyed while the WeakWrapperSharedURLLoaderFactory is still alive, and a request attempts to use it. This seems to be happening the most when the AdDelayThrottle is enabled and is delaying ads requests, which may explain why the request is finishing after the RenderFrame is destroyed. Bug: 884638 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I66960e5c5150345e7fd59f5ab5795414ec482a71 Reviewed-on: https://chromium-review.googlesource.com/1241955Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594489}
-
Kevin Bailey authored
This CL describes an experiment to see if a dark blue keyword mode button will make it more visible and attention-getting. Bug: 883901 Change-Id: Ibef0b56b1a36f6debae0a446123632e173448c48 Reviewed-on: https://chromium-review.googlesource.com/1234035 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#594488}
-
James Cook authored
This makes it easier to find and consistent with ChromeShellDelegate. Also cleanup unnecessary includes in ChromeShellDelegate. I'm doing this because I may need to add a method to the delegate. Bug: none Test: existing browser_tests, manually test magnifier Change-Id: Icf0fdda4f6bea0f9fc3c281902e87fc036764950 Reviewed-on: https://chromium-review.googlesource.com/1246661Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#594487}
-
Scott Chen authored
This is to prepare for a following CL to move all the components/nux/ backend code to chrome/browser/ui/webui/welcome/. The decision to move components/nux/ to chrome/browser/ui/webui/welcome/ is based on the fact that nux is only ever going to be used in webui and exclusively within the welcome flow. Bug: 874122 Change-Id: I873047c06dc76f14c4d9affb5c3829dc0f4b5e18 Reviewed-on: https://chromium-review.googlesource.com/1229333 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594486}
-
Mathieu Perreault authored
Will only log the validity of PaymentsCustomerData's billing customer id during the full card request. This is the only moment we can be sure that the user has an account. Bug: 884689 Change-Id: I74699f14827e2954ac03480f17ac7f51b391ae73 Reviewed-on: https://chromium-review.googlesource.com/1246289 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594485}
-
Justin DeWitt authored
When testing end-to-end, found some problems with the Fetcher: * POST is not accepted by the server, converted to GET (using query params) * URL was not set in the request * URL utils had a bug causing "/v1/" to be missing from the path. Bug: 867488 Change-Id: Ie60010bc45ac67923d211bce2a84248186f2dbc0 Reviewed-on: https://chromium-review.googlesource.com/1247021Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594484}
-
Alexei Filippov authored
No changes to the class except renaming from HeapTrackingOverviewGrid BUG=889545 Change-Id: I6ffd4d40e7ca9d34e37794ebcc1a631ad3b40ff9 Reviewed-on: https://chromium-review.googlesource.com/1246362 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594483}
-
danakj authored
This bool is always true, and is not used. No need to send it. Also removes the dead needs_repainting_on_restore_ from the RenderWidgetHostImpl. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: I673e5de215a9118b061478260d0dc012ae078d37 Reviewed-on: https://chromium-review.googlesource.com/1246942Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594482}
-
Joanmarie Diggs authored
Preferring the title attribute over "submit" means that end users will potentially get a more precise name for the widget. In addition, because both Gecko and WebKit prefer the title attribute, making this change will increase interoperability. Lastly, the HTML-AAM does state user agents can use the title attribute; using "submit" is presented as an option. Note that a bug has been filed against the HTML-AAM because such options seem to decrease rather than increase the likelihood of interoperability. Bug: 889562 Change-Id: I73b4f6ed79488d7e2eb41e9ae80aabafe8590a88 Reviewed-on: https://chromium-review.googlesource.com/1246724 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594481}
-
Sarah Hu authored
Bug: 888704 Change-Id: I3d6ccd1d4d4d19377db2d0698ac403ff79cd40e6 Reviewed-on: https://chromium-review.googlesource.com/1244124 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594480}
-
Kevin Marshall authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org TBR=sergeyu@chromium.org TBR=mmenke@chromium.org Change-Id: I470f7f3a9b10ed9c31b40b02e1f5a01a36ff25f4 Reviewed-on: https://chromium-review.googlesource.com/1246955 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594479}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c6bd073ee01..5767fc042834 git log 6c6bd073ee01..5767fc042834 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 96a1ceb171cf..3d27f2e721ed (1 commits) 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 82ea7fbce65f..0eb21d4ecadd (1 commits) 2018-09-26 mtklein@google.com refactor downsamplebitmap GM Created with: gclient setdep -r src/third_party/skia@5767fc042834 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I8193bbb55af0b0c38bcb8501b413a950b2110246 Reviewed-on: https://chromium-review.googlesource.com/1246835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594478}
-
Pavel Feldman authored
This is a reland of 3321d814 Original change's description: > DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter. > > Change-Id: Ic22c1bf38aaf8e5d3e7caabf3c686c8c45b985b0 > Reviewed-on: https://chromium-review.googlesource.com/1244460 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594161} Change-Id: I8a33e70976a2e52b7f69c5b2d0fa4e5af3594c6a Reviewed-on: https://chromium-review.googlesource.com/1246901Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594477}
-
chrome://discardsSigurdur Asgeirsson authored
Bug: 874968 Change-Id: I289e12b23e3bac144615ca5cfbe861e22404170a Reviewed-on: https://chromium-review.googlesource.com/1244497Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594476}
-
Chris Palmer authored
Bug: 888926 Change-Id: Iab0d82d272e2f24a5e91180d64bc8e2aa8a8238d Reviewed-on: https://chromium-review.googlesource.com/1246827Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594475}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74114507769e..74419b36e4b2 git log 74114507769e..74419b36e4b2 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 dgarrett@chromium.org chromeos_config: Mark eve/nocturne as important again. 2018-09-26 chrome-bot@chromium.org Update config settings by config-updater. 2018-09-26 dgarrett@google.com chromeos_config: Mark initial firmwarebranch builds active. 2018-09-26 dgarrett@google.com chromeos_config: Create firmwarebranch builders. Created with: gclient setdep -r src/third_party/chromite@74419b36e4b2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3d93c09b8e19bb4abecc0e7f350b6c8fb57209a6 Reviewed-on: https://chromium-review.googlesource.com/1246237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594474}
-
Sergey Ulanov authored
GN now supports string_replace(), which allows to remove namespace_path TBR=dcheng@chromium.org (trivial change in //base) Change-Id: Iac8a71b6962cf48bc7a79e2f7fc62a88969f80a1 Reviewed-on: https://chromium-review.googlesource.com/1246834 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594473}
-
Weidong Guo authored
Bug: 884889 Change-Id: If9c93d44de4693ded68e09947d8bee1fff00c471 Reviewed-on: https://chromium-review.googlesource.com/1246151 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594472}
-
Shakti Sahu authored
This CL connects offline item with the download shelf. Some of the OfflineItemModel methods are still not implemented. Bug: 881499 Change-Id: I2f0cd71815a08bcddfca753378543749389d78db Reviewed-on: https://chromium-review.googlesource.com/1239875 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594471}
-
Kevin Marshall authored
This CL adds cookie support to the browser, so that the content layer can set and query cookies. * TestLauncher modified to give isolated /data directories to child processes. * Browsertests added to test cookie support in incognito/in-memory and persisted cases. Bug: 858853 Change-Id: Ia22e27778323e5b08fd872a2b29b4c7d879f80a0 Reviewed-on: https://chromium-review.googlesource.com/1168479Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594470}
-
Jeffrey Kardatzke authored
Recently we updated all timeouts in cicerone to be longer because we were running into too many failures relating to timeouts and we should be much more lenient with that for now. We also avoid using the D-Bus default timeout now as well in here so the values are well known. BUG=chromium:849438 TEST=Builds Change-Id: I6fef4a25c1056d91fc4059146fa2a67094ad9a5d Reviewed-on: https://chromium-review.googlesource.com/1246784Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#594469}
-
Jordy Greenblatt authored
Note that there will be a separate CL with password page formatting because it requires some additional tweaks. Specs: https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view?usp=sharing New change screenshots: Start Setup Page: http://screen/1PkWGgTYmVG Setup Complete Page: http://screen/drwnruTOBNw Bug: 878646, 878644 Change-Id: Idf2afceb75dbb1c5b0157ffd8405fceea59cff46 Reviewed-on: https://chromium-review.googlesource.com/1246781Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#594468}
-
Bailey Berro authored
This change adds Start/ContinueReadDirectory methods to SmbProviderClient. These map 1:1 to corresponding smbprovider daemon methods. Bug: chromium:757625 Change-Id: Idb33b81492949b5499fb402686c211948d736f00 Reviewed-on: https://chromium-review.googlesource.com/1228438 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#594467}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b07993ebf420..bfcdc913c418 git log b07993ebf420..bfcdc913c418 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 antiagainst@google.com [ci] Checkout a specific Google Test commit (#1931) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@bfcdc913c418 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8cb0a648eb3496c3191c27a89892a961b60faf40 Reviewed-on: https://chromium-review.googlesource.com/1246478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594466}
-
Alexey Kozyatinskiy authored
Corresponded V8 change was rolled to Chromium. TBR=pfeldman@chromium.org Bug: v8:8200 Change-Id: If887514a6baa6fb293a8ed600a2ca0477debbcb7 Reviewed-on: https://chromium-review.googlesource.com/1246365Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594465}
-
David Tseng authored
TBR=dtseng@chromium.org Change-Id: Ie4a1691308224d015856d93cbee256f6420a0b51 Reviewed-on: https://chromium-review.googlesource.com/1246663Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#594464}
-
Dominic Mazzoni authored
This call makes no sense. There's no reason that loading the speech synthesis component extension should trigger enabling the filesystem in guest mode for a related, but entirely different, extension (ChromeVox). If ChromeVox needs EnableFileSystemInGuestMode, we should be calling this from code that loads the ChromeVox component extension, but I suspect that it doesn't need it at all. As far as I can tell this was accidentally added here as part of a refactoring: https://codereview.chromium.org/1162283002 Note that OnceClosure() would be better, but that'd require a big cleanup of many other functions, so I don't want to do that as part of the same change. Bug: none Change-Id: I1f67b78548048fffa9194083b10e0ff5c5aaa863 Reviewed-on: https://chromium-review.googlesource.com/1246364Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594463}
-
agrieve authored
Follow-up from original review. Change-Id: I375b2f266d3712f20efc769fc822df67701297a3 Reviewed-on: https://chromium-review.googlesource.com/1246836Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#594462}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a53f1444701..1b71de973c63 Created with: gclient setdep -r src-internal@1b71de973c63 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8b3480c33e076d89f23e5f059d998e31ea6c4b86 Reviewed-on: https://chromium-review.googlesource.com/1246474Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594461}
-
David Benjamin authored
It's the exact same code, but no sense in implementing it twice. Bug: none Change-Id: Ie3688b2d56c80b1d513fc5eab37b04aa365417ee Reviewed-on: https://chromium-review.googlesource.com/1246271Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#594460}
-
liberato@chromium.org authored
This CL adds a new flag, UseSurfaceLayerForVideoPIP, which will switch to SurfaceLayer only when entering PIP mode. The player does not switch back when exiting PIP. When doing this, the VideoFrameCompositor, VFS, etc. all run on the compositor impl thread rather than a dedicated media thread. This is to simplify the switchover. This CL also changes the default from Use...Video to Use...PIP. This is based on https://chromium-review.googlesource.com/c/chromium/src/+/1219948 Bug: 883931 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibb612d83df721712929aeab42aba790e32c1a8ea Reviewed-on: https://chromium-review.googlesource.com/1220562Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#594459}
-
Robert Sesek authored
Bug: 832676 Change-Id: Ife9b271854db2b4379d9df1869cc51eb9c2dbaa0 Reviewed-on: https://chromium-review.googlesource.com/1246722 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#594458}
-
rbpotter authored
This reverts commit 525b54bb. Reason for revert: Major changes to input behavior required, pushing to later milestone. Original change's description: > Print Preview Refresh: Make pages a dropdown > > Make pages a dropdown, and only show the custom input if "Custom" > page range is selected > > Bug: None > Change-Id: If29a941ca2ff9d75f08bc1e103ac3d0a836e540c > Reviewed-on: https://chromium-review.googlesource.com/1237241 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594076} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Id2bbfedbf7ab5406a7a583c9acaf9fd5eeac930b No-Presubmit: true No-Tree-Checks: true No-Try: false Bug: 889382, 889383, 889389 Reviewed-on: https://chromium-review.googlesource.com/1246407Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#594457}
-
Joey Arhar authored
This patch adds two fields, _initiator and _priority, to each entry in each HAR file. I chose to use underscores in the exported names because they are not part of the HAR standard and the other non-standard fields we export also have underscores. I tested by importing this new type of HAR file in chrome 69, importing a chrome 69 HAR file with this new patch applied, and by exporting and importing with all types of initiators. Bug: 654536 Change-Id: Ibd96eb6374900f29b03880d3292933b539708f18 Reviewed-on: https://chromium-review.googlesource.com/1232374 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594456}
-
Xida Chen authored
This CL removes an un-necessary included header file in the touch_action_filter.h, there is no behavior change. TBR=nzolghadr@chromium.org Bug: None Change-Id: Iebc8e3269cc96c101392a60f2717662a49b80f21 Reviewed-on: https://chromium-review.googlesource.com/1246410Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594455}
-
Majid Valipour authored
This reverts commit 701add99. Reason for revert: The tests introduced in original CL was failing because it was not being run with the right flags. This happened because CL landed at the same time as another CL which migrated all the tests. Moving test and updating expectations accordingly. https://chromium-review.googlesource.com/c/chromium/src/+/1237235 Original change's description: > Revert "[animation-worklet] Transfrom related worklet animations should respond to zoom" > > This reverts commit dec72e86. > > Reason for revert: > virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html seems to be failing most of the time on all platforms. > > Sample failures: > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/91172 > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/146546 > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/193114 > > Original change's description: > > [animation-worklet] Transfrom related worklet animations should respond to zoom > > > > Worklet animation compositing state should be updated when a zoom or viewport > > resize changes css pixel to dip ratio. > > > > The fix is to simply match what we already do for regular animations for worklet > > animations. > > > > TEST=virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html > > > > Bug: 879107 > > Change-Id: I0b74bd8297e83b18afd087247f09339aedcc618b > > Reviewed-on: https://chromium-review.googlesource.com/1237133 > > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Commit-Queue: Majid Valipour <majidvp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593171} > > TBR=majidvp@chromium.org,smcgruer@chromium.org > > Change-Id: I9eaf621c931ad9003fd7413aeea9f2ec3a7824a4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 879107 > Reviewed-on: https://chromium-review.googlesource.com/1239773 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593414} TBR=mmenke@chromium.org,majidvp@chromium.org,smcgruer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879107 Change-Id: Ib174c0e257c893d9cd5df3d1e6c5157b04603f44 Reviewed-on: https://chromium-review.googlesource.com/1243572Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#594454}
-