- 28 Aug, 2014 40 commits
-
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/fd759a525b9eb5c4889947a317439bd510b2a969..5d3187faa8b0dc282ac6f16311c8ba96bfb91bd8 TBR=mlamouri@chromium.org,hclam@chromium.org Review URL: https://codereview.chromium.org/517783002 Cr-Commit-Position: refs/heads/master@{#292479}
-
Sam Clegg authored
R=binji@chromium.org Review URL: https://codereview.chromium.org/514333002 Cr-Commit-Position: refs/heads/master@{#292478}
-
lfg authored
AppView internal API doesn't need to go through ExtensionsAPIClient anymore, since AppView is now in extensions. BUG=352290 Review URL: https://codereview.chromium.org/498303002 Cr-Commit-Position: refs/heads/master@{#292477}
-
prasadv authored
If the script is switching between Blink and WebKit during bisect, over a year it's been only blink for chromium and we don't need these codes. BUG= NOTRY=true Review URL: https://codereview.chromium.org/513253003 Cr-Commit-Position: refs/heads/master@{#292476}
-
maruel authored
$ git log b8aeeaef0..e7d8b9884 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//' 2014-08-26 vadimsh Fix cacert.pem extraction from zip. 2014-08-26 kmg Add output location on isolateserver to JSON 2014-08-25 vadimsh Make net.url_open reuse connections again. R=vadimsh@chromium.org BUG= Review URL: https://codereview.chromium.org/514173002 Cr-Commit-Position: refs/heads/master@{#292475}
-
mfoltz authored
BUG=338449 Review URL: https://codereview.chromium.org/503503003 Cr-Commit-Position: refs/heads/master@{#292474}
-
felt authored
BUG=404472 Review URL: https://codereview.chromium.org/512983003 Cr-Commit-Position: refs/heads/master@{#292473}
-
dtu authored
-state is disabled by default. BUG=336558 TEST=None. R=tonyg NOTRY=True Review URL: https://codereview.chromium.org/512383002 Cr-Commit-Position: refs/heads/master@{#292472}
-
jmadill authored
These tests were not previously triggered, but were previously failing. BUG=408251 TBR=kbr@chromium.org Review URL: https://codereview.chromium.org/512353003 Cr-Commit-Position: refs/heads/master@{#292471}
-
jvoung authored
Add more checks to test to detect that the resource type of the URL request is indeed OBJECT. Would like to get this merged to the M38 branch. BUG=401755 Review URL: https://codereview.chromium.org/471233003 Cr-Commit-Position: refs/heads/master@{#292470}
-
Sadrul Habib Chowdhury authored
BUG=none R=oshima@chromium.org Review URL: https://codereview.chromium.org/509093003 Cr-Commit-Position: refs/heads/master@{#292469}
-
Sadrul Habib Chowdhury authored
The changes in this patch: . If in split-view mode, the left and right windows remain fixed in the overview state. . Selecting either of the left/right windows returns to the split-view mode with the same windows. . Selecting one of the other windows in the stack gets out of split-view mode, and switches to the selected window. In subsequent patches: . Allow dragging a window from the stack on top of the left/right windows to switch that window and remain in split-view mode. . Allow dragging one of the left/right windows to get out of split-view mode and switch to that window. BUG=404119 R=oshima@chromium.org Review URL: https://codereview.chromium.org/495193003 Cr-Commit-Position: refs/heads/master@{#292468}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/511313002 Cr-Commit-Position: refs/heads/master@{#292467}
-
maniscalco authored
Prior to this change, on Windows, GetComputerName resulted in a call to GetComputerNameA, which returns an ANSI string (not ASCII, not UTF-8). Call GetComputerNameW instead and convert the returned wide string to UTF-8. Tested by adding U+00AB to the computer name. Saw in about:sync the name contained a U+FFFD instead (symbol for unrepresentable character). Performed sync dashboard clear, applied patch, saw that the name correctly contained U+00AB. This CL does not address corrupted device info that's already in the field. Depending on impact that may be addressed in a future CL. BUG=406470 Review URL: https://codereview.chromium.org/479703004 Cr-Commit-Position: refs/heads/master@{#292466}
-
jamiewalch authored
https://codereview.chromium.org/478033004/ broke the dialog screen, causing it to cover the title-bar in apps v2. This fixes it be adding an explicit <div> representing the window client area (the logical <body> for apps v2). Review URL: https://codereview.chromium.org/507013002 Cr-Commit-Position: refs/heads/master@{#292465}
-
ananta authored
This is on similar lines as Windows 8. The difference being launching into ASH on Windows 8 launches ASH into Windows 8 metro environment. Reused the existing tunneling we have via delegate_execute to ensure that the calling process is terminated before launching the browser into the other environment. Removed the erstshile Open Ash Desktop and Close Ash Desktop menu options as they are no longer needed and they don't work correctly anyways. BUG=356475 Review URL: https://codereview.chromium.org/498573003 Cr-Commit-Position: refs/heads/master@{#292464}
-
xians authored
Revert of Revert of Remove the last piece of deprecated synchronous IO code. (patchset #1 of https://codereview.chromium.org/509893002/) Reason for revert: https://codereview.chromium.org/510893003/ fixed the ledger bot, so I am going to revert this revert CL. Original issue's description: > Revert of Remove the last piece of deprecated synchronous IO code. (patchset #5 of https://codereview.chromium.org/460373002/) > > Reason for revert: > Build failure on Google Chrome ChromeOS: > > http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71164 > > Original issue's description: > > Remove the last piece of deprecated synchronous IO code. > > > > BUG=337096 > > TEST=bots > > > > Committed: https://chromium.googlesource.com/chromium/src/+/c4a64ffdd0d511c66d774341fa0a318af7911193 > > TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,xians@chromium.org > NOTREECHECKS=true > BUG=337096 > > Committed: https://chromium.googlesource.com/chromium/src/+/3e8c19c89c16fe8a7c2dfe0cae2990cd4a004339 TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,tnagel@chromium.org NOTREECHECKS=true BUG=337096 Review URL: https://codereview.chromium.org/518433002 Cr-Commit-Position: refs/heads/master@{#292463}
-
rdevlin.cronin authored
More-or-less consolidate calls to show an ExtensionAction's popup into ExtensionActionAPI. This has the happy effect of reducing the amount of piping we have to do in the UI code (cutting a few steps out of the Browser -> BrowserWindow -> Toolbar -> BrowserActionsContainer -> BrowserActionView chain), and, more importantly, lets page action command executions happen in the BrowserActionsContainer when the redesign is enabled. Hopefully, this means that we can stop showing page actions in the location bar with the switch enabled - but that's another patch. BUG=397259 TBR=sky@chromium.org (minor changes to test_browser_window) Review URL: https://codereview.chromium.org/489183005 Cr-Commit-Position: refs/heads/master@{#292462}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/dc53701216c0e9f98eacf6c0cda769ebbd200b59..60cc7d353b2adc8fcc1712e1f7a965e70121ebcc CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel TBR=djsollen@google.com Review URL: https://codereview.chromium.org/510393002 Cr-Commit-Position: refs/heads/master@{#292461}
-
aa authored
1. URLLoaders can't be reused, so we need to construct one per-load. This became too gnarly to handle with callbacks so I put it back to having a loader object that owns the URLLoader. 2. The relevant URLLoader needs to be passed to ContentHandler::OnConnect() so that it stays alive long enough to read the entire response. BUG= Review URL: https://codereview.chromium.org/513573002 Cr-Commit-Position: refs/heads/master@{#292460}
-
mpearson authored
They were disabled because they flakily time out. Now with the switch to Aura, I don't see timeouts anymore. All the tests I enable in this changelist pass 10/10 on my machine. Trybots seem okay with it. BUG=131179,165765 Review URL: https://codereview.chromium.org/517683002 Cr-Commit-Position: refs/heads/master@{#292459}
-
mlamouri authored
It seems that the cons are fairly weak and the benefits might be worth it. This flag breaks WebView builds. BUG=None Review URL: https://codereview.chromium.org/502743002 Cr-Commit-Position: refs/heads/master@{#292458}
-
hclam authored
This change excludes libvpx from linking if it is disabled. This is needed to enable linking Chrome with GN, since libvpx is not building with GN yet. Review URL: https://codereview.chromium.org/501153003 Cr-Commit-Position: refs/heads/master@{#292457}
-
eroman authored
BUG=407858 Review URL: https://codereview.chromium.org/504413004 Cr-Commit-Position: refs/heads/master@{#292456}
-
noms authored
Tabbing should navigate through all the visible controls. I've changed the EditablePhotoButton to actually be a button and not just an image, so that tabbing and pressing enter actually works. BUG=405056 Review URL: https://codereview.chromium.org/489143002 Cr-Commit-Position: refs/heads/master@{#292455}
-
mlamouri authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=180973%3A181040&mode=html TBR=hclam@chromium.org BUG=None Review URL: https://codereview.chromium.org/512283002 Cr-Commit-Position: refs/heads/master@{#292454}
-
zea authored
Simple rename patch, in preparation for making the DataTypeStatusTable copy-able and having it track more than just errors. BUG=368834 Review URL: https://codereview.chromium.org/513543004 Cr-Commit-Position: refs/heads/master@{#292453}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/514233002 Cr-Commit-Position: refs/heads/master@{#292452}
-
bauerb authored
BUG=none Review URL: https://codereview.chromium.org/511253002 Cr-Commit-Position: refs/heads/master@{#292451}
-
Stephen White authored
BUG= R=tonyg@chromium.org Review URL: https://codereview.chromium.org/514143003 Cr-Commit-Position: refs/heads/master@{#292450}
-
prabhur authored
Adding droppedframecount UMA to monitor videoplayback quality. Metric gets logged only if the pipeline has video & has decoded atleast one video frame. BUG= R=dalecurtis Review URL: https://codereview.chromium.org/497913002 Cr-Commit-Position: refs/heads/master@{#292449}
-
thestig authored
Review URL: https://codereview.chromium.org/512663002 Cr-Commit-Position: refs/heads/master@{#292448}
-
Brett Wilson authored
The yasm uses of compiled action used sources instead of inputs. Sources applies to the _foreach version but not the plain "compiled_action". These did not trigger an unused variable warning because the declarations themselves dereferenced the sources variable for computing args to the script. This adds some extra documentation and assertion to the compiled action template. It also adds the binary itself as an input. This should be strictly unnecessary since there should be an implicit dependency on the target, but I like this since it makes things more explicit. R=ajwong@chromium.org Review URL: https://codereview.chromium.org/505403002 Cr-Commit-Position: refs/heads/master@{#292447}
-
Aurimas Liutikas authored
Our designers generated assets that do not use sRGB color profile and this makes libpng unhappy. According to jreck@ Android does not use these profiles. This CL removes all these color profiles using this command: find . -type f -name "*.png" -exec convert {} -strip {} \; BUG=394138 R=dtrainor@chromium.org, newt@chromium.org TBR=tedchoc@chromium.org Review URL: https://codereview.chromium.org/510423002 Cr-Commit-Position: refs/heads/master@{#292446}
-
Brett Wilson authored
Some errors remain but these are circular includes that can't be fixed in the build files only. Enable views_unittests and wm_unittests now that they compile BUG= R=sky@chromium.org, tfarina@chromium.org Review URL: https://codereview.chromium.org/513313002 Cr-Commit-Position: refs/heads/master@{#292445}
-
zelidrag authored
BUG=408429 TEST=none TBR=miket Review URL: https://codereview.chromium.org/515313002 Cr-Commit-Position: refs/heads/master@{#292444}
-
andresantoso authored
Mac does not use Skia image natively even if TOOLKIT_VIEWS=1. BUG=378134 Review URL: https://codereview.chromium.org/517723002 Cr-Commit-Position: refs/heads/master@{#292443}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/515303002 Cr-Commit-Position: refs/heads/master@{#292442}
-
hclam authored
Testing clock needs an owner. Put a scoped_ptr<> to where it was first created. BUG=400728 Review URL: https://codereview.chromium.org/488133005 Cr-Commit-Position: refs/heads/master@{#292441}
-
jrummell authored
If a CDM calls the wrong Resolved() method to resolve a promise, the promise is cast to the wrong type and causes a crash. This fixes the problem by verifying that the promise is the correct type before casting it. BUG=408319 TEST=existing EME tests pass Review URL: https://codereview.chromium.org/515753002 Cr-Commit-Position: refs/heads/master@{#292440}
-