GitLab

Fix site settings and detail link not shown on page info under URL
with certain unescaped characters.

Bug: 874455
Change-Id: Icf31bee1b644136d285c5286938b16bc2b3de88c
Reviewed-on: https://chromium-review.googlesource.com/c/1278205
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599315}

This API is being used for abuse.

Bug: 880863
Change-Id: I122e23f589d62eecc01a4418db3573c53779de7f
Reviewed-on: https://chromium-review.googlesource.com/c/1275165Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599314}

ScopedBlockingCall is now used to label blocking calls. There is no need to annotate
calls to blocking //base APIs (base::File) since those are already annotated.

Original CL intention was:
This CL uses ScopedBlockingCall to mark blocking calls in /components/filename_generation.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

Bug: 874080
Change-Id: Iaa06bd88ea651b96f69b594158ee859124b890d8
Reviewed-on: https://chromium-review.googlesource.com/c/1191662Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599313}

R=eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I272879d680d0960944224e581855df9bd51aebf1
Reviewed-on: https://chromium-review.googlesource.com/c/1278950Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599312}

Bug: 894861
Change-Id: I67fe7f9e2f77e71af570bb8bd85793d02a41272f
Reviewed-on: https://chromium-review.googlesource.com/c/1278932Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599311}

It was previously on an A/B experiment to assess the performance overhead. This
overhead is <1%, so I'm turning the feature on by default.

Bug: 859155
Change-Id: I555637a294cf8c5d7ce97f57b8aebe7f2fb73734
Reviewed-on: https://chromium-review.googlesource.com/c/1277574
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599310}

Existing PhishGuard warning flow is a 2 step warning:
modal warning -> change password card on chrome://settings -> accounts.google.com

Based on our data, users are more likely to change their passwords when they
reach accounts.google.com. Thus, to boost action rates, this CL skips the settings
page. In addition, this CL refines the text in the modal dialogs.

Bug: 889936
Change-Id: I0322a4a13a3f285d7db1db7173645b7682765b51
Reviewed-on: https://chromium-review.googlesource.com/c/1263340Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599309}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ae38f99451d..f9da224859f3


git log 3ae38f99451d..f9da224859f3 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 gmx@chromium.org elm: enable new tcmalloc


Created with:
  gclient setdep -r src/third_party/chromite@f9da224859f3

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ie54ec4e14ec3dd8091cec3f144ea73394dcf1819
Reviewed-on: https://chromium-review.googlesource.com/c/1278202Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599308}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f8930395748..4bc3c99c2672


Created with:
  gclient setdep -r src-internal@4bc3c99c2672

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I9b8838c505a99871954e99d9bbb35adf47507a1e
Reviewed-on: https://chromium-review.googlesource.com/c/1278203Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599307}

This cl has the following clean ups:
-ShouldDiscardFlingCancelEvent is no longer needed in GEQ since the
fling controller discards redundant GFC events.

-fling_in_progress_ in GEQ was only used in ShouldDiscardFlingCancelEvent
by removing the function it is not needed anymore.

-FlingHasBeenHalted is removed since it was only in charge of resetting
fling_in_progress_ which we don't need in GEQ anymore.

-Instead of handling GFS/GFC events in ShouldForwardForBounceReduction and
QueueAndForwardIfNecessary, DCHECKs are added to make sure that these events
are filtered by the fling controller before reaching GEQ.

Bug: 249063
Change-Id: Ibc46aa3a47cc1e1bc28abad7ebf68b432c68b4ef
Reviewed-on: https://chromium-review.googlesource.com/c/1274827
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599306}

Instead of passing bare jarray pointers into the JNI array helper
functions, pass in JavaRefs to avoid the caller having to use .obj()
everywhere.

TBR=asanka@chromium.org,sadrul@chromium.org,hubbe@chromium.org,carlosk@chromium.org,ctzsm@chromium.org,sdefresne@chromium.org,piman@chromium.org

Bug: 519562
Test: base_unittests
Change-Id: Ib01509aa73ada6adb2605011a8160b53cf957895
Reviewed-on: https://chromium-review.googlesource.com/c/1255702Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599305}

https://pdfium.googlesource.com/pdfium.git/+log/94f3ca931552..29b708e7af32


git log 94f3ca931552..29b708e7af32 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 thestig@chromium.org Mark the bigint target as XFA only.
2018-10-12 thestig@chromium.org Make PDF_DataDecode()'s buffer out parameter a std::unique_ptr.


Created with:
  gclient setdep -r src/third_party/pdfium@29b708e7af32

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I770ea2845a105850d44065334d3532cca04ed8f4
Reviewed-on: https://chromium-review.googlesource.com/c/1278947Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599304}

Replaces PointerWatcher with a more generalized EventObserver.
EventObserver supports local code and remote window-service clients.

Ash & remote client aura::Envs host their respective EventObservers.
Ash notifies local observers via a pre-target event handler adapter.

WindowTreeClients forwards requested event types to WindowTree.
WindowTree notifies WindowTreeClients of input and observed events.

Needed to support more existing ws client pre-target event handlers.
Replaces the remaining ws mouse/touch->pointer event conversions.

A followup CL will rebase views::EventMonitor on EventObserver:
 https://chromium-review.googlesource.com/c/chromium/src/+/1258217

Bug: 887725, 872450, 865781
Test: No --show-taps, immersive, touch edit handle, etc. changes.
Change-Id: I5ed870a3be948bf48448ed1a5e54a2bf4512e3b0
Reviewed-on: https://chromium-review.googlesource.com/c/1269806Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599303}

TBR=csharrison@chromium.org

Change-Id: I4098f454fcd981536238f92c0ec43abf63d9a6ba
Reviewed-on: https://chromium-review.googlesource.com/c/1207510Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599302}

DeviceService retrieves system SharedURLLoaderFactory on creation.
If ServiceManagerContext is created before browser process, the
SharedURLLoaderFactory cannot be accessed.
This CL provides a wrapper for system SharedURLLoaderFactory, and pass
it to DeviceService, so that it can be used later when network
service is created.

BUG=894167

Change-Id: Ibd7ed15399d247f7dc5b9eee99edf331b85ac04b
Reviewed-on: https://chromium-review.googlesource.com/c/1274485Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599301}

When kHighlightPath is in use the ink-drop effects are masked. As such
we can use a flood-fill ripple and default highlight path that cover the
entire view (that will be masked to the correct shape). This allows
removing custom ink-drop ripples and significantly simplify highlights
for toolbar-related buttons.

This change makes use of these simpler inkdrops in for bookmark-bar
buttons and menu buttons.

Bug: chromium:888204
Change-Id: I32f21dde80783cdd262351596a4a4a504505e21c
Reviewed-on: https://chromium-review.googlesource.com/c/1277268
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599300}

RenderViewImpl clears the |webview_| in DidCloseWidget() which happens
from RenderWidget::Close() which is a posted task from OnClose() which
removes the IPC route to the RenderWidget. So no IPCs are received after
OnClose(), and we don't need to worry about IPC handlers running after
DidCloseWidget().

Also RenderViewImpl::SetScreenMetricsEmulationParametersForWidget() is
called from RenderWidget::SetScreenMetricsEmulationParameters which is
a delegate method for the RenderWidgetScreenMetricsEmulator. The
emulator is created and destroyed, and updates parameters in response
to IPCs, so it should not be calling to the RenderWidget after OnClose().

The LayerTreeView is destoyed in RenderWidget::Close() which comes after
OnClose() so null checking for that in IPC handling code is not needed
either.

However it's possible the browser could not send the IPC to destroy the
SetScreenMetricsEmulationParameters, at least theoretically, in which
case it would try to set parameters when it was destroyed later, and
that could crash. So we should be sure that we destroy the
RenderWidgetScreenMetricsEmulator when we close the IPC route. It is
already destroyed in RenderWidget::Close() /before/ we destroy the
LayerTreeView or call DidCloseWidget() so working as intended.

R=avi@chromium.org

Change-Id: I52fa395af4ae7ba89eb4641f16b4a00fb77728fc
Bug: 419087
Reviewed-on: https://chromium-review.googlesource.com/c/1278854
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599299}

Bug: 805600
Change-Id: If740354ab8f664d4b89f722ec50d718fe94c71f2
Reviewed-on: https://chromium-review.googlesource.com/c/1274391Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599298}

The function BridgedNativeWidgetHostImpl::SetIsFirstResponder is called
when the BridgedContentView observes that it became or lost first
responder.

When losing first responder, this would call ClearNativeFocus inside
FocusManager::StoreFocusedView, which would then make the
BridgedContentView first responder again.

That would happen to not be a problem for the synchronous in-process
mode because the call sequence is
1. -[NSWindow _realMakeFirstResponder:], which internally calls
  2. -[BridgedContentView resignFirstResponder], which calls
    3. BridgedNativeWidgetHostImpl::SetIsFirstResponder, calls
      4. FocusManager::StoreFocusedView which eventually calls
        5. -[NSWindow makeFirstResponder:], which is now recursively
           setting the first responder set. This either has no effect
           or is overridden by the below calls
  6. -[NSView becomeFirstResponder] for the new NSView that now has
     focus

But when we're running this out-of-process, the call to 3 is an IPC
back to the browser, so we have the sequence 1, 2, 6, 3, 4, 5, and now
the call to makeFirstResponder in step 5 actually does something.

Fix this by just not calling ClearNativeFocus (which is consistent, as
this is just observing a change in state that has occurred, not
requesting a change in state).

Bug: 859152
Change-Id: I289c652228bbaa1ca58aa2ec72ff87dd422a54d9
Reviewed-on: https://chromium-review.googlesource.com/c/1272680Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599297}

Bug: 894826
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I864822675c8d7fbf10b57c72b11607916773f6b5
Reviewed-on: https://chromium-review.googlesource.com/c/1278928Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599296}

Update WebContentsViewMac to always report the view as visible when
it is hosted in a remote process.

Fix an a11y crash crash in BridgedContentView's
accessibilityAttributeValue function.

Make the doppelganger NativeWidgetMacNSWindow in the browser process
be transparent and have no controls (closing that window causes
complicated lifetime issues).

Make NativeWidgetMacNSWindow directly store a pointer to its
BridgedNativeWidgetImpl, instead of looking it up by id.
- This was causing problems where the doppelganger window in the
  browser process was fighting with the true NativeWidgetMacNSWindow
  in the app shim.
- When the gfx::NativeWindow handle patch lands, we can make the
  doppelganger window be a different class, which will help to
  de-confuse things.

Update NativeViewHostMac::GetViewsFactoryHostId to return the same
sentinel value for "use the local process" as is used in content (this
had been causing LOG errors).

Bug: 859152
Change-Id: Ic0222351a54b20387c019263ee1a04d03461c063
Reviewed-on: https://chromium-review.googlesource.com/c/1278294Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599295}

Changing the Display's work area is not allowed while overview
mode is active, but the docked magnifier need to update the
display's work area. As a result we should exit the overview
mode before toggling the docked magnifier.

BUG=894256
TEST=Added new ash_unittests

Change-Id: Id1776bb814aa6dc7cbdc338575b9c8fdc02ab69d
Reviewed-on: https://chromium-review.googlesource.com/c/1278473
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599294}

GpuProcessHost installs a filter on ServiceManagerConnection. It should
be removed when GpuProcessHost is destroyed to avoid memory leak.

BUG=885393

Change-Id: I7621b52b6110f1e1671f0ec966477f1302fbc585
Reviewed-on: https://chromium-review.googlesource.com/c/1277945Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599293}

Bug: 894301
Change-Id: I7b137db2f75a32c871c882346295c4b8770b3237
Reviewed-on: https://chromium-review.googlesource.com/c/1277813Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599292}

Bug: 894350
Change-Id: Ic5cde2aef449e745e1301ee0c09b6e9ad50308e3
Reviewed-on: https://chromium-review.googlesource.com/c/1278534Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599291}

https://chromium.googlesource.com/angle/angle.git/+log/671809e62e80..c97e3f6684c7


git log 671809e62e80..c97e3f6684c7 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 jmadill@chromium.org Revert "ES31: Add vector and matrix support in SSBO for D3D"


Created with:
  gclient setdep -r src/third_party/angle@c97e3f6684c7

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I871d9042ed0b44cf93537b418a19e94092f6faae
Reviewed-on: https://chromium-review.googlesource.com/c/1278945Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599290}

These may be causing the WindowServer to die on 10.13.

Tbr: ellyjones@chromium.org
Bug: 828031
Change-Id: I5ed668eb5fbb9c70d06ea607bdabe74964d71498
Reviewed-on: https://chromium-review.googlesource.com/c/1277576Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599289}

The new test runner is named WprProxySimulatorTestRunner, and descends from SimulatorTestRunner,
mostly diverging in two ways:
* It performs additional set up and tear down to specifically set up the Web Page Replay proxy.
* It runs the suite under test multiple times, assuming the suite takes in one replay+recipe
pair per run, corresponding to testing one webpage. Each webpage will have separate results in the
final results report.

This test runner is triggered if a new flag, replay_path, is set for a iOS test.
This flag represents the path containing saved web page replay and recipe files for use with
WprProxySimulatorTestRunner.

Key files (such as the certificate needed to proxy traffic on simulator) are passed in
to the test runner from api.py (see https://chromium-review.googlesource.com/c/chromium/tools/build/+/1272236)
through a CIPD package installed and passed in through the wpr-tools-path flag.
Thanks Sergey for the tip!

For comments on WIP versions of this which can provide more insight, see here:
https://chromium-review.googlesource.com/c/chromium/src/+/1243565

Thanks!

Bug: 881096
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id2174a535ffc8a9941fc68062b0c7f69a75d80ab
Reviewed-on: https://chromium-review.googlesource.com/c/1263557
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599288}

Use TextViewWithClickableSpan for the subtitle text so that it responds
to accessibility events when the learn more link is appended to the end.
Also update the XML to make the root view focusable instead of the
scroll view, which fixes an issue where focus was previously going to a
child of the ScrollView instead of the container.

BUG=894844,757017

Change-Id: I737d3aa8cbe03064caa95065a6ce07ba41e6194e
Reviewed-on: https://chromium-review.googlesource.com/c/1278797
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599287}

This reverts commit d306c779.

Reason for revert: speculative revert, suspected of causing flakiness in ErrorPageAutoReloadTest tests. (see https://chromium-review.googlesource.com/c/chromium/src/+/1260491)

Original change's description:
> [CrOS MultiDevice] Enable multi-device features during OOBE.
> 
> This CL enables several multi-device flags by default. This resulted in
> lots of broken tests, so this CL also fixes those broken tests.
> 
> Instant Tethering is enabled via Finch flags; however, Finch does not
> immediately enable/disable features. Instead, when a user logs in, a
> Finch configuration is downloaded and is applied the next time the user
> logs in. Thus, to ensure that these features are available during OOBE,
> this CL overrides multi-device feature experiments during the first
> run. On subsequent logins, the Finch feature list will be applied.
> 
> Bug: 884066
> Change-Id: Ie12f3c62e766457456fd8a35e13168e6b35331ec
> Reviewed-on: https://chromium-review.googlesource.com/c/1260491
> Commit-Queue: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
> Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599223}

TBR=xiyuan@chromium.org,skuhne@chromium.org,khorimoto@chromium.org,benwells@chromium.org,asvitkine@chromium.org,jlklein@chromium.org,takumif@chromium.org

Change-Id: Icd73d0f4f859ab9ea6c0b4a0761d77a32a9bee15
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 884066
Reviewed-on: https://chromium-review.googlesource.com/c/1277577Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599286}

It is only called from RenderViewImpl, and just forwards to
RenderView::ApplyWebPreferences. We can just call that directly.

R=avi@chromium.org

Bug: 361761
Change-Id: Ifaf2d586b314d49506029fb9426d6d1cb1d63d67
Reviewed-on: https://chromium-review.googlesource.com/c/1278857Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599285}

This could be used to make consistent builds of Cronet before official builders are available.

Bug: 786559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5154f9e4461cdae1cbe07dc7e4309978d98d8508
Reviewed-on: https://chromium-review.googlesource.com/c/1273824Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599284}

Depending on which process the MediaCodec is running in, there may
already be a non-default looper and handler which results in stale
input/output indexes being delivered to the bridge after start().

To prevent this, we now call start() immediately after flush(),
but post the clearing of mPendingStart through the handler/looper.

A sequence counter is added so that rapid flush()/stop() calls
don't prematurely use invalid indices.

BUG=892591
TEST=Run chrome with --in-process-gpu and seek a bunch on any video.

Change-Id: I8c60a73b8c00c85a7ab3d253bc8df2397c1fa00d
Reviewed-on: https://chromium-review.googlesource.com/c/1278293Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599283}

The author of https://crrev.com/588577 did not realize the HUD layer
could be used for non-full-viewport rect debug information such as the
FPS meter. This patch restores the non-rect size logic from
https://crrev.com/588577 and adds a test of the FPS meter size.

Bug: 894717
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ied6d6c80e396ab59dbc201994db5214ed1db09a0
Reviewed-on: https://chromium-review.googlesource.com/c/1277658Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599282}

Bug: 721403
Change-Id: I266cafc445813b0305b00bbae8698542505cfcfc
Reviewed-on: https://chromium-review.googlesource.com/c/1274613Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599281}

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I58cf3cdd266a2df589e28645888728a6333c7a6b
Reviewed-on: https://chromium-review.googlesource.com/c/1239900Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599280}

Setting the virtual URL means that all UI surfaces will use the
"original" URL, that is, the origin URL where the content came from.
This should not affect any security features of Chrome, which should
be using the loaded URL, not the virtual one. Security-related UI that
are impacted are addressed as follows:
* Site Settings - explicitly disabled when a preview is shown
* Permissions Dialog - explicitly denied in r1260082

Adds virtual URL testing to HTTPS Previews browser tests and one
additional test for navigation actions.

Bug: 881938
Change-Id: I6e6f2e2a3ef267d61c18295f019d307adc9756bb
Reviewed-on: https://chromium-review.googlesource.com/c/1217351
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599279}

Note that these new histograms will help us understand more about the update
check error codes of the unified extension updater Finch experiment currently
running in Beta.


Bug: 722942
Change-Id: Ie20083437c8a06b7649c5ed01e91ac68357d84ca
Reviewed-on: https://chromium-review.googlesource.com/c/1271790
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599278}

Using wpt-import in Chromium 79df1ff1.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25976

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org:
  external/wpt/trusted-types

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I69e6efafb3ac195e0db73834a882c48e0270fddb
Reviewed-on: https://chromium-review.googlesource.com/c/1278929
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599277}

Demo mode enrollment flow.

Bug: 854101
Change-Id: I87111b78ee89c5acd242ce4808a23162dee038e0
Reviewed-on: https://chromium-review.googlesource.com/c/1252481Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599276}