GitLab

Moves the existing XrInstallHelper interface to content/public/browser
and creates an XrIntegrationClient interface. This allows embedders to
provide any factory methods for XR that may end up being required.
Currently this is expected to be GetXrInstallHelper and GetVrUiHost.

A mojom interface method was considered, but ultimately not feasible as
most of the installation steps actually still need to stay in the
browser process and some steps are also chrome specific. This code needs
to remain in the browser process because the install kicks off an intent
to the Play Store, which needs to be notified of the Resume event, and
in chrome as some of the installation paths (mainly for ARCore) show
custom UI. In addition to intenting out to the play store, VR also needs
to ensure that the appropriate DFM is installed, which is specific to
chrome.

Note that for AR, if an embedder were to require ARCore in their app
manifest, the current installation steps would mostly be a no-op, though
it is still recommended to check the ARCore install status.

This is one of the refactors that needs to happen before VRServiceImpl
can be moved into content.

Bug: 1031622
Change-Id: I730ec082422a92f47b5b8abe0cebe5dd9bb68c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095957
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750376}

Have android-lollipop-arm-rel to run the same tests as in Lollipop Phone Tester
to verify if LMY48M works fine with those test suites

This helps kitkat deprecation as android-kitkat-arm-rel runs a subset of
the test suites in Lollipop Phone Tester.
Also helps move Lollipop Phone Tester from LMY48I to LMY48M later on.

Bug: 1032336
Change-Id: I91ddd08a26384b3980edd32247b808a1819b3ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103513
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750375}

Due to the destruction order, the task execution environment in
App::Run() gets destroyed before the App object. Therefore, the run loop
is missing a task runner and dchecks.

This CL fixes flushing of prefs for UpdateApps just like they it was
fixed for InstallApp. It is not needed to wait for prefs to flush
under a runloop.

Bug: 1053729
Change-Id: I0ed8d3e97366c052277716e85cbaa74cad81236d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103320Reviewed-by: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750374}

This reverts commit e304bfb9.

Reason for revert: Fixed failing test that was not setting the state of the PrivacySettingsRedesign flag and didn't call the setup function.

Original change's description:
> Revert "Dynamically update cookies link row label based on cookie setting."
>
> This reverts commit c3a94015.
>
> Reason for revert: Flakily failing on all platforms:
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/88090
> [27939:27939:0312/140853.144376:ERROR:CONSOLE(49)] "Mocha test failed: SiteSettingsPage CookiesLinkRowSublabel
> AssertionError: expected 'Allow sites to save and read cookie data' to equal undefined
>     at Function.assert.strictEqual (file:///b/s/w/ir/third_party/chaijs/chai.js:2329:32)
>     at assertEquals (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:699:15)
>     at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/site_settings_page_test.js:74:5)
> Bug: 1061249
>
> Original change's description:
> > Dynamically update cookies link row label based on cookie setting.
> >
> > Previously link rows for content settings displayed one of two labels
> > describing their current setting. This CL extends the capability of
> > the cookies link rows specifically to express one of the four possible
> > effective cookie settings.
> >     -Allow
> >     -Block Third Party only in Incognito
> >     -Block Third Party
> >     -Block
> >
> > To ensure that this label remains correct across both the preference
> > and content settings changes that affect the effective cookie setting,
> > an additional WebUI listener is created which pushes updates to JS
> > for immediate display.
> >
> > This updated label is applied to both cookies link row locations
> > when the privacySettingsRedesign flag is enabled, and applied to
> > neither when it is disabled.
> >
> > Bug: 1032584
> > Change-Id: I11a984bce60878b6224506bfc1cd1a5cf3a2e63e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095925
> > Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
> > Reviewed-by: dpapad <dpapad@chromium.org>
> > Reviewed-by: Martin Šrámek <msramek@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#749510}
>
>
>
> Change-Id: I43acd7240282ed62e20f2321cd53bf6f2963d45a
> No-Presubmit: true
> No-Tree-Checks: true
> Bug: 1032584
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101389
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749986}

Bug: 1061249, 1032584
Change-Id: I43c594b28228720a5383587eee81aba24d2e1db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103508Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750373}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f29465e5291..c48fb8427c8c

git log 9f29465e5291..c48fb8427c8c --date=short --first-parent --format='%ad %ae %s'
2020-03-13 ehmaldonado@chromium.org Revert "git-cl: Refactor CMDUploadChange"

Created with:
  gclient setdep -r src/third_party/depot_tools@c48fb8427c8c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Idf177e8e08df4f6920f8e98b61b8d20d1983867a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103609Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750372}

"LocalServer32" was incorrectly being created as a value instead of a
key. And the TypeLib GUID was incorrect. Fixing both these issues.

Bug: 1027769
Change-Id: I88b3d723e481564d004225d64ce474208fad7fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103750
Auto-Submit: S. Ganesh <ganesh@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750371}

Fix typos in mojo public bindings. s/params/writer/ All other BufferWriters in the same directory are writer. Name a BufferWriter to `params' confuse user learning mojo.

Change-Id: I2d6a9bd629d296767977574efc029e979d2c6bcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097505Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#750370}

ui::Cursor is a superset of blink::Cursor. Delete the latter and replace
all of its uses with the former.

Bug: 1028080
Change-Id: I687ebbc323f346aa12cc40f264e38d74e7173331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000620Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#750369}

This CL updates InfobarBannerPresentationController to subclass
OverlayPresentationController so that it can specify that it resizes
its presentation container view.  This allows the overlay presentation
context view to be resized to match the container view so that touches
that fall outside the banner can pass through to the underlying browser
UI.  When the infobar overlay flag is disabled, subclassing this
presentation controller does not change any behavior.

Additionally, this CL updates InfobarBannerOverlayCoordinator to use
the InfobarBannerTransitionDriver.  In order to improve upon the
InfobarBannerPositioner interface, this CL also updates
|-bannerYPosition| to specify that the returned position is in window
coordinates.  This disambiguates the coordinate system in which the
returned position is calculated, allowing a shared point of reference
for both the overlay and legacy infobar implementations.

Bug: 1030357
Change-Id: I6425a81dbed40715c2cebd53f1459d3f924b44b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040748
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750368}

This CL is related to two ongoing projects: the implementation of file
handling APIs for PWAs in Chrome (go/chrome-file-handling-api), and
BMO (go/chrome-bmo), which is concerned with moving PWAs off the
Extensions stack and establish them on an independent web apps
platform.

As part of the first project, we created a new representation for file
handlers (apps::FileHandler) that has some properties needed for OS
integration. Pre-BMO PWAs ("Bookmark Apps") use apps::FileHandlerInfo.
It's simple to convert from FileHandler to FileHandlerInfo, but
impossible to do the reverse. This means that if file handling lands
before BMO, migrating installed PWAs to the new system will be a
destructive operation.

The goal for the set of CLs to which this one belongs is to have BMO
web apps and Bookmark Apps share the apps::FileHandler representation.
We have added a new "web_app_file_handlers" key to the Extension
manifest, along with parsing for the new format (crrev.com/c/2081714).
Here we serialize the apps::FileHandlers attached to a web app (under
the new key) when installing it as a Bookmark App. In subsequent CLs,
we replace apps::FileHandlerInfo with apps::FileHandler across both
Bookmark Apps and BMO web apps (crrev.com/c/2087306), and finally
implement migrating Bookmark App file handlers to the new platform as
a simple copy (crrev.com/c/2086453).

Bug: 938103
Change-Id: Iec258386be92ae36b8016a21119ee324a955e5d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087327Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Robert Woods <robertwoods@google.com>
Cr-Commit-Position: refs/heads/master@{#750367}

While investigating a debug info size regression with distributed
ThinLTO, I noticed that we are not passing -g* flags to distributed
code generation. This change fixes that, allowing debug fission to
be used with distributed ThinLTO.

R=akhuang,gbiv,hans,manojgupta

Bug: 1058525
Change-Id: Ia1c0ec0dfb045fede639f7749d40ff1f883551e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101390
Auto-Submit: Bob Haarman <inglorion@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750366}

Change-Id: I04e3bfcf520eef8b7fe41cfa1cb04e87de413363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052585
Commit-Queue: Amy Huang <akhuang@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750365}

Bug: 1018230
Change-Id: Ibe41ab0c8de8ccc2e55f3971154e035427da3e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101528Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750364}

This is already gated by a suer pref, which will be launching in M82.
So we will use this feature flag as a kill switch only.

Change-Id: If5416964d6ff99d7548a6355e5a086daaf61d79d
Bug: 1061591, 1051679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103294
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750363}

https://dawn.googlesource.com/dawn.git/+log/0338b7ae194a..459c2f930fbb

git log 0338b7ae194a..459c2f930fbb --date=short --first-parent --format='%ad %ae %s'
2020-03-13 enga@chromium.org Slab-allocate Metal bind groups

Created with:
  gclient setdep -r src/third_party/dawn@459c2f930fbb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I84db05d0c8f8564583c99c9a72b0c49e3597082f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103608Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750362}

This CL disables the new tab variation when the incognito mode is
disabled and adds some tests around the new tab variation.

Bug: 1056896
Change-Id: I840619aa868bab79ca108a2c85fbe79f16711be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097058Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750361}

Just one remains since it's actually needed.
This will let GN validate that deps are not missed.

Bug: 1054892
Change-Id: I5c6ab2a311f819bb678b3490505cdb5001105eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102767Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750360}

PaintCanvasVideoRenderer relies on the context supporting a
RasterInterface.

R=dalecurtis@chromium.org

Bug: 1061341
Change-Id: I0e404355b3ec91ef3bad1fb19a232ec65d679628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103553
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750359}

Static initializers are generated in the C++ proto code when extensions
are used. This CL just inlines the extensions. The wire format is
preserved, but we can avoid the static initializers.

Change-Id: Ibb7a103488ecb7efb27cca02ea48ec994738f5c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103434Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750358}

Not able to reproduce, but add null pointer checks for the shadow dom
elements.

Also start using SetInlineStyleProperty to avoid unnecessary creation of
a CSSStyleDeclaration object.

Bug: 1061415
Change-Id: Ib40a7fa6e52d4b0c209747923ae806e2b678966b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102549Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750357}

ApplicationBreadcrumbsLogger gets destructed on app clean exist, so this
is the same as logging from applicationWillTerminate: callback.

UIApplicationWillTerminateNotification notification is sent after
~ApplicationBreadcrumbsLogger and can't be used for this log.

Bug: 1046223
Change-Id: Ie2844ac66d4135c76baf12b6d56beb2b67129ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103394Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750356}

Blocked by policy dialog is shown when an extension can be installed due
to policy. This also includes extension request rejection. But it will not
be used if the extension is blocked in child account.

The dialog is for information only and user can only close the dialog. When
the dialog is closed, the webstorePrivate.beginInstallWithManifest3
function will return user cancel to stop extension instllation.

This dialog replaces the old "Oops" dialog in CWS. The dialog UI has been
approved by UX team.

The dialog is by design very similar to ExtensionInstallDialogView
including Layout, title, icon and a ScrollbarView for additional message.

Screenshots:
https://drive.google.com/file/d/1qj3wx8wMv3F5B6PZAAGcShViHZO-VYF0/view?usp=sharing
https://drive.google.com/file/d/1KgQPU-yTgiiYPJvOxsZNpT-w7WJnY1VL/view?usp=sharing
https://drive.google.com/file/d/19W6W4K3bH4OGXByi-mM1o87mwU7BQQ1b/view?usp=sharing

Bug: 1006899, 1061559
Change-Id: I3887c2ff3247d4df6401ec9829dce046461aa075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068680
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750355}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5158d6360055..735a9cd7804e


Created with:
  gclient setdep -r src-internal@735a9cd7804e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I93903b2d9f6a04d502339db7638ea8c3fa38044c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103362Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750354}

Not removing includes of post_task.h yet as they implicitly provide
task_traits.h while thread_pool.h can't (cyclical dependency during
the migration).

R=etiennep@chromium.org

Bug: 1026641
Change-Id: If977e02ec18abc369ffcb9ca22d3b40cb10e9010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101488
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750353}

Previously, the sRGB color space was filled with actual sRGB when
wide color is supported. However, some devices will always stay in
wide and never actually use sRGB. When the sRGB color space is
requested, it should continue to use the wide color space rather
than sRGB.

This CL only fills the sRGB color space when wide color is not
always on. Said another way, if the color space can change
dynamically, the dynamic color spaces will be populated.

Bug: 955158
Change-Id: Ia4d153e23841b6ef4e412c9ba118f029d33441d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102777Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750352}

Bug: 1056482
Change-Id: Ie98feb28394de53a648d656da0a0cecd18a6e0fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103396Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750351}

NGLineLayoutOpportunity is large class but inlining
ComputeLineLayoutOpportunity lets compiler completely eliminate stores.

The rest is vectors or classes with vectors.

https://pinpoint-dot-chromeperf.appspot.com/job/153f79d3620000

Bug: 1055705

Change-Id: I09401148710df3bb4b830835651286036706ee2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101943
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750350}

https://swiftshader.googlesource.com/SwiftShader.git/+log/7d09824f5aa1..f6e439f96c7f

git log 7d09824f5aa1..f6e439f96c7f --date=short --first-parent --format='%ad %ae %s'
2020-03-13 sugoi@google.com Compile Vulkan library with Subzero in Chromium

Created with:
  gclient setdep -r src/third_party/swiftshader@f6e439f96c7f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1060139
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Id3f26c47fd2465efdad1d73edc66045d5ec40fc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103363Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750349}

Refactor code for mach service name. Call the common code from all appropriate sites.

Bug: 1048653
Change-Id: Iccaa5cc6703152a2f4ab24e289008dbe12331473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101848Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Mila Green <milagreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750348}

This CL refactors file_format.py, so the code can be more easily
transitioned to Python 3. Specifically:
* Add class _Writer that wraps |file_obj.write()| and supplies more
  interfaces for different write cases.
  * Specifically, |file_obj| will require type byte, but for most cases
    the caller supply str.
* Split write_numeric() into smaller pieces, using generators.
  * Write numbers to line: _Writer.writeNumberList().
  * Delta encoding: gen_delta() (optionally).
  * Visit |group| and map with |func|: itertools.imap().
  * New helper: write_groups(), to loop over sections & choose delta.
* Update callers to call the proper interfaces.

Relevant bugs and fixes:
* In Python 2, json.dumps(..., indent=2) injects extra space at end of
  each line. This is fixed in Python 3, thereby causing superficial
  differences in .size (and .sizediff) files.
  * Fix: Manually remove space. This causes minor .size file changes.
* cStringIO.StringIO disappears in Python 3 (will need io.BytesIO).
  The previous _LogSize() check for |fileno| won't work: The pass will
  pass, but for io.BytesIO (or io.StringsIO), the function call fails.
  * Fix: Simply use |file_obj_.tell()| for all cases.

Other bug fixes:
* nm.py: Fix missed-a-spot error in "concurrent" -> "parallel" change.

Bug: 1054018
Change-Id: I2b2c34cc43d4bffd6e1239cd2c0817711e47d26d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102589
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750347}

One of our detection points for enabling web content accessibility was
when a UI Automation element was requested from the legacy window. On
non-desktop Windows devices such as Hololens where HWND support is
limited, the OS may not talk to the legacy window, and it won't hit any
of the other existing detection points either, since they're tied to
MSAA/IA2 and UI Automation is the only supported API on these devices.

This CL moves the legacy window point of detection to where we obtain
a platform object for any fragment root, including either the top-level
window or the legacy window.

Bug: 928811
Change-Id: I8867258f4d1e2109c27066f978e9f5cf70766137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101257Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#750346}

This bug used to happen when switching back to clamshell mode from
tablet mode: the hotseat's translucent background failed to get hidden.

The bug has been fixed but this will prevent future regressions.

Bug: 1050383c
Change-Id: Id9721209c2144fade3248f9d236306e97041e41a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102552Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750345}

Bug: 1026426
Change-Id: I21afcc4961fc68eded190d8cbe8b72d2796aab6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103145
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750344}

This reverts commit c29bddc2.

Reason for revert: this has broken exposeDevToolsProtocol somehow.

Original change's description:
> [DevTools] Roll inspector_protocol (Chromium)
> 
> Upstream PR:
> Introduce a crdtp/dispatch.{h,cc} library.
> https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1974680
> 
> New Rev: 8c2064ea99cffdb5647760ad3953c43e612e07fc
> 
> Notable downstream changes:
> - ChromeDevToolsManagerDelegate::HandleCommand no longer carries
>   a method. Reason being, the shallow parser (crdtp::Dispatchable)
>   should be efficient enough to parse an incoming message a couple
>   of times, e.g. once for the content layer and once for the
>   embedder, and if we felt differently then we'd quite possibly
>   want to carry more than just the method - e.g., we'd want to also
>   pass the params. Anyway, for now simplifying this interface.
> - crdtp::FrontendChannel::FallThrough; here, it's advantagueous
>   to keep the method around, but now it's a crdtp::span. This is
>   much better than const std::string& because the generated code
>   knows exactly which method is going to fall through and we
>   can pass a C++ string literal via this span.
> - The crdtp/dispatch library presents a somewhat different surface
>   between the UberDispatcher and the session implementations.
>   The session implementations are responsible for creating a
>   crdtp::Dispatchable instance (the shallow parser) which
>   it then hands to the dispatcher for dispatching. Rather than
>   querying for whether it can dispatch and then doing it,
>   the result of the Dispatch indicates whether a method was
>   found and can be executed. There's no more need to instantiate
>   protocol::Value in a devtools session class.
> - Since the dispatch library uses crdtp::span to represent
>   method names, we no longer need to reference platform specific
>   routines for finding strings and making substrings. As a result,
>   v8_inspector_string.h is losing a few more methods
>   (and same for base_string_adapter_h.template).
> - crdtp::DispatchResponse (also known as protocol::Response) has
>   some renames for consistency (
>   Response::Error -> Response::SeverError,
>   Response::OK -> Response::Success). Touches all domain handlers
>   but is mechanical.
> - All protocol error messages, such as the parameters passed
>   to DispatchResponse::ServerError are required to be UTF8 strings,
>   even for Blink, so when code generates them as WTF::String,
>   we convert them to std::string using WTF::String::Utf8()
>   before passing them to DispatchResponse::ServerError.
> - We're better about checking messages and sending errors when we
>   can't parse them - esp. we no longer drop messages on the floor
>   if we can't make sense of them; the LOG statements are gone,
>   because we can either send an error or assume that we've
>   previously parsed the message elsewhere and put a DCHECK (e.g.,
>   a message received by blink has always been shallow-parsed by the
>   browser before).
> - DevToolsAgentHost::DispatchProtocolMessage no longer has a boolean
>   return value. Reason being, it's not well defined what the
>   boolean should indicate. If we reject the message and send
>   an error, arguably we've also handled it. And of course, we
>   always do that (now). So it's not useful to generate or check
>   this return value, and there is only one DCHECK on it currently,
>   which is also not covered by tests.
> - content::DevToolsSession uses binary searches to match method names
>   (e.g. in ShouldSendOnIO).
>   This is because I've switched the method names to span, and
>   implemented similar searches for the dispatching library, so
>   it's best to be consistent. It will also scale better if we add
>   more methods.
> - The additional unittests added to the CRDTP library upstream cover
>   shallow parsing, dispatching, etc. and are now also part of
>   the content_unittests.
> - Improves Android binary size by about 36k, by reducing code
>   duplication. There's now just one UberDispatcher, for example,
>   as opposed to one for blink, one for content, one for headless,
>   one for chromium, ...
> - Speeds up execution by 1-2% (based on internal measurements),
>   because message serialization no longer takes a detour via
>   protocol::Value.
> 
> Change-Id: I422fe527d6f8a6ffb098b3992728ecba408b571f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047966
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Leonard Grey <lgrey@chromium.org>
> Commit-Queue: Johannes Henkel <johannes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750284}

TBR=dgozman@chromium.org,caseq@chromium.org,gogerald@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org

Change-Id: I122738b9057cf6ab48b904a6ee0e67c7c9610b95
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103517Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750343}

The original AddObserver was called in GpuDataManagerImplPrivate
constructor. Somehow this doesn't work with the latest code for
display::Screen::GetScreen() is null. To avoid any racing situation in
the future, delay this AddObserver until BrowserThreadsStarted.
display::Screen is available after the browser thread started.

Bug: 1042989
Change-Id: I0ba1116e8f50a877000259db219e3b860ef64116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097536
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750342}

This change marks the following tests:

- fast/canvas/toBlob-in-detached-document.html as crashing on Windows and Mac
(https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/26239)

- peek-updated-composited-property-on-main.html as failing on Linux
(https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/11972)

- editing/selection/replaced-boundaries-1.html as failing on Mac
(https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/22973)

TBR=jbudorick@chromium.org

Bug: 1061131
No-Try: true
Change-Id: I7e2c5bf3500bf424cf4e7c6bf37f49872d0c0edb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103550
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750341}

Current behaviour with fullscreen app & Android IME showing is to exit
fullscreen, then close the IME. It should be the other way around, but
needed to be merged back to M81, so an intermediate "quick fix" was
done first.

The bug triggers some refactors:
  * Create a keyboard util function CloseKeyboard which closes
    whichever IME is open. Temporary until crbug.com/1060272 is
    resolved.
  * Moves some static functions in TabletModeWindowManager to a
    shareable location.
  * Moves some duplicate code in BackButton and BackGesture to a
    shareable location

Test: manual
Bug: 1056939
Change-Id: I6112d79c8ae02ec7d6e0a1fba7f55b2862171288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099476
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750340}

https://chromium.googlesource.com/angle/angle.git/+log/a8c95f74dac6..03de11ac882b

git log a8c95f74dac6..03de11ac882b --date=short --first-parent --format='%ad %ae %s'
2020-03-13 timvp@google.com Add ANGLE_FOR_ANDROID_TOAST_MESSAGE to AndroidManifest.xml
2020-03-13 jmadill@chromium.org Vulkan: Timestamp internal RenderPasses in perf tests.

Created with:
  gclient setdep -r src/third_party/angle@03de11ac882b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jmadill@google.com
Change-Id: I1118ccbd6269faf8f6691cc8b6ced5480e167c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103358Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#750339}

PathService::Get was documented as guaranteeing that returned
directories existed. The getter for DIR_TASKBAR_PINS was recently
updated to check for existence and return false otherwise, but this
broke PathServiceTest.Get because it expected that paths can always be
retrieved. In this CL, we relax the existence guarantee in the API, stop
checking to ensure that the taskbar pins directory exists, and instruct
the test not to check for existence of this dir.

BUG=1053446

Change-Id: Ie0742bd191f6894494f5f2c7124b097dbb319eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102489
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750338}

Generalize the name in preparation for adding methods to detect UI
Automation API usage.

Bug: 928811
Change-Id: I5bab0b4cb39c7eca67b86f7fc6b0171444200534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101853Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#750337}