- 03 Dec, 2020 40 commits
-
-
Anna Malova authored
Bug: 1085115 Change-Id: Id3f30716cdda3c295cd251efc1d51933aee90018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571697Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#833398}
-
Marina Ciocea authored
This is a reland of 022c5b0e. Consumers of WebEngine have been prepared for a soft transition, and runners_integration_tests.test-cmx is now updated. Original change's description: > [fuchsia] Migrate to fuchsia.net.interfaces/State > > Fixed: fuchsia:21155 > Change-Id: I85b388be33d4c9697ba866cf11a143493b2b3239 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380329 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Reviewed-by: Sergey Volk <servolk@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828229} TBR=servolk@chromium.org Change-Id: I7c63e2ab88ce8b087411de97bc4ee2eceebc7c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554857 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#833397}
-
Kelvin Jiang authored
Sometimes a request can be made after a tab has been destroyed (invalid tab ID) which can happen for beacon requests. In this case, if a rule was matched for the request, the feedback API should attribute it to the unknown tab ID. This behavior is similar to when a tab is destroyed, its matched rules get re-mapped to the unknown tab ID. Bug: 1153953 Change-Id: Ief359df2dd83fb5eeaab7ab881a62a9ff4d888eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567632 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#833396}
-
Aaron Leventhal authored
When a node is attached, explicitly ensure the parent accessible object for it has ChildrenChanged() called for it, rather than relying on unclear codepaths for this to happen. This regressed in CL:2399317, which altered deferred the work in UpdateCacheAfterNodeIsAttached. Previously, side effects from Get() during dirty layout led to having the parent recompute its children. R=dmazzoni@chromium.org Bug: 1141106 Change-Id: I655784f19668b606b02d1d6ac6e30fbf655cc5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567228 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833395}
-
Robert Kroeger authored
This reverts commit 31b56eca. Reason for revert: This is the most likely cause for b/1155159 from the blame list. Original change's description: > Connect VmCameraMicManager with camera service for PluginVM > > The camera notification/indicator is shown when PluginVM accesses camera > now. Note that flags pluginvm-show-camera-permissions and > vm-camera-mic-indicators-and-notifications need to be turned on. > > Bug: b/167491603 > Change-Id: Ib2e3f7bc85531313811d2525ecac394aadee6e17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557122 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832576} TBR=xiyuan@chromium.org,joelhockey@chromium.org,lxj@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/167491603 Change-Id: I9bbe24795038456a08dc1ea1819de8ed639f2642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571642Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#833394}
-
Yi Gu authored
Similar to other outcomes, we'd like to record when the new backend is not available to help with debugging the browser code API. Bug: 1127397 Change-Id: I9354a9a637bff19968f3cc53638950f5cfc6e335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566349 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833393}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4640dfbfd719..1ec57124a67c 2020-12-03 ehmaldonado@google.com [presubmit] Add option to ignore TBR on PRESUBMIT.py checks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iff49624a8c8080def50936cb8ea4888eedddd42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572118Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833392}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c9f76ea16b75..30bf3b85f1d9 2020-12-03 wolfi@chromium.org [DarkMode] resourcesPanel.css 2020-12-03 jacktfranklin@chromium.org Fix misaligned clear icon in filter box 2020-12-03 tvanderlippe@chromium.org Add support for hashbang comments when formatting JavaScript 2020-12-03 tvanderlippe@chromium.org Fix binary base64 resource view 2020-12-03 jacktfranklin@chromium.org Fix failing theme_color interaction test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4f446f16682236ccc786256b6303727d75de791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570996Reviewed-by:
-
Gavin Williams authored
Define the commonly used variables outside of the individual tests. Bug: 1059779 Change-Id: I527e06e824669e3c44c9b226dbfe7e3e0079b264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570736 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#833390}
-
Roger Tawa authored
Change-Id: I46e011578002acef68e2c3e187883db8a2461aea Bug: 1150852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535685 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833389}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id090c393003080ad2dc6560386ad7b8b9c9b1ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570107Reviewed-by:
-
Victor Hugo Vianna Silva authored
For all remaining implementations except SyncController, implementing SyncStateChangedListener (~SyncServiceObserver) is enough. So this CL converts the observer interface into a delegate interface. Bug: 1107904 Change-Id: Iaa2acd4cbb6ce0efc6b8d9a6e441f4e2b1f8e4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570573 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#833387}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/5656fec512a8dfd2833fbf47b6aaa76364c26fad..3094902fcdc2db2cc832fa854b9a6a8be383926c The following commits have update notes: c3f4612d8 Only accept little-endian ARM and MIPS variants in base.h. 0a6bfa36c Always check the TLS 1.3 downgrade signal. Bug: none Change-Id: I2beb676d8ccdbc04628f2668dd88ae35558b4442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569382 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#833386}
-
Maria Petrisor authored
The fallback will be enabled on Neverware devices using the added build flag: system_slot_software_fallback. Its default value is false and this behavior is not intended for Chromebooks which always have a TPM. In case Neverware enables the build flag: (a) Devices with a TPM will still initialize a TPM-backed system slot. (b) Devices without a TPM will initialize a software-backed system slot. DD: https://docs.google.com/document/d/1rbTiAMpR18SoN0be_AW-ysvptAHbYcTYeZHL6KcAcTQ/edit?usp=sharing Initial bug discussion: https://docs.google.com/document/d/16w4xyCi2tQTIBtS8o4Ga01KxpHwICVnCjyGC6ezlNS0/edit?usp=sharing Bug: b:171461831 Change-Id: I533a7de7bf5367143aa539b9a7883abd6d8f405a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552600 Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Reviewed-by:Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#833385}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9433fa316c9..3dba3ee4654f 2020-12-03 johnstiles@google.com Fix various codegen issues for Metal array types. 2020-12-03 fmalita@chromium.org [skottie] Add image sampling and transform options 2020-12-03 jvanverth@google.com Use MTLCommandBuffer status to determine if completed. 2020-12-03 mtklein@google.com add store64 2020-12-03 reed@google.com get 4x4 initialMatrix in pictureplayback 2020-12-03 reed@google.com stop using bitmapcontroller 2020-12-03 bungeman@google.com Remove NVIDIA_Shield bots. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Icac9f260b94ce3c7ad7e3616ab9250d02fe09bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571201Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/877fbcb69179..8ddf5ae4b8a5 2020-12-03 primiano@google.com Docs: more small improvements to markdown renderer for proto reference. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174570917 Tbr: perfetto-bugs@google.com Change-Id: I85014725c1a606f3d81eea14cf01e46d3eab4301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571997Reviewed-by:
-
ckitagawa authored
First stage of the CSN project. Bug: 1149972 Change-Id: I950258e4fe493d17b934518f64b65331b27a1307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505919 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#833382}
-
Gayane Petrosyan authored
Fix for cases when previous text is incorrectly skipped due to PreviousSkippingChildren. For following example: <div id=1> <div id=2></div> </div> <div id=3></div> PreviousSkippingChildren(div3) = div1 but Previous(div3) = div2 that's why Previous should be used when we are searching for a previous text. Bug: 1154308 Change-Id: I043bf8f5a7db4e361afbe34d2d854566e5bacd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565812 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#833381}
-
Guillaume Jenkins authored
Mark all policies that are ready and fully functional as "supported_on" instead of "future_on" so they correctly show up as supported on iOS in the Enterprise support pages. Bug: 1153879 Change-Id: I08b9a166f257a71b44ea5f7345f5953e81ea7c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566348 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#833380}
-
Taylor Bergquist authored
This reverts commit 98e681e4. Reason for revert: Speculative fix for test failures in https://crbug.com/1155028 Original change's description: > Roll Media App from 6AHX-97XE... to SDoonf2Hk... > > Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012030600_RC00.html > > https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/SDoonf2Hkjiq08J3Ms2EUYh3QtvIsKK630F0L4wd46gC > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll > Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: b/173978830,b/174603791,b/174637068 > Tbr: media-app@grotations.appspotmail.com > Change-Id: I4b2504c38e7441bd375fc733e3f4bf8c6a9980f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568299 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#833328} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,media-app@grotations.appspotmail.com Change-Id: I5ee539abef7cb8b9737f804942a393302c029f74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/173978830 Bug: b/174603791 Bug: b/174637068 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572141Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#833379}
-
Michael Lippautz authored
Bug: 1154667 Change-Id: I65fe8ef14793a65571362b49cc5c7250f43cd30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567168Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833378}
-
Sigurdur Asgeirsson authored
Bug: 1143281 Change-Id: Id8e82c2af615611207a73cede662cf24e39f6599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571959 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#833377}
-
Tommy Li authored
This CL exercises the existing keyword uniquification logic for when sync merges in multiple engines with the same keyword. This soon will be changed once we get rid of uniquification. Bug: 1022775 Change-Id: If88e5d74123c99605e95ab2ebb9c86f4f2bee43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569383 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833376}
-
Thiabaud Engelbrecht authored
alive. Bug: 1154299 Change-Id: I914536086a74fe67657c6b915c1244ce56c80caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568901Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#833375}
-
Wenyu Fu authored
Announce the privacy disclaimer when skipping ToS by policy. Extend the delay for exit to let screenreader to finish the announcement (English) similar to SnackbarManager. Change-Id: Iaee2c5dffb131311e89a6cdbebef2221ecbaea87 Bug: 1128158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568257 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#833374}
-
Scott Violet authored
I had wanted to register the providers as well, but that is problematic. In particular, Initialize() is called before consent has been determined (it's async for WV/WL). As some providers are configured differently depending upon whether reporting is enabled, configuring before reporting is enabled is problematic. I moved registering VariationsIdsProvider to where it happens on the desktop. Another possibility is to keep a pref of the last value and use that when initializing. That way MetricsService and providers could be created immediately. This route has the possibility for uploading some data when we shouldn't. This change would also be trickier (bigger), and I'm hoping to merge this to 88. Lastly, AndroidMetricsServiceClient is initialized earlier then happens on the desktop. In fact it's before threads have been initialized. This means some shuffling around of creation order would have to happen should we want to initialize all the providers (because current place triggers DCHECKs if it does try to create providers). BUG=1148351 TEST=MetricsServiceCreatedFromInitialize Change-Id: Ia82225cb237da38c3bef56815382dc597155fac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551292 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#833373}
-
Ravjit Singh Uppal authored
Extend the Permissions.Engagement metrics to include One-time permission grants. Bug: 1150635 Change-Id: I0e3a738b449832e794c17486d0047592b7f1679e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548620Reviewed-by:
Illia Klimov <elklm@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#833372}
-
David Van Cleve authored
Trust Tokens is a new web feature that extends the fetch API to allow specifying executing certain cryptographic operations alongside outgoing requests: the requests gain new HTTP request headers bearing outbound cryptographic payloads, and the corresponding responses from servers usually contain corresponding cryptographic responses; the browser processes and strips the responses, updating local state. Sometimes, these operations' results can be cached: when we encounter a cached result from a previous operation, we fail the request with ERR_TRUST_TOKEN_OPERATION_CACHE_HIT. This is because we assume that the main reason for sending a request with an associated Trust Tokens operation is executing the Trust Tokens operation (rather than sending whatever's in the request body and obtaining whatever's in the response body), so the caller wouldn't want to incur the resource consumption caused by the request if the Trust Tokens operation's result is already stored locally. While failing a request with ERR_TRUST_TOKEN_OPERATION_CACHE_HIT follows the ResourceError code path in Blink and causes fetch() calls to reject, these requests: - do not trigger additional "request failed" error prints in the DevTools console (assuming that the caller catches the exception that the fetch Promise rejects with); and - show up as "cache hits" (black, in contrast to red errors) in the DevTools network panel. We're adding a new code path ("platform-provided trust tokens"; crbug.com/1130248) where we can have a Trust Tokens operation complete by calling out to a system service, instead of sending a HTTP request to a server. This is pretty similar to the existing "cache hit" case in that we discover we don't need to send anything to a server after all, so we bail early by "failing" the request (since it is messy to populate an empty "success" response) in this case, too. To make the error handling for Trust Tokens operations that are successfully fulfilled locally have the same developer-facing characteristics as cache hits (no console error; not a failure in the network panel), we want to achieve similar error handling. The easiest way to do this seemed to be making the existing net error more generic, to the effect of "we didn't need to send a request to execute the desired Trust Tokens operation, so there's no response to provide" and setting the new error code for both cache hits and locally fulfilled Trust Tokens operations. This CL renames the error code; a follow-up CL will update URLLoader to set this net error for locally fulfilled Trust Tokens operations in addition to, as currently, cache hits. R=mmenke Bug: 1154847 Change-Id: I33e80515c77f2f8e0fc442ccbe9cc98c9b693738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568205Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Chris Sharp authored
Bug: 1139046 Change-Id: I016594eaf8415fb35cade1002d025209e06e9e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568203Reviewed-by:
-
Patrick Monette authored
The IdType class already has built-in support for an invalid ID. Bug: 971272 Change-Id: I7121400d72c22b90c153da32f0a0f74e46a27569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545442 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#833369}
-
James Vecore authored
This CL plumbs the location hint from Nearby Connections to the SendMessage and StartReceivingMessages calls and puts the information into the Tachyon server requests. This allows Tachyon to use the location hint for geo sharding when available. Fixed: 1142001 Change-Id: I3345ea4e6936c934be46178b2128bca66a69af87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568228Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#833368}
-
Patrick Monette authored
This voter casts a USER_BLOCKING priority vote when a frame is audible. Bug: 971272 Change-Id: Ic0b777a48451322e8685c3d19e7d95bab89fb273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542562 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
Livvie Lin authored
Bug: 1015626 Change-Id: I92d5c225677760bf0a5dc4c3c1381db05dd36697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552626 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833366}
-
Alex Ilin authored
TBR: shaktisahu@chromium.org Bug: 1155085 Change-Id: I40ad4748a310230e75e1b02d0c1697f2c539c9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571756Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833365}
-
Norman Rosas authored
and //components/v…, also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I5a9b09421e2199b2e0ed3edd0ea2f32335253cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570248 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833364}
-
Side Yilmaz authored
This CL gets profile from the current tab model instead of always using regular profile. Bug: 1048632 Change-Id: I61458edce798ff205cdd4b2915bbebb58df504ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567921Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833363}
-
bttk authored
This change dissolves method LocationBarLayout#updateVisualsForState(). Method LocationBarCoordinator#updateVisualsForState() remains, and is used in Toolbar. Bug: 1142883 Change-Id: If8b7b46bd6634adc514d607baab406205852263b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545192Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833362}
-
Charlie Hu authored
This CL fixes the missing Document Policy issue for XSLT document. The fix is similar to the previous fix on Permissions Policy. See https://chromium-review.googlesource.com/c/chromium/src/+/2561144. Bug: 1151954 Change-Id: Ie080c360ddc70ac46a63d5166b3830752ecdd94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563440 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833361}
-
Alice Wang authored
This CL make account picker bottom sheet announces the title when a new screen opens. Bug: 1144826, 1143259 Change-Id: I6e5b28733d0d6dfd99b4d1ed36e1e8de799f846c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565533Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833360}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/685cb02ea8d9..76d12f0f5a33 2020-12-03 bclayton@google.com Add EmitVertexPointSizeTransform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Iba3d1b5cbb2a3b4991020d07850c9c0b8d9d9d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571195Reviewed-by:
-
