- 26 Nov, 2019 40 commits
-
-
danakj authored
The PRESUBMIT.py rule checking for base::Bind and base::Callback usage was not working, so new usage crept into places that were previously marked clean. This CL updates the list in PRESUBMIT.py. A lot of places listed in the list are now clean or no longer exist. For places that were previously clean and now violate the rule, we mostly convert them over. 3 exceptions that we add to the PRESUBMIT.py list are: //jingle //media/blink //weblayer R=sky@chromium.org Bug: 1028284 Change-Id: I2e34f57879265c4894be1d1c4d132bf17fb973a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934767 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719249}
-
Friedrich Horschig authored
The password check switch can only be toggled when the Safe Browsing toggle is enabled. The subtitle is displayed when the user is signed out and safe browsing is enabled, since that is the moment when leak detection will be enabled when signing in. Note that disabling the Safe Browsing toggle only disabled the switch in the UI and doesn't change the pref. The code which prevents the leak detection logic to be run if safe browsing is disabled is on the native side in https://crrev.com/c/1937175. Bug: 1028095 Change-Id: I84ff30b8245417e8255024cea2e7679437a98636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932785 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#719248}
-
Sean Kau authored
git cl lint wants the WeakPtrFactory to be the last element in the class. However, DISALLOW_COPY_AND_ASSIGN is also supposed to be last. To fix this, remove the use of the macro. Bug: None Change-Id: Id617ab238d1a7929017fe8c28be2689e4d3df404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937137 Commit-Queue: Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Auto-Submit: Sean Kau <skau@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#719247}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/978d58b7ae4d..c959541ab602 Created with: gclient setdep -r src-internal@c959541ab602 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I3c9102191a4a505e4f85316c6027e11993516f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936192Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719246}
-
Roman Sorokin authored
* Make buttons stick * Content scrollable together with the title * Buttons not go under shelf * Tweak eula paddings Bug: 1019879 Change-Id: I9722316531eafcee7b496cd394b6768192184966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928703 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#719245}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e9356045a4e0..20c014cee7c3 git log e9356045a4e0..20c014cee7c3 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 cwallez@chromium.org Fix typo in the name of wgpuGetProcAddress Created with: gclient setdep -r src/third_party/dawn@20c014cee7c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iac01f43bc9f4a3bf7b8a3443089b3006aab4169b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719244}
-
Sven Zheng authored
Test still failed on Win7 with TIMED_OUT. After some checking, I found PostRunTestOnMainThread should get skipped. There are several RunLoop in https://cs.chromium.org/chromium/src/chrome/test/base/in_process_browser_test.cc?g=0&l=550 We did not proper setup the browser so shutting down the browser would potentially have some unknown issues. TEST: Tested on Win7: https://chromium-swarm.appspot.com/task?id=48bce24f0c843610 Bug: 1025335 Change-Id: I323cf6aaad599fb0661949281dd97e0f58117b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933383Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#719243}
-
rbpotter authored
Failure could not be reproduced locally on a Chrome OS debug build; this is a speculative fix based on the stack trace. Bug: 1028272 Change-Id: I1c10839a82061b6ce4daf7a1d8d80ce0e6210dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935720Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719242}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/68c657298074..6a4a14635e70 git log 68c657298074..6a4a14635e70 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 titovartem@webrtc.org Add ability to strip out logging messages from the binary Created with: gclient setdep -r src/third_party/webrtc@6a4a14635e70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If4b648ba4792822c51373a6b61132789ccc8aaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936905Reviewed-by:
-
kdillon authored
Login handler test fix needed to land field trial testing config for compositor priority experiments. This CL fixes a login handler browsertest that flakes with a timing error when theses experiments are turned. The fix ensures that the web contents are finished loading before we attempt to do anything with them. Bug: 1027606 Change-Id: Ie504a14b831940a8552358a2890904c9c0eca9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854646 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#719240}
-
Caleb Rouleau authored
This feature was originally intended for Pinpoint's use, but that never happened. Supporting this feature would complicate my work in crbug.com/965158. We can re-add this feature later if Pinpoint ever wants it. Bug: 965158 Change-Id: Ifef1e2ae844b5bd047e033461a4f9a0bb116c5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935748Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#719239}
-
Rune Lillesveen authored
Test extensively testing HaveRenderBlockingResourcesLoaded is always run with the BlockHTMLParserOnStyleSheets disabled since it always true with that flag enabled. Various tests required us to test::RunPendingTasks() to do the work after unblocking the parser. There is one test still not passing because xml-stylesheet processing instructions are not blocking parsing with the runtime flag enabled. Will address that separately. Bug: 891767 Change-Id: If237faca49ba965114e51b02763307f56039d8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936256Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#719238}
-
Dominique Fauteux-Chapleau authored
This DCHECK was not included to avoid causing problems with older code that would read the value of empty tokens. Now that this code is migrated the check can be included. Change-Id: I1a9daff8624ba1f7e72df269636d765f2ad9ee20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935833Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719237}
-
Daniel Rubery authored
It's possible the new UX won't have UX approval by the M80 branch point, so place all the changes behind a feature flag, just to be safe. Bug: 1020423 Change-Id: Ia10280e3313fc5754c0c0ac46a33db59f98cf7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931646Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#719236}
-
Daniel Rubery authored
Now that the necessary tests have been added, we can safely add the new endpoint URL. Fixed: 1020434 Change-Id: Ib1b3073a1368d9e794104a4e8df5449cc3c4ef4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927571 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#719235}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b62621c1dd8e..1b1f18689958 git log b62621c1dd8e..1b1f18689958 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 primiano@google.com Fix chromium build, remove some assert_no_deps 2019-11-26 treehugger-gerrit@google.com Merge "Refactor: define oom_score_adj span once" 2019-11-26 fmayer@google.com Merge "Handle DeobfuscationMapping." 2019-11-26 treehugger-gerrit@google.com Merge "perfetto-ui: Changing picture in the record page for heap profiling" 2019-11-26 primiano@google.com Merge "Remove libprotobuf from IPC layer" 2019-11-26 primiano@google.com Merge "tools(tmux): correctly find ninja" Change-Id: I3d771fa153e89ac0b8edf1a7c40b27f3d151bb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937169 Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719234}
-
David Bokan authored
This CL adds back the source bit on injected ACTION_SCROLL motion events. This got lost when [1] tried to make this bit a parameter and then subsequently removed the option due to performance regressions in [2]. The reason this breaks is because in ContentUiEventHandler.java, onGenericMotionEvent only dispatches a wheel event if the ACTION_SCROLL event comes from a Pointer source[3]. [1] https://crrev.com/02cd150c24de8bdebb14d88c1a144b921a47756f [2] https://crrev.com/14e88d0ddbdd58d346bc9c3bb0629af3fdf56f0f [3] https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chromium/content/browser/ContentUiEventHandler.java?rcl=3df6abb639be7564b7743ade8db455a3564e7d32&l=67 Change-Id: I1ba4143f61ad889173735b0a168d7790a00d0865 Bug: 1025789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935432Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719233}
-
Erik Staab authored
Bug: 1007744 Change-Id: Iad1c2de0d2f611feec63175905254d9a739e0a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931917Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#719232}
-
Matt Wolenetz authored
BUG=920044 Change-Id: Idb03f2bc1d2a2f7fb9f9ebd6247259ca097e2ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933385 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719231}
-
Tomasz Wiszkowski authored
TBR=pkotwicz@chromium.org Bug: 1028636 Change-Id: I749bc375a59582d6369edfa05910cea5e6849692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935368 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719230}
-
Ayu Ishii authored
Bug: 1007736 Change-Id: I2304f4f2bb6b031f1834fa23054027a315ef9781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934887Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#719229}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. These are the last instances in //content/renderer/ entirely. R=liberato@chromium.org TBR=dpranke Bug: 953861 Change-Id: Ib32ab468dcdf835e4b8fa08c19cf569a03a50144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934833Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719228}
-
Egor Pasko authored
Bug: 1021524 Change-Id: I1b15ac40c3930e650ae54306d4ac358dea6f60d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936295 Auto-Submit: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719227}
-
Christopher Cameron authored
Prior to this change, we were asynchronously poking around in the filesystem to see what apps are installs for which profiles. Just use the AppShimRegistry. Delete all of the asynchronous profile loading code, and rename some of the menu functions to be more clear in their meaning. TBR=dominickn Bug: 1001213 Change-Id: I27ec96b2ddcfcd0169fa7663a30b8dc8eb113819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929846Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#719226}
-
Friedrich Horschig authored
Before this change, the keyboard accessory (and the settings pages it stole these icons from) were using old icons. This CL adds modern icons and replaces pngs with smaller vector assets: ic_vpn_key.xml: 777B -> 767B infobar_autofill_cc.xml: 1289B -> 661B permission_location.xml: 2505B -> 773B The images have been compressed with avocado for ~22% space gain: ic_vpn_key.xml: 0.987 Kb - 24.1% = 0.749 Kb infobar_autofill_cc.xml: 0.831 Kb - 22.3% = 0.646 Kb permission_location.xml: 0.977 Kb - 22.7% = 0.755 Kb Screenshots for all affected surfaces are attached to the linked bug. Bug: 1028107 Change-Id: Ia66e7ae71f73a2e620969dd87ee74813cf9a9752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937007Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#719225}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/704d5408dbf0..17096c763c24 git log 704d5408dbf0..17096c763c24 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 emircan@google.com Revert "Disable VkProtectedContext_DDLMakeRenderTargetTest" 2019-11-26 brianosman@google.com Remove ResourceProvider and ImageAsset sample impls from skottie Created with: gclient setdep -r src/third_party/skia@17096c763c24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I62b1e2f2dbd4f030a0cadee6c3b8fdc7b627d070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936901Reviewed-by:
-
Olivier Li authored
The test part of this change is necessary to support running HistoryBackend on the ThreadPool.(Feature:HistoryServiceUsesTaskScheduler) On the ThreaPoool we cannot FastForwardUntilNoTasksRemain() for tasks using repeating timers. Regardless of the new feature this change is intended to be a no-op and has the added benefit of being more explicit in the time related expectations. Bug: 661143 Change-Id: I1dcd2f3e2d1e5a5455953b0555c6475b2d0fdafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932417Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
CSVPassword already has the method Parse(PasswordForm*), which parses the associated CSV row. It returns the success/failure of the parsing and stores the corresponding PasswordForm into the location passed as the only argument. If the argument is null, Parse() only checks that the CSV row is a correct serialization of a credential and then does not create the PasswordForm. This is often used in the code. This CL introduces the TryParse() method, which is equivalent to calling (the old) Parse(nullptr). Its purpose is to improve readability of the code: with Parse(nullptr) the reader might wonder what the type and meaning of the "nullptr" is, whereas with TryParse() it is clear that this is some kind of check that parsing works. Parse() now DCHECKS that the passed PasswordForm* is not null. Bug: 934326 Change-Id: I92578ac1f87798535a7e8ba11bd7b464dd724629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932776 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#719222}
-
Peter Beverloo authored
Bug: 1028344 Change-Id: Iba393d02c795f32b9b1341cdf9ef12037fd9126c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937069 Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719221}
-
Sinan Sahin authored
Bug: 1022804 Change-Id: Ifdd7c6abaa0abbacc911c744884e0162f838db41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931107Reviewed-by:
-
Owen Min authored
The test has been disabld on Mac already, but it's also flaky on win, linux and chromeos. Disable the tests on all platforms. Bug: 877109 Tbr: hcarmona@chromium.org Change-Id: I8e2d1e205b5d4077194898ee82337656135e299a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935838Reviewed-by:
-
Matt Jones authored
See bug for details. TBR: pkotwicz@chromium.org Bug: 1028628 Change-Id: If6e85886a4c6572fa4874a77f443dcd716fbe72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937129Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#719218}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4cef8a49b49d..fe2d3ddde90a git log 4cef8a49b49d..fe2d3ddde90a --date=short --first-parent --format='%ad %ae %s' 2019-11-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader afc52b0b26d7..663dcefa22ea (10 commits) 2019-11-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 5efc3922e3e8..8c954d5a413d (3 commits) 2019-11-26 xinyi.he@arm.com Vulkan: Large builtins overflow during string construction in glslang Created with: gclient setdep -r src/third_party/angle@fe2d3ddde90a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None Tbr: cwallez@google.com Change-Id: I69f86c9fae7bf9907af7dc3cdd0f86960dc9dd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936893Reviewed-by:
-
David Van Cleve authored
This patch adds a boolean global which, when enabled, causes the default referrer policy to retain its current default value of no-referrer-when-downgrade even when the ReducedReferrerGranularity base::Feature is enabled. This is a temporary addition that will back an enterprise policy for a couple milestones (targeting M82 for deletion). In multi-process mode, the value propagates to the renderer process through a command-line switch added by RenderProcessHostImpl. Bug: 1021277 Change-Id: Icb4905715467a4f1baacd9e762dd6c0358b38a35 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904231Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719216}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=estark@chromium.org Bug: 1023677 Change-Id: I749cc58adb7de03c55d90527f1276368dc4996af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925739 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Mia Glaese authored
Bug: 982018 Change-Id: If3abc60b1a7f911e76a655886979d572664c9abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930142Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#719214}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b71b5729688e..978d58b7ae4d Created with: gclient setdep -r src-internal@978d58b7ae4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5453e84b66f71a14e17fa1844c5b047148617256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936930Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bcda22bca456..b5a297f389e0 git log bcda22bca456..b5a297f389e0 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 vapier@chromium.org unittests: use 0.1.2.3 for device IPs 2019-11-26 vapier@chromium.org osutils: WriteFile: add automatic encoding support 2019-11-26 vapier@chromium.org cros_build_lib: align CommandResult with subprocess.CompletedProcess 2019-11-26 vapier@chromium.org cros_build_lib: align RunCommandError with subprocess.CalledProcessError 2019-11-26 vapier@chromium.org auto_updater_unittest: rework mocks 2019-11-26 vapier@chromium.org flash_unittest: rework mocks 2019-11-26 engeg@google.com chromium: Trivial cros lint fixes 2019-11-26 vapier@chromium.org cbuildbot_launch: get unittests passing under Python 3 2019-11-26 vapier@chromium.org release_stages: fix channel pickling 2019-11-26 vapier@chromium.org failure_message_lib: tweak dict usage for Python 3 2019-11-26 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-26 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-26 jacobraz@google.com flash_ap: integrate ap flashing with cros commands. 2019-11-26 vapier@chromium.org flash: fix encoding handling of files/programs 2019-11-26 vapier@chromium.org config: delete all Chrome PFQ related builders 2019-11-25 vapier@chromium.org cros_sdk: fix download under Python 3 2019-11-25 vapier@chromium.org cros_sdk_unittest: rework skipping logic for python3 2019-11-25 vapier@chromium.org wrapper: inrease min python version to 3.5 2019-11-25 vapier@chromium.org vm_test_stages_unittest: fix mock return 2019-11-25 manojgupta@google.com config_lib: Fix Lab name mapping for ARM64 boards. 2019-11-25 vapier@chromium.org signer_payloads_client_unittest: fix mock typo Created with: gclient setdep -r src/third_party/chromite@b5a297f389e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: If9bd826fb2add1208170133ec6c0f836ac03bd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936894Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I8656ee4a72e3da131e0e1a31c799fd6b697c7e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929826 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#719211}
-
Kevin Ellis authored
PlayStateInternal is being phased out as it relies on an extended play state that includes a non-spec-compliant pending state. This patch cleans up the implementation of UnlimitedCurrentTimeInternal. The DCHECK code was previously used as a sanity check to ensure that an update to the timing calculations did not change the value of current time. This check is no longer being performed. The unlimited time may deviate from the current time for a finished animations since the hold time is not being used in the calculation when a start time is set and not paused. Bug: 960944 Change-Id: Ie8bd77b8cf770dc79fa65a08ed66c88fd6327c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933123 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719210}
-
