- 17 Jun, 2019 40 commits
-
-
Tim Schumann authored
Mark layout test virtual/mouseevent_fractional/fast/events/before-unload-return-value-from-listener.html as flaky on all MacOS Example failure on MacOS 10.12: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/24041 TBR=alancutter@chromium.com NOTRY=true Change-Id: Id0de4c88720abeefc911f548d57bed44c72a781f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662388Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#669629}
-
Mario Sanchez Prada authored
The include for accounts_cookie_mutator.h is not really needed since we already have a forward declaration for AccountsCookieMutator, so let's remove it and add it explicitly to inline_login_handler_impl.cc. As for account_fetcher_service.h, we can use a forward declaration for this one as well and move the include to the implementation file, so that we eliminate this transitive include as well, so let's do it. Bug: 939372 Change-Id: I55164145021f32fc3e1d88fcc9372c3881482326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660444 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#669628}
-
Morten Stenshorne authored
The virtual/layout_ng_experimental/ failure isn't very interesting, since we don't yet support spanners in NG block fragmentation. TBR=eae@chromium.org Bug: 915204, 973761 Change-Id: Id0c647418d7b8f48011d8f6b747988c3bbb24771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660854Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#669627}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ce8c837. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." 8bbed8ff "Reland tests from "Change ICE connection state on transceiver changes"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: panicker@chromium.org: external/wpt/longtask-timing NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I020771378ddffd0124770e0508b1e643560abbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661498Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669626}
-
Gauthier Ambard authored
The descriptor name of the gesture recognizer which needs to be disabled changed in iOS 13. This CL updates the code to take the new name into account. Bug: 971760 Change-Id: I481ab5abfa04b5ba7b6b38dbcd0fbdc4278e11c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657832 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669625}
-
Tim Schumann authored
-- fast/events/before-unload-return-value-from-listener.html TBR=alancutter@chromium.org BUG=974725 NOTRY=true Change-Id: I305b33d2a9396ade8d61a724b89f5242560efd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662349Reviewed-by:
-
Jit Yao Yap authored
The browser test checks that an installed extension with permissions can call the chrome.loginScreenUi APIs. The tests are: - check that a window can be opened - check that multiple windows cannot be opened - check that a window can be opened and closed - check that calling close fails when there is no open window whitelisted_extension has been updated for the test logic. Change-Id: I51be44d8bcf2089e77d39b8e4f2753e80576f7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640406Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#669623}
-
Fredrik Söderquist authored
Preferred logical widths can depend on the intrinsic aspect ratio, so we need to make sure they are updated when the viewBox (which defines the intrinsic aspect ratio) changes. Bug: 971647 Change-Id: I3151c34cd1e2cbf0ac5d861bc72c1a3c8201db6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660564 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Tim Schumann authored
NOTRY=true TBR=alancutter@chromium.org BUG=974720 Change-Id: Ie70ec24271563cab39b285bea4b55385ac33d040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662348Reviewed-by:
-
Anders Hartvoll Ruud authored
This removes the need to manually update core/BUILD.gn as well as longhands/shorthands_custom.cc when adding a new property. Adding a new property will still not be frictionless, but this improves the situation somewhat. This also enables us to make some nice cleanups, since we can always assume that a .cc file exists for a given property (that was not the case before). * style_builder_functions don't have to support generating Apply functions in headers. * We can remove the logic that figures out whether to put Apply functions in the header or not. * We can remove the preposterous code that tries to optimize #includes based on aspects of the property. * Remove lots of code that figures out the names of all the .h and .cc files. In addition, this CL does some other cleanups, just because: * CSSPropertiesWriter must not inherit behavior from CSSPropertyBaseWriter. This just makes it harder to understand what is happening. Prefer composition, and use css_properties.CSSProperties directly. * CSSPropertyBaseWriter is actually the generator for the property instance files, so rename it. * Make generation of Flags nicer, without crazy formatting in the result. * Remove kSupportsPercentage. (Unused). * Remove PropertyMethod (Python). It's basically useless. Change-Id: Ifff907b53cca89580d8c37aeacfd45f683592d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661671Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#669620}
-
Sergio Villar Senin authored
This is the second step on removing WebThreadSupportingGC from the tree. In this CL we're converting all the callsites to use blink::Thread. All the InitOnThread()/ShutdownOnThread() calls are being removed because all the GC stuff is now handled internally in WorkerThread::SimpleThreadImpl::Run() with the help of WorkerThread::GCSupport. We can also move the thread TLS update from blink::Thread to WorkerThread::SimpleThreadImpl. A new thread creation param had to be added in order to specify that the thread is able to handle GC stuff. Bug: 961743 Change-Id: Ibe3353a2b161045d79eb39a6381a3fd2512d5970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655392 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#669619}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e4b470c912b..ff0c0141d0e2 git log 2e4b470c912b..ff0c0141d0e2 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 perezju@chromium.org [Telemetry] Add value.grouping_label 2019-06-17 perezju@chromium.org [Telemetry] Tweak run.AsDict() to match new test results spec Created with: gclient setdep -r src/third_party/catapult@ff0c0141d0e2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921616,chromium:966835 TBR=eyaich@google.com Change-Id: Idbe9af8d603faaf87d233580b4b5512a16d23788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661838Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669618}
-
Tim Schumann authored
NOTRY=true TBR=alancutter@chromium.org BUG=974717 Change-Id: I1b21897023b4470918059dcf7263f0450d2530d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659451 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Intended to help synchronizing FreeType version between Chromium and PDFium. Tested using $ ../../depot_tools/watchlists.py third_party/freetype/README.chromium ['thestig@chromium.org', 'drott+watch@chromium.org'] Tbr: thestig, bungeman Change-Id: I60d4ebfac716a3625b8d6698bf181b971b091eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660663Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#669616}
-
Hiroki Nakagawa authored
One test case for shared workers is failing because it's not allowed to create a dedicated worker on a shared worker. Bug: n/a Change-Id: I4f7139adacdccb0f16d7afedd7eaab065c4bea2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657855 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#669615}
-
Benoît Lizé authored
PartitionAlloc decommit happens at discrete points up to this CL, typically when renderer memory metrics are collected. This adds a mechanism to post periodic idle time tasks to trigger the reclaim. These tasks run on the main thread as this is likely to be more efficient, and they run during idle time to avoid regressions. This CL does a few things: - Add a feature to enable periodic reclaim to evaluate the impact - Collect total CPU time overhead metrics - Add PostDelayedIdleTask() These are together, as the new classes wouldn't have a use case before this CL. Also fix a couple "git cl lint" warnings. Bug: 942512 Change-Id: I264b49cb8a0da306957bac1b0f714670b20b2eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593260 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#669614}
-
Cathie Chen authored
The crash reason is that the NGInlineItem is obsolete after change list-style-type. This patch added ListStyleTypeChanged to make sure marker is fully updated and re_CollectInlines for marker. Bug: 966750 Change-Id: I8c51bc90d31344fb36627fe29608b2b576d85228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660399 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#669613}
-
Luciano Pacheco authored
Change FileTransferController to *not* update the copy command from selection changed throttled event. This can cause an update to the context menu that was displayed to different entries than the ones in the selection. From my understanding, the reason to update the copy command from the selection updated event is to make Ctrl+C enabled/disabled accordingly, however the Command class already calls "canExecuteChange" before executing the command from a keyboard shorcut [1], so it's safe to not update copy command from file selection event. [1] - https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/command.js?l=298-302 Bug: 936429 Change-Id: Ie9822a272cccf91f0619f65a05cefc39fdddd28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662252Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#669612}
-
Himanshu Jaju authored
Bug: 966032 Change-Id: I5282a0dcbf058d7ab9d9bd900e17db8bb3bc22b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649758 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669611}
-
Luciano Pacheco authored
Remove wait(100) and wait for an UI clue that the pinned action has finished, which is more predictable. Change the ActionsController to listen to ActionModel invalidated event to clear the cached ActionsModel instance. Change the pinned action (DriveToggleOfflineAction) to call 'onExecute_' which invalidates the model, after it has finished processing all entries, the last |pinDriveFile| API callback has been called and metadata has been cleared and re-fetched from backend. The flakiness was due to cache invalidation and refreshing was happening before the |pinDriveFile| API had finished, so metadata and ActionsModel were getting cached with outdated value for |pinned|. Bug: 936429 Change-Id: Ib0878d41d28a46205dc3e2ced8243d681ec1945d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660301 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
lijunsong authored
autocomplete should not hold both `username` and `email` token. This diff removes email from the search list. test: open verbose level in console, console now says `[DOM] Input elements should have autocomplete attributes (suggested: "username"): (More info: https://goo.gl/9p2vKq)` Bug: 973162 Change-Id: I2b86f0f5546bb653593d8fe68e432339ddbe3da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660193Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#669609}
-
David Benjamin authored
I believe this was fixed upstream in https://github.com/sctplab/usrsctp/commit/ec03a56a315b7af60b87e0a975e190d700db6d53 Confirmed race no longer reproduces locally, and if I comment out the locks added above, it does. Bug: 347538 Change-Id: I313f5ed4aafbf012ffa4543580f3b3a5541c2c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657299 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#669608}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/42830e5a68c3..59983a601091 git log 42830e5a68c3..59983a601091 --date=short --no-merges --format='%ad %ae %s' 2019-06-15 33432579+alan-baker@users.noreply.github.com Validate variable initializer type (#2668) 2019-06-14 dneto@google.com Fix uint -> uint32_t in fuzz.cpp (#2675) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@59983a601091 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ib4f4c32910f6288c3be96145cf776436001367f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661580Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/21eba761b5a0..abdb566c3032 git log 21eba761b5a0..abdb566c3032 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 cwallez@chromium.org Remove OpenGLBinding's dependency on glad Created with: gclient setdep -r src/third_party/dawn@abdb566c3032 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I7542199257e8ca9d92a3d8690900f876fa0f66e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661835Reviewed-by:
-
Luciano Pacheco authored
R=lucmult Change-Id: I6f300a68445b55a9b973b44f31a46ad000ca58c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660370 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Chris Hall <chrishall@chromium.org> Reviewed-by:
-
Yi Su authored
This CL moves handler methods for window.history.go/back/forward messages from CRWWebController into CRWJSNavigationHandler. Bug: 956511 Change-Id: I16d919288b62e81810705f89e56ea73501fd007f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660437 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Yi Su authored
This CL adds CRWWKNavigationHandlerDelegate as a required arg in constructor of CRWWKNavigationHandler to make it consistent with CRWJSNavigationHandler. Bug: 956511 Change-Id: I2b81a795bef2d6ac76f200299503aea745d6adbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660560 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Alex Danilo authored
This CL adds a custom element that implements a button for the feedback panels. Included are SVG assets for the different button decorations. Note, the custom element template includes a 'paper-ripple' child which does nothing stand-alone but triggers a ripple effect on the button if combined with the Polymer 'paper-ripple' element in an application. Bug: 947388 Change-Id: I345c300349008cbcb1bd96cd294d96886afaf3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657380Reviewed-by:
-
Yi Su authored
This CL moves the handler method for navigation.didReplaceState message from WebController into CRWJSNavigationHandler. Bug: 956511 Change-Id: I8b507a944848565043e7115057e983bd2758c1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660496 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Adding google_services_settings_egtest.mm into :eg_tests. :unified_consent_eg_tests has been previously removed. It should have been done in: crrev.com/c/1617444 Change-Id: I9ea11da456358412162888d9b64f8f884d7daaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660851 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#669600}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/95ac7b7ceeec..5262bc70d4d9 git log 95ac7b7ceeec..5262bc70d4d9 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 96ee92f09b7c..def9662348b0 (2 commits) Created with: gclient setdep -r src/third_party/angle@5262bc70d4d9 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: Ie91b7aa3f08c8d8ba24a3e95f3b02071f40374cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661581Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=kmackay@chromium.org Change-Id: I1ac52d598e71f6569f544c0cdaee67c07ffd7f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648269 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#669598}
-
Yi Su authored
This CL moves the handler method for navigation.didPushState message from CRWWebController into CRWJSNavigationHandler. Bug: 956511 Change-Id: I6a3941f8ab46725fe1a5680af6f89b7ed44fb8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660491 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=tbarzic@chromium.org Change-Id: Ib2a2cd41a6a01184a2876bcc099f4c49879dcb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648206 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#669596}
-
Mario Sanchez Prada authored
This repeating callback got introduced along with crrev.com/c/1630162 but it's not used anywhere, so let's remove it. Bug: 939372 Change-Id: I772d7c766da0669b4b11fa55a77e7adbb3c483cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660445Reviewed-by:
-
Lin Sun authored
Remove several suppressions on the passthrough command decoder with ANGLE's OpenGL backend, and one Windows suppression with the D3D11 backend. Bug: 602688, 782317 Change-Id: I7782106acd05fbef1828c4c4be7b3c3cf6aef9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645493Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#669594}
-
Mario Sanchez Prada authored
This converts the GetPushMessaging() method from DocumentInterfaceBroker along with the relevant parts of the implementation of mojom::PushMessaging at chrome::PushMessagingManager, and the two classes that use it from Blink, that is, blink::PushProvider and blink::PushMessagingClient. Note that, for now, this still relies on implicit conversions to get a PendingReceiver<T> from InterfaceRequest<T> in PushMessagingManager, which should go away once RenderProcessHostImpl has migrated away from service_manager::BinderRegistry, to service_manager::BinderMap. Also, it needs to keep using the InterfaceProvider in PushProvider to bind the remote interface to avoid thread-related issues that would happen if we tried to use service_manager::Connector now, since that requires being in the main thread to run Connect(), and that code usually runs from the ServiceWorker thread instead. This should stop being a problem once we have a ServiceWorkers-based InterfaceBroker, at which point the code can be fully migrated to service_manager::Connector. Bug: 955171 Change-Id: I62fb6d8b8e1a5872a14740260ea2bca14daf1a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655536Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#669593}
-
Takuto Ikuta authored
Bots are added in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1387683 TBR=jbudorick Bug: 954450, 956776 Change-Id: I1444fd2b196e10310abc449d965a7213b81deecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661319Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#669592}
-
Takuto Ikuta authored
TBR=jbudorick Bug: 956776, 954450 Change-Id: I4ef5268679a71be3b1d368fc1eeab30e1aadfa29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662105Reviewed-by:
-
Noel Gordon authored
Since rendering work here is way more important, idle delay the UMA to a better place: when the browser is idle. Bug: 965370 Change-Id: Idf14450312b07a751901f3a3b0ea99f988890c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662106Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669590}
-
