- 01 Feb, 2019 40 commits
-
-
Yi Gu authored
[Animation Worklet] Clean up animator registration logic for wpt test worklet-animation-with-fill-mode.https.html Similar to [1], we should register the animator only once in the setup. [1] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/animation-worklet/scroll-timeline-writing-modes.https.html Bug: 923881 Change-Id: I0f6761b7753aacdf3ebe6d8ed63fe4e0ea183e25 Reviewed-on: https://chromium-review.googlesource.com/c/1448519Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#628460}
-
Aaron Gable authored
It appears that this test is crashing, and thereby causing webkit_layout_tests to leak content_shell.exe processes on Swarming, which in turn causes the entire swarming shard to fail. Disabling to hopefully stop the leakage and green up the Win10 bot. R=wjmaclean Bug: 926016,927862 Change-Id: Ia655db8ad1918fb3fb567a850bb07a1b9427aa6d Reviewed-on: https://chromium-review.googlesource.com/c/1450407Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#628459}
-
Charlie Harrison authored
Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/e0bzxOfL-2I Bug: 880863 Change-Id: I9dc88d7521444c0a965f8e4d6e4bb23ce3f27905 Reviewed-on: https://chromium-review.googlesource.com/c/1449009Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#628458}
-
Leonard Grey authored
This was causing a weird discontinuity in retina. Bug: 924484 Change-Id: Idaefc7933a69fbb46cfbe8180e1df02161067d0b Reviewed-on: https://chromium-review.googlesource.com/c/1450213Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#628457}
-
Xiaohan Wang authored
When using ScopedTaskEnvironment::NowSource::MAIN_THREAD_MOCK_TIME, both base::Time::Now() and base::TimeTicks::Now() are affected. However, this isn't clear in the comment and there's no unit test covering it. This CL updates the comment and added tests to cover both base::Time::Now() and base::TimeTicks::Now(). Bug: 917527 Test: New tests added. Change-Id: Ida9b5f334e12e0bceb9e952f97f0ee9ef01ffc45 Reviewed-on: https://chromium-review.googlesource.com/c/1450402 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#628456}
-
Evan Stade authored
Test fixtures include: - AcceleratorInteractiveUITest (renamed to AcceleratorTest) - AppListTest - DragDropTest - NativeCursorManagerAshTest interactive ui test is deleted (it was only ever enabled for x11) Bug: none Change-Id: Ifdae12d85eba18e589b9282ee39c2e903d27e560 Reviewed-on: https://chromium-review.googlesource.com/c/1449092 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#628455}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b80b951e0bf..263746b68633 Created with: gclient setdep -r src-internal@263746b68633 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3cf6b376117009b5259fc74a075f2d08dbc4daf8 Reviewed-on: https://chromium-review.googlesource.com/c/1449789Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628454}
-
Parastoo Geranmayeh authored
to HasGreaterFrecencyThan. Some nits that I forgot to commit for crrev.com/c/1446866. Change-Id: I5117154f40a6b97f882fc90fe7c6b6f76e9528f7 Reviewed-on: https://chromium-review.googlesource.com/c/1450050Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#628453}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a0126f61a98..3ed198faf93a git log 1a0126f61a98..3ed198faf93a --date=short --no-merges --format='%ad %ae %s' 2019-02-01 reed@google.com remove docs for containsText 2019-02-01 robertphillips@google.com Rename GrContext::uniqueID to contextID and hide it 2019-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cf9383ed325c..a54104803d72 (1 commits) 2019-02-01 reed@google.com delete orphaned sample 2019-02-01 reed@google.com remove breakText, and all utf cache accessors Created with: gclient setdep -r src/third_party/skia@3ed198faf93a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I21ea2a74e7e8a04ac9d23d8ae37d7d68df892c26 Reviewed-on: https://chromium-review.googlesource.com/c/1450312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628452}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b2d43541..1fe1ad2c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia71e97fe86c3f9cc4de21fa7fedc045b38f579f5 Reviewed-on: https://chromium-review.googlesource.com/c/1450309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628451}
-
Drew Davenport authored
This is called in Debug builds when initializing the GPU process: 0x5620120abcfc sandbox::Trap::SigSysAction() 0x7b1559a70ab0 <unknown> 0x7b155865ae80 __getrlimit 0x56200dd02039 base::AssertMemoryIsReadOnly() 0x56200dd00dd5 base::AutoWritableMemory::AutoWritableMemory() 0x56200dd01a17 base::AutoWritableMemory::Create<>() 0x5620105343bf gl::SetGLGetProcAddressProc() 0x56200526dde4 ui::(anonymous namespace)::LoadEGLGLES2Bindings() 0x56200526d9b4 ui::LoadDefaultEGLGLES2Bindings() 0x5620051fa447 ui::(anonymous namespace)::GLOzoneEGLGbm::LoadGLES2Bindings() 0x56200526e2dc ui::GLOzoneEGL::InitializeStaticGLBindings() 0x562010d78287 gl::init::InitializeStaticGLBindings() 0x562010d72e8f gl::init::InitializeGLOneOffImplementation() 0x562010d72c95 gl::init::(anonymous namespace)::InitializeGLOneOffHelper() 0x562010d72df0 gl::init::InitializeGLNoExtensionsOneOff() 0x562010fc594c gpu::GpuInit::InitializeAndStartSandbox() 0x56201b3f43bb content::GpuMain() 0x56200ca83652 content::RunOtherNamedProcessTypeMain() 0x56200ca85619 content::ContentMainRunnerImpl::Run() 0x56200ca7a88c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() 0x56200ca9a0ba service_manager::Main() 0x56200ca80d83 content::ContentMain() 0x562002f9f298 ChromeMain 0x562002f9f182 main BUG=923570 TEST=Build and deploy debug build to grunt; get to login screen Change-Id: I2c91e0bb3932dcb462b1e89123e0ea357abf93cb Reviewed-on: https://chromium-review.googlesource.com/c/1448771Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#628450}
-
Kurt Horimoto authored
If a Tab is leaked, it's possible for BVC's URLLoadingObserver callbacks to be triggered after the Tab's corresponding WebState has been destroyed. This CL updates that implementation to prevent crashes if this occurs. Bug: 925757 Change-Id: Id47321d2555605e1c1634080c7601b4d0f0b969d Reviewed-on: https://chromium-review.googlesource.com/c/1448686 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628449}
-
Jorge Lucangeli Obes authored
There was a missing space that was making logs confusing. BUG=None TEST=Compile, run, see better log line. Change-Id: I1740323a60393686b0badbd2ab737096c6f8ac5d Reviewed-on: https://chromium-review.googlesource.com/c/1450214 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628448}
-
Francois Doray authored
Previously, we had logic to avoid handling ScopedBlockingCalls outside of blocking tasks. This logic is redundant now that the WaitableEvents used by SchedulerWorkers are marked as "only used while idle" (https://chromium-review.googlesource.com/c/chromium/src/+/1305891/22/base/task/task_scheduler/scheduler_worker.cc) Change-Id: Ie349c868dc89b0e806c9d22937cd95b4e06c5824 Reviewed-on: https://chromium-review.googlesource.com/c/1450044 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#628447}
-
Christian Dullweber authored
This test failed near the end of month in 2009. There was a suspicion that sqlite might need to be updated and it was updated in 2011. I couldn't reproduce the failure by manually setting my time to Jan 31 5:35PM PST, so maybe the reason behind the failure was fixed within the last 10 years. Bug: 15724 Change-Id: I72cc042b46af2b11d6f7679a5f76c0d2b0c4b575 Reviewed-on: https://chromium-review.googlesource.com/c/1449597 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#628446}
-
Nicolas Pena authored
Bug: 927866 Change-Id: I7659f8262d7292e372d90a47f91d7e0dcad3af20 Reviewed-on: https://chromium-review.googlesource.com/c/1450531Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#628445}
-
Matt Menke authored
HostResolverImpl used to use a worker pool, a global base/ object which didn't work well with thread sanitizer. It has since been converted to use the shiny new(ish) base/task_scheduler code, which doesn't have this issue. Bug: 334140 Change-Id: Ief61b2d677191baf9b3f8c0170e206d64bc4b0ae Reviewed-on: https://chromium-review.googlesource.com/c/1450391Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#628444}
-
Steve Anton authored
This allows the mDNS experiment to work for the standalone RTCIceTransport in addition to the ICE transports created by the RTCPeerConnection. Bug: 927579 Change-Id: I75d1bbb7f469d3282a984cae346a096229b3d08b Reviewed-on: https://chromium-review.googlesource.com/c/1449320Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#628443}
-
Matt Menke authored
At the end of the test it closes the other end of socket that it has a pending write to, then reads from the socket, expecting success or a socket closure, but apparently can get a connection reset on Win64. My guess is what's happening is the socket is closed before the pending write completes, and writing to the closed socket then results in a connection reset. Regardless of the cause, though, there's no actual need to close the socket - data was successfully written to the socket by this point, and the socket was never read from, so the read should succeed without closing the socket, contrary to what a comment claims. It looks to me like the comment has been wrong since the CL landed. Bug: 552053 Change-Id: Ieb64f71ad7c54ec6b5be455ffeaf98ed3a7c2b59 Reviewed-on: https://chromium-review.googlesource.com/c/1450431Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#628442}
-
Paul Meyer authored
This patch adds a "Frobulate" feature policy to test being controlled via the Frobulate sample origin trial. Bug: 925097 Change-Id: I8f85926546dc0eafd3f882273af87bbc79a321b2 Reviewed-on: https://chromium-review.googlesource.com/c/1435534 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#628441}
-
Harley Li authored
In Application's Clear Storage panel, when the current site is invalid, e.g. localhost:5000 (no server running there), the 'clear site data' button should be deactivated, and the subtitle for this panel should not display the security origin address. Component 'ParsedURL' has the ability to tell whether the url is valid. Bug: 915703, 919857 Change-Id: I41f6079bbef299d284b36815d3888e3cec1e0050 Reviewed-on: https://chromium-review.googlesource.com/c/1447317Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#628440}
-
David 'Digit' Turner authored
This is only used to get rid of an annoying issue where third_party/android_tools/sdk/platform-tools/package.xml appears as an untracked file, because it was not properly listed in its .gitgnore file. See https://chromium-review.googlesource.com/c/1449574 R=agrieve@chromium.org, jbudorick@chromium.org BUG=NONE Change-Id: I93e830a4e75e4ed28d597e7a79fd306f1bf192af Reviewed-on: https://chromium-review.googlesource.com/c/1449667Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#628439}
-
Aaron Leventhal authored
Bug: 903588 Change-Id: Ie33670e71e91ec992ea51fc8e1fa2a0416698a91 Reviewed-on: https://chromium-review.googlesource.com/c/1450233 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#628438}
-
Chris Lu authored
Add delegate for FindInPageManager. CreateFindInpageManagerTest to test it's behavior. Add property inFindInPageManagerImpl to keep track of total matches in a find. Bug: 896867 Change-Id: I0c4b951c898eb8f3f91562a564db369b66afa78e Reviewed-on: https://chromium-review.googlesource.com/c/1436946 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#628437}
-
Christian Fremerey authored
Flakiness was caused by it not being deterministic whether or not adding and removing virtual devices to/from the video capture service would actually take effect before the Renderer requesting to enumerate devices. The fix is to wait for the service to send a confirmation before proceeding to enumerate in the Renderer. Test: content_browsertests --gtest_filter=WebRtcVideoCaptureServiceEnumerationBrowserTest* Bug: 885256, 927714 Change-Id: If942900c419244454378fe6d53f5bb524207ff03 Reviewed-on: https://chromium-review.googlesource.com/c/1450392Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#628436}
-
Azeem Arshad authored
This CL adds some logic to AndroidSmsAppSetupController so that when removing the PWA, a cookie will be set on the old domain to indicate the status of the migration. This will allow the client to redirect users to new url. We also attempt to remove this cookie when installing the PWA so that the client won't redirect inside the PWA in a rollback case. Bug: 927472 Change-Id: Ia11ce407b2140242c6746d2b28e39d229dff58d4 Reviewed-on: https://chromium-review.googlesource.com/c/1448984 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#628435}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0e08d5911290..7da523216533 git log 0e08d5911290..7da523216533 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 thestig@chromium.org Add CFX_Font::kUntitledFontName. Created with: gclient setdep -r src/third_party/pdfium@7da523216533 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iaf2a22a6d616faf5e34021f13dd99da2e3086c40 Reviewed-on: https://chromium-review.googlesource.com/c/1450314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628434}
-
kylechar authored
This software output device implementation created a child window to draw into from the GPU process. This was to prevent some flashes in the blank areas of the window on resize. While investigating https://crbug.com/924975 it seems like drawing directly into the browser HWND no longer causes any issues on Windows 7 or 10. Drawing directly in the browser HWND also fixes the bug where we aren't redrawing exposed regions on Windows 7 with DWM disabled and software compositing. This was caused by the WM_PAINT update region being empty for the browser window because it has the WS_CLIPCHILDREN style. The child window wasn't handling the WM_PAINT message and with DWM disabled Windows doesn't keep it's own copy of the pixels. As a result, nothing was telling the display compositor to paint those pixels again. Bug: 924975, 835906 Change-Id: I70eef78223ea6f18f4898ebb4d973811fa85c1d2 Reviewed-on: https://chromium-review.googlesource.com/c/1450399 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#628433}
-
Mike Reed authored
Motivated/found by https://skia-review.googlesource.com/c/skia/+/188630 TBR= Change-Id: Iac8fdfe741a51eace1c7ab5ca6116a82e9172ece Reviewed-on: https://chromium-review.googlesource.com/c/1450437 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#628432}
-
Jeremy Klein authored
The existing message makes it sound like the wrong device responded with a ConnectTetheringResponse, but really this log happens every time a non-success response code is received. Bug: None Change-Id: I6c34857a30e86751febff93b13d84b3db6ddc883 Reviewed-on: https://chromium-review.googlesource.com/c/1450404 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#628431}
-
Asanka Herath authored
This change stops attaching the origin and referrer URL metadata to downloaded files on Linux. This information was previously set via the user.xdg.origin.url and user.xdg.referrer.url xattrs. Attaching this metadata doesn't provide any security guarantees on Linux, and is a privacy risk. Originally landed as: https://crrev.com/10156ea4faa45bc0a61817c07659dc4c Reverted as : https://crrev.com/c1f63eb16417863e361a5de3265bd0fa Relanding after removing change to enable a PPAPI browser test on macOS. Bug: 917842 Bug: 927074 TBR: wfh@chromium.org Change-Id: I911776ec2c6d30f0ed24761f4f1257a62b3b62d6 Reviewed-on: https://chromium-review.googlesource.com/c/1447122Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#628430}
-
Hao Zhang authored
Design Doc: https://docs.google.com/document/d/1Sm3Yh3xxIcvo3qF2HQpQzJYR3v7K15B516vidtLNYvY/edit?usp=sharing Change-Id: If9d866d84cda3bf9b31c4db4792cfe6033e459cf Bug: 899057 Reviewed-on: https://chromium-review.googlesource.com/c/1443629Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Hao Zhang <hozhng@google.com> Cr-Commit-Position: refs/heads/master@{#628429}
-
Min Qin authored
This CL moves DownloadPathReservationTracker from chrome/ to components/. This will make it easier to move DownloadTargetDeterminer to components/, which is crucial for making download a standalone component. Bug: 927083 Change-Id: Idff5737a9ef79988de6eb9d3f7669e8636f86688 Reviewed-on: https://chromium-review.googlesource.com/c/1447118Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628428}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/da18f31f960f..3e7bf99febab git log da18f31f960f..3e7bf99febab --date=short --no-merges --format='%ad %ae %s' 2019-02-01 dgarrett@google.com workspace_stages: Add UpdateSDKStage. 2019-02-01 dgarrett@google.com workspace_stages: Use chroot_args and extra_env. 2019-02-01 dgarrett@google.com workspace_stages: Add tests for InitSDK, SetupBoard. Created with: gclient setdep -r src/third_party/chromite@3e7bf99febab The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I237d4a44d2d8e7924ec6d52531620dd83d83ea1d Reviewed-on: https://chromium-review.googlesource.com/c/1450164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628427}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/da7318dd0eeb..8af4b4b64443 git log da7318dd0eeb..8af4b4b64443 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 rmhasan@google.com Fixing issue with tests skipped via the 'Skip' tag Created with: gclient setdep -r src/third_party/catapult@8af4b4b64443 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:923494 TBR=sullivan@chromium.org Change-Id: I94398bb9ae913c15cf53e7e58fb519d85cb03574 Reviewed-on: https://chromium-review.googlesource.com/c/1450163Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628426}
-
Varun Khaneja authored
Also, add a comment in the proto. See http://b/123719599 for details. R=drubery Bug: 907280,927831 Change-Id: Idc690f25bfc3b909eead54c0184184bcf0df8a32 Reviewed-on: https://chromium-review.googlesource.com/c/1450415Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#628425}
-
Vladislav Kaznacheev authored
The current height is 90dp, while the spec requires 92dp. Bug: 925204 Test: manual Change-Id: I484d604028c9bb1c9b82ceae115f871fc1640566 Reviewed-on: https://chromium-review.googlesource.com/c/1450413Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#628424}
-
Leonard Grey authored
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1436948 Change-Id: I553d0a1d50aa764a79b163a8a3a26ab774e4e162 Reviewed-on: https://chromium-review.googlesource.com/c/1440525 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#628423}
-
Ryan Hansberry authored
This restores previous Smart Lock behavior (regressed in M71), improving latency. Before (average of 10 local runs): * StartScanToReceiveUnlockableRemoteStatus: 9007.0 ms * StartScanToAuthentication: 8827.2 ms * AuthenticationToReceiveUnlockableRemoteStatus: 179.3 ms After (average of 10 local runs): * StartScanToReceiveUnlockableRemoteStatus: 3685.6 ms * StartScanToAuthentication: 3576.6 ms * AuthenticationToReceiveUnlockableRemoteStatus: 108.6 ms ((9007.0 - 3685.6) / 9007.0) = 59% reduction in overall latency. Bug: 905724 Change-Id: Ic9dd8e3d11bd3f4140d68bc920a96f2822fc3519 Reviewed-on: https://chromium-review.googlesource.com/c/1448987Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#628422}
-
Dana Fried authored
Currently, Chrome offers to update plugins that are blocked because they are outdated. In Dec 2020, there will be no way to update, as plugins will be end-of-life. When the user tries to load an outdated plugin now, they get a status message that offers to run the outdated version or upgrade the plugin. This patch changes the message seen when a plugin is blocked and cannot be updated - it only offers to run the plugin as-is (no upgrade option). Bug: 918427 Change-Id: If6019fc9492575d7c2e9efbec7c3d665f1db47ac Reviewed-on: https://chromium-review.googlesource.com/c/1448794 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#628421}
-