- 23 Apr, 2020 40 commits
-
-
Ryan Sturm authored
Bug: 1053101 Change-Id: I5c3ee229a94ff9326d9a9e3c19f2fed852aca4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161448Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#761935}
-
Roman Sorokin authored
* Login.TokenObtainResponseTime Fixed: 1072523 Change-Id: Ic19814674908b9ac5861b354cdeecdfd74f197b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162805Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#761934}
-
Andrew Grieve authored
Came across these deps when looking at updating the library. It's pulled in via weblayer but turned out to be unused. Saves 220kb normalized apk size for system_webview_apk. Bug: 1064727 Change-Id: Ie1fc056d9d93da1942183ffe905fb836ad04f01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159799Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#761933}
-
Mohamed Amir Yosef authored
When introducing |date_last_used| field in crrev.com/c/1768320 some PasswordFormData initialisations have been migrated to the new field. This CL is fixing that. Those are only test changes and don't have any product behavioural change. Change-Id: If9df2cf8ee550e338a5c78594b9325c495fd5dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162769Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#761932}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/edccc66c323f..cefc2d9a4582 git log edccc66c323f..cefc2d9a4582 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 mtklein@google.com convert Val* fingers to int regs Created with: gclient setdep -r src/third_party/skia@cefc2d9a4582 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: Id65539ff87856574f64e0f41b84f8cd453901ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761931}
-
Owen Min authored
IOS platform has its own ConfigurationPolicyHandlerListFactory class and policy_test_cases.json file. Add two files' links to the documentation. Change-Id: I5e2f9202af1e306b9a47f8a9a4fd360533bf4df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157248 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#761930}
-
Saurabh Nijhara authored
This browser test EnterpriseEnrollmentTest.StoragePartitionUpdated checks that storage partition is changed when the enterprise enrolment screen is shown the second time. Currently, the test is dependent on the fact that wizard controller is recreated on every call to StartWizard() in login display host. The goal is to make the test independent of this. 1) To fix this, the first enrolment screen is cancelled by tapping on the back button. The exit callback of the screen hides it and shows the login screen but |current_screen_| in the wizard controller still points to the enterprise enrolment screen. Due to this, the screen is not shown the second time as the wizard controller thinks that it is already shown. To fix this, |current_screen_| is reset to NULL when login screen is shown. 2) If the wizard control is reused and WizardController::ShowLoginScreen is called multiple times, like in case of reset screen shown and hidden multiple times, then due to login_screen_started_ being true after the first time, the login screen is not shown in the further attempts. For this we need to reset login_screen_started_ when we advance to another screen. Bug: 1064271 Change-Id: I01d2c44a85256cb9d21f6a92f746bee3819fe074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144197 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#761929}
-
Ryan Sturm authored
Bug: 1036900 Change-Id: Ib3ba74825403c35b7e8d265d52ef20089accb681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161737Reviewed-by:
-
Owen Min authored
Like 'deprecated' or 'future', 'cloud' will hide the policy from policy templates and documentation. However, cloud policy will be treated as a released policy. Bug: 1067190 Change-Id: I9bbf195bb4805c7bf0f998f1d83917c82a320635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158014Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#761927}
-
Mohamed Amir Yosef authored
Bug: 1012203 Change-Id: I0e70dd0135bb84126b82bf62b55bc32cd04ae0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160993 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#761926}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/595075bda5d3..34c40d668082 git log 595075bda5d3..34c40d668082 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 treehugger-gerrit@google.com Merge "Make github happy with LICENSE" Created with: gclient setdep -r src/third_party/perfetto@34c40d668082 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3463035cd9049053db0ecaf7563505f701816bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162693Reviewed-by:
-
Gauthier Ambard authored
The DefaultUserAgent is only enabled for iOS 13. This CL updates the tests to reflect that. Fixed: 1073875 Change-Id: I9ad4490d80baad68cdbfeddd675d4105b989ad06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162749Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#761924}
-
Jesse McKenna authored
This reverts commit f909a6a2. Reason for revert: _RemoveCurrentDirectoryPrefix was missing a line to return the original argument if it was not modified, i.e. the function was returning None if no modification took place. This reland adds the missing return statement. Original change's description: > Revert "boilerplate.py: Ignore current-dir prefixes .\, ./" > > This reverts commit 9d14b9ec. > > Reason for revert: Change is breaking calls without .\ prefix. > > Original change's description: > > boilerplate.py: Ignore current-dir prefixes .\, ./ > > > > This change makes boilerplate.py trim a leading ".\" (Windows's > > current-directory prefix) or "./" (Unix's current-directory prefix) > > from the filename argument, if present. > > > > This is a convenience change for cases where the current-directory > > prefix is prepended. For example, Windows PowerShell automatically > > prepends ".\" to a path when tab completion is used (e.g., typing > > "chrome/b" and pressing tab results in ".\chrome\browser"). This > > change will remove artifacts of this for users who use tab completion > > while typing the filename argument. > > > > Currently: > > `tools/boilerplate.py .\test.h` produces include guard `__TEST_H_` > > `tools/boilerplate.py ./test.cc` or `.mm` produces `#include "./test.h"` > > > > With this change: > > `tools/boilerplate.py .\test.h` produces include guard `TEST_H_` > > `tools/boilerplate.py ./test.cc` or `.mm` produces `#include "test.h"` > > > > Change-Id: I19fd2e72c58135b5e87d4a1e22ec8bc76ef326aa > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157876 > > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#761085} > > TBR=rsesek@chromium.org,jessemckenna@google.com > > Change-Id: Ic02537133fd1548f5279ead83abb0492d6657aaa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159993 > Reviewed-by: Jesse McKenna <jessemckenna@google.com> > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > Cr-Commit-Position: refs/heads/master@{#761185} Change-Id: Iaef7fdecaff8ae205fd0c242777676bbffb788a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161895 Auto-Submit: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#761923}
-
Evan Stade authored
ChannelDefinitions is made into an abstract class that exposes functionality to ChannelsInitializer, and defines useful types like PredefinedChannel. The channel definitions themselves live in the Chrome subclass, ChromeChannelDefinitions. Some of these definitions will be duplicated later for WebLayer. ChannelsInitializerTest uses ChromeChannelDefinitions so it's left in //chrome. (We could replace ChromeChannelDefinitions with a TestChannelDefinitions, but that would reduce coverage of production code.) Both the channel IDs and the channel group IDs will have to be different for WebLayer. It would be possible to account for this in code by judiciously prepending "org.chromium.weblayer.", and then keeping the channel definitions together, but that was both more complicated and seemed more error prone, as it would mean that the ChannelDefinitions.ChannelId type would no longer represent the Android system notification channel identifier. For example, code that used NotificationManagerProxy.getNotificationChannel() would have to be careful *not* to pass ChannelDefinitions.ChannelId without adding a prefix. In Chrome, which has no prefix, this would succeed, but in to-be-shared code, such as NotificationCompatBuilder, this would succeed for Chrome and fail for WebLayer. Bug: 1069895 Change-Id: I55890466797aafc34ef8a821a1cb43de8e3d03ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150066 Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#761922}
-
Ryan Sturm authored
Prerender only runs in the NoState Prefetch configuration, which doesn't run script. Since pop ups can only be opened by script or click, removing the pop up handling code is safe. The removed test runs in the deprecated prerender configuration. Bug: 1038054 Change-Id: Ie2442bdd3c4d03e20f7dd7fff0f63ccc0029f816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161315Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/209a6444a270..28447fd262e4 git log 209a6444a270..28447fd262e4 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 jacktfranklin@chromium.org Add ESLint rule to ban `assert.equal` 2020-04-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@28447fd262e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icffe0095ea0df924556ef0b48c65226c1df3ffca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162690Reviewed-by:
-
Liviu Tinta authored
The test code was not waiting for pointerlockchanged and pointerlockerror events before checking for correctness. Bug: 1014324 Change-Id: I04dac67731f954a5f220c426db031502a6309e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158934Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#761919}
-
Chris Mumford authored
No longer logging the following disused metrics: LevelDBEnv.TimeUntilSuccessFor* LevelDBEnv.IDB.TimeUntilSuccessFor* MojoLevelDBEnv.TimeUntilSuccessFor* Note: LevelDBEnv.IDB.TimeUntilSuccessFor did not have an entry in histograms.xml Bug: 1053059 Change-Id: If6cd4783d8b0714a5a2a359cb4bab8b97b1c5a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161126 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#761918}
-
Ryan Sturm authored
Chrome Prerender (NoStatePrefetch) no longer runs script, so the credentials manager can not run during a prerender. Bug: 1038066, 658732 Change-Id: I34dc2229e56119cf7949b855d66e667511c9830f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158446Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Liviu Tinta authored
The test was not waiting appropriately for events to fire. Now it waits for proper events to fire for requestPointerLock, exitPointerLock, mousemove before it checks for the correctness of the operation. Bug: 766450 Change-Id: Id9f1db83f4555a16a45960f1869680a90c77757e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158386Reviewed-by:
-
Elly Fong-Jones authored
This test flakily crashes, breaking the rest of the suite. Bug: 1069608 Change-Id: I2d4593342e903b75ebd7609f0171873176cd9aa3 Tbr: tommi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161348Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#761915}
-
Colin Blundell authored
The //chrome and //weblayer ExternalNavigationDelegate implementations have identical isPdfDownload() functions. This CL dedupes these functions into the shared ExternalNavigationHandler.java. Bug: 1071390 Change-Id: Iebde2257f10a8704b79a76a2fa00b6d6f04845c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161014Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#761914}
-
https://login.live.comJan Wilken Dörrie authored
This change fixes recording the FillingAssistance for websites that submit fields that differ from the fields that the Password Manager filled in. This happens on popular websites such as https://login.live.com. Bug: 1071122 Change-Id: I6088034a1840d16b931ee3d8c8303e9bab74a66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160933Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#761913}
-
Ella Ge authored
This CL adds PermissionUpdater and LocationPermissionUpdater classes. PermissionUpdater class owns both the NotificationPermissionUpdater and LocationPermissionUpdater. LocationPermissionUpdater only has constructor for now, implementation for updater TWA location permission will be added in following CLs. Bug: 1069506 Change-Id: I35069c18e3ec767c9baa657cad1d8dd232ce8ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131007 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#761912}
-
Nicolás Peña Moreno authored
This is a reland of 7aa36149 Original change's description: > Reland "Add an end-to-end test for LCP" > > This is a reland of 0a615aa9 > > Some tests run without DCHECK so we instead call > event.GetKnownArgAsValue(). > > Original change's description: > > Add an end-to-end test for LCP > > > > This CL adds an end-to-end test for verifying the behaviour of Largest > > Contentful Paint. Specifically, we check that the API exposed through > > JavaScript, UKM, UMA and TraceEvents all capture consistent measurements. > > > > Change-Id: I5d3c2489e747d410c7d67afe2a49ead6482a3bb5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105395 > > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > > Reviewed-by: Steve Kobes <skobes@chromium.org> > > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#760594} > > Bug: 1072789 > > Change-Id: Ic7f6cf486ed18939a98462a458ac0bb1cc74ff93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159616 > Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> > Commit-Queue: Steve Kobes <skobes@chromium.org> > Reviewed-by: Steve Kobes <skobes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761304} Bug: 1072789 Change-Id: I74b2e41bdce17444139e5f05f29db76f5c103db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161687Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#761911}
-
Anatoliy Potapchuk authored
This cl replaces placeholder logic with the display of actual menu with the list of features users can enable/disable. PRD: go/kiosk-a11y UX: go/kiosk-a11y-ux Bug: 1049566 Change-Id: If67d7ef3ce41b888cbed7fae59c8cadd8afba498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151565 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#761910}
-
Daniel McArdle authored
New histograms: + Net.DNS.JobQueueTime.PerTransaction + Net.DNS.JobQueueTime.Failure + Net.DNS.JobQueueTime.Success The PerTransaction histogram records the time between DnsTask creation and the creation of individual DnsTransactions. We also aggregate the PerTransaction values by HostResolverManager::Job. The success or failure of the Job as a whole determines whether we use the Success or Failure variant. Change-Id: I47acb785f63171239522d56f6f3f4833e38a61c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145862Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#761909}
-
Michael Lippautz authored
Wrapper counts have been used to schedule GCs before unified heap. Bug: chromium:1056170 Change-Id: Ibd1b87dbe3d90d4b63ef643121f390f831db4cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162866Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761908}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I4f161c4e55a69e8e025a142d692e3210f36e4078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162267Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761907}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d4302437c9f1..7e972be1216d git log d4302437c9f1..7e972be1216d --date=short --first-parent --format='%ad %ae %s' 2020-04-23 cwallez@chromium.org Revert "Slab-allocate VkDescriptorSets" 2020-04-23 yunchao.he@intel.com Read and write usage in compute pass is valid 2020-04-22 bryan.bernhart@intel.com D3D12: Enable sub-allocation for RTV/DSV heaps. 2020-04-22 enga@chromium.org Slab-allocate VkDescriptorSets 2020-04-22 brandon1.jones@intel.com Non-Local Residency 1: Get Non-Local Memory Info 2020-04-22 rafael.cintron@microsoft.com Allow Ref<Derived> -> Ref<Base> assignment, and move operations Created with: gclient setdep -r src/third_party/dawn@7e972be1216d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3a6c3bd856e99a52d7049bfbd5d5c7f4e6cdb460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162688Reviewed-by:
-
Jérôme Lebel authored
This is a reland of 45e71297 Changing the pure virtual into NOTREACHED() implementation. It is not possible land this patch with pure virtual methods since the subclass is already used. And this patch cannot be landed at the same time than crrev.com/i/2863263. Original change's description: > [iOS] Reauth for trusted vault service > > Adding virtual methods in ChromeTrustedVaultService class to support > re-authentication. > > To present the reauth UI: > void ChromeTrustedVaultService::Reauthentication() > To dismiss the reauth UI: > void ChromeTrustedVaultService::CancelReauthentication() > > See ChromeTrustedVaultServiceImpl for the real implementation (in > crrev.com/i/2863263). > > Related to: > => crrev.com/c/2149330 Adding APIs in ChromeTrustedVaultService > crrev.com/i/2863263 Implementation in ChromeTrustedVaultServiceImpl > crrev.com/c/2153071 Adding coordinator to present the view > crrev.com/c/2152788 Using the coordinator to present the view > > Bug: 1019685 > Change-Id: I935098793ead1f726d7f220e9bb886afb14baa7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149330 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761800} Bug: 1019685 Change-Id: Idc27951ac252405a86f2447ca8686fa3d5e54716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160971 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761905}
-
Scott Violet authored
Without this, the value isn't reported. BUG=none TEST=none Change-Id: I4e02d0cfc5aa0a9156a44884e6ea37682aee9cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161583 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#761904}
-
Benoit Lize authored
ParkableStrings can be written out to disk, through DiskDataAllocator which multiplexes all writes onto a single file descriptor. The file is provided by the browser process. This adds the logic on the browser side to actually provide the file. It is guarded by a (disabled by default) feature, and in any case for incognito renderers. This CL adds: - A mojo interface to provide the file - A feature to enable field trials - Plumbing on the browser and renderer side. Bug: 1029320 Change-Id: I6d1b4ce72561e6ac4dd74a1c4d2fd60a23c48995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160912 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#761903}
-
Sigurd Schneider authored
Bug: chromium:1064587 Change-Id: Ib6cc1601a4cce272835748b160525c307a21ddb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119539 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#761902}
-
Stephen McGruer authored
This runs at 5-6s in the Chromium CQ, and occasionally tips to 7s, which then times out. Bug: 1069117 Change-Id: Ied941b276a59edec98cd12441b68ed0a1ac7a931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161894 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761901}
-
Ioana Pandele authored
These are no longer needed. Bug: 1021013, 1070241 Change-Id: Ifab53ce51898c3798446f47bf485818e8e006655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152591 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Alex Rudenko authored
The CL[1] changes the CSS color format used throughout DevTools. It breaks some of the web tests. This CL updates exectations according to the changes made in [1] and disables the tests temporarily. The tests will be re-enabled once the change is made. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2159516 Bug: 1073350 Change-Id: I4b27909e5f27ee142cf609bab0cbfdd7b3887364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162885Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#761899}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d605957919ad..209a6444a270 git log d605957919ad..209a6444a270 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 wolfi@chromium.org Update protocol 2020-04-23 szuend@chromium.org [issues] Add test for de-duplication of cookies in AggregatedIssue 2020-04-23 janscheffler@chromium.org Add regression test for layers 2020-04-23 jacktfranklin@chromium.org assert.equal => assert.strictEqual 2020-04-23 bmeurer@chromium.org [CodeMirror] roll CodeMirror to 5.53.2 Created with: gclient setdep -r src/third_party/devtools-frontend/src@209a6444a270 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042721 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I476869145ef189b8afa89c8f79abd6fbf1488cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162687Reviewed-by:
-
Sebastien Lalancette authored
Added configuration in ConfirmationAlertViewController which allows moving the primary action button to the toolbar, and keep showing the image, when the layout changes to compact height mode. Also added a way to overwrite the title text size - made it smaller in the QRGeneratorVC case, as page titles tend to get fairly long. Bug: 1064990 Change-Id: I7588088b60b64a4cf2953326d666ccb081d2d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161376Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#761897}
-
David Jean authored
Bug: 1072990 Change-Id: I6965224ce0d8f8dfc90ecb9f5e0bf663f3e94204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160905 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
