- 16 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d6eacbfadd07..b2c3373106d2 git log d6eacbfadd07..b2c3373106d2 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 metzman@chromium.org cros_fuzz: Improve handling of UBSAN, reproduce and cleanup 2018-11-16 derat@chromium.org scripts: Improve status logging in cros_run_vm_test.py. 2018-11-16 shapiroc@chromium.org cbuildbot: Delete config.dtb support 2018-11-16 achuith@chromium.org cros_chrome_sdk_unittests: Seabios symlinks test. 2018-11-16 dgarrett@google.com workspace_stages: Create dual sync stage. 2018-11-16 dgarrett@google.com workspace_builders: Refactor inheritance. 2018-11-16 dgarrett@google.com generic_stage.GetRepoRepository: Make arguments flexible. 2018-11-16 dgarrett@google.com CleanUpStage: Cleanup Workspaces. Created with: gclient setdep -r src/third_party/chromite@b2c3373106d2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie82f53b56e166b2c9a98d1803e1fafbbcd4755f3 Reviewed-on: https://chromium-review.googlesource.com/c/1340148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608785}
-
Mythri Alle authored
IsolatedCodeCache feature has been on finch trial since 71 and the results are as expected. No measurable regressions on the top-level loading metrics and an expected regression of ~7-10% on the time spent compiling Javascript. The regression is expected because we do not share the compiled code across different origins. Bug: chromium:812168 Change-Id: Ib0aec9def0be83ae59298adc8516979b7587ae27 Reviewed-on: https://chromium-review.googlesource.com/c/1337625 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608784}
-
https://chromium-review.googlesource.com/c/1312234Nico Weber authored
Bug: 875037 Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3 Reviewed-on: https://chromium-review.googlesource.com/c/1339339Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608783}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6ad86b66386..4d4ac41560ad git log c6ad86b66386..4d4ac41560ad --date=short --no-merges --format='%ad %ae %s' 2018-11-16 fmayer@google.com Merge "profiling: Don't use default memory order in client." Created with: gclient setdep -r src/third_party/perfetto@4d4ac41560ad The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5c3ef638d14b6a61037831e7ea439a5a87366316 Reviewed-on: https://chromium-review.googlesource.com/c/1340150Reviewed-by:
-
Olivier Robin authored
These are metrics of the old Today extension. Change-Id: Icd0d7c832dacd725cfb33554fc0cf026344dd7ea Reviewed-on: https://chromium-review.googlesource.com/c/1339839Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608781}
-
gogerald authored
Make the default switch preference in settings is true as we used in AutofillAssistantFacade.isConfigured. This CL also refactors the code to clear class scope and dependency. Bug: 806868 Change-Id: I85326c7075d1f353b301934f20a3e2aef127ecc5 Reviewed-on: https://chromium-review.googlesource.com/c/1338470 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608780}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=asanka@chromium.org Bug: 903957 Change-Id: I7ae73e710d70fb3872942b50b7c26285cad73571 Reviewed-on: https://chromium-review.googlesource.com/c/1338124Reviewed-by:Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608779}
-
Benoît Lizé authored
This has two benefits: - Not touching the whole data (as most of it is not written to except for the initial memset() in vector's constructor.) - Allowing to recover from allocation failures. Bug: 905777 Change-Id: I748ec518af8cfc272a8342fdd567d957dbe1fbcc Reviewed-on: https://chromium-review.googlesource.com/c/1339872 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Yi Su authored
SettingsSwitchCell. SettingsSwitchCell should not have a UITableViewCellSelection animation, so set selectionStyle to UITableViewCellSelectionStyleNone when configuring SettingsSwitchCell. Bug: 894791 Change-Id: I21da349f8b888f16af2466d72c1957f17adfe200 Reviewed-on: https://chromium-review.googlesource.com/c/1340260Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608777}
-
Hans Wennborg authored
This picks up package.py changes #607265 and #608413. It does not change the version of clang. It also includes a crazy workaround for msys binaries (in our case find.exe and mv.exe, used by lit tests) crashing during some unknown chrome infra problem (see last bug). Bug: 870331, 905289 Change-Id: Ic1d9fa64d6fcd4b590139c9343bed5bbe4d3faa3 Reviewed-on: https://chromium-review.googlesource.com/c/1337614 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#608776}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/302134240b5d..7dbb7c311f00 git log 302134240b5d..7dbb7c311f00 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 mbonadei@webrtc.org Adding missing build target for audio_device_default. 2018-11-16 srte@webrtc.org Removes templating from CompositeMediaEngine. 2018-11-16 srte@webrtc.org Adds interfaces for audio and video engines. 2018-11-16 nisse@webrtc.org Tweak ChannelSend interface, to make it closer to ChannelSendProxy 2018-11-16 nisse@webrtc.org Delete class ChannelReceiveProxy. 2018-11-15 artit@webrtc.org Android: ignore LintError for absent class files Created with: gclient setdep -r src/third_party/webrtc@7dbb7c311f00 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:856189 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idb96613892a627f2dea77c1e306d193bf29cc53c Reviewed-on: https://chromium-review.googlesource.com/c/1340145Reviewed-by:
-
Marc Treib authored
Sync-the-feature requires a primary account, so this is more accurate. Bug: 871221 Change-Id: Iadd226c28d0d82cc86640a3c210f95505a219465 Reviewed-on: https://chromium-review.googlesource.com/c/1339939 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608774}
-
Clemens Hammacher authored
This makes use of the new fuzzer-specific asan_options, msan_options and ubsan_options. Wasm fuzzers need to be able to install custom segfault handlers, and v8-generated code sometimes uses SIGTRAP in internal code assertions. We might need to allow segfault handlers for more fuzzers (if it's not the default anyway), but this CL is conservative here and only adds it to selected fuzzers. We can still add more later. R=ahaas@chromium.org, mmoroz@chromium.org Bug: chromium:863799 Change-Id: I3fa24b60851501b9c194f7b0cf131cb19325972e Reviewed-on: https://chromium-review.googlesource.com/c/1335572 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This is a prereq for https://chromium-review.googlesource.com/c/chromium/src/+/1338221 without this change, the MTA assertions fail in unit tests even though they are correct in prod. This change matches the browser process' params @ content/browser/startup_helper.cc It has the adverse side-effect however of enabling the MTA in renderer unit tests but the downside there is not as bad as it just means some COM asserts may pass in unit tests where they wouldn't in integration tests or prod. I think that's okay because unit tests are already generally very loose on allowing I/O, waits, etc. Misuse will still be caught, but that's just not unit tests' main role. R=fdoray@chromium.org Bug: 708584, 707362 Change-Id: I68c5e41c24396885af43427d09c11e1e84ecea43 Reviewed-on: https://chromium-review.googlesource.com/c/1338305 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#608772}
-
Michael Lippautz authored
The GCObservation handle is always set and empty state implies that the observed object was garbage collection. Use phantom reference which avoids clearing out the reference manually. Bug: 903586, 843903 Change-Id: I77e6e9d9ef4625d4bb91b3907b0d1b69c17f2208 Reviewed-on: https://chromium-review.googlesource.com/c/1340320Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608771}
-
Antonio Gomes authored
This CL removes the direct needs to SigninManager and PO2TS from UserCloudPolicyManagerChromeOSTest code. CL also removes left-over code from [1], namely kChildAccountId, kChildTestGaiaId and ::AddAndSwitchToChildAccountWithProfile. [1] https://crrev.com/c/1089462 BUG=894075,904358 Change-Id: Ibfddebed7747a2f3cf0a4e8cadf9a4b71d804e18 Reviewed-on: https://chromium-review.googlesource.com/c/1332748Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#608770}
-
Michael Lippautz authored
Change-Id: I4ad3be28aba7c7620e766e1cd5ad5bc81629615c Reviewed-on: https://chromium-review.googlesource.com/c/1339871Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608769}
-
Etienne Pierre-doray authored
Original CL intention was: Use ScopedBlockingCallWithBaseSyncPrimitives to annotate sync primitives. Migrate AssertBaseSyncPrimitivesAllowed() to ScopedBlockingCallWithBaseSyncPrimitives in base::Process. Bug: 903957, 905788 Change-Id: Ief5072d7e9b9feaf1ee7b817add26545bf80b78a Reviewed-on: https://chromium-review.googlesource.com/c/1324418Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#608768}
-
Mustaq Ahmed authored
This fixes the following three tests for UAv2: - BrowserActionApiTest.TestPictureInPictureOnBrowserActionIconClick - PictureInPictureLazyBackgroundPageApiTest.PictureInPictureInBackgroundPage - NotificationsApiTest.TestUserGesture Bug: 860718 Change-Id: I004f7a3922b7b9f39f4371c0dfdd439c6f0b9a07 Reviewed-on: https://chromium-review.googlesource.com/c/1336029Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#608767}
-
Josh Karlin authored
The problem: The BackgroundSyncManager would attempt to fire a sync event as soon as it finished registering an event and fired its client callback. The client callback and the firing of the event could race since the client callback happens on the background sync mojo channel but the event firing happens on the service worker mojo channel. This meant that a registration might fire before its registration promise resolved. The fix: The BackgroundSyncManager sets a "hold_firing" bit on new registrations and won't fire them until the client has acknowledged it has received its registration callback with a DidResolveRegistration IPC. Bug: 671980 Change-Id: Ie5f982776bffc8913033fba6ec2743a18fcfd964 Reviewed-on: https://chromium-review.googlesource.com/c/1307934Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608766}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: Iaf4ac2022102652c9f5ae38a2b778f5c26620532 Reviewed-on: https://chromium-review.googlesource.com/c/1329744Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608765}
-
Tanja Gornak authored
UMA metrics that represent the total E2E latency in the life of a sync change. Per committed sync entity, the elapsed time between the local model being changed (e.g. password created) to the corresponding (reflection) updates processed by the datatype model on the same device (we’ll disable reflection-blocking). Bug: 902343 Change-Id: Iaec9824016662d2ee984419824bde05ea99a32d4 Reviewed-on: https://chromium-review.googlesource.com/c/1292567Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL moves the utils and constants files for the toolbar to the public folder as multiple components are using them. Bug: none Change-Id: I2334a01bc8ffaa93979f0fe08611980eb42d29f3 Reviewed-on: https://chromium-review.googlesource.com/c/1335589 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608763}
-
Morten Stenshorne authored
writing-system-segment-break-001.html fails in legacy layout, but not in LayoutNG. Also moved two failure expectation lines to the right place. They clearly don't belong in the "New passes" category. TBR=kojii@chromium.org Bug: 905629 Change-Id: Ie3d036d53defbbbbb78d86313c56fe885b602d69 Reviewed-on: https://chromium-review.googlesource.com/c/1340302 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#608762}
-
Stepan Khapugin authored
1. Makes the NTP tiles have a11y type of Button 2. Matches the a11y behavior of the NTP tiles for shortcuts. Change-Id: I295f4b23776c0ede8209b86d02c4becbc6d3dd23 Reviewed-on: https://chromium-review.googlesource.com/c/1335597 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#608761}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c30f45d3f9c1..9e63a8137860 git log c30f45d3f9c1..9e63a8137860 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 jmadill@chromium.org Revert "Minor inlining optimization to Context draw calls." Created with: gclient setdep -r src/third_party/angle@9e63a8137860 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I474fcfb94c08e9f122b5c436ce1eee14d70bd39d Reviewed-on: https://chromium-review.googlesource.com/c/1340144Reviewed-by:
-
Lukasz Suder authored
If there is a difference between current and new details it's highlighted and two chips are displayed; to allow move forward or go back (which closes CCT). Screenshot: https://screenshot.googleplex.com/kOoC3B1frUp Bug: 806868 Change-Id: I95ff09c379398d5a5858aa3947d4c578f39b14c9 Reviewed-on: https://chromium-review.googlesource.com/c/1335941 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#608759}
-
Peter E Conn authored
Web App Manifests allow icons to be specified with the "maskable" purpose [1]. These icons are designed with enough space on the sides to allow the user agent to mask them (eg, cut the icon into a circle). On devices that support this, attempt to load a maskable icon. [1] https://w3c.github.io/manifest/#purpose-member Bug: 904354 Change-Id: I08c404d7b956e678b37f995e9ae0d3f13a5a49fe Reviewed-on: https://chromium-review.googlesource.com/c/1333778 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#608758}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b053faa13970..b81a9c76c982 git log b053faa13970..b81a9c76c982 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 perezju@chromium.org [soundwave] Run soundwave scripts using vpython 2018-11-16 perezju@chromium.org [soundwave] Migrate isolate_service to luci-auth Created with: gclient setdep -r src/third_party/catapult@b81a9c76c982 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904441,chromium:903026 TBR=sullivan@chromium.org Change-Id: I348fa92c0279d3a9eb309b221a3359b7f9bd991e Reviewed-on: https://chromium-review.googlesource.com/c/1340146Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f45d57d6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I63ef6212955c636b66a1feb49e102887fd1c0ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1340141 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608756}
-
Mugdha Lakhani authored
Start a background fetch in a paused state whenever appropriate instead of starting and then pausing on the first update. This is now possible after the following change went in: https://chromium-review.googlesource.com/c/chromium/src/+/1265556 Bug: 903248 Change-Id: I55f613de9f7ebf36ec3daa971067e8cd34d44bed Reviewed-on: https://chromium-review.googlesource.com/c/1337627 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#608755}
-
Marc Treib authored
We were already using SetChosenDataTypes. Unfortunately, GetPreferredDataTypes must still be exposed to the Java side because invalidations code needs it. Bug: 884159 Change-Id: I42745e28a312a3ad0494392d2a283c75fa36b08e Reviewed-on: https://chromium-review.googlesource.com/c/1339865Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#608754}
-
Maxim Kolosovskiy authored
Before this CL, |PasswordAutofillAgent| creates a |PasswordForm| when a form is submitted, and copies some data from |provisionally_saved_form_|. If a site clears field values, the submitted form will miss some useful data. For example, confirmation field can be detected only if there are non-empty field values. After this CL, a |provisionally_saved_form_| will be used. It is updated on every user keystroke. So, Javascript can not corrupt the data at submission time. Change-Id: I080f97e5dcf0b3dd184c22900303a35669edef2e Reviewed-on: https://chromium-review.googlesource.com/c/1337508Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#608753}
-
Ruslan Burakov authored
link to the experiment thread https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hE2B1iItPDk Bug: chromium:904764 Change-Id: Ic89e7915a21c60868e0a25b5a9ba160956f86c69 Reviewed-on: https://chromium-review.googlesource.com/c/1332194 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#608752}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/66a44ccac54e..c6ad86b66386 git log 66a44ccac54e..c6ad86b66386 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 fmayer@google.com Merge "profiling: Improve connection management." Created with: gclient setdep -r src/third_party/perfetto@c6ad86b66386 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia6043aa4e5030c63a956e8d19193bb6a01a5d2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1340142Reviewed-by:
-
Vadym Doroshenko authored
If server predicitons are cached, then often PasswordManager receives them earlier than learns about a corresponding form in DOM. So NewPasswordFormManager is created later. And predictions are lost. This CL fixes this, by caching predictions in PasswordManager. Bug: 905982, 831123 Change-Id: I833fe675c3c621edbae31d5b449e274c7d5a33e6 Reviewed-on: https://chromium-review.googlesource.com/c/1338101 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608750}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b4a9d92fc53..7893fd8c43b1 Created with: gclient setdep -r src-internal@7893fd8c43b1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I13538a8e7aba6a740d4e1f42b9fd87cac42daeb0 Reviewed-on: https://chromium-review.googlesource.com/c/1339483Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608749}
-
Gauthier Ambard authored
This CL makes sure that the value returned by -pinnedYOffset is adjusted to the nearest pixel. This is because when the content size isn't the default one, the value isn't adjusted on a pixel. When it is used to compare to the scroll value of the collection view, this gap prevents the collection view from being considered as completely scrolled. Bug: 905276 Change-Id: Ia44de6063b039a022fcde95e015c3e7df4259308 Reviewed-on: https://chromium-review.googlesource.com/c/1337490 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608748}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c33d62e0821..b053faa13970 git log 0c33d62e0821..b053faa13970 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 dtu@chromium.org [pinpoint] Show chart even if the job failed. 2018-11-16 dtu@chromium.org [pinpoint] Fix CIPD / vpython arguments to Swarming. 2018-11-16 perezju@chromium.org [soundwave] Migrate dashboard_services to luci_auth Created with: gclient setdep -r src/third_party/catapult@b053faa13970 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:901630,chromium:905807,chromium:903026 TBR=sullivan@chromium.org Change-Id: I9aa456cfa9804629f7bc66b15091f6825fca4af7 Reviewed-on: https://chromium-review.googlesource.com/c/1340140Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c735b4f9dc50..6e486cec6a10 git log c735b4f9dc50..6e486cec6a10 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d9ee8bf96207..c30f45d3f9c1 (1 commits) Created with: gclient setdep -r src/third_party/skia@6e486cec6a10 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ie74b7d56fd8cd586851c9800bb7587bbf0776e80 Reviewed-on: https://chromium-review.googlesource.com/c/1340139Reviewed-by:
-
