GitLab

The old SigninManager::IsSignoutProhibited() had a few smells
1. callers of SM::SignOut() were expected to always call SignOut()
   even when prohibited. This allowed the *chrome* client to do special
   cleanup.
2. ProhibitSignout() was really meant to narrowly prohibit user-triggered
   sign-out for scenarios like cloud-managed accounts. But the prohibition
   was applied broadly for all SignOut() calls, leading to weird states
   when sign-out was triggered for internal reasons (e.g. cloud policy
   changes).

These issues came up in planning an analogous API for the new
IdentityManager. This CL implements the proposed fixes
https://docs.google.com/document/d/14esaufZT0fr258zL5I69y7YBBc24XsxtDU0B7wpWxBo/edit#bookmark=id.t69fnqpy377k

Namely:
- Prohibiting sign-out is now up to the SigninClient. SignOut() signals
  the source of the sign-out (user-driven vs internal reasons) and the client
  runs a callback indicating whether the sign-out may continue.
- signin_util::SetUserSignoutAllowedForProfile() chrome/ code
  allow/block user-driven sign-outs.
- Other implementers of SigninClient never block sign-out and are unchanged.

NOTE: For now, signin_util::SetUserSignoutAllowedForProfile() actually
prohibits most non-user-driven signouts to avoid changing sign-out behavior in this
large plumbing CL. This will change in a follow up CL where non-user-driven
sign-outs are always permitted.
https://chromium-review.googlesource.com/c/chromium/src/+/1175797/


Bug: 866518
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4758706d796f953cbb68ff1b4a0c8d2985d12fb3
Reviewed-on: https://chromium-review.googlesource.com/1162173
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595214}

The WebAudio spec moved the resume method from the BaseAudioContext to
its subclasses AudioContext and OfflineAudioContext.

Update the idl and implementation to reflect this change.  This change
causes the following tests to fail:

AudioContext/audiocontext-properties.html
BaseAudioContext/baseaudiocontext-properties.html
OfflineAudioContext/offlineaudiocontext-properties.html

We remove these tests because they basically duplicate the test in
external/wpt/webaudio/idlharness.https.window.html.

Bug: 889663, 888870
Test: already covered by existing tests
Change-Id: Ic7ed8a5f950e8d069ac7c916d716526f96bf3c18
Reviewed-on: https://chromium-review.googlesource.com/1247703Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595213}

mojo::MakeRequest never fails to create to initialize the InterfacePtr
and it is ok to start using the InterfacePtr before initialization is
complete.
https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/interface_request.h?l=96-99&rcl=2985a2476a50ee04dbd78b6a0c3228c5f96a2559

Change-Id: Ie5ec84cdcf8896cf646a58aca4ceab8db82eb428
Reviewed-on: https://chromium-review.googlesource.com/1249811Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595212}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/928526013073..6956b3094ad4


Created with:
  gclient setdep -r src-internal@6956b3094ad4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie15ea4976a4c890e70b01fcafae4985763fe7843
Reviewed-on: https://chromium-review.googlesource.com/1252344Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595211}

Update storage/browser/quota to use url::Origin to represent origins
rather than GURL. Various bits of chrome/ and content/ reach into
storage/browser, so update those minimally.

As in previous changes for this issue, any calls to origin.GetURL()
are data flowing into a system that needs similar updating. Calls to
url::Origin::Create (outside of tests) indicate data coming out of a
system that needs updating.

Bug: 598424
Change-Id: I8253ec84221c8e4aba50252c291457b28b692b3f
Reviewed-on: https://chromium-review.googlesource.com/1242035
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595210}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/32381e30ef56..ddc705933d3f


git log 32381e30ef56..ddc705933d3f --date=short --no-merges --format='%ad %ae %s'
2018-09-28 stevenperron@google.com Analyze uses for all instructions. (#1937)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@ddc705933d3f

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib1ef3b27ab19b8f45308dfcb18ad8cdf20017241
Reviewed-on: https://chromium-review.googlesource.com/1252368Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595209}

Using wpt-import in Chromium acc15375.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25464

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Ib1b59bfb388f27991be43dac5d329204de190c9f
Reviewed-on: https://chromium-review.googlesource.com/1252325
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595208}

Revert "Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456."

This reverts commit 86cf2b47.

Reason for revert: Likely causing build flakiness: https://bugs.chromium.org/p/chromium/issues/detail?id=890293#c2

Original change's description:
> Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456.
> 
> Bug: webrtc:5836
> Change-Id: I2ded915e82a7e967962ff3b1f4027b422d055157
> Reviewed-on: https://chromium-review.googlesource.com/1191925
> Commit-Queue: Tim Haloun <thaloun@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594931}

TBR=pauljensen@chromium.org,rch@chromium.org,thaloun@chromium.org

Change-Id: If2502da611962557ecf4eb4da2760860a3c9540a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:5836
Reviewed-on: https://chromium-review.googlesource.com/1252529Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595207}

This CL reverts my recent cleanup changes here:
  https://crrev.com/c/1246826/7/ui/aura/window_targeter.cc#b140
The event target may not be |root_window| nor one of its descendants.

Bug: 890062
Test: Touch input on linux desktop works correctly.
Change-Id: Icf49255b55797488ecc186597de910ecde600efc
Reviewed-on: https://chromium-review.googlesource.com/1251467
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595206}

Follow-up on this CL:
  https://chromium-review.googlesource.com/c/chromium/src/+/1249909

R=piman@chromium.org, oysteine@chromium.org

Bug: 888580
Change-Id: Ia8a6404b7a750f102d224f173abf59c48c5e3b10
Reviewed-on: https://chromium-review.googlesource.com/1251765Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595205}

A CHECK in base::Value::FindKey(..) is hit in a small number of crashes
during shutdown. A check should be in place to make sure the base::Value
instance is in fact a dictionary before calling FindKey(..)

Bug: 890399
Change-Id: I0b24395afc192dbab03f241d94b25309923758d6
Reviewed-on: https://chromium-review.googlesource.com/1252623Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595204}

This reverts commit e392dddd.

Reason for revert:
Follow-up design discussions with dmazzoni and dtseng suggest that
this might not be the right direction to go.

Instead we might want to use AXHostService as the way that both
out-of-process ash and remote app windows/widgets talk to the
browser. We may also have a different mechanism for assigning
AX child tree IDs per-widget.

Original change's description:
> chromeos: Move AXHostService into ash
> 
> This is a step toward supporting multiple remote apps and widgets. We
> need this for browser windows under single-process-mash.
> 
> Under mash the ash process is responsible for top-level window creation
> for remote apps. It will need to route accessibility actions (like hit
> testing) to the correct remote app. Likewise it manages window frames
> and focus. Therefore it should own the mojo AXHostService, not the
> browser.
> 
> Accessibility events from the remote app must be routed out of ash
> into chrome to the accessibility extension. For now we do this with
> the in-process AccessibilityDelegate. I didn't introduce a new delegate
> because the mojo service is lazily created and it's hard to connect
> a new delegate at startup. Subsequent CLs will:
> * Always create the service at ash startup
> * Convert the delegate methods to mojo
> 
> See go/mash-ax-node-tree for the full plan.
> 
> Bug: 888147
> Test: ash_unittests, manually use ChromeVox and STS with shortcut viewer
> Change-Id: Ia9e63689a8cb407b66397778be4617479fdf6c92
> Reviewed-on: https://chromium-review.googlesource.com/1249920
> Commit-Queue: James Cook <jamescook@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594949}

TBR=jamescook@chromium.org,sky@chromium.org,dtseng@chromium.org

Change-Id: I156656b5114a28693308252ee531bbf4c3db867a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 888147
Reviewed-on: https://chromium-review.googlesource.com/1252629Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595203}

Adds a NewTabWithUserActivation method to open a new tab
with a user activation. This means that the page will
behave as if the user has interacted with it and autoplay
will always be allowed.

This CL also tweaks assistant to use it so that it can
open tabs without the autoplay restriction.

BUG=884777

Change-Id: I7c9327b438ac51003442f0e97bd6e63086fb48cd
Reviewed-on: https://chromium-review.googlesource.com/1239543Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595202}

This patch ensures that we don't leak geometry outside of paint
contained element, which may incorrectly affect layout oveflow
of other elements.

Added a WPT with a tall clipped div which causes scrollbars without
this patch, and passes with the patch.

R=chrishtr@chromium.org

Bug: 882322
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I929542d4ad643df8dad1ab388a878bd0892c0c69
Reviewed-on: https://chromium-review.googlesource.com/1246922
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595201}

In practice, Extension objects are pretty much always const. Update
extensions/browser/api_unittest.h to use const Extension objects, rather
than mutable ones.

Bug: 889925
Change-Id: I7e13dac4376eb0e358a30e2fe49154976f02fb0d
Reviewed-on: https://chromium-review.googlesource.com/1252008Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595200}

When undo is pressed on the theme installation info bar the background
should be reset to the selected custom background. To accomplish this
run the same update theme info logic whenever the theme is changed.

Bug: 881750
Change-Id: I1fe5d8d2f8c6d9459a65a4cd801b5583b8f21935
Reviewed-on: https://chromium-review.googlesource.com/1252461
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595199}

Also refactors all FilterGroup contruction out of StreamMixer into a
more focused class.

Bug: 112439135
Test: tuning console
Change-Id: I2c8011a73bdc641eb0b014a18dd3448b6bacb5ed
Reviewed-on: https://chromium-review.googlesource.com/1244608Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Benjamin Shaya <bshaya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595198}

This removes most Token Binding code from chromium. There are a few
places that still have Token Binding references (but will go unused)
that can possibly be removed in the future. These are:
- android_webview/
- net/third_party/quic/
- third_party/tlslite/

There are two UMA histograms in //net that also have TokenBinding in
their name; these are (confusingly) used by Channel ID code as part of
the work on debugging Channel ID mismatches, and can be removed with the
rest of the Channel ID code.

Bug: 875046
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie3d23f8e9580f2d582febfb04e777006f57baa17
Reviewed-on: https://chromium-review.googlesource.com/1248125Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595197}

Bug: 889346
Change-Id: I44a357c52c0a37064e1bb98bf2cfaef44e60db6b
Reviewed-on: https://chromium-review.googlesource.com/1246947Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595196}

R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3d4efdc5e5f164cd990f76a8d5f863f3e5db3942
Reviewed-on: https://chromium-review.googlesource.com/1249861
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595195}

For get_characterExtents() at the offset just past the last character,
return bounds equivalent to the caret's bounds if it
placed there, e.g. width of 1, but the same height as the current line.

Bug: 869985
Change-Id: Ib544b863c1fd7ab132dc5ff4ddbeebdde8ed342b
Reviewed-on: https://chromium-review.googlesource.com/1157228
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595194}

In some versions of MacOS, live regions don't work consistently, due to a bug
in those versions of VoiceOver. Due to these bugs, use the announce API when
running on an older version of MacOS.

Bug: 884801,875843
Change-Id: Ia9711cf935ba605785dfb3cfaf32f85bd2c8cf13
Reviewed-on: https://chromium-review.googlesource.com/1228635
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595193}

This CL keeps most usage of the DocumentLoadStatistics struct as a
normal struct and not a *Ptr, since we don't really need nullability.

Bug: 820612
Change-Id: Ib00002d6b5d320fa7bf4341812f3aca26da2e244
Reviewed-on: https://chromium-review.googlesource.com/1214506
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595192}

This change implements the RTCQuicTransport.start() method and
associated events: onstatechange, onerror.

Bug: 874296
Change-Id: I8cb5d525ff5dd9d7d0a07a306f72297febc9aaaa
Reviewed-on: https://chromium-review.googlesource.com/1171904
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595191}

Prior to this patch, IntersectionObserverEntry was reporting
coordinates in device pixels.

BUG=887974

Change-Id: Ic91748cd2eb9b828a787bb4372d5d5b10bcf8cfb
Reviewed-on: https://chromium-review.googlesource.com/1250121
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595190}

Change-Id: If1678386ef82177792ed0b5e3ed091249eb901c6
Reviewed-on: https://chromium-review.googlesource.com/1251764Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595189}

Introduce a commandline flag --ignore-background-tasks that would be set
by Telemetry when running startup benchmarks to avoid random tasks from
caching the process and skewing the metrics that are based on process
creation.

The bug has an example trace and more details.

Bug: 890424
Change-Id: I456e0f15406ebba7c930f8ec445da0759e9a087d
Reviewed-on: https://chromium-review.googlesource.com/1252382Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595188}

Official build with Firebase enabled uses variants to specify
which Info.plist to use as resource for Firebase. This causes
a conflict as two bundle_data have the same output path.

Move the dependency on ios_firebase_resources_target to the
definition of the "chrome" target, behind the check for use
of the variants to prevent this conflict.

Patchset 1 is the original CL http://crrev/c/1250924 by sdefresne
from which this CL is cloned from.

TBR=sdefresne@chromium.org, justincohen@chromium.org

Bug: 845383
Change-Id: I0e74f04f27708eb970c61b1048cb2492c45cbba4
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1252321
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595187}

Some tests (e.g. ArcSessionManagerTest.ConsumerAccount) are already
flaky on waterfall, and we don't want them here to avoid confusions.

Bug: 881976
Change-Id: Iddc8fd5f18ab6abe54038a5078750bf16968c272
Reviewed-on: https://chromium-review.googlesource.com/1252011Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595186}

Bug: 890336
Change-Id: I649336ca32aa4b23b8859a06f44bdf8dc7a6da26
Reviewed-on: https://chromium-review.googlesource.com/1251464
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595185}

https://skia.googlesource.com/skia.git/+log/656cefe65d62..f88f49d2a52e


git log 656cefe65d62..f88f49d2a52e --date=short --no-merges --format='%ad %ae %s'
2018-09-28 mtklein@google.com Revert "Have Renderer use combined path code"
2018-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e8dd07969872..af0f31d3a909 (2 commits)
2018-09-27 csmartdalton@google.com Cleanup resource flags
2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 122919bddd98..e8dd07969872 (4 commits)
2018-09-27 bungeman@google.com Detect macOS font smoothing behavior.
2018-09-27 egdaniel@google.com Remove assert about top left origin in lazy image generator unique key.
2018-09-27 herb@google.com Have Renderer use combined path code
2018-09-27 nathanrogers@google.com Fix a typo in SkISize comments
2018-09-27 bsalomon@google.com Reland "Change how GrTextureOp computes outset vertices."
2018-09-27 scroggo@google.com Make SkCodec truly default to sRGB
2018-09-27 borenet@google.com [infra] Add nightly UpdateGoDEPS


Created with:
  gclient setdep -r src/third_party/skia@f88f49d2a52e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:858861,chromium:887372
TBR=bsalomon@chromium.org

Change-Id: I4800ec89e6f922e57489b97b2672cf009c93dd34
Reviewed-on: https://chromium-review.googlesource.com/1250949
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595184}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f0aa6f4e3a57..32381e30ef56


git log f0aa6f4e3a57..32381e30ef56 --date=short --no-merges --format='%ad %ae %s'
2018-09-28 stevenperron@google.com Handle decoration groups with no decorations. (#1921)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@32381e30ef56

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iac1c369a62c44201f68dabec0be16659431390e7
Reviewed-on: https://chromium-review.googlesource.com/1252262Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595183}

Add an animtion for the button appearing and disappearing. Also animate
the button when the URL is focused/unfocused.

BUG=889536

Change-Id: I7ca53c2e41da3bedab5b07a133ab4475887c3e17
Reviewed-on: https://chromium-review.googlesource.com/1246944
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595182}

The supported version of the Android NDK now provides sys/ucontext.h for
all architectures, and we no longer need to provide our own definitions.

Keep the ones used by PNaCl but update the defines to no longer use them
on Android.

Bug: 437330
Change-Id: Ia46c746b17b72261842284d4fed3772fea3a96ef
Reviewed-on: https://chromium-review.googlesource.com/1252243Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595181}

https://chromium.googlesource.com/catapult.git/+log/7453eba4feb2..d525ef309fca


git log 7453eba4feb2..d525ef309fca --date=short --no-merges --format='%ad %ae %s'
2018-09-28 perezju@chromium.org [pinpoint_cli] Add isolate_service module.


Created with:
  gclient setdep -r src/third_party/catapult@d525ef309fca

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:879526
TBR=sullivan@chromium.org

Change-Id: Ic1f1490a93133c829095aa4f3d53710bf58a6fa7
Reviewed-on: https://chromium-review.googlesource.com/1250945Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595180}

Bug: 874094
Change-Id: Id80332c84f574b70ba0b0e50f54aebb681276082
Reviewed-on: https://chromium-review.googlesource.com/1251229Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595179}

This is a followup to crrev.com/595106, realizing that there are ~80
more lines to change.

The same (anti)pattern is found in:
shell> git grep '\\\\\\/' -- '*.py'  # my job is counting slashes
  android_webview/support_library/PRESUBMIT.py
  mojo/PRESUBMIT.py
  native_client_sdk/PRESUBMIT.py
  third_party/blink/PRESUBMIT.py
  third_party/blink/renderer/bindings/PRESUBMIT.py

Not updating these files now because:
1. lazy
2. allowing the world where this might break
3. will shoot those at different OWNERS

Bug: None
Change-Id: Ib9d9209098147fa9a36bb179a138b625ad2ff3d6
Reviewed-on: https://chromium-review.googlesource.com/1251629Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595178}

The incognito mode profile should be aware of the user's advanced
protection status (from original profile) if the user signs into
Chrome.

Bug: 887754
Change-Id: Ic4dec677f9adf1464b8c7398934f2d10cb62323b
Reviewed-on: https://chromium-review.googlesource.com/1247001Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595177}

In 1240638e, AVC keyframeness analysis result in MP4 was used instead of
MP4 keyframe metadata, but the conversion of the AVC frame to Annex-B
(and the conditional injection of SPS/PPS) still relied upon the MP4
keyframe metadata. Since that metadata could be incorrect, decode errors
could occur on some decoders due to missing SPS/PPS data for incorrectly
muxed AVC keyframes.

This change performs the bitstream analysis as part of frame conversion,
after converting to Annex-B, but before the conditional SPS/PPS
injection, and uses the analysis's keyframe result (if determined) to
condition the injection instead of the MP4 keyframe metadata.

BUG=889311

Change-Id: I1ef327ef7d399d5a9da552e0da4a58b0f0b04435
Reviewed-on: https://chromium-review.googlesource.com/1250171
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595176}

Keys and entries can currently be loaded separately, but never at the
same time, meaning it requires separate calls to LoadKeys/LoadEntries
to get keys and entries. Some users of ProtoDatabase have resorted to
storing the keys in the entries to get around this.

This CL adds LoadKeysAndEntries(WithFilter) that returns both at the
same time. ProtoDatabase's new LoadKeysAndEntriesCallback gives back a
vector of string/proto pairs.

Bug: 883409
Change-Id: Id624bbdeb356395c6ce679528d85c1f934a9772e
Reviewed-on: https://chromium-review.googlesource.com/1228305
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595175}