- 25 Aug, 2020 40 commits
-
-
Haiyang Pan authored
This reverts commit 90d9fea6. Reason for revert: Missed a wild card Original change's description: > Disable P/CompositorImplBrowserTestRefreshRate.VideoPreference on M x86 > > Test flakes frequently on M emulator. > > BUG=1120813 > > Change-Id: I481b39088f22e295e31ec5eed155f168e0fbad78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373284 > Commit-Queue: Theresa <twellington@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Auto-Submit: Theresa <twellington@chromium.org> > Reviewed-by: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#801172} TBR=twellington@chromium.org,hypan@google.com Change-Id: I2ac2f638512ac603c0c7877c90a5de84857e947c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374048Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#801393}
-
Nicolas Ouellet-Payeur authored
This reverts commit 22a95fed. Reason for revert: class will not be used anymore, since this change: https://crrev.com/c/2335639 Original change's description: > [Extensions] Add ParallelUnpacker class > > This class makes it easy to starts multiple SandboxedUnpacker's in > parallel, and get notified as soon as any of them completes. Since > SandboxedUnpacker is disk-bound and often takes >2s to run, running them > in parallel can be beneficial. > > Right now ParallelUnpacker is not used anywhere, but a follow-up CL will > use it to make extensions update in parallel, which will speed up > extension installs when many of them are queued at the same time (such > as for force-installed extensions). > > Bug: 1103447 > Change-Id: Ibc35588134fe0e91c4f7a243677181a08c642552 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294563 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791835} TBR=rdevlin.cronin@chromium.org,nicolaso@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1103447 Change-Id: Ibd1459dfdf6104ad5aac0bf4f62b5933ad437af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367988Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#801392}
-
Annie Sullivan authored
Also include a change missed in M84. Change-Id: I0091c73b5d56fee3d326412a367a1cb85cdbd865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373218 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#801391}
-
Jeroen Dhollander authored
This is the main controller for the Bloom feature. In this CL I simply: * Introduce the |BloomController| class, and an (mostly) empty |BloomControllerImpl|. * Create the |BloomController| inside the |AssistantClient|, by means of a |BloomControllerFactory|. In later CLs this will actually start doing something. Bug: b/165356952 Change-Id: Ib4d22016bd60ae27e940807e9bb47a2d317eaf96 Tests: Compiled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363399Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#801390}
-
Tom Anderson authored
Nothing references the build target, so it should be safe to remove. xvfb.py now has its own check: https://source.chromium.org/chromium/chromium/src/+/master:testing/xvfb.py;l=172?q=xvfb.py&ss=chromium Also we now have xwmstartupcheck, which checks that the WM (openbox) is running, which implies the X server is up and running. BUG=1066670 Change-Id: I175df13aef8515e9cc39e0baf8db00c74c6f5cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373175 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#801389}
-
Rob Buis authored
Add method to check whether operator should be stretched vertically [1] as well as a unit test. This method will be used in a follow-up CL. [1] https://mathml-refresh.github.io/mathml-core/#stretchy-operator-axis Bug: 6606 Change-Id: If57b13db6c8a710ff553ead6dff9157812122679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375346 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#801388}
-
edchin authored
Tracking images marked for Close All and Undo Close All is no longer necessary with SnapshotBrowserAgent, since there is one SnapshotCache per Browser. Change-Id: I115d0fd11fc22285204446c71bdeae05bf916898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370563Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801387}
-
Joshua Pawlicki authored
The file is not in an archive, since it is convenient for the release tool to be able to copy it directly to the download server (instead of unzipping it, saving it back to GCS, then copying it to the download server). Bug: 1058102 Change-Id: I487afbdc5587fe0f36f400af5b3c070a8850f349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374513 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#801386}
-
edchin authored
The calls to SnapshotCache methods via SnapshotBrowserAgent required obtaining and passing in a Tab ID. It is more correct to directly call the SnapshotTabHelper since it is tied to the WebState. Change-Id: Ie0a7f1976544bc860e4b0cf4ba4e4e381689333e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370015Reviewed-by:
-
Alexander Dunaev authored
On Linux, application modal dialogs should use custom implementation of javascript_dialogs::AppModalDialogViewViews that instantiates the so called event blocker that prevents all windows except the given one from receiving events. The issue affected both X11 and Wayland. This CL moves the creation of the blocker into the default dialog class and makes the latter asking at run time whether the blocker is required, thus fixing the behaviour for Ozone/X11 and Ozone/Wayland. Other platforms use the default implementation that doesn't create the blocker. Change-Id: Ia114ec98dc03167381cbe59e32c30ab09258b704 Bug: 1121138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366745Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#801384}
-
chrome://multidevice-internalsKyle Horimoto authored
(1) Add a newline at the end of each line when saving logs file. (2) Show logs in chronological order. (3) Fix issue which showed "../../" at the start of every filename. Change-Id: I3c40a4c083d156c70998149a0c61b618767c7fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372600 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#801383}
-
Xianzhu Wang authored
It corresponds to blink::RuntimeEnabledFeatures::CompositeSVGEnabled(). This is to allow perf tests with CompositeSVG enabled by default with a testing variation. Bug: 1101002 Change-Id: If9a92b9eb56d0b242d8a46e397df71faa01577e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373398Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801382}
-
Andrew Paseltiner authored
This is a reland of 312a57a1 Original change's description: > Trigger heavy ad intervention when an unloaded heavy ad navigates > > Bug: 1099014 > Change-Id: I98a2d0e548a48fd93618fbae1c1d458f1dbd58a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269740 > Reviewed-by: John Delaney <johnidel@chromium.org> > Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791488} Bug: 1099014 Change-Id: I0894d1f43127e3776e9f71bd35dcb723a1778ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356164Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/master@{#801381}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I08113ee4e4f103a71d5a45aae9888fec4fd7fa41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374681Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801380}
-
Francois Doray authored
It is useful to have a page to reference when explaining shutdown steps. Additional info will be added as needed. Change-Id: I8185372618d6af83d1050a621e8a9898530d4352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372896 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd8de1d295b4..41db2fb64914 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib7f0c0adeacc871fbce433e8d9a80815698c05ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374406Reviewed-by:
-
Antonio Gomes authored
This CL moves - audio_output_ipc_factory.cc - audio_output_ipc_factory_test.cc - mojo_audio_output_ipc.cc|h - mojo_audio_output_ipc_test.cc ... to blink/renderer/modules/media/audio, and - audio_output_ipc_factory.cc ... temporarily to blink/public/web/modules/media/audio/. It also adapts the mojom types to their blink variant. BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: I40798801d3c81379dd7e39a357c2f7633c7178e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360325 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#801377}
-
John Abd-El-Malek authored
Change-Id: I5b17ca633a51dd96d7cc2e73a56a54c6f07a36c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373951 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#801376}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a5c279111d94..ab849683685b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hbos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112738 Tbr: hbos@google.com Change-Id: I241de3bc49eba30144799746396caf5da3de2980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374676Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801375}
-
ckitagawa authored
This splits the existing compositor failure exit cause into several to help understand and possibly debug the failures better. Bug: 1109991 Change-Id: I62b1f6f7ed017568667d14142d06d00760563c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368511 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801374}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/578215be44d0..3a96e2c4c1ca 2020-08-25 johnstiles@google.com Draw patches/atlases using the AutoLayerForImageFilter's SkPaint. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I808f673131e940d8bbcff09f2c3578883a498c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374678Reviewed-by:
-
Mugdha Lakhani authored
The API isn't yet supported on Android WebView. Bug: None. Change-Id: Id7715efcb11ae7a0e0a2d4cebdd0bbe627a986b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374211 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#801372}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /ui/gl/gl_image_shared_memory_unittest.cc This CL was uploaded by git cl split. R=dcastagna@chromium.org Bug: 1110266 Change-Id: I4f6881377c76f5522cc846e8f7840a3941936414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371304Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801371}
-
Satoshi Niwa authored
Bug: b:163967283 Test: none Change-Id: I5437b5fc338b02c1648266463466f3268cfd1fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371087Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#801370}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 420fe2a9. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I7298a74e59544ea85197b9721634bd60e77ce234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375066Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801369}
-
Yutaka Hirano authored
As specified at [1],the empty destination should be the empty string, not "empty". We use "empty" for the "sec-fetch-dest" header[2] though. Fix the implementation and fix incorrect WPTs altogether. 1: https://fetch.spec.whatwg.org/#concept-request-destination 2: https://w3c.github.io/webappsec-fetch-metadata/#abstract-opdef-set-dest Bug: 1121493 Change-Id: Ia86d716dd434c3b6b0e6f1914019fd6110a7ab8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374725Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#801368}
-
Sean Gilhuly authored
SingleClientSessionsSyncTest.NavigationChainAlteredDestructively has a lot of flakes from this fatal log. Until the root cause for this particular crash is found, use DLOG(ERROR) to avoid a crash. This should only affect debug and canary builds. Bug: 992207, 1043899 Change-Id: I53c1fbfbbfe76e4271ba873434e9cd4e3fee92c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374512Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#801367}
-
Robbie Gibson authored
As seen in the attached bug, sometimes accessing the pasteboard from the PasteboardChangeNotification callback causes the notification to be posted again, causing an infinite recursion and crash. The bug is most likely on the Apple end, but without reproduction steps, I'm not sure if they will respond. Nevertheless, we can work around this by only updating in response to the notification once at a time. Then the second notification will be ignored. Bug: 1049053 Change-Id: If15c8d6b17d39b927ac4d21a643de28fa3851a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360021 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801366}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc This CL was uploaded by git cl split. R=dcastagna@chromium.org Bug: 1110266 Change-Id: I59878d4ecbedf46659a65b383efdcbd5b4b3d08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370300Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cdedf581e53e..f1b9b50369f3 2020-08-25 sigurds@chromium.org Fix bug in async function _pollComputedStyleUpdates If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1066772,chromium:1121534 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90afcd5277a7eb794fa58b2da71ae2706ac41367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374674Reviewed-by:
-
Anders Hartvoll Ruud authored
Parsing of the 'none' keyword was already supported, so this CL simply connects the dots between the parsed timeline name and the timeline we pass to the CSSAnimation. For the InertEffect, the inherited_time now needs to be a base::nullopt to prevent an effect value from being produced, so a small adjustment was needed there. Note: Changing from IsScrollTimeline() to IsMonotonicallyIncreasing() is just a cosmetic change. Note also that the test animation-timeline-in-keyframe.html required a small adjustment: previously, the computed value of animation-timeline was 'bar', but there was no @scroll-timeline corresponding to 'bar', so according to spec the animation has no timeline in this case, and therefore no effect value [1]. We previously fell back to the DocumentTimeline, which is not correct: we should have fallen back to "no timeline", which is what we do as of this CL. [1] https://drafts.csswg.org/css-animations-2/#animation-timeline Bug: 1074052, 1097046 Change-Id: Ia664f92f70dff68a17eb82315d6bb7bf18de79f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367835Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#801363}
-
Minggang Wang authored
This patch moves RecordLoadHistograms into Blink, which is needed when implmenting sort of URLLoaderClientImpl inside Blink along with the OnionSoup work. Bug: 860403 Change-Id: I3a2abecd963547d989d31510cf6906e5b7609e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363506Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#801362}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d6482730a5b0..41db2fb64914 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3f2f26561ad530952947829cb457033df86fdd14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374607Reviewed-by:
-
Ewann authored
This CL fixes the background color of items presented in a context menu from the NTP. The previous color displayed was clear color, or it seems that Apple doesn't handle the transparency of the background during animations linked to context menus. To fix this bug, I set the background color to be the same as the NTP. Bug: 1120321 Change-Id: Ibe8d5aece84802b03c2baddf9e43c2fe796b9b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371631 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#801360}
-
Andrew Grieve authored
Bug: 1040534 Change-Id: Ic9873612462612e510b91d713c24c046e017cafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368510 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#801359}
-
Mohamed Amir Yosef authored
This reverts commit a39032ce. Reason for revert: Suspect to have caused egtest failures https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/26041 Original change's description: > [Passwords] Save CompromisedCredentials in the correct store > > Bug: 1108422 > Change-Id: I3a96f9d3a422590df5c0b0947e6b803c074ef9a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372322 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801346} TBR=jdoerrie@chromium.org,mamir@chromium.org Change-Id: I93de62690d0d950243d48e36ad10d14fd866fb43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375365Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#801358}
-
Matt Jones authored
The update to the theme color was removed here: https://chromium-review.googlesource.com/c/chromium/src/+/2343269 Bug: 1121108 Change-Id: I6af81f699c69b4c919fed02c6777a4765e1b5485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372805 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801357}
-
Mohamed Amir Yosef authored
This reverts commit d705fd61. Reason for revert: the parent CL is suspect for test failures Original change's description: > [Passwords] Remove passwords from the correct store in ... > > ... CompromisedCredentialsManager() > > Bug: 1108422 > Change-Id: I66ea95309a1c3242fe8e32591ae986d68dbe5ee2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372429 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801348} TBR=jdoerrie@chromium.org,mamir@chromium.org Change-Id: I39199d239fe2053dc6f0a2c6f7dacefd1eb78651 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375325Reviewed-by:
-
Clemens Arbesser authored
This adds a new flag to the prompt action that controls whether the UI should be detached during BROWSE mode or not. Bug: b/162065211 Change-Id: I38c38903edea236d749313dfb6ca39e13cd1a3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372324 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801355}
-
Michael Tang authored
- Formalize coordinate space of subframe placeholders to be in their parent's space. Bug: 1009552 Change-Id: I75c44a648acc18696e019c669d850bc842823af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363875Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#801354}
-
