- 03 Dec, 2018 32 commits
-
-
Matt Falkenhagen authored
Previously, ResourceResponse had Url() and OriginalUrlViaServiceWorker(), but it was not an obvious API. Namely, the API drives people to use Url() and unless you read the comment above it you aren't aware of the potential security bug. This CL changes the API to have CurrentRequestUrl() and ResponseUrl(). Both functions have potentially surprising behavior, so the API takes a more neutral surface and people must choose one or the other after reading the comments. The CL itself does not cause behavior changes. It's fairly mechanical. Callsites are updated such that: - Url() becomes CurrentRequestUrl() - OriginalUrlViaServiceWorker() becomes something like WasFetchedViaServiceWorker() ? ResponseUrl() : KURL() Future work is to: - Update WebURLResponse similarly - [https://crbug.com/553535] Make behavior changes by updating callsites to use the repsonse URL when appropriate (yhirano started an audit on the codereview) Change-Id: Ia608a53bcf2674f1943f09da9be1bdb5fc7eba34 Bug: 435446 Reviewed-on: https://chromium-review.googlesource.com/c/1356464Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#613018}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I236fec691de04d3013d02ac4d699757e111304fe Reviewed-on: https://chromium-review.googlesource.com/c/1358201Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613017}
-
Noel Gordon authored
- remove navigation_list_model_unittest.html - add BUILD rules to auto-generate and compile this unittest - fix MockFolderShortcutDataModel BUILD rule - MockFolderShortcutDataModel depends on ui:array_data_model - fix FolderShortcutsDataModel BUILD rule - FolderShortcutsDataModel depends on cr:event_target - add prefix comments to all test cases - test cases should describe their intent - fix Closure compile errors Bug: 910991 Change-Id: I8ba2ad3e917473b83011871d94cf17b80ad64d31 Reviewed-on: https://chromium-review.googlesource.com/c/1356731 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#613016}
-
Renee Wright authored
When crostini is disallowed by hardware, Chrome flags, etc, we do not want to show the Linux row in Chrome Settings. If it is not disallowed by these factors but it is enforced off by the enterprise policy then we want to show the Linux row, but disable the "turn on" button and show a policy indicator icon in the row. This change implements that behavior. Change-Id: I8d4367a3e9e732e308ae166855dc91ac1d8ef52b Reviewed-on: https://chromium-review.googlesource.com/c/1322338Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#613015}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id1cf3721127a14a203c57b5c806fa03fd23e886b Reviewed-on: https://chromium-review.googlesource.com/c/1358123Reviewed-by:
-
calamity authored
This reverts commit d21d2ed3. Reason for revert: Causing devtools_eslint failure https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928389307771200912/+/steps/devtools_eslint/0/stdout Original change's description: > DevTools: allow showing views above and below the Sources sidebar. > > Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817 > Reviewed-on: https://chromium-review.googlesource.com/c/1357513 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612830} TBR=dgozman@chromium.org,pfeldman@chromium.org,kozy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I58fd8fab81766fee2aca0747a78f4ac61647f7cf Reviewed-on: https://chromium-review.googlesource.com/c/1358118Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#613013}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f83a6296366..876ca4326d7d Created with: gclient setdep -r src-internal@876ca4326d7d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6043e8fa10de79306ad888c5f3144655f73c3b0b Reviewed-on: https://chromium-review.googlesource.com/c/1358082Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613012}
-
Koji Ishii authored
Following bot results are included. 12246 12248 12253 12254 12259 12266 12269 12276 12281 12288 12290 12292 12298 12301 12319 12332 12334 12335 12336 12340 0 lines were removed and 17 lines were deflaked by consecutive results since 12281. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I0efc7329ca04fb946eb78acacd0d26110cdf7a5d Reviewed-on: https://chromium-review.googlesource.com/c/1354728 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#613011}
-
Dean Liao authored
IsStorageTypeMappable() was defined and used in video_frame.cc only. Export it as VideoFrame::IsStorageTypeMappable() to use in other places. BUG=None TEST=Pass CQ. Change-Id: Ib3bcf5291e64464c8a75f0e9c5fe2f4c62b179d5 Reviewed-on: https://chromium-review.googlesource.com/c/1356459Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#613010}
-
Maggie Cai authored
When dragging a multi-selection of bookmarks in the manager, the order of the selected bookmarks became the order of the selection instead of their original displaying order. This CL updates the order of dragged nodes to the displaying order. BUG=794886 Change-Id: I4ab3ead0454874eee9e7dc49522156aba27f10d4 Reviewed-on: https://chromium-review.googlesource.com/c/1349130Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#613009}
-
Matt Falkenhagen authored
The comments talks of MakeGarbageCollected, but this was meant to refer to `new Response()` in JavaScript. Also quote the relevant specification step. Change-Id: Ib9d545bd610b30d1ce04e6433355053165afd7b9 Reviewed-on: https://chromium-review.googlesource.com/c/1358108Reviewed-by:
-
Matt Falkenhagen authored
FlagExpectations for NetworkService had failing expectations for "cors-rfc1918" (including both non-virtual and virtual suites), but this is already Skipped in the root TestExpectations directory. Therefore the expectations had no effect, so remove them. Also, skip virtual/outofblink-cors entirely, since these are intended to be run with NetworkService off. Note that virtual tests were never actually run with NetworkService on on the NetworkService bot until last week (see https://crbug.com/908654). Bug: 729849 Change-Id: I34f502f23fe026869daacbaf6cacf771195a6910 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1356736 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#613007}
-
Avi Drissman authored
BUG=556939 Change-Id: I769c70035bc61aaf43e6e5c3494df8e725e5bde0 Reviewed-on: https://chromium-review.googlesource.com/c/1356885Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#613006}
-
Noel Gordon authored
- remove progress_center_item_group_unittest.html - add BUILD rules to auto-generate and compile the unittest - fix Closure compile errors Bug: 910989 Change-Id: I1fc5c09f6d13026b21eee4717dc303ab8beb8ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1356730 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Paul Noffke authored
R=johnchen@chromium.org Change-Id: I8f21d99596c78ff7890432a790242c3876d4ba23 Reviewed-on: https://chromium-review.googlesource.com/c/1352772Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/897e391e1f64..7f83a6296366 Created with: gclient setdep -r src-internal@7f83a6296366 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib4584b064b2149e74e0f8015a48de25d426aac3e Reviewed-on: https://chromium-review.googlesource.com/c/1358121Reviewed-by:
-
Rob Schonberger authored
Change-Id: Ic7466250f4438eda5f4d5bd1c0f9b651253e97f0 Reviewed-on: https://chromium-review.googlesource.com/c/1173196Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613002}
-
calamity authored
This reverts commit 6ce17133. Reason for revert: Failing on linux-chromeos-rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16712 Original change's description: > Chrome OS: Fix and re-enable OobeLocalizationTest > > Bug: 633246 > Change-Id: Id6c302696c955401a991c0235d86f05d03019036 > Reviewed-on: https://chromium-review.googlesource.com/c/1355045 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612867} TBR=alemate@chromium.org,jdufault@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 633246 Change-Id: I8d8994bc4d89fd87427d055a2946e6168a4d2f89 Reviewed-on: https://chromium-review.googlesource.com/c/1358106Reviewed-by:
-
Sam McNally authored
- Remove testPromise and StepsRunner. - Assume all files app integration tests return a promise. - Change helpers in background.js to use async-await. - Change setupAndWaitUntilReady to only return the app ID and to not take a callback. Bug: 909056 Change-Id: I5a2f9c87665ab39b8c814f67332b100dea1e32dc Reviewed-on: https://chromium-review.googlesource.com/c/1356738 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#613000}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61ea30737c65..0b287c5bcafd git log 61ea30737c65..0b287c5bcafd --date=short --no-merges --format='%ad %ae %s' 2018-12-03 tikuta@chromium.org introduce ninjalog_uploader to autoninja.bat Created with: gclient setdep -r src/third_party/depot_tools@0b287c5bcafd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:900161 TBR=agable@chromium.org Change-Id: Ie0f08417833db7f8f632808c1513638f104da034 Reviewed-on: https://chromium-review.googlesource.com/c/1358081Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ib9af0ff0386cbcfd4dd21ac9b33f50da0a8be2f6 Reviewed-on: https://chromium-review.googlesource.com/c/1357905Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#612998}
-
Noel Gordon authored
- remove media_inport_handler_unittest.html - add BUILD rules to auto-generate and compile this unittest - define mockChrome, install it during the unittest - remove unused unittest vars and JS auto-format - document test fixtures and test helpers - fix Closure compile errors (there were lots). No change in test behavior, no new tests. Bug: 907970 Change-Id: Id90b4b1eaf84764521fb0d77aa2c29ff56db7c07 Reviewed-on: https://chromium-review.googlesource.com/c/1356728 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This reverts commit f0e7045f. Reason for revert: Power regression on eve crbug.com/910986 Original change's description: > Vaapi: Activate |decode_using_client_picture_buffers_| for h264 > > This CL cleans up and activates |decode_using_client_picture_buffers_| > after recent power consumption measurements done by the Intel folks > reveal that there should be no regression, and also because skipping > the Vpp has a huge impact in memory consumption since Va doesn't need > to allocate ~13/14 Buffer Objects inside (see crbug.com/909926). > > Bug: 909926, 822346 > Change-Id: Ie8d6b41521f5d8ee62568f9674ae071a67c290bf > Reviewed-on: https://chromium-review.googlesource.com/c/1356019 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612498} TBR=mcasas@chromium.org,hiroh@chromium.org,sreerenj.balachandran@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 909926, 822346 910986 Change-Id: I1cb5d54064413d27cd3472e9918c5fcd62385a1c Reviewed-on: https://chromium-review.googlesource.com/c/1358099Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612996}
-
Joshua Peraza authored
mini_chromium and Crashpad's zlib are checked out directly with Crashpad, so don't have their own README.chromium. They are only used when building Crashpad outside chromium. No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I9298c8071dafef84e85992ade91c3801757588f3 Reviewed-on: https://chromium-review.googlesource.com/c/1358002 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#612995}
-
Sam McNally authored
Bug: 819822 Change-Id: I1900ba4bf4c3a1e3c2f407b1fb45f883b0ff5d25 Reviewed-on: https://chromium-review.googlesource.com/c/1263677Reviewed-by:
-
Matt Falkenhagen authored
Change-Id: I5b4035dadf55b3a5e1d1b32010f0bfd324ad9b6b Reviewed-on: https://chromium-review.googlesource.com/c/1355313Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612993}
-
Chris Hall authored
R=dmazzoni,aboxhall BUG=889370 Change-Id: Ic3cb08d971a387fe55fe9b6c527eaab09db18dd5 Reviewed-on: https://chromium-review.googlesource.com/c/1354734 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#612992}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53a14f8c058b..897e391e1f64 Created with: gclient setdep -r src-internal@897e391e1f64 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id885b19ffdd455527b821d7c5999ca8fc344c231 Reviewed-on: https://chromium-review.googlesource.com/c/1358080Reviewed-by:
-
Noel Gordon authored
- remove file_operation_handler_unittest.html - add BUILD rules to auto-generate and compile this unittest - document, add Closure @type's, and auto-format the unittest - fix Closure compile errors No change in test behavior, no new tests. Bug: 910774 Change-Id: Ie91e8ac6951821af05cd5c8482b7be7ae2c3b04f Reviewed-on: https://chromium-review.googlesource.com/c/1356726 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
calamity authored
This reverts commit 66b2e0f1. Reason for revert: Breaks compile https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/5134 Original change's description: > Enable Crashpad for Android > > Overview: > This CL disables Breakpad for Chrome, Content Shell, WebView, and > Chromecast on Android and replaces it with Crashpad. When a crash > signal is received, the browser forks+execs a Crashpad handler process > either for itself or on behalf of a crashing child to create a crash > dump. > > components/crash/ > - Remove CrashDumpManager. Minidump creation is handled entirely by > Crashpad. > - Remove OnChildStart from ChildExitObserver as it is no longer > necessary. > - ChildExitObserver observers CrashHandlerHost to be notified when > child processes receive crash signals. > - De-duplicate calls to ChildExitObserver::Client::OnChildExit when > NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent. > > components/minidump_uploader/ > - Uploaders expect crash reports to already be MIME encoded since > Breakpad was doing that in a signal handler call-back. > CrashFileManager now automatically calls into native code to do > the encoding and write to a directory of crash reports whenever it > checks for reports without logcats. > > chrome/app/*.{cc,h} > chrome/browser/*.cc > content/shell/app/*.{cc,h} > content/shell/browser/*.cc > - Initialize Crashpad instead of Breakpad, with minor cleanup and > adjustment for changes to CrashDumpObserver. > > chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc > - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED, > CLOSED} and signals sent to ChildExitObserver instead of a crash > dump. > > android_webview/ > - AwBrowserTerminator now observes child process crashes via > ChildExitObserver rather than its own pipe. > - Crashpad always produces minidumps, and not microdumps. > - Disabling Crashpad is not yet supported. > > chromecast/ > - There are now two directories that crash report uploaders should > be aware of: "Crashpad" contains a database of raw minidumps > produced by Crashpad, and "Crash Reports" contains MIME encoded > minidumps. MIME encoding is performed by a CrashReportMimeWriter > in CastCrashUploader.java:checkForCrashDumps(). > > Bug: crashpad:30 > Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg > Change-Id: I0efa451585f60287853c47f860f09ced581c8958 > Reviewed-on: https://chromium-review.googlesource.com/c/989401 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Simeon Anfinrud <sanfin@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612987} TBR=yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org,jam@chromium.org,wnwen@chromium.org,torne@chromium.org,halliwell@chromium.org,tobiasjs@chromium.org,rsesek@chromium.org,sanfin@chromium.org,jperaza@chromium.org,mark@chromium.org Change-Id: I602251d05a6f89aa8f1a7c40c50d7b413fb514d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: crashpad:30 Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Reviewed-on: https://chromium-review.googlesource.com/c/1358103Reviewed-by:
-
Noel Gordon authored
- banners.js depends on type {chrome.echoPrivate} - add externs deps: externs/chrome_echo_private.js - combobutton.js and files_menu.js depend on type {PaperRipple} - add externs deps: externs/paper_elements.js - providers_menu.js depends on type {MenuItemUpdateEvent} - add externs deps: externs/menu_item_update_event.js - search_box.js depends on type {SearchItem} - add externs deps: externs/search_item.js - suggest_apps_dialog.js depends on {chrome.webstoreWidgetPrivate} - add externs deps: externs/chrome_webstore_widget_private.js No change in test behavior, no new tests. Bug: 910975 Change-Id: Ib38947f6f6717b9767be6ec4472b1bbd16ac384a Reviewed-on: https://chromium-review.googlesource.com/c/1356734Reviewed-by: -
Joshua Peraza authored
Overview: This CL disables Breakpad for Chrome, Content Shell, WebView, and Chromecast on Android and replaces it with Crashpad. When a crash signal is received, the browser forks+execs a Crashpad handler process either for itself or on behalf of a crashing child to create a crash dump. components/crash/ - Remove CrashDumpManager. Minidump creation is handled entirely by Crashpad. - Remove OnChildStart from ChildExitObserver as it is no longer necessary. - ChildExitObserver observers CrashHandlerHost to be notified when child processes receive crash signals. - De-duplicate calls to ChildExitObserver::Client::OnChildExit when NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent. components/minidump_uploader/ - Uploaders expect crash reports to already be MIME encoded since Breakpad was doing that in a signal handler call-back. CrashFileManager now automatically calls into native code to do the encoding and write to a directory of crash reports whenever it checks for reports without logcats. chrome/app/*.{cc,h} chrome/browser/*.cc content/shell/app/*.{cc,h} content/shell/browser/*.cc - Initialize Crashpad instead of Breakpad, with minor cleanup and adjustment for changes to CrashDumpObserver. chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED, CLOSED} and signals sent to ChildExitObserver instead of a crash dump. android_webview/ - AwBrowserTerminator now observes child process crashes via ChildExitObserver rather than its own pipe. - Crashpad always produces minidumps, and not microdumps. - Disabling Crashpad is not yet supported. chromecast/ - There are now two directories that crash report uploaders should be aware of: "Crashpad" contains a database of raw minidumps produced by Crashpad, and "Crash Reports" contains MIME encoded minidumps. MIME encoding is performed by a CrashReportMimeWriter in CastCrashUploader.java:checkForCrashDumps(). Bug: crashpad:30 Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: I0efa451585f60287853c47f860f09ced581c8958 Reviewed-on: https://chromium-review.googlesource.com/c/989401 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612987}
-
- 02 Dec, 2018 8 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae58624a3a9b..53a14f8c058b Created with: gclient setdep -r src-internal@53a14f8c058b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaf777c3c5c941f895052e934544f181d20bd14f7 Reviewed-on: https://chromium-review.googlesource.com/c/1358079Reviewed-by:
-
dstockwell authored
Most of this change was automated by running `eslint --fix` but a few cases were resolved manually (in particular global definitions and typedefs). Bug: 792774 Change-Id: Iea4e373a088d7d276975bf946a738bc9d81772c3 Reviewed-on: https://chromium-review.googlesource.com/c/1355302 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612985}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfda24364504..ae58624a3a9b Created with: gclient setdep -r src-internal@ae58624a3a9b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib268a116f56f6afa15dfa54a65a0e2e0389c416b Reviewed-on: https://chromium-review.googlesource.com/c/1357897Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1354d1a0ca50..dfda24364504 Created with: gclient setdep -r src-internal@dfda24364504 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idcc3f324ca52f1b4446ffe785a34e86a01ffbc6f Reviewed-on: https://chromium-review.googlesource.com/c/1357896Reviewed-by:
-
Findit authored
This reverts commit a61d2bb4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 612980 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTYxZDJiYjQzMDRkZjgyOGRhNjBhZjA3ZjBiMDVmMzNlNDlmZDE4Zgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/9304 Sample Failed Step: sync_integration_tests Sample Flaky Test: SingleClientSessionsSyncTest.NavigateThenCloseTabThenOpenTab Original change's description: > Reland "Avoid recycling sync tabs if commit pending" > > This is a reland of 62414cfc > > Test improved to avoid flakes. > > Original change's description: > > Avoid recycling sync tabs if commit pending > > > > When a tab is closed, it's possible that the corresponding history > > hasn't been committed yet, and hence there is a risk that synced history > > is lost if the entity is recycled (for another tab that is opened). > > > > In this patch, and behind a feature toggle, this issue is prevented by > > *not* freeing tab nodes while the sync entity is unsynced. Old tabs are > > excluded from this (to avoid problems with expired history) and a max > > cap is also introduced to the number of tabs in this state, in order to > > avoid memory regressions. > > > > Bug: 882489 > > Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b > > Reviewed-on: https://chromium-review.googlesource.com/c/1356541 > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612971} > > TBR=treib@chromium.org > > Bug: 882489 > Change-Id: Ib3f3ff9e4d620512435d9b22ba7b2c338f92203f > Reviewed-on: https://chromium-review.googlesource.com/c/1357086 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612980} Change-Id: I69bf304dc196b29f2b6ccf5f15ff8dd77ca7d610 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882489, 910947 Reviewed-on: https://chromium-review.googlesource.com/c/1357826 Cr-Commit-Position: refs/heads/master@{#612982}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d33123b9f809..1354d1a0ca50 Created with: gclient setdep -r src-internal@1354d1a0ca50 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I58962cea7d1ca7bd32a27ca09b215b6e1514760e Reviewed-on: https://chromium-review.googlesource.com/c/1357895Reviewed-by:
-
Mikel Astiz authored
This is a reland of 62414cfc Test improved to avoid flakes. Original change's description: > Avoid recycling sync tabs if commit pending > > When a tab is closed, it's possible that the corresponding history > hasn't been committed yet, and hence there is a risk that synced history > is lost if the entity is recycled (for another tab that is opened). > > In this patch, and behind a feature toggle, this issue is prevented by > *not* freeing tab nodes while the sync entity is unsynced. Old tabs are > excluded from this (to avoid problems with expired history) and a max > cap is also introduced to the number of tabs in this state, in order to > avoid memory regressions. > > Bug: 882489 > Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b > Reviewed-on: https://chromium-review.googlesource.com/c/1356541 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612971} TBR=treib@chromium.org Bug: 882489 Change-Id: Ib3f3ff9e4d620512435d9b22ba7b2c338f92203f Reviewed-on: https://chromium-review.googlesource.com/c/1357086Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/affb25a9e181..d33123b9f809 Created with: gclient setdep -r src-internal@d33123b9f809 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I46761826d6c9bf0a748dad070bc253b35ea5bebb Reviewed-on: https://chromium-review.googlesource.com/c/1357894Reviewed-by:
-
