- 05 Dec, 2012 6 commits
-
-
finnur@chromium.org authored
It looks like there might be a correlation between our features and the memory regression. This will hopefully tell us which feature is causing it. BUG=163697 TEST=None Review URL: https://codereview.chromium.org/11299344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171093 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171092 0039d316-1c4b-4281-b951-d872f2087c98
-
tburkard@chromium.org authored
R=rvargas@chromium.org, jhawkins@chromium.org Review URL: https://codereview.chromium.org/11419319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171091 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
the linux one is needed at all. Layout tests that try to set a default theme when USE_DEFAULT_RENDER_THEME is set won't work. I'll figure that out when we get further along. BUG=none TEST=none R=tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/11416342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171090 0039d316-1c4b-4281-b951-d872f2087c98
-
eae@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171089 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
With this, we survive killing the adb process which produces the same stack as: http://build.chromium.org/p/chromium.perf/builders/Android%20GN/builds/764/steps/jsgamebench/logs/stdio BUG=163661 TEST='killall -9 adb' while running a benchmark Review URL: https://codereview.chromium.org/11348370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171088 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Dec, 2012 34 commits
-
-
scottmg@google.com authored
(I can't see any good reason why this code was disabled on aura) R=jam@chromium.org BUG=154081 TEST=interactive_ui_tests on win_aura, PanelBrowserTest.MinimizeRestore* Review URL: https://codereview.chromium.org/11416351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171087 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://flashbauerb@chromium.org authored
TBR=estade@chromium.org BUG=105673 Review URL: https://chromiumcodereview.appspot.com/11308348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171086 0039d316-1c4b-4281-b951-d872f2087c98
-
csharp@chromium.org authored
BUG=164091 Review URL: https://chromiumcodereview.appspot.com/11411364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171085 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
test_support_ash -> ash_test_support test_support_aura -> aura_test_support this means all the target names will align: foo foo_unittests foo_test_support et al. BUG=163674 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11428130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171084 0039d316-1c4b-4281-b951-d872f2087c98
-
tedv@chromium.org authored
The associated CR involves moving mutation interfaces of URLRequestJobFactory to URLRequestJobFactory. As such, their initializations need to maintain their type as URLRequestJobFactoryImpl before those interfaces can be removed. See CL https://codereview.chromium.org/11227017 for more information. BUG=146602 Review URL: https://chromiumcodereview.appspot.com/11418203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171083 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
When draggin a window from the tab to re-attach the tab to another window it didn't work because the windows enumeration was not ignoring the window that was being moved (aka itself). BUG=128578 TEST= windows aura desktop, drag tab out and try to re-attach. Review URL: https://codereview.chromium.org/11416345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171082 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
This CL also changes the expected behavior of GenerateKeyRequest() of CleryKey key system when init_data is null. Previously it returns MediaKeyException (from render side) or fires KeyError (from plugin side). Now it fires an empty KeyMessage regardless. In the future the spec should be clear about this. BUG=163785 TEST=media Layout test; media_unittests; content_browsertests Review URL: https://chromiumcodereview.appspot.com/11348365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171081 0039d316-1c4b-4281-b951-d872f2087c98
-
raymes@chromium.org authored
The refactors PPB_Flash_File_ModuleLocal/FileRef to the new resource model. Calls for both these interfaces are now made directly to the browser. This removes the in-process implementation for these interfaces also (as they are flash-only). Tests are added for PPB_Flash_File_ModuleLocal. Review URL: https://codereview.chromium.org/11359097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171080 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
browsing), and unravel the knots that result from it: - Decouple it from the admin policy. - Take the other half of blacklist logic out of ExtensionPrefs and into Blacklist. - Fix bug where blacklisted extensions couldn't be re-installed (let alone re-enabled) if they get taken off the blacklist. TBR=sky@chromium.org BUG=154149,156750 Review URL: https://chromiumcodereview.appspot.com/11415216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171079 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
This CL moves the detached bookmark bar to the bottom of the new tab page. Some differences between this and the old detached bookmark bar: - view is horizontally centered - view has a maximum width of 720 - view is hidden if the height of the new tab page goes below 558 - view doesn't animate when attached or detached from the toolbar Some things that this CL doesn't do yet: - update the look of the detached bookmark bar - hide the attached bookmark bar when showing instant search results Screenshot: http://i.imgur.com/ihkO0.png BUG=160843 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11428149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171075 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
AppCacheEnabled is mapped onto WebPreferences.application_cache_enabled, which goes directly into WebKit Settings. AppCachePath is only used as a flag to enable AppCache. We can't make use of the full path given, because in Chromium the Application Cache directory lives inside the browser context (profile). The tests added trigger a DCHECK in disk cache, unless the profile is empty when the test starts. This makes impossible to run them both now, so only one of them is enabled for now. Android CTS tests WebSettings.testAppCache{Disabled|Enabled} are passing with this patch. Review URL: https://chromiumcodereview.appspot.com/11411229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171074 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
(This should be reverted after a day on the canary.) BUG=143155 TEST=none Review URL: https://chromiumcodereview.appspot.com/11299320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171073 0039d316-1c4b-4281-b951-d872f2087c98
-
yoz@chromium.org authored
Also simplify handling of legacy disabled extensions. BUG=162062 Review URL: https://chromiumcodereview.appspot.com/11412239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171072 0039d316-1c4b-4281-b951-d872f2087c98
-
skyostil@chromium.org authored
During the move from WebKit::IntSize to gfx::Vector2d in the compositor code an IntSize::isEmpty() got accidentally replaced with Vector2d::IsZero() in LayerTreeHostImpl::scrollBy(). This caused cases where we'd change the position of a layer during scrolling but didn't schedule a commit or a redraw. This happened for instance when diagonally scrolling a layer against its edge. This patch fixes the issue by always requesting a commit/redraw if any layer was moved while applying the scroll delta. TEST=LayerTreeHostImplTest.scrollByReturnsCorrectValue Review URL: https://chromiumcodereview.appspot.com/11348381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171069 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremya@chromium.org authored
TBR=benwells@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11434117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171066 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://settingsbauerb@chromium.org authored
It's only accessible at chrome://settings/managedUser and requires the --enable-managed-users switch. Also, not all of the settings are hooked up yet. TBR=ben@chromium.org,cpu@chromium.org BUG=163884 Review URL: https://chromiumcodereview.appspot.com/11414294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171065 0039d316-1c4b-4281-b951-d872f2087c98
-
pshenoy@chromium.org authored
1. src/chrome/browser/nacl_host 2. src/chrome/browser/automation 3. src/chrome/browser/autofill 4. src/chrome/browser/autocomplete 5. src/chrome/browser/captive_portal 6. src/chrome/browser/geolocation Review URL: https://chromiumcodereview.appspot.com/11415289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171064 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
to catch memory problems early, easily, and cleanly. This is disabled by default. Because of gyp limitations, the flag is to force-disable the feature, but there is no flag to force-enable it. BUG=30715 TEST=none Review URL: https://codereview.chromium.org/11266019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171063 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
also, differentiate cancel from success in AutofillDialogController. BUG=157270 Review URL: https://codereview.chromium.org/11299323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171062 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@chromium.org authored
The scoped_ptr<LifeCycleObject> was unncessary and confusing. The LifeCycleWatcher safely owns its LifeCycleObject and deletes it. The scoped_ptr made things a bit confusing even, since the only reason we weren't getting a double delete was because the scoped_ptr had an (ever so) slightly narrower scope than watcher. Making the LifeCycleObject mostly private should encourage future callers not to add scary aliases. R=willchan@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11416166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171058 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=129187 TEST=NONE Review URL: https://chromiumcodereview.appspot.com/11348344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171057 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This bug was caused by returning a string as an index from list_selection_model.js in an Event argument of a change event. In the list.js, such index stored as string was incremented, which caused concatenation instead of incrementation. This patch converts these values to number to avoid such problems. TEST=Enable ChromeVox, enter Files.app (CTRL-M), navigate among files. Correct item number should be spoken, eg. 2/x, 3/x. BUG=164061 Review URL: https://chromiumcodereview.appspot.com/11421214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171056 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
> > * Adds support for Apache libraries to be able to use multipart in Java > HTTP clients. > * Orders all Android-specific DEPS > * Adds missing third_party/findbugs to .gitignore > > BUG=159203 > > Review URL: https://codereview.chromium.org/11421224 TBR=nyquist@chromium.org Review URL: https://codereview.chromium.org/11415295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171055 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
json minify was landed in r124878. Chromium stopped using it in r132692, but not all files were removed. Removing it completely. Review URL: https://codereview.chromium.org/11416227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171053 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
We need to launch DevTools before WebUI for login screen is up and running so we can attach remotely do run automation tasks there. BUG=162730 TEST=make sure you can connect to devtools when ChromeOS is camping on the login/OOBE screen Review URL: https://chromiumcodereview.appspot.com/11412281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171052 0039d316-1c4b-4281-b951-d872f2087c98
-
shawnsingh@google.com authored
As calculateDrawTransforms has evolved, the math has become substantially more overhead. This patch refactors the matrix math to reduce the number of matrix copies and matrix multiplications. Changes that would drastically affect readability or robustness are avoided. With this patch, cc_perftests improves by approximately 6-8%. SevenTabSwitcher: 2030 runs/s --> 2220 runs/s (9.3%) tenTabSwitcher: 757 runs/s --> 807 runs/s (6.6%) BUG=163769 Review URL: https://codereview.chromium.org/11280271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171051 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
Use "Remove all" for the recently closed tabs list, and "Remove" for all other lists. BUG=163944 Review URL: https://chromiumcodereview.appspot.com/11416322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171050 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=145734 Review URL: https://chromiumcodereview.appspot.com/11299307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171049 0039d316-1c4b-4281-b951-d872f2087c98
-
mazda@chromium.org authored
PhantomWindowController shows two styles of window, STYLE_SHADOW and STYLE_DRAGGING. Although STYLE_SHADOW is specific to workspace, STYLE_DRAGGING is not specific to workspace. This CL separates this feature into two classes so that the STYLE_DRAGGING part can be used from non-workspace specific code - Extract the STYLE_DRAGGING part from PhantomWindowController into DragWindowController. - Move the ownership of the copied window layer from WorkspaceWindowResizer to DragWindowController. BUG=156519 Review URL: https://chromiumcodereview.appspot.com/11280283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171048 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
BUG= Review URL: https://chromiumcodereview.appspot.com/11316335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171047 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
Add enough recycling logic to ResourcePool to eliminate unnecessary command buffer flushes. BUG=163430 TEST=manual Review URL: https://chromiumcodereview.appspot.com/11418299 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171046 0039d316-1c4b-4281-b951-d872f2087c98
-
nyquist@chromium.org authored
* Adds support for Apache libraries to be able to use multipart in Java HTTP clients. * Orders all Android-specific DEPS * Adds missing third_party/findbugs to .gitignore BUG=159203 Review URL: https://codereview.chromium.org/11421224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171045 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
Make wallpaper picker manifest and thumbnails available when offline. This CL did the following: 1. Save/update manifest in chrome.storage.local when user successfully requested latest manifest from server. If user failed to get manifest from server(offline or server error), fallback to the manifest saved in chrome.storage.local last time. 2. Lazily saves all requested thumbnails to thumbnails directory. And load from that directory when user open wallpaper picker next time. Note that thumbnails are shared across user session. So after one user saved thumbnails, all other users will directly use the thumbnails that saved in thumbnail directory. BUG=158668 Review URL: https://chromiumcodereview.appspot.com/11348215 TBR=bshe@chromium.org Review URL: https://codereview.chromium.org/11280300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171043 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
cros: Fix a comparison of a bool with -1 BUG=none TBR=bshe Review URL: https://codereview.chromium.org/11419315 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/11434113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171042 0039d316-1c4b-4281-b951-d872f2087c98
-