- 07 Aug, 2018 40 commits
- 
- 
Harald Alvestrand authoredThis histogram name was different in webrtc source than what was entered in histograms.xml Bug: webrtc:9532 Change-Id: Id0a637c6a70969fc1056147b2bdaee2e3c04f29d Reviewed-on: https://chromium-review.googlesource.com/1162335Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#581085} 
- 
nacl-chromium-autoroll authoredhttps://chromium.googlesource.com/native_client/src/native_client.git/+log/64cb8d9d67fb..821833667ccc git log 64cb8d9d67fb..821833667ccc --date=short --no-merges --format='%ad %ae %s' 2018-08-06 thomasanderson@chromium.org Fix arm build with -std=c11 Created with: gclient setdep -r src/native_client@821833667ccc The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:427584 TBR=mseaborn@chromium.org Change-Id: If0b1ba66262b33ab569850d988b0631c14c39e20 Reviewed-on: https://chromium-review.googlesource.com/1164285Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581084} 
- 
Tommy Steimel authoredThis CL adds a ModernMediaControls check before checking whether an event is over the internal overlay play button, since the internal button only exists on modern controls. This fixes a crash in the legacy controls which dereferenced this null internal button. Bug: 870490 Change-Id: Ic0990ffd1f4eb5c1f576c38191eb27848eedd9c9 Reviewed-on: https://chromium-review.googlesource.com/1163284Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581083} 
- 
Ned Nguyen authoredNOTRY=true # covered by PRESUBMIT tests Bug: 868675 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ia5fb548ba314edda307b5b7d7d7d27ff9e24fb30 Reviewed-on: https://chromium-review.googlesource.com/1164565Reviewed-by: David Tu <dtu@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#581082} 
- 
Michael Giuffrida authoredAdds a new "assistantStatus" property to chromeosInfoPrivate.get that returns "[un]supported" depending on whether the device supports a version of Google Assistant. Bug: 856719 Test: browser_tests, manually with eve and another device Change-Id: I947c7849bbb1f134dde7515e6ea40504d470d69c Reviewed-on: https://chromium-review.googlesource.com/1157384 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581081} 
- 
Devlin Cronin authoredUpdate the permissions.md doc to include information about the runtime host permissions feature, including the changes being introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1153986. Bug: None Change-Id: I1e0a6a8b41fdd007808b1564297750958ae2d22a Reviewed-on: https://chromium-review.googlesource.com/1155252 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#581080} 
- 
Daniel Rubery authoredRenderFrameHosts can be deleted when a navigation commits, and this does not call FrameDeleted(). This can trigger the same race condition as https://chromium-review.googlesource.com/1146997. If GetThreatDomDetails completes, then the navigation commits (and the old RenderFrameHosts is deleted), then OnReceivedThreatDOMDetails runs, we will crash. Bug: 817724, 860445 Change-Id: Iae81a1c3dc724113d30e17652b75a88bcd7f4de5 Reviewed-on: https://chromium-review.googlesource.com/1162422 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#581079} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/97d0970c25e9..fdf05f4ff4e9 git log 97d0970c25e9..fdf05f4ff4e9 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 bsalomon@google.com Revert "Move GrGeometryProcessor's textures out of classes and into" 2018-08-06 caryclark@skia.org fix pathops stitching bug 2018-08-06 herb@google.com Remove posText system from GrTextContext 2018-08-06 bsalomon@google.com Make result of GrOp::combineIfPossible be an enum. 2018-08-06 bsalomon@google.com Remove multitexturing support from GrTextureOp. 2018-08-06 halcanary@google.com Revert "Test: New GMs should be nicely named" 2018-08-06 jvanverth@google.com Fix missing offsets in simple-polygon-offset-v 2018-08-06 timliang@google.com changed SkASSERT -> SkAssertResult in GrMtlPipelineStateBuilder.mm 2018-08-06 halcanary@google.com Test: New GMs should be nicely named 2018-08-06 kjlubick@google.com [PathKit] Add more Path2D functionality and move some methods to be members 2018-08-06 fmalita@chromium.org [skottie] ResourceManager tweaks 2018-08-06 herb@google.com Remove fPath and fTooLargeForAtlas from GrGlyph 2018-08-06 herb@google.com Move path fallback logic into drawer 2018-08-06 brianosman@google.com Fix imagefiltersbase GM in ColorSpaceXformCanvas configs 2018-08-06 timliang@google.com implemented the pipeline state builder for metal gpu backend 2018-08-06 borenet@google.com [infra] Update Go to 1.10.3 Created with: gclient setdep -r src/third_party/skia@fdf05f4ff4e9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/112244393 TBR=djsollen@chromium.org Change-Id: I1d37367f62fb8fd8b663a0b122411583e2e30917 Reviewed-on: https://chromium-review.googlesource.com/1164286Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581078} 
- 
David Black authoredThis CL implements the entrance animation (when Assistant UI is shown) for the following elements: - Molecule icon. - Greeting label. - Caption bar. - Dialog plate. See bug for spec/demo. Bug: b:112239362 Change-Id: Iae75ecaec0c9f0ffc794509434b18a83f7d19e5b Reviewed-on: https://chromium-review.googlesource.com/1163287 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581077} 
- 
Sergey Ulanov authored1. Added --system-log-file argument to the runner script which saves Fuchsia debug logs in a file 2. Enabled that flag in run-swarmed.py. 3. Removed the LogReader. Bug: 869753 Change-Id: I4ef5c375e06937533841bab2696d90ed49887a0f Reviewed-on: https://chromium-review.googlesource.com/1162899 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581076} 
- 
David Black authoredCurrently always hidden, but a follow up CL will hide/show this view appropriately based on the user's opt in state. Another follow up CL will also implement click handling to launch setup. See bug for screenshot. Bug: b:112236931 Change-Id: I6db726e8947e9b97772f06bda7e4c55678ab3859 Reviewed-on: https://chromium-review.googlesource.com/1163283 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581075} 
- 
Ben Pastene authoredAnd disable http/tests/media/video-load-metadata-decode-error.html, which appears to have a dependency on GPUs. Bug: 854874, 871445 Change-Id: I254ce21953ac428351203d6479e1936347ce5b4c Reviewed-on: https://chromium-review.googlesource.com/1162963 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581074} 
- 
Johannes Henkel authoredBug: 851762 Change-Id: I0208bb9a528c0e40cdb2b962461ac90225cb31b1 Reviewed-on: https://chromium-review.googlesource.com/1164062 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#581073} 
- 
bsheedy authoredMakes the following changes to the VR browser tests to bring them more in line with the Java implementation: * Renames "webvr_*browser_test.cc" to "webxr_vr_*browser_test.cc" * Adds some missing functions such as "PollJavaScriptBooleanOrFail" * Adds failure messages to all asserts * Standardizes function ordering * Spelling/punctuation fixes * Updates the Markdown documentation * Renames the "vr_browser_tests" test suite to "xr_browser_tests" Bug: 868143 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4ec82eaed3101667cc7574fd0df81aa5d1ce155b Reviewed-on: https://chromium-review.googlesource.com/1157697 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581072} 
- 
Daniele Castagna authoredCurrently, to enable in-fences, it's possible to specificy CLI flag "use-gpu-fences-for-overlay-planes". The flag sets a gpu preference that propagates to gpu capabilities |use_gpu_fences_for_overlay_planes|. This patch removes the CLI flag and the gpu preference, and it instead sets |use_gpu_fences_for_overlay_planes| asking the output surface. If the output surface supports in fences, they'll be used by the direct renderer. output surfaces will claim to supports per plane gpu fences when the underlying system supports KMS atomic. Bug: 828393 Test: 'start ui' on a chromebook with kernel version >= 4.4 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1359aad2680aac840ba43b436df6d00347b5fe0b Reviewed-on: https://chromium-review.googlesource.com/1160773Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#581071} 
- 
src-internal-chromium-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca942e227a7a..3cd5de0de3a1 Created with: gclient setdep -r src-internal@3cd5de0de3a1 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852038 TBR=mmoss@chromium.org Change-Id: I9d7ee59a61de8382b0a2537f675b1cc4136df3a6 Reviewed-on: https://chromium-review.googlesource.com/1164283Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581070} 
- 
Takuto Ikuta authoredThis is for slow surface_sync_content_browsertests step like belows. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/54921 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/54740 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/54965 Overhead of the test is small, 6 seconds overhead vs 35 mins runtime. https://chromium-swarm.appspot.com/task?id=3f2773404bdad410&refresh=10&show_raw=1 So overhead increase is negligible. Bug: 868114 Change-Id: Iab6b396fcdf5a25ba50f299a0fa5e294ccea32ae Reviewed-on: https://chromium-review.googlesource.com/1163642 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581069} 
- 
Kenneth Russell authoredMost of the various Telemetry-based GPU tests which test context loss do so by creating a new tab, navigating it to chrome://gpucrash, and switching back to the original tab. This tab manipulation is introducing too many variables, and unreliability, into these tests. Instead, allow the already-privileged gpu_benchmarking_extension to crash the GPU process. Bug: 858907 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I174694c359d253e5b62f50f8e48cda0129731f1e Reviewed-on: https://chromium-review.googlesource.com/1161558Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581068} 
- 
Will Harris authoredAlso, add this mitigation to the browser process. BUG=870463 Change-Id: I1e749a4ede0b41cca69f60262fd878c57ed35564 Reviewed-on: https://chromium-review.googlesource.com/1162581Reviewed-by: Penny MacNeil <pennymac@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#581067} 
- 
Olli Etuaho authoredThe extension flag needs to be checked when multiview functions are called on the GPU command buffer service side. BUG=870240 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I372593c510154ab96fc7e2415c534a1fc46286e2 Reviewed-on: https://chromium-review.googlesource.com/1161901 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#581066} 
- 
Charlie Harrison authoredSee bug for details. Bug: 870824 Change-Id: I6fc9e029e6e62ab7cb6e196e7b7d1afe270f819d Reviewed-on: https://chromium-review.googlesource.com/1162642Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#581065} 
- 
Reid Kleckner authoredThis reverts commit 9a40eecd. Reason for revert: Test fails in official builds. Original change's description: > [NTP] Update NTP to respect the HideWebStoreIcon policy > > Now, changing the HideWebStoreIcon policy will affect the > prepopulated_list when a new profile opens or reopen the browser. The > policy doesn't affect current profile on the NTP. This is because the > browser will cache the prepopulated list so that it can fetch the tiles > quickly. > > Bug: 855603 > Change-Id: I99ac05040fc44f64ac61151218dcbcc612465e72 > Reviewed-on: https://chromium-review.googlesource.com/1137432 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580699} TBR=sky@chromium.org,ramyan@chromium.org,sweilun@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855603, 871166 Change-Id: If88116adf0fdd613ec5c2ede8abeb3c8b6b6207c Reviewed-on: https://chromium-review.googlesource.com/1164205Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#581064} 
- 
Sky Malice authoredAlso fixed lint and presubmit errors. Change-Id: I559d8eed024d84b6fdc0bcc0e7d6019dadb4b5f2 Reviewed-on: https://chromium-review.googlesource.com/1162275Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Yafei Duan <romax@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#581063} 
- 
Trent Apted authoredSince https://crbug.com/732993 was fixed, gn now supports a `friend` property which the ui/views/ test targets can use. This means "internal" headers only used (also) in tests no longer need to be repeated in test targets inside views/BUILD.gn. So, declare other targets in views/BUILD.gn as friends, remove those repeated headers, and mark some things internal. Start with ui/views/cocoa. Currently 3 headers are used in mac browser code (for OS-specific fullscreen/native frame, and touchbar things). Bug: 871123 Change-Id: I5e5a260dd200f1bffc4f6fb8456d6e854fe19c52 Reviewed-on: https://chromium-review.googlesource.com/1163351 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581062} 
- 
Tom Anderson authoredBUG=853841 R=pkasting Change-Id: Iac25d17618487e03aac7bfa6f54e98848ce47c24 Reviewed-on: https://chromium-review.googlesource.com/1159385 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581061} 
- 
Reilly Grant authoredThis change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader. Since this request does not make use of the response a new method has been added to SimpleURLLoader, DownloadToNull. This download mode still reads the response body from the network but does not save it anywhere. This is useful for requests which upload data and would otherwise have to specify an arbitrary |max_body_size|. A maximum may still be set if the caller wants to limit the amount of data transferred over the network. Bug: 773295 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f Reviewed-on: https://chromium-review.googlesource.com/1161551 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#581060} 
- 
Lukasz Anforowicz authoredThis CL removes not_site_per_process_browser_tests from the bots, because: - Site Isolation has shipped to the stable channel in Chrome 67. Currently //chrome layer defaults to site-per-process mode (see r552589 and testing/variations/fieldtrial_testing_config.json). - After recent changes (see https://crbug.com/671734 and https://crbug.com/824962) no known tests are skipped when run in site-per-process mode. Bug: 870761 Change-Id: I158e8980846077c2d1ef03bf03f3b80c8191ca81 Reviewed-on: https://chromium-review.googlesource.com/1164172Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#581059} 
- 
Clark DuVall authoredThis is a reland of c9cbab07 request_completed_ was being set unnecessarily after RemoveRequest was called. Original change's description: > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service > > The error event was not being sent when the client was reset. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I951422061022d50644d8453900af14be27bb9eaf > Reviewed-on: https://chromium-review.googlesource.com/1150403 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580911} TBR=jam@chromium.org Bug: 721414 Change-Id: I48769a4b86d2a18acbe5fbcedb9de3ed478e4c54 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1164209Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581058} 
- 
Yafei Duan authoredAdding flag for live page sharing of Offline Pages. Bug: 870895 Change-Id: Id34ae2ebcc1c83e736505f69a9d78055d3aec94e Reviewed-on: https://chromium-review.googlesource.com/1162824 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#581057} 
- 
Takuto Ikuta authoredThis does not allow arbitrary files are included in isolated input from fontconfig_caches directory. Bug: 870622 Change-Id: I69bc8993800f263d7e3d7679ed85f9c79a380a0b Reviewed-on: https://chromium-review.googlesource.com/1163596Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#581056} 
- 
James Cook authoredChrome OS supports the concept of a "root window for new windows", which allows new windows to be automatically placed on the correct display. This knowledge lives in ash, currently inside the browser process. Remote processes that use views::Widget (e.g. the shortcut viewer app) sometimes need to know what window they are going to open on, for example to do initial bounds computations. Change Screen to provide set and get for the display for new windows. Use mojo to send the information to other processes via ScreenProvider (on the ash side) and ScreenMus (on the remote side). Send the display id as part of display updates so that ScreenMus gets it on startup, and also so updates are atomic with other display changes. Once this lands we'll be able to port browser windows to use this mechanism and delete the ash::ShellState / chrome ShellStateClient code I built as a one-off for browser windows under mash. Bug: 867559, 764009, 826569 Test: added unit tests Change-Id: I6b5beb2610243f30072c3d73180b3ce21a310ca6 Reviewed-on: https://chromium-review.googlesource.com/1162980Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#581055} 
- 
Eric Willigers authoredResizeObserver shipped to stable in M64 https://chromium-review.googlesource.com/754562 https://www.chromestatus.com/features/5705346022637568 BUG=612962 Change-Id: I8b323722c3bf8caa028ec5d14964b43dc13d1faa Reviewed-on: https://chromium-review.googlesource.com/1163060Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Yoav Weiss <yoav@yoav.ws> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581054} 
- 
Kenichi Ishibashi authoredBug: N/A Change-Id: I81c242020af0121c6876704839f1a89a751d5b97 Reviewed-on: https://chromium-review.googlesource.com/1163233Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581053} 
- 
Ramya Nagarajan authoredRecords metrics for availability (or unavailability) of background and shortcuts customization. Also records interactions with aspects of these features. See go/ntp-metrics-doc. Bug: 855935 Change-Id: I24b376c0752adb4077e9f48dd10ab23ff6253d68 Reviewed-on: https://chromium-review.googlesource.com/1158800Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581052} 
- 
Ned Nguyen authoredBug: 870905 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ic558eb8ce497bda92a8956b498c999ca06bc1a05 Reviewed-on: https://chromium-review.googlesource.com/1163126Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: David Tu <dtu@chromium.org> Commit-Queue: David Tu <dtu@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#581051} 
- 
Robert Liao authoredBUG= Change-Id: I91c108d80a9418b9447ae394ceb9a56e4c9c48a9 Reviewed-on: https://chromium-review.googlesource.com/1164395 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581050} 
- 
Chris Palmer authoredBug: 680657 Change-Id: I2d879f5b28c392a083fbd867a3eb05568d19dc67 Reviewed-on: https://chromium-review.googlesource.com/1164252Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#581049} 
- 
Xiaoqian Dai authoredThe new selector item's window and its |item_widget_| should be placed below the dragged window. Bug: 871580 Change-Id: I48d5705c687b4b75518d5ec47c71b8f746f22587 Reviewed-on: https://chromium-review.googlesource.com/1164525Reviewed-by: Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581048} 
- 
Sheng-Hao Tsao authoredThis CL does 2 things: 1. Hide legacy camera app icon 2. Launch legacy camera app (com.android.camera2) when com.google.android.GoogleCameraArc is not available. Sometimes when devices are upgraded from version with Camera2 installed, GCA still has com.android.camera2 as the package name. That's why this CL is needed. Bug: b:112121210 Test: Tested on nautilus that after this CL, the legacy camera app icon Change-Id: I16e4d29d4cb538bd2ad6607456bcf4667be1f188 Reviewed-on: https://chromium-review.googlesource.com/1127899Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#581047} 
- 
Ted Choc authoredTurns out this line matters: https://chromium-review.googlesource.com/c/chromium/src/+/1148680/16/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java#b226 BUG=871131 Change-Id: I3b37cb9b97f58b7f9bcb14b29107c82d79721b44 Reviewed-on: https://chromium-review.googlesource.com/1164382Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#581046} 
 
-