- 16 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b9be10d305f8..497d3d907b45 git log b9be10d305f8..497d3d907b45 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@497d3d907b45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I01fd79416afea2e86635f6c6929168c8423b8f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805728Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696931}
-
Dmitry Gozman authored
This call does supposedly cancel client navigation, while in reality it does not, since there is no client navigation happening just yet. See fragment-change-does-not-cancel-pending-navigation.html which exhibits this behavior. Bug: none Change-Id: If474156d4e2ebddc8c2129bd2173aa1713345ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805248 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#696930}
-
Tibor Goldschwendt authored
This deduplicates code and prepares for some more build system simplifications. + Use this template for the public bundles. Bug: 950056 Change-Id: Ic3a6211efe5190e590793255b48d0ea4f636046f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803912 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#696929}
-
Mei Liang authored
This CL updates TabSelectionEditor to use the same color palette as Dark mode. Change-Id: I005f9c23f684e96f22a3075db231d2c6e2cd2d17 Bug: 996943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772120 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#696928}
-
Jesse McKenna authored
On Windows systems with > 64 logical processors, the processor count returned by base::SysInfo::NumberOfProcessors() is below the actual count. This is because Windows splits logical processors on systems with more than 64 into Processor Groups, and an accurate count of system processors requires using newer Windows API call ::GetActiveProcessorCount(ALL_GROUPS), which counts processors across all groups. For most code in Chrome, using more than one processor group's processors is likely overkill (and requires additional code to assign each thread to a processor group), so this change does not modify the existing base::SysInfo::NumberOfProcessors() - it will still reflect the number of processors in the calling process's group. Instead, this change modifies the test launcher itself, as that is the only currently known use case for running on more than one processor group's processors. On the 72-core P920 (which has two groups containing 36 CPUs each), when running base_unittests.exe, this change has the following effect: Before: C:\src\chromium\src>out\Default\base_unittests.exe [...] Using 36 parallel jobs. After: C:\src\chromium\src>out\Default\base_unittests.exe [...] Using 72 parallel jobs. Bug: 983014 Change-Id: Ie7a828b4fba9f2e8e7f220738af58d5de8e17816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704388Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#696927}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d9cc8c08dce8..f5dec1c6af02 git log d9cc8c08dce8..f5dec1c6af02 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 danilchap@webrtc.org Implement Dependency Descriptor reader Created with: gclient setdep -r src/third_party/webrtc@f5dec1c6af02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I4f1b0ab79831c48ee4a3b6f8fb44ed85ef6dc223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696926}
-
Samuel Huang authored
DevUI DFM is on for bundle (AAB) builds only. For APK builds, which does not support DFM, DevUI pages should be available by default. However, the |dfmify_dev_ui| flag is common for bundle and APK builds. So when the flag is on, for both bundle and APK builds: * dev_ui_resources.pak is split from resources.pak, and * Code to {check, perform} DevUI DFM {install, loading} are active. As a result, DevUI pages break for APK builds (used by Android K). Currently this only affects chrome://bluetooth-internals since that's the only page moved into the DevUI DFM. The fix: Include DevUI DFM Java classes and dev_ui_resources.pak into the APK file. The Java classes tells DFM infra stub that the DevUI module is installed, and the PAK provides the resources needed. Bug: 1004263 Change-Id: I3bec6682799c49e84cf0a700c1b61a33a3335005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807069Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#696925}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/acad1a99eaae..556890be42d8 $ git log acad1a99e..556890be4 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 rsbultje AVX2 for chroma 4:2:0 film grain reconstruction 2019-09-05 rsbultje Remove luma width check in fguv_32x32xn 2019-09-05 rsbultje Y grain AVX2 implementations 2019-09-01 rsbultje Add film grain checkasm tests 2019-09-01 rsbultje Split out film grain block functions into a DSPContext 2019-09-06 jamrial obu: fix deriving render_width and render_height from reference frames Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Change-Id: I8b5fbe2237fc9f8d3bdc30dcc063cda04ec670b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806620Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696924}
-
Robert Ogden authored
Undos change in https://chromium-review.googlesource.com/c/chromium/src/+/1748081 which was used for debugging. Bug: 969163 Change-Id: I2008c4f467947f19143bf070b9263f03cc215c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807334Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#696923}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ed3e8e779e4..c25802db30fa git log 6ed3e8e779e4..c25802db30fa --date=short --no-merges --format='%ad %ae %s' 2019-09-16 jvanverth@google.com Add ETC2 support to Metal backend. 2019-09-16 brianosman@google.com Particle effect scripting update 2019-09-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-16 brianosman@google.com Fix precompiling shaders on GLES / Android 2019-09-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c25802db30fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I9a6d38e7c909354a79333c129c8bc1cd21655f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696922}
-
Evan Stade authored
Replace NOTIFICATION_PROFILE_CREATED with UserSessionStateObserver Bug: 268984 Change-Id: If7d345d4261fbabbafefa429c5d217acfe77b714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804069Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#696921}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8c78202c36a7..d8359680722c git log 8c78202c36a7..d8359680722c --date=short --no-merges --format='%ad %ae %s' 2019-09-16 rmhasan@google.com [Telemetry] Re-add --skip-typ-expectations-tags-validation Created with: gclient setdep -r src/third_party/catapult@d8359680722c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:999335 Change-Id: Ib8bb55406e3846b5055319a6f0cc1363c954ffe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696920}
-
Tom Anderson authored
This CL avoids using "canvas->drawImage()" in PaintCanvasVideoRenderer::Paint(). Most of the time (when the video isn't rotated etc), all that's necessary is to convert YUV to RGB pixels. But the drawImage() call will first create a temporary SkBitmap, copy the frame into that, and then redundantly memcpy() the bitmap to the resulting canvas. The memcpy() is very expensive and results in a lot of dropped frames when playing back 8K video. A single 8K frame is 145MiB, so at 60fps we'd be copying 8.24GiB/s, which uses up most of the RAM bandwidth. With this change, I can playback 8K video at 60fps with only 49% dropped frames when I was getting 76% dropped before. The remaining bottleneck is in ConvertVideoFrameToRGBPixels(): if I remove that function, I can playback 8K video at 75fps with zero dropped frames (but with no video :P), so the current plan is to try to parallelize that function after landing this CL. BUG=1001207 Change-Id: I0f69988e224d28cd06973beedf00d461ebd5e67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788320 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696919}
-
Chris Lu authored
This change adds an overflow badge. Since it is the first non-infobar badge, BadgeTappableItem is created to configure it. BadgeLocalDispatcher will send a signal to the LocationBarCoordinator in response to tapping the badge. Ultimately LocationBarCoordinator will relay that signal to BrowserViewController with badge model information to present the overflow popup menu. Since badges should not be shown both in the BadgeViewController and the popup menu, this will allow the BadgeViewController to dynamically decide what badges it will show and then pass the rest to the popup menu. While that could be possible through matching assumptions in the separate popupmenu and badge mediator, it is possible that the BadgeViewController will decide on how many badges it shows based on available space. Bug: 976901 Change-Id: If3d977ae49949c0d65413bb61d6028e5febb2605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789852 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#696918}
-
Sam Maier authored
Removed some -dontnotes as well, as R8 doesn't even process dontnote. Bug: 887942 Change-Id: Iecc56bf704495386ffb748f538ec0ee1fce4aa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801035 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#696917}
-
Shakti Sahu authored
This CL adds the detailed layout of toolbar for ephemeral tab, which includes the title, caption, close button, and favicon. Bug: 998826 Change-Id: I8103a12e010a1d6b43ef5cb5e0a8bc728255bd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775223 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#696916}
-
Xi Han authored
Test is flaky. TBR=beccahughes@chromium.org Bug: 1000400 Change-Id: Icaefdb8956223fa8a13db56560f3d00b7d361747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807569Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#696915}
-
Dominic Mazzoni authored
Currently on platforms with native accessibility (Windows, Mac, Linux, Android) we have some stats on accessibility being enabled, but this overcounts users who actually need accessibility, because there are other tools that use accessibility APIs (automation, SSO, form fillers, touch screen tools, etc.). Let's keep track of some actions that are more likely to be associated with a user actively using assistive technology, rather than some software passively monitoring what's going on. I picked four actions that might help us distinguish between different usage patterns: DoDefault (click), Focus, ScrollToMakeVisible, and HitTest. Users with assistive technology would call most of these APIs a lot. On the other hand, form-fillers would call them rarely, and touch screen tools might only call HitTest a lot and the others rarely. Bug: None Change-Id: I763ada82cebce6cdd15e322efdac2a530a5a64fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782518Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#696914}
-
Yue Zhang authored
Bug: 1004170, 995678 Change-Id: I53c9941694272dc3da944141f51823bf58205f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807553Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696913}
-
jonross authored
The Viz project has shipped on all platforms aside from Chrome OS. This makes --enable-features=VizDisplayCompositor redundant. This change removes that flag from all non-Chrome OS test configs to clean up. TEST=Basically anything with skia_renderer in its name. Bug: 844469 Change-Id: If0dfe28100ed98eca956abec4e44e81d8e960d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802831Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#696912}
-
Eric Roman authored
This seems to have the same meaning, however use of "return" in assumenosideffects is not working for some versions of proguard. Change-Id: Ie6dde7612d25c7ee5fd2d2fd42dfe74444188c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804064Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#696911}
-
Kyle Milka authored
Bug: 1004189 Change-Id: I451d02611491877cac78c7bf598e0b95fb9588b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805253 Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#696910}
-
Toni Barzic authored
Previously, the background shiled transform would get applied immediately on the app list view state change, causing a small vertical background shield jump (perceived as the app list view jump). BUG=1004063 Change-Id: Iec874a2c0939cf415e18839d9f14b35aafe1c482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804780 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#696909}
-
Xianzhu Wang authored
Previously, - in layer tree mode, it was set to the bounds of the masked/mask layer; - in layer list mode - in Blink, it was not set - in tests, we set it in test code sometimes to the bounds of the masked/mask layer. Not setting it resulted infinite mask_uv_rect in DrawQuad. Though we didn't observe any problem, it looked incorrect and might have performance impact. Now remove the field and let RenderSurfaceImpl::AppendQuads() use the mask layer's bounds instead. This doesn't change behavior of layer tree mode and tests in layer list mode, and avoid infinite mask_uv_mask for Blink. About test: existing tests ensure the correctness. Bug: 1003414 Change-Id: Ic2959b7ad3632ac8c59118661be6f23aa9b5024c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805692Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696908}
-
Etienne Pierre-doray authored
This CL uses the lower bit of worker_count to indicate that a JobTaskSource is canceled. It implements the logic to cancel the task source and force workers to yield. Bug: 839091 Change-Id: Ia621cd174d57dabdfa1df74e0b48a7afb20e8b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772239 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#696907}
-
Daniel Nicoara authored
The Webview WebContents and the aura::Window it attaches to are not created in the same place and there is a disconnect between how the EXO window is created and how the Webview is created. Webview creation event results in a request to create an EXO window. Thus WebviewRpcInstance doesn't have a window to display in until the client creates an EXO window with the appropriate ID. There needs to be a way to listen for window events to discover the EXO window hosting the Webview. WebviewWindowManager listens for new aura::Windows to be created and registers as an observer on them to find windows with the exo::kClientSurfaceIdKey property. The ID is then used to find the Webview that will be attached to the window. BUG=b/132811925 TEST=Compiled Change-Id: I053e2b792b311f0c95e791ef5c70a9e18b24f5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803957 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#696906}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/51ac9ed8487b..b9be10d305f8 git log 51ac9ed8487b..b9be10d305f8 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 tcwang@google.com afdo: Use chell to generate AFDO profiles on branch builders. Created with: gclient setdep -r src/third_party/chromite@b9be10d305f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2314549769d82be722dce7984e5ec79113fbb171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696905}
-
Wez authored
Bug: 961457 Change-Id: I1174440bf92b975fd165067f4ff0bee21281148c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476971Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#696904}
-
Mikel Astiz authored
Nothing seems to guarantee, strictly speaking, that the split between ApplyUpdates() vs PassiveApplyUpdates() maps to initial sync having been done. In practice, that's almost certainly the case, we some flaky tests do suggest the assertion gets violated. Circumstances that could contribute to this failure include polling sync cycles and failing configuration cycles, which would all lead to a non-configuration cycle downloading the initial data for a sync datatype, and that being passed via ApplyUpdates(). Since the DCHECK is not guaranteed to hold, let's just relax it. TBR=treib@chromium.org Bug: 1002549 Change-Id: I901886cb34b68266a024c259328be204a6f88fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807294Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#696903}
-
Yue Zhang authored
Bug: 1003127 Change-Id: I85e5903d336bc909a81ef6623856e2b625a4c4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801395Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696902}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74a7664fb54e..765f9f266eec git log 74a7664fb54e..765f9f266eec --date=short --no-merges --format='%ad %ae %s' 2019-09-16 chiur@google.com Merge "Update protobuf for GPU events" Created with: gclient setdep -r src/third_party/perfetto@765f9f266eec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic4f817e54c74552719f81b92cdba9dec67e0eca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807253Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696901}
-
sczs authored
Since some VC's presented by SettingsNavigationController might not be a SettingsRootTableViewController (e.g. GFBFeedbackViewController) this CL sets currentPresentedSettingsViewController to nil if this case is true. Bug: 980037 Change-Id: I5771c27c66820769756ba64b05354b13592e43b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807024 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#696900}
-
Lucas Furukawa Gadani authored
Change-Id: I65796ae20779fd4e32b174e75263246962d9366a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798884Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696899}
-
Tim van der Lippe authored
We were force-lowercasing CSS variables, which breaks if you type "var(" and then inspect the autocompletion of DevTools where it would autocomplete to "--camelcased" instead of "--camelCased". Bug: 911303 Change-Id: I48b74953fef34e545f020d186ba279023667ce68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781427Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Cr-Commit-Position: refs/heads/master@{#696898}
-
Toby Huang authored
Add a browser test that ensures the kCompleted UMA metric is being recorded correctly after executing javascript commands simulating supervision being enabled. Bug: 982543 Change-Id: I30caa56c67103801bbbfc453c176dd13d1d87b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804494Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#696897}
-
Xing Liu authored
This CL adds the logic to close notification after clicks. This can be the default behavior built in to the system. If any notification types want custom behavior, we can tweak the logic for them later. Bug: 987830 Change-Id: Ib7c0d722dabf5757dda718d40b408fea0113d73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802519Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696896}
-
Roger McFarlane authored
This CL updates prefs::kSyncDemographicsBirthYearOffset to be syncable. This change prevents a user who resets their profile data without changing their UMA client id from generating a new random offset, which could narrow down the true birth year value. Bug: 978849 Change-Id: I34d347dfdf5a35381443baa327883c72fb0aaed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803763 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#696895}
-
Alex Clarke authored
We wish to prioritize loading and compositing tasks until first contentful paint. This changes the ordering of LocalFrameView::UpdatePluginsTimerFired which breaks (or makes flaky) some web_tests, typically the following console log goes missing: CONSOLE MESSAGE: Blink Test Plugin: initializing This patch fixes this by ensuring LocalFrameView::UpdatePluginsTimerFired runs in FIFO order with loading tasks. The spec doesn't seem to specify which task source should be used so I believe we're free to make this change. Bug: 971191 Change-Id: Ib62fafd7cf1f86835a7c5b749fa0639f884e7089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795790Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#696894}
-
Abhijeet Kandalkar authored
This CL converts RecorderPtr and uses new Mojo types. Bug: 955171, 978694 Change-Id: I78b4994e0874d9f2235cc3a62192cdadfd1dd5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789204Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#696893}
-
Yulun Wu authored
Bug: 1000169 Change-Id: Id3e32e8587a1449f08c7de73c394eb4cf7c2d1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783801 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#696892}
-