- 29 Oct, 2019 27 commits
-
-
Livvie Lin authored
Matches the about_flags.cc implementation. Bug: 1008219 Change-Id: I3755cf4f7b968fc347acc0ae5ab6ef31c70223bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884755Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710126}
-
Ali Juma authored
WKWebView and iOS do not permit navigation to arbitrary files on a device's file system. Attempting to load such inaccessible files in WKWebView can later trigger broken behavior (see crbug.com/1010526 for more details). To prevent this brokenness, disallow these navigations right away, rather than waiting for WKWebView to disallow them. Bug: 1010526 Change-Id: Ieefb5befad659669a38efad127dfdb6e0179a165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881667 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#710125}
-
Qingsi Wang authored
disabled in WebRTC. This policy gates the effectiveness of chrome://flags/#enable-webrtc-hide-local-ips-with-mdns. Only when a URL is not whitelisted by the policy and the feature flag has the value 'Enabled', local IP addresses are concealed with mDNS hostnames in WebRTC ICE candidates. Bug: 1012945 Change-Id: I7782db6f1196921361c12738e00e471282e64058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857184Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710124}
-
Tricia Crichton authored
Several tests that require features not supported on Android were added to the ANDROID_NEGATIVE_FILTER. Fixed: chromedriver:3191 Change-Id: I3c30057df11a008b59100e4e1aae91a1f90d754d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884284Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#710123}
-
rbpotter authored
Also fixing some tests that fail due to the addition of the assert. cr.js is included by default in the extraLibraries of the PolymerTest base class, so test classes that do not override extraLibraries and import cr.m.js cause the webUIResponse/webUIListenerCallback to be set twice. Bug: 1004967 Change-Id: I7c31cc4df5119556f62e1afe7ebf1b85cb0c6722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885230Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710122}
-
Jarryd authored
The only place where this event was fired has been removed. https://crrev.com/c/1369551/ shows in site_entry.js that the event was removed, and a search of cs for the event turns up no results. Change-Id: Id1b198382cfbd004c7fbd6035e2ec7cbc656e845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869017Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710121}
-
Julie Jeongeun Kim authored
This CL converts Producer for VideoCaptureServiceTest and MockProducer to new Mojo types using PendingReceiver and Receiver. Bug: 955171 Change-Id: Iccc4ad2e500c6a2dc55fa0467b851cb63efe2836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882264Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#710120}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for DevicesChangedObserver from VirtualDeviceEnabledDeviceFactory. Bug: 955171 Change-Id: I3cac65b00124e0735a8656190fe9c2cbdd9c3e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882266Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#710119}
-
Nick Diego Yamane authored
XEvent raw events are currently being "leaked" to views' DWTHX11 so that they can be forwarded to ATK. This CL moves the platform specific part of that process into platform_window level, which consists of translating XEvent into AtkkeyEventStruct, and adds a callback into PlatformWindowDelegateLinux to handle ATK key events, thus making it more aligned with Ozone design and removing more platform specific code from views. Bug: 990756, 965991 Change-Id: I9a3ba12969dcd5582f79f118cc12879d55a56388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864783Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#710118}
-
Chong Gu authored
Added checkout_aemu to gclient_gn_args. Check checkout_aemu when generating runner scripts, and only download AEMU if the value is true. Bug: b/142756812 Change-Id: Ic08b0abe945703ee5d6cddbc661831bbbdce784d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879819 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710117}
-
Gyuyoung Kim authored
This CL converts old Mojo types to new Mojo types in InterfaceFactory::CreateCdm and InterfaceFactory::CreateDefaultRenderer. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Convert mojo::StrongBindingSet to mojo::UniqueReceiverSet. Bug: 955171 Change-Id: I5f26b7efddf75ab48f6b6a5f02d84f91e027ba9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883447Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#710116}
-
Brian Sheedy authored
Disables several tests derived from ExtensionMessageBubbleTest due to flakiness that is preventing unrelated CLs from getting through the CQ. TBR=rdevlin.cronin@chromium.org Bug: 836332 Change-Id: Ide21a20e639f26e1d4a3d740cdb3e660b155e28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884581Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#710115}
-
Jamie Madill authored
conformance/ogles/GL/struct/struct_001_to_008.html conformance/ogles/GL/step/step_001_to_006.html conformance/ogles/GL/sqrt/sqrt_001_to_006.html Bug: 1017162 Change-Id: I1b633cb37a25539f238d2290ba7aa3a2f783416e Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884601Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#710114}
-
Peter Kotwicz authored
This CL: - Stops passing the "share_target">"params">"url" JSON parameter from the Web Manifest to the WebAPK server - Stops using the "share_target">"params">"url" in determining whether the WebAPK needs to be updated BUG=993651 Change-Id: Iaca496e9acccaad8edb590d496cb40b559a3a9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759050 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#710113}
-
Robbie McElrath authored
The last reference to this target was removed in crrev.com/i/2031130. Test: autoninja -C out/aw system_webview_apk Bug: 934152 Change-Id: I1c0fd238776e2346b77c83142a27b9d95a3854fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881493Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#710112}
-
Tim Song authored
In this state, the padding is already applied by the shelf in bottom alignment, so we need to make a special case. BUG=1011924 Change-Id: I211d5d0181a8c7419f6b8a587c6d05d3ec87235a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880569Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710111}
-
David Van Cleve authored
Cleans up - possibly providing AddressSorter::Sort a moved-from address list - a few use-after-move / passing result of std::move into const ref arguments / moves of trivially copyable types R=ericorth Change-Id: Ib383b5d695f1aab7193b194410bb041f27f6abf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883876Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#710110}
-
Giovanni Ortuño Urquidi authored
Attemps to clarify the reason why blink_tests is not in third_party/blink Change-Id: Id7938c8259a61fab5485f4c1f48a772abf59a62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874967Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#710109}
-
Caleb Raitto authored
Bug: 953995 Change-Id: I8c62dcb938c044195b5260bee49463135c38f850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884091 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#710108}
-
Henrique Ferreiro authored
Bug: 919392 Change-Id: Idecfec7e65c23fd55c64e9113a5ae6bf19615146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883514Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#710107}
-
Thomas Guilbert authored
Commit 'ab98b39d' broke the MSAN bots and was reverted. This CL relands those changes, while fixing the UTs. Original description: The WSOLA algorithm introduces noticeable audio artifacts when doing small adjustments to playback rate (e.g. 1.03 playback speed). The distortions can be described as warbling or transient stuttering. This CL introduces fixes this issue by using resampling instead, for speeds close to 1.00. The resampled audio doesn't have any distortions, but its pitch is shifted proportionally to the playback changes. The maximal slowdown/speed up we use resampling for is 5-6%, which corresponds to shifting by 1 note tone. Beyond that, the WSOLA artifacts become tolerable, and the pitch shifting doesn't. Bug: 920019, 1018617 Change-Id: Ide606af05253f02576f548f20dfc9007040cc106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884572 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#710106}
-
Wez authored
ReconnectToNetworkContext flaked due to raciness between disconnection of the Mojo NetworkContext, CookieManager and CookieChangeListener channels. The test now explicitly tears down the NetworkContext binding at the same time as the NetworkService, and sets a closure to watch explicitly for the CookieManagerImpl becoming disconnected from the CookieManager. Bug: 1018178 Change-Id: I2c55569c39e75d1c7190d8c87dbd359d7d1ae709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881779Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#710105}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/37fe72f23b..70f122128c TBR=lomitch@chromium.org Change-Id: I371e009293902593db7cc671fe75cfe1e387d3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884791Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710104}
-
Justin Cohen authored
Extend Prerender.PrerenderStartToReleaseContentsTime histogram. Bug: 1018790 Change-Id: Ia60073efa70414346517ab74079d3a6824f8b476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884230 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#710103}
-
Stephen Martinis authored
This reverts commit 23dd050b. Reason for revert: Broke rebaseline-cl, https://crbug.com/1018936 Original change's description: > Remove exparchive from testing configs > > Bug: 840252 > Change-Id: I7181f1adde1d2b11b4ca5da6535210112f031317 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877229 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709666} TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. # Skipping CQ because the failure is unrelated, other tests pass, and # this is breaking rebaseline-cl. No-Try: true Bug: 840252 Change-Id: If30dac52b2e23aff12dd8144d517e7a504a9c1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885251 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710102}
-
jchen10 authored
This was mistakenly enabled by CL 1877817. Bug: 709351 Change-Id: I52ef7c4e90926f71870d208f253bc1cfa8711a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881761 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710101}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/91ae3918387e..eab918f02856 $ git log 91ae39183..eab918f02 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 renjietang Remove unused return value for QuicSession::OnStopSendingFrame(). 2019-10-28 dschinazi Remove no-longer-required QUIC_EXPORTs 2019-10-28 ianswett Deprecate gfe2_reloadable_flag_quic_simple_inflight_time. 2019-10-28 ianswett Deprecate gfe2_reloadable_flag_quic_sent_packet_manager_cleanup. 2019-10-26 rch gfe-relnote: Add a VersionSupportsGoogleAltSvcFormat() method to move the version check out of the version manager. No behavior change. Not flag protected. 2019-10-25 bnc Move QPACK test utilities to test_tools/qpack/. 2019-10-25 dschinazi Inline trivial constructors 2019-10-25 renjietang Fix some test expectation regarding SendControlFrame(). 2019-10-25 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_detect_spurious_loss. Created with: roll-dep src/net/third_party/quiche/src R=zhongyi@chromium.org Change-Id: Ia9d65ea1d21c56b539c7ba1870bcc348181e8b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885090Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#710100}
-
- 28 Oct, 2019 13 commits
-
-
Yun Liu authored
Bug: 985581 Change-Id: Ia96e404d0b04efdeaeab703b86c4c7f4df856005 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885026Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#710099}
-
Peng Huang authored
This CL adds --js_deserializable_struct=gpu.mojom.VulkanInfo param for mojom binding generator to allow generating js deserialize method for specified mojom struct. Bug: 887018 Change-Id: I98f2224e7422d52fb0c4aeb684078dd191f8e616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869685Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710098}
-
Akihiro Ota authored
This change adds support for navigation by list in ChromeVox. This behaves in a similar manner to other navigation types such as navigation by heading, link, button, etc. This change also fixes bug 1012907. In this bug, ChromeVox would jump to the second to last element, instead of the last element, when jumping to the previous element from the top of the page. Bug: 887630 Bug: 1012907 Change-Id: I35194c9c125e6b237db1258f8cb1a4cfdc1aa769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830364 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#710097}
-
David Benjamin authored
The MSan bug does not appear to reproduce anymore. Bug: 405951 Change-Id: I57c643a638381ae66ca5b8d871c57bdda861166d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657753 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710096}
-
Robert Sesek authored
With the Service Manager going away, the manifest files that previously mediated access to Mojo services across processes are going away too. Under the new system, various //content classes have methods that bind mojo::Receiver<T> objects via GenericPendingReceiver. Since these call sites control access to objects across a privilege boundary, they should be under the SECURITY_OWNERS review system. This pass splits out BindHostReceiver calls. Bug: 1012033 Change-Id: I390a26af782953625b603270e3201535ff4ee9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880315Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710095}
-
Jeremy Roman authored
It's never necessary to extract a non-const pointer from DOMDataStore::wrapper_map_, so it can be keyed by WeakMember<cont ScriptWrappable>, which avoids the need to const_cast. Change-Id: Ib1e25bf312cf09cf7c117a0485c1c30c338474c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884280 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710094}
-
Omer Katz authored
Make all calls to header->IsInConstruction go through MarkingVisitor::IsInConstruction. Having a single call instead of multiple calls scattered around the code would make the code easier to maintain (in case we need to change atomicity for example). Bug: 986235 Change-Id: Ie386a59737bbcaa9d35c87e1ccc45037729b69c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885050 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710093}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4592a8d52f74..41a660b1765e Created with: gclient setdep -r src-internal@41a660b1765e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic4bb3137d3b7ac812cfaf4d05c837efaa3085e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884694Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710092}
-
Will Harris authored
Error happens after https://chromium-review.googlesource.com/c/chromium/src/+/1884757/2#message-b121b34981a18b718765187998ac1e4dc2b61005 BUG=1018977 Change-Id: Ic7090d5325102798522fd4ae6f7edffd90a8b471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885177Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710091}
-
Yoshisato Yanagisawa authored
For ease of putting xcode SDK under Chromium src, let me implement an option to make SDK path relative. Bug: 1015730 Change-Id: I3c473c3715bfc90b3692649d27ee832048a7e8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883469 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#710090}
-
Chrome Cunningham authored
This reverts commit aa028783. Reason for revert: Downgrading CHECK to DCHECK. No crashes hit. Original change's description: > MediaCapabilities: Temporarily CHECK that we don't save bad data > > CHECK is very aggressive - saving bad data is generally not a show > stopper (except for data that causes FLT_EXCEPTIONS on win). The idea > is to let this sit in pre-beta channels for a bit and find out if there > are any remaining ways we can cause corrutpion. > > TODO(me): revert this before beta promotion. > > Bug: 982009 > Change-Id: If2faf12e56a54bd7244f08aa940be2ace9781ca4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855199 > Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704998} TBR=chcunningham@chromium.org,liberato@chromium.org Bug: 982009 Change-Id: Ia98547875444cfefc3f8178f5f9127c9a86d2f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885074 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#710089}
-
Reilly Grant authored
This change adds special handling for read and write errors for which recovery is impossible (i.e. disconnection). In this case the readable and writeable attribute are not initialized with new streams on demand. Bug: 1013763 Change-Id: Ibd03cb684cb34cf9a8b22848f7b9ebc50f4d6621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884357Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710088}
-
Charlene Yan authored
The fixed insets makes it crash on the DCHECK with certain sizes. Updating this to be managed by layout manager fixes this issue while developing and fiddling with the final sizes. The insets might need to be updated later on for the first and last elements. Bug: 1015634 Change-Id: I947c1e6b01013fd353602e8e96739a21b5f4e7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884351 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#710087}
-