- 01 Mar, 2019 40 commits
-
-
Peter E Conn authored
Bug: 929169 Change-Id: I06cf33cb79c42052adc460ce0ccce54e43a379a4 Reviewed-on: https://chromium-review.googlesource.com/c/1472719 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#636753}
-
Yi Su authored
This CL converts ios_web_shell_egtests.MetaTagTestCase to ios_web_inttests.MetaTagTest, because it doesn't require UI for testing. Bug: 930859 Change-Id: Idad9e27707ded89a180d9e47e127a8e3cf5260d1 Reviewed-on: https://chromium-review.googlesource.com/c/1488917 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#636752}
-
Robbie Gibson authored
Before, the option would appear regardless of the default search engine, but would DCHECK if the default search engine didn't support search-by- image. Now, the option doesn't appear in that case. Bug: 935386 Change-Id: Ic1e1ef896674b72bd8de8f159cf8afb9718c93a5 Reviewed-on: https://chromium-review.googlesource.com/c/1486093 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636751}
-
Adam Rice authored
Add an |is_settled_| member variable to StreamPromiseResolver. This is used to protect against cases when Resolve() is called re-entrantly inside Resolve(), which can happen when resolving with an object that has a getter on "then". Also use IsSettled() in two places rather than a check of State(), as it is considerably cheaper. Include a test for re-entrant use of Resolve(). BUG=902633,931640 Change-Id: I38aeea82cf2e1499fccacda2e9f27f871ff8e9af Reviewed-on: https://chromium-review.googlesource.com/c/1488489Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#636750}
-
Mugdha Lakhani authored
This adds logic to verify that the background task that wakes up Chrome is called with network connectivity. Unit tests are also added to verify the same. Follow-up CLs will add more unit tests to verify the behavior of BackgroundSyncBackgroundTask. Bug: 924490 Change-Id: I1950e00704054c120b6668ebabcb99c32ec9f5c3 Reviewed-on: https://chromium-review.googlesource.com/c/1482462Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#636749}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/100cc47d5e0a..27fb2bec31ac Created with: gclient setdep -r src-internal@27fb2bec31ac The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I506dd7d2adf6b15e8b6968108ec2f9c2d1163624 Reviewed-on: https://chromium-review.googlesource.com/c/1495782Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636748}
-
Marc Treib authored
This reverts commit 46584179. Reason for revert: Still breaks http/tests/devtools/application-panel/storage-view-reports-quota-and-clear.js on Mac, see https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests Original change's description: > Reland "[DevTools] Application>Clear Site Data: stop service worker when unregistering it" > > This is a reland of 3dc09a0d > > Original change's description: > > [DevTools] Application>Clear Site Data: stop service worker when unregistering it > > > > We should stop the service worker before unregistering it. > > > > Originally, clicking "Clear site data" will unregister the service worker. In > > Application>Service Workers, the service worker's tab title is marked as > > "deleted", but its "status" says it's still running. > > > > Bug: 894783 > > Change-Id: Ib1550cfab8274a27495bb795501f54e9a19f6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/1480725 > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#635263} > > Bug: 894783 > Change-Id: I4b1b9a2f3764391846e47f8752cab6e223adbb1d > Reviewed-on: https://chromium-review.googlesource.com/c/1490432 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636612} TBR=dgozman@chromium.org,pfeldman@chromium.org,hhli@chromium.org Change-Id: I3935ddfc1374e418e4ec935e3387dabf8c183161 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894783 Reviewed-on: https://chromium-review.googlesource.com/c/1495979Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#636747}
-
Yutaka Hirano authored
Some callers, notablly flash, with |grant_universal_access| want to have an origin matching with referrer. Bug: 935662 Change-Id: I99fc48266015d1a6ef611102f2cfbe2330ccc465 Reviewed-on: https://chromium-review.googlesource.com/c/1496125Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#636746}
-
Darwin Huang authored
- I saw that we use HashSet::Find(T Value) == HashSet::End(). HashSet::Contains is simpler, so I figure we should change it where applicable. Thankfully, we don't use Hashset::Find(..) == HashSet::End() too often. - Likely no logic changes. Change-Id: If6d595877318d0de9c8510a2b489871a16767c56 Reviewed-on: https://chromium-review.googlesource.com/c/1496249Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636745}
-
Hayato Ito authored
The return value is always non-null there. Change-Id: I114d563d10736cfb4cefdf0b40ec44d645ebeed4 Reviewed-on: https://chromium-review.googlesource.com/c/1496269 Auto-Submit: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#636744}
-
Lowell Manners authored
This logic is no longer needed after https://crrev.com/c/1372318. Change-Id: I15db2bf94d54fd92c92cdd455d58fed9bc8421f6 Bug: 913400,933109 Reviewed-on: https://chromium-review.googlesource.com/c/1488871Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#636743}
-
Clemens Arbesser authored
The new parameter is 'autofill-assistant-url'. This allows us to remove the dependency on finch trials to be able to override the server url from the command line (see related CL cr/235482708). Bug: 806868 Change-Id: I25c75201c92d02540b5fa44e75a07d90a990fbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1494656Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#636742}
-
Juan Antonio Navarro Perez authored
Tidy up a bit the directory structure in tools/perf by adding a new command_line_tools module. It is intended to include, as submodules, packaged implementations for each of the scripts available within tools/perf itself. Currently update_wpr and flakiness_cli are moved as the first two submodules. This is in preparation for moving over further tools from catapult/experimental/soundwave. Bug: 922030 Change-Id: I6a568e13916cd607047ef301bd77f5597709b637 Reviewed-on: https://chromium-review.googlesource.com/c/1489246 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636741}
-
Marc Treib authored
This reverts commit 932fdb31. Reason for revert: use-of-uninitialized-value on ChromiumOS MSan: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/11553 Original change's description: > Introduce ash::network_icon::NetworkIconState > > This CL: > * Introduces a NetworkIconState to cache state that the network > icon code cares about in an intermediate format that will be > compatable with Mojo network state. > * Fixes a rather bad edge case (that I previously introduced) > where ActiveNetworkIcon stores pointers to NetworkState that could > possibly be accessed after being deleted. > * Modifies the criteria for ActiveNetworksChanged() to include > significant changes to signal strength. > * Adds some verbose logging for continued debugging. > > Bug: 923444 > Change-Id: I917b353c9da7a3c5e20dc8e69191a6a97f752aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/1469521 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636562} TBR=stevenjb@chromium.org,tbarzic@chromium.org,khorimoto@chromium.org Change-Id: If8523f3b782bf78c858d1390a5fc89e5b3a34c2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923444 Reviewed-on: https://chromium-review.googlesource.com/c/1495521Reviewed-by:
-
Marc Treib authored
This reverts commit 1e0ea868. Reason for revert: Depends on crrev.com/c/1469521 which needs to be reverted for introducing a use-of-uninitialized-value. Original change's description: > network_icon: Use GUID instead of path to track state in cache > > NetworkHandler uses Shill service paths to identify network services, > but the forthcoming mojo API and the rest of the UI code uses GUID > so this code needs to switch to GUID to support the mojo API. > > Bug: 923444 > Change-Id: I739b36762b6f380ae70e054eba9284bad2773ba9 > Reviewed-on: https://chromium-review.googlesource.com/c/1470939 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636603} TBR=stevenjb@chromium.org,tbarzic@chromium.org,khorimoto@chromium.org Change-Id: Ib21003e61b5cd5e819463ba4c6d66fa2c9a4f92b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923444 Reviewed-on: https://chromium-review.googlesource.com/c/1495520Reviewed-by:
-
Min Qin authored
With recent changes, the target path is not a content Uri if download is written to a content Uri. This may cause some undesirable effect for resumption. We kept the target path earlier due to display names. This Cl solves both issues by loading the display names from ContentResolver on initialization time, and pass them to all the download items so that could be used later. The target path will be changed to content Uri once intermediate file rename completes. TBR=dtrainor@chromium.org BUG=931021 Change-Id: I36bf5245ea1f7d36aa707a4b0f1065a5b0f8b133 Reviewed-on: https://chromium-review.googlesource.com/c/1479934 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636738}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/520d06f4107a..df7065a0be96 git log 520d06f4107a..df7065a0be96 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 sadrul@chromium.org Revert "speed: Use thread-pool for processing results." 2019-03-01 sadrul@chromium.org speed: Use thread-pool for processing results. 2019-03-01 benjhayden@chromium.org Integrate ResultChannelReceiver into RequestBase Created with: gclient setdep -r src/third_party/catapult@df7065a0be96 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935834,chromium:935834,chromium:918193 TBR=sullivan@chromium.org Change-Id: Ia942c3b0552ac375f8028e8b03527ad2a93648df Reviewed-on: https://chromium-review.googlesource.com/c/1495781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636737}
-
Leo Zhang authored
Bug: 937152 Change-Id: I8a295b46cf2a6e261839121eadf87dfa76e8b66d Reviewed-on: https://chromium-review.googlesource.com/c/1496257Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636736}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b8a4d688f907..8e98c60f8483 git log b8a4d688f907..8e98c60f8483 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 benwright@webrtc.org Cleanup for openssl_stream_adapter.cc. 2019-03-01 steveanton@webrtc.org scale_resolution_down_by and rid are implemented 2019-03-01 mellem@webrtc.org Implement OpenChannel() on test media transports and make it pure virtual. 2019-02-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 16b06806..d1e2a1cf (636404:636518) 2019-02-28 titovartem@google.com Use default values for video and audio streams generation in PC E2E framework 2019-02-28 srte@webrtc.org Allow injection of TaskQueueFactory in FrameGeneratorCapturer. Created with: gclient setdep -r src/third_party/webrtc@8e98c60f8483 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1fd1c0ac76dcc4736d4520ba1b67731371d5ee1b Reviewed-on: https://chromium-review.googlesource.com/c/1496384Reviewed-by:
-
Gauthier Ambard authored
This CL changes the fakebox animation to have something smoother. The animation should be one transition directly from the fake omnibox to the real omnibox, instead of the two steps process we currently have. Bug: 910753 Change-Id: Iac51c08b49db09b3a2e0041e236af6cba90fa55c Reviewed-on: https://chromium-review.googlesource.com/c/1473231Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#636734}
-
Gauthier Ambard authored
This CL makes sure that the Switch to Tab element is present before closing the tab in the testSwitchToClosedTab test. It might reduce flakyness as it is possible that the tab is closed before the suggestion is displayed. If it is the case then the suggestion appears as if no tab with this URL is opened, making the test fails. Bug: 936085 Change-Id: Ief59c0436677d02c915d65543d93f1c081ab83bd Reviewed-on: https://chromium-review.googlesource.com/c/1491613 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/486980d1..9ea32aab Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I55a75e938fc527f448a759df31309d8fdaeaacc7 Reviewed-on: https://chromium-review.googlesource.com/c/1496609Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636732}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6edf76bf7b99..100cc47d5e0a Created with: gclient setdep -r src-internal@100cc47d5e0a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I65a3f25fb9bb482bdce0d12ade5d02cf4857659b Reviewed-on: https://chromium-review.googlesource.com/c/1496391Reviewed-by:
-
Dominic Mazzoni authored
This is enough to quickly check how many images it's trying to label and what successes we got back. To use, run Chrome with: --enable-logging=stderr --vmodule="*ax_image_annotator*=1" Bug: 905419 Change-Id: If3ceedbbb1a4d673f2045319836046690ccf7ed9 Reviewed-on: https://chromium-review.googlesource.com/c/1493198 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#636730}
-
David Jean authored
Merged LoadURL directly in UrlLoadingService::LoadUrlInCurrentTab. Removed URLLoadResult enum. Exported InduceBRowserCrash. Bug: 907527 Change-Id: I7070a954db76c1466564538e3896b402be8516ab Reviewed-on: https://chromium-review.googlesource.com/c/1488914 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch removes Shadow DOM V0, Custom Element V0 (CEv0) and HTML Imports. Intent to Deprecate and Remove: http://bit.ly/2RGHe3x Bug: 911943 Change-Id: I1baa906e019e0f59331c1fb590eccbc38a482fec Reviewed-on: https://chromium-review.googlesource.com/c/1481130Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I6f69877637a0baab35d46e897f6be6c188780257 Reviewed-on: https://chromium-review.googlesource.com/c/1496658Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#636727}
-
Yoichi Osato authored
Refactoring: Clarify DocumentMarkerController::InvalidateRectsForTextMatchMarkersInNode type to const Text&. This patch refactors the function to receive only const Text& rather than Node* because the function does only on text node. Bug: 868229 Change-Id: I23b5d3c3accf721771d55ebbcf413dda33d71312 Reviewed-on: https://chromium-review.googlesource.com/c/1491167Reviewed-by:
-
Hiroshi Ichikawa authored
Change-Id: I1aecaedcfdf9ebd09530792565548b91bfe8ffad Reviewed-on: https://chromium-review.googlesource.com/c/1496263 Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#636725}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1757d2dc1b48..6edf76bf7b99 Created with: gclient setdep -r src-internal@6edf76bf7b99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: I70230a51e4e21c3a11e588e3e7a6945177eb953c Reviewed-on: https://chromium-review.googlesource.com/c/1496390Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ffa277a12fcd..1581ff030b9c git log ffa277a12fcd..1581ff030b9c --date=short --no-merges --format='%ad %ae %s' 2019-03-01 ynovikov@chromium.org Vulkan: disable VK_PRESENT_MODE_FIFO_KHR on Linux Intel Created with: gclient setdep -r src/third_party/angle@1581ff030b9c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I08174113dc762dfc72d953ba3ee09d105a2aff08 Reviewed-on: https://chromium-review.googlesource.com/c/1496389Reviewed-by:
-
Sam McNally authored
Files app has migrated to file_handlers, so allowing it to use file_browser_handlers is no longer necessary. Bug: 933674 Change-Id: Ifffadba9c7444516ebd759ecc5fa9246bbd620f8 Reviewed-on: https://chromium-review.googlesource.com/c/1496117 Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#636722}
-
Noel Gordon authored
Install the Piex WASM on the page & say "boo". The Puppeteer driver is watching and calls the test page function runTest(image) and waits for test done (document.title == "DONE"), then tests the next image. For each image: the test page fetches the image, sends its data to the Wasm module and renders its image preview and thumbnail results on the test page. The test page logs all processing steps and time taken, and also the hash of the test image preview and thumbnail data returned by the Piex Wasm module, then sets document.title = "DONE". An 'npm run test' test run compares the golden hash values of all test images to the hash values logged by the test page. If the hashes match tests PASS. If they do not, tests FAIL. Updating the test images would mean updating the golden files (easy to do). Small issue though, since the external Piex has tests for many more raw images. Minor: add README.md documenting install/build/test steps. Bug: 935285 Change-Id: I9a46936a7c20d242fb84f578c785833205a38c1f Reviewed-on: https://chromium-review.googlesource.com/c/1493635 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#636721}
-
Kent Tamura authored
The original behavior before r410495 depended on 1px margin-inline-end specified by the UA stylesheet for -webkit-search-cancel-button. After r410495, the search field correctly moves the cancel button to the left side. This CL recovers the original behavior by adding margin-inline-end to #searchTerm. Also, this CL removes selectors for -webkit-search-decoration and -webkit-search-results-button from cr_toolbar_search_field.html. These pseudo elements were removed from Blink. This CL doesn't intend to fix other existing issues. - We should secure space for the custom clear button at the right side, or - We should flip the position of the custom clear button; crbug.com/638484 BUG=639256 Change-Id: I9e3368c03067f42235ce4904c47133e4e709a34c Reviewed-on: https://chromium-review.googlesource.com/c/1491880 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#636720}
-
Chris Hall authored
R=aboxhall Bug: 889370 Change-Id: Ib4c28c3fd7df0e9e2423708abff8a93ba70a0626 Reviewed-on: https://chromium-review.googlesource.com/c/1496400 Commit-Queue: Chris Hall <chrishall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Auto-Submit: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636719}
-
Kent Tamura authored
r636661 changed a relative path to update_histogram_enum.py. Change-Id: I2692e5afafd7590355d58dfaaef69be9968c93c3 Reviewed-on: https://chromium-review.googlesource.com/c/1496266Reviewed-by:
-
khachatryan authored
CL https://crrev.com/635738 fixes the bug 2710 so we are removing the workaround for this bug. Bug: chromedriver:2710 Change-Id: Ic6704a7dbca2de13cf49ea12e7e77dae1568d380 Reviewed-on: https://chromium-review.googlesource.com/c/1495222Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636717}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16c76cb9..486980d1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1efba1e42158d100193eebad0d3d17174aade339 Reviewed-on: https://chromium-review.googlesource.com/c/1496601Reviewed-by:
-
Rob Schonberger authored
For Dinner For One, add a dinguishing piece of text for accessibility. Bug: 914864 Bug: 911427 Change-Id: I39cc682fbb57ae3e7f3e3b26e582ee3ec127ae5e Reviewed-on: https://chromium-review.googlesource.com/c/1496114 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636715}
-
Yoichi Osato authored
This patch is a preparation for Shadow DOM V0, Custom Element V0 (CEv0) and HTML Imports removal. Intent to Deprecate and Remove: http://bit.ly/2RGHe3x Though we soon make these APIs only available for test by turning the json5 feature flag from status: "stable" to status: "test", there is browser tests/chrome internal components that use them. FilesApp finished migration but it was only for w/o Polymer2. FilesApp w Polymer1 still needs the APIs for it. Descussion of flagging was done at previous patch among Jochen and Devlin: crrev.com/c/1405955 Bug: 924873, 911943 Change-Id: I0d3038ce5d21c410e1a055b57752d0df62cf62fb Reviewed-on: https://chromium-review.googlesource.com/c/1496259Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#636714}
-
