- 18 Oct, 2019 40 commits
-
-
Victor-Gabriel Savu authored
The current UMA, InvalidDevicePolicyFiles, that logs the number of invalid files doesn't allow to understand if all the files are broken (which might suggest a disk corruption). This change introduces InvalidDevicePolicyFilesStatus logs if no, some or all files are invalid. CL that implements the code change: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1863798 Bug: 10148806 Change-Id: I79841e847a78f1b965f56e7b9616501b85966483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864771Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#707275}
-
Matt Falkenhagen authored
Android's New Tab Page has an empty site URL by design to let navigations from the NTP use the same process. The site URL is assigned after the navigation is committed. However, this doesn't interact well with SW. SW is created in a process suitable for the service worker's script URL, and the navigation stays in the NTP process, so the SW is out-of-process which has a performance and memory cost. With this CL, when the SW process is chosen, it takes a process that hasn't yet been assigned to a SiteInstance. The idea is to choose the Android NTP process. Bug: 1012143 Change-Id: I423de186982a11c68e4c2bec7b5ca56b3245f62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849473 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707274}
-
Primiano Tucci authored
Manually fix API change in protozero iterator. https://android.googlesource.com/platform/external/perfetto.git/+log/45f9f6cebc3a..95524e4897be git log 45f9f6cebc3a..95524e4897be --date=short --no-merges --format='%ad %ae %s' 2019-10-17 treehugger-gerrit@google.com Merge "Clarify sampling rate unit of power rails." 2019-10-17 treehugger-gerrit@google.com Merge "processor: Move json, fuchsia, systrace parsers to importers subdirs" 2019-10-17 treehugger-gerrit@google.com Merge "protozero: Remove untyped accessor for RepeatedFieldIterator" Change-Id: I1407d7ff0a067c3c30c965bc55b5bd48b21f2995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864664 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#707273}
-
Yuta Kitamura authored
Bug: 999409 Change-Id: I97e343f985b23087a958cd5182663733a52d35bb Tbr: mpawlowski@opera.com Tbr: mattreynolds@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868570Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#707272}
-
Hajime Hoshi authored
This adds new metrics for eviction by back-forward navigation: BackForwardCache.NotRestoredReason BackForwardCache.NotRestoredReason records the reason why the page cannot be put into the cache, e.g., due to disallowed features. BackForwardCache.EvictedReason is now merged with BackForwardCache.NotRestoredReason by this CL. Bug: 1004676 Change-Id: I2af3d49b806ee731c296e716513d16fb732f988d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827099 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#707271}
-
Yuta Kitamura authored
Bug: 1015737 Change-Id: I595c11f58a7b7c5d2b13241e1c06dc71787493da Tbr: rtoy@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868531Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a08aa5a7. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" ba49a3d6 "autofocus: Change the timing of 'flush autofocus candidates'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I66d51f4884195a11328bbb725e9ca83309a4a6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866820Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707269}
-
Wenbin Zhang authored
In order to ensure homogeneous fleets, we need to have more specific dimension values when looking for bots. This set of CLs updated some existing dimensions, and added the synthetic_product_name values for dimensions if appropriate. This CL updated the dimensions for Win 7 Perf: - Added synthetic product name 'PowerEdge R210 II (Dell Inc.)'; - Updated GPU from '102b:0532' to '102b:0532-6.1.7600.16385'. Please check the link below for the available bots based on the old/new dimensions: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=gpu%3A102b%3A0532&f=os%3AWindows-2008ServerR2-SP1&f=cpu%3Ax86-64&f=pool%3Achrome.tests.perf&s=synthetic_product_name Bug: chromium:996830 Change-Id: I1fc8278887a8e362958205f1cccde11f1f129030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867473Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#707268}
-
Noel Gordon authored
TreeItem handles the item content creation, label, tree parent_ etc so remove local ShortcutItem code related to that. Bug: 992819 Change-Id: I137853c9f85db7c78516cbe708cc79186f449412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868351 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707267}
-
Peter Kasting authored
Bug: 82078 Change-Id: I5883996d3474f10898689defc6bdfd0932b332f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866263 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#707266}
-
Alan Cutter authored
The current merge process for Phase 3 (late beta/stable) doesn't cover cases where it's unclear whether the severity of the issue meets the requirements for merging. This CL adds a segment to tell the engineer to consult the TPM/their manager. Bug: 1015723 Change-Id: Ia8406f47be7e0ed6ce87b6f4b3bf4cc9ecca78ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868213Reviewed-by:
Josafat Garcia <josafat@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#707265}
-
Noel Gordon authored
TreeItem handles the item content creation, label, tree parent_ etc so remove local AndfroidAppItem code related to that. Bug: 992819 Change-Id: Idc618323fdfae016c2e8788f3d54148ae33f38b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868352 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0a08bf275b625ca03d0113fee1babe204ac7c1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707263}
-
Alex Danilo authored
Checks the behaviour of createPanelItem(), attachPanelItem() and removePanelItem() with different ordering of API calls. Checks changing feedback panel types. Adds 2 getters to the feedback panel API to help testing. Bug: 1009318, 1009853 Tests: browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Change-Id: Ie7b2a198b0259c344418dcb21ca0208de0837cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865915 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#707262}
-
Morten Stenshorne authored
While it's nice on its own to handle this, this CL can also be used as an example to lean on when implementing block fragmentation support in other layout modes, such as flexbox and tables. We still don't support early breaks before column rows. That may also be a useful thing to support, but it would require some more work, since we'd need another way of specifying early breaks, because column rows aren't uniquely identified by nodes. NGEarlyBreak currently only supports breaks before line numbers or nodes. Bug: 829028 Change-Id: Id1517790826223402c6ea4cd72ca565e0bd0e368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865325 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#707261}
-
Raphael Kubo da Costa authored
They were referring to geolocation due to some copy-pasting, which leads to testharness errors like Harness Error. harness_status.status = 1 , harness_status.message = 1 duplicate test name: "Test geolocation permission in DedicatedWorker scope." Bug: 648553 Change-Id: Idf92966019af27ce6062d8cf04b1e0e257a47323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864991 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#707260}
-
Yuta Kitamura authored
This reverts commit 0908b290. Reason for revert: This CL caused ~290 test failures due to use-after-free on ASan bots. See: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/35773 Original change's description: > Fix calculation of inner padding of OOBE dialog depending on outer margins > > Bug: 1007294 > Change-Id: I99b7b3cc46e12c0fb060f76e086f5f31bd4cb812 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865216 > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Auto-Submit: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707055} TBR=antrim@chromium.org,rsorokin@chromium.org Change-Id: I31d64629695d0696667c64055950c8791108369b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868217Reviewed-by:
-
Darwin Huang authored
Bug: 1013400 Change-Id: Ia24879f52e4665b3edbd937725eb3c5c0a1621ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854532Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707258}
-
Noel Gordon authored
All items set prototype and do their window.IN_TEST code first and the DriveVolumeItem can too. Bug: 992819 Change-Id: I8a0ed617f8c404ceb08302771a8b936a5dbe5420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866340 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Noel Gordon authored
- base class handles row content creation, label, tree parent, etc - use this.querySelector('.icon') as everywhere in this file does - de-squish updateDriveSpecificIcons() for better code reading - add missing Closure markup, add comments Bug: 992819 Change-Id: Ib339f5b102a1c19d4db72179b3b685d61c91bbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866891 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: -
Julie Jeongeun Kim authored
This CL converts MediaPerceptionService, MediaPerceptionController, and MediaPerceptionControllerClient from media_perception_service.mojom to new Mojo types using Remote, PendingReceiver, and Receiver. Bug: 955171 Change-Id: Ia6806762929076808599c90a71a743c010f3bd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851784 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#707255}
-
Noel Gordon authored
TreeItem handles the item content creation, label, tree parent_ etc so remove local DirectoryItem code related to that. Bug: 992819 Change-Id: I2427d1d3716402decc52cd842cdc04c6591acb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866337Reviewed-by:
-
Danyao Wang authored
This change adds 3 new bits to the PaymentRequest.Events bitvector to record which payment app(s) are available for selection at the time of launching the payment sheet. This change also adds a new TestObserver event onShowInstrumentsReady so that android_browsertests can wait for all instruments are displayed in the payment sheet, abort the request, and assert on the histogram. This is needed because android_browsertest doesn't currently have any mechanism to interact with the UI elements on the payment sheet. New android_browsertests are added to test the new bitvector bits. A number of existing metrics tests are brittle. The expectations had to be updated to include the new bits. Bug: 1014717 Change-Id: I624f74b26428cfdc1a970537f5e7c7f91fb6b3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866204 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707253}
-
Peter Kasting authored
Hopefully prevents cached stale layouts. Bug: 1012324 Change-Id: I9d7dc99890a78d6179a5347dd29ec8c9eba44953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867480Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#707252}
-
Moe Ahmadi authored
Bug: 996516 Change-Id: Iee2e5402eb7a997d3a1819016e3cec8e72030213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860698Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707251}
-
Koji Ishii authored
This patch implements [NGLineBoxFragmentPainter] to support [NGFragmentItem]. This class paints the background of `::first-line`. Bug: 982194 Change-Id: I2080ce74b006edd721531fe93466544d5310cd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864755 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707250}
-
David Bokan authored
This CL fixes an issue when scroll chaining from fixed nodes in combination with |pointer-events: none|. |pointer-events: none| causes a subtree to become invisible to hit testing. This means scrolling over it should pass through to the element below. The way the test case in the bug normally works is that the scroll hit test on the compositor will hit the fixed layer, but the first *scrollable* layer hit is the <div> below the fixed layer. Since scrolls from fixed layers chain to the inner viewport, the check in IsInitialScrollHitTestReliable sees different layers so it returns false and the scroll is sent to the main thread where the |pointer-events: none| scroll chaining behaivor is explicitly implemented. I'm not sure that this behavior is intentional. With RootScroller, the scroller below the fixed layer becomes the outer viewport. This means that scrolling the "viewport" scrolls this scroller. Prior to https://crrev.com/c/1752866, scrolling over a fixed layer would chain to the viewport so it would incorrectly cause scrolling in this non-document scroller. The CL above fixed this case by chaining scrolls from fixed layers to the inner viewport *only*. However, we failed to update the chaining behavior in IsInitialScrollHitTestReliable. So when this method checks for the first scrollable ancestor of the fixed layer, and gets the inner viewport, it still assumes it'll be scrolled using the "viewport" and thus substitutes it for the outer viewport node. This causes IsInitialScrollHitTestReliable to return true and we handle the scroll on the compositor which doesn't know that the fixed layer has |pointer-events: none|. This CL updates IsInitialScrollHitTestReliable to use the same chaining behavior as the rest of the scrolling code. Bug: 1011866 Change-Id: I83020cc934255a6e22e1619833f5a5e82a55d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856853 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707249}
-
dpapad authored
This method is using /deep/ which only worked in Shadow DOM v0. WebUI has been using SDv1 since M72, and this test is silently doing nothing (does not find any iron-icons to assert on). Moreover, running additional checks after every test is a questionable pattern. - The state of the DOM is not necessarily valid/useful at the end of a unit test (see workaround removed in site_details_permission_test.js). - Such checks often confuse developers by throwing an error only if another error has happened earlier (which affects the DOM state). - Given that these tests are silently injected by the PolymerTest base class developers often are not aware that these checks are even happening. Overall, I think these speculative tests are not worth their maintenance burden. Bug: 885401 Change-Id: I2574d690dc5596513bc089efd1738805ccd0404d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863673Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#707248}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 93ede3b9. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I13e76d3cc882fed4ec34e3c47591990fbacfd38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868109Reviewed-by:
-
Matt Menke authored
This is a cleanup prior to splitting server auth cache entries by NetworkIsolationKey, but not proxy auth cache entries. TBR=alemate@chromium.org Bug: 993806 Change-Id: I66fa53bb1ae0d6f3e0836d80bc03db8d2c3324f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860531 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#707246}
-
W. James MacLean authored
We shouldn't be able to create a traversal iterator when there's no current_frame_host(), as it will crash in NodeIterator::operator++ when that function tries to access child_count() via |current_node_|. Change-Id: Ib9314b4189d9828fa5ff22a58b89b414426be590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867435 Commit-Queue: W. James MacLean <wjmaclean@google.com> Reviewed-by:
-
chrome://downloadsDaniel Rubery authored
This CL adds UX on the chrome://downloads page for all the new WebProtect download states. These correspond to the changes made in the download shelf. Screenshots: https://screenshot.googleplex.com/DgQ6RMa47eU.png https://screenshot.googleplex.com/cRWuijJRw8H.png https://screenshot.googleplex.com/dT5XRGgX1v0.png https://screenshot.googleplex.com/5d1DfXa3WYf.png https://screenshot.googleplex.com/sYeBGWwuJrb.png https://screenshot.googleplex.com/VAobzSD4J89.png Bug: 980777 Change-Id: I7b4f8e99dc61cf7c7135fd0a9c03dffefd574f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865039 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707244}
-
Andrew Grieve authored
Each test was creating: * a non-incremental wrapper script, * an incremental wrapper script, * another non-incremental wrapper script. This third target is actually just needed to depend on the other two, so refactored to make this more clear. It also makes it easier to address changing incremental install a GN arg (linked bug). Bug: 1013688 Change-Id: I530e95a3277aa9a5164e7ad9a02f0f1ec830e556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856841 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707243}
-
sczs authored
In order to avoid a RecentTabsTableVC update everytime a tab is closed after Closed All Tabs has been triggered, RecentTabs mediator stops forwarding any update signals to its consumer (RecentTabsTableVC) while all close tabs is taking place. Once this operation is complete it will tell its consumer to update, thus only refreshing once per Close All Tabs operation. Bug: 994229 Change-Id: I9eec07fada9863fbaae600ed1dc9675527c24681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860526 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707242}
-
tby authored
Currently we assume search result score are in [0,1], which is not the case for Drive files. This changes LogZeroStateReceivedScore to take lower and upper bounds, and re-ranges them into [0,100]. While here, I've changed two calls to UMA_HISTOGRAM_COUNTS into UMA_HISTOGRAM_EXACT_LINEAR, which is more aligned with what we want. Bug: 1011221 Change-Id: If70fd8a184d24bd73ee29f580088c3a3c7de4df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858063 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#707241}
-
Kenichi Ishibashi authored
Looks like ServiceWorkerStorage doesn't implement ServiceWorkerVersion::Observer anymore. Bug: N/A Change-Id: I39852d7a41686863f5c1a48b6eb058362982a85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866224Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707240}
-
Sam Maier authored
I manually tested that 1013972 was fixed. Bug: 1013972 Change-Id: If93c5a8e0486599060efb0b8d6b116f7082c4e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864565 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#707239}
-
Ricky Liang authored
The h264 and vpx software encoder implementations the MediaRecorder uses only support I420 as the input pixel format, so we need to explicitly convert the GpuMemoryBuffer video frame for them. The software encoders mainly serve as a fallback mechanism and in most cases the hardware encoders would be used instead. Bug: 982201 Test: blink_unittests Test: Disables hardware video encoder in chrome://flags and verify that the recorded videos in Chrome camera app are correct. Change-Id: I76942d2681f9e3ab30c2502a24c2332f3c236bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846423 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#707238}
-
Makoto Shimazu authored
This reverts commit 23fa6714. Reason for revert: Caused a regression around the port forwarding in Android due to wrong conversion. Let me revert this first to unblock beta release. Original change's description: > Convert base::Bind to base::Bind{Once,Repeating} in content/browser > > This CL converts base::Bind to BindOnce or BindRepeating, and also changes > relevant base::Callbacks or base::Closures to appropriate types. > > This CL is split from https://crrev.com/1831621. > > This CL was uploaded by git cl split. > > R=yangguo@chromium.org > > Bug: 1007760 > Change-Id: Id6da42c61527457fcb365f49ce3561bc0fce3399 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849542 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Auto-Submit: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705069} TBR=yangguo@chromium.org,shimazu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1007760, 1014376 Change-Id: Iadb6008679b5ccfc6df8591f8bda3c9eb922d739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866339Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707237}
-
Robert Ogden authored
The current histogram buckets (http://shortn/_CI2Q9eMaXS) are too wide to be helpful. This makes them exponential, with the success metric being 50 buckets over 30 seconds and failure 50 buckets over 60 seconds. Change-Id: Iae667ff36dca5ce402bf87447166174ba9e31a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867293 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#707236}
-
