- 14 May, 2020 40 commits
-
-
Tibor Goldschwendt authored
The logging flow for simple doodles looks as follows: 1. On image load -> fetch image_impression_log_url and download additional params for later logging. 2. On image click -> open on_click_url with image_click_params from 1. appended. 3. On doodle share -> ping gen_204 url with share_id from 1. appended. For animated doodles the flow is: 1. On CTA load (i.e. preview image) -> same as 1. for simple doodles. 2. On CTA click -> ping interaction_log_url from 1. 3. On animation load -> same as 1. but with animation_impression_log_url. 4. On animation click -> same as 2. for simple doodles but with image_click_params from 3. here. 5. On doodle share -> same as for simle doodles but with share_id from either 1 or 3 depending on when sharing. JS drives the logic for these flows since it owns the required state. However, JS cannot make the network requests directly since it lives in a WebUI process. Therefore, JS delegates networking to the browser process through mojo. Fixed: 1070762 Change-Id: I786a9cf977d7bce978ab9ccfa4d6e9b00c616656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200420Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769039}
-
Nicholas Hollingum authored
panel_rotation() is the difference between the buffer and hardware's scanlines as opposed to rotation() which is the "logical" uprightness of the screen. This matters on devices where the logical orientation does not match the hardware orientation. There are two cases where exo uses the wrong rotation which means: - cursor images are drawn in the wrong orientation - the screen orientation is reported incorrectly to clients. This is ~fine~ until you start using applications which refuse to handle events which are "offscreen". We model this CL after changes in crrev.com/c/1911344. Bug: 1081085 Change-Id: Ia3a01b8dd5d745dbdb6a5b2220cae44061088a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195341Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#769038}
-
John Abd-El-Malek authored
The removal of the UI->IO thread hop in r768133 seems to cause some tests in the PFQ to flake. Add extra hops (now UI->IO->UI) to avoid flakiness in the PFQ. This should be reverted once the test issue is tracked down. Bug: 1082298 Change-Id: I64e3e27461a73bf269c8193d9d5c7a65cb3a072a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202671 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#769037}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ce925b4cbe60..fecd1afcb287 git log ce925b4cbe60..fecd1afcb287 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 timvp@google.com Vulkan: Move necessary members from ProgramState to ProgramExecutable 2020-05-14 timvp@google.com Update Program[Pipeline]State to hold a ProgramExecutable Pointer 2020-05-14 ianelliott@google.com Vulkan: Create a test to debug Android pre-rotation Created with: gclient setdep -r src/third_party/angle@fecd1afcb287 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@chromium.org Change-Id: I4de870579b5bc5e895341756dcb99becd715e4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202485Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769036}
-
Ionel Popescu authored
Scenarios that we are interested in: - how often is the popup exceeding the owner window bounds - how often does the popup receive tap/mouse down/ mouse wheel events outside the owner window bounds This CL has no user visible behavior changes. Bug: 1066241 Change-Id: I0f88e75b452a2c7490045b31f0b9e773314a2d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200425 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#769035}
-
Raymond Toy authored
copyFromChannel can produce overlapping areas when the source array is the same as the channel data array. Use memmove instead of memcpy to handle this case. copyToChannel has the same issue, so fix that too. Manually tested the repro case with a local asan build. The issue no longer reproduces. Bug: 1081722 Change-Id: I168ef418fccf45646bb4d8a01c22cecfbd5da20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202394Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#769034}
-
Hirokazu Honda authored
We want to be able to run a VA-API driver in Constant Quantization Parameter mode for vp9 encoding. VaapiVideoEncodeAccelerator needs to tell VP9Encoder about the bitrate control. This CL adds enum of BitrateControl in AcceleratedVideoEncoder interface so that VaapiVEA can configure vp9 encoder with the enum. Bug: 1060775 Test: video.EncodeAccel.* Change-Id: I16db7bafcee0642e71bc36ef3e2bce257e33c7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159669Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#769033}
-
Matt Swartwout authored
This was causing some -Wshadow compiler errors in Chromecast builds. Change-Id: I2ebdd629e3472302db5d4d05e340c89223d690eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197490Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Auto-Submit: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#769032}
-
Chris Hamilton authored
This will be used by upcoming frame and process priority logic. BUG=1077217 Change-Id: I817a8af44306598d1294068042b924c7832d434a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199397 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769031}
-
Erik Jensen authored
Bug: 1082919 Change-Id: Ia90e3bd3d428d941842147dcb5dce8440f16b5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202389 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#769030}
-
Robert Ogden authored
The started NSPs are just normal for now, but thru future CLs will be migrated over to a privacy-preserving context. Adds a command line flag to gate this functionality during development. Bug: 1082505 Change-Id: I7c4095787c12c210a4fdcb00b553ee69f28dcd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200176 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#769029}
-
Vasiliy Telezhnikov authored
This CL modifies MediaCodec path to get use real coded_size and visible_rect in VideoFrame instead of relying on texture matrix transform. To achieve this we utilize similar approach as in YCbCrHelper. Helper is renamed to FrameInfoHelper. During CreateVideoFrame VideoFrameFactoryImpl will check if it has cached FrameInfo for current visible size that comes from media codec. If not it will post task to FrameInfoHelper to get it. To avoid unnecessary frame renders FrameInfoHelper also does similar caching. If info is not cached it will Render frame early to get the info. To be able render frame before creation CodecImage and SharedImageVideo the render logic is extracted from CodecImage to CodecOutputBufferRenderer. Bug: 1076564 Change-Id: I5baac124f46d78a89ae4300d5a01a9b9ab04af2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196922Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#769028}
-
Travis Skare authored
This makes it consistent with our other vector icons in the dialog, which were vectorized. Does not modify other uses of the print icon. Change-Id: If76259efef1d8b5e50fa204fd6ea3ba17a18efc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194941Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#769027}
-
Kevin McNee authored
Doing so is a DEPS violation. We now move the contents into a portal in the caller and then pass the portal. Bug: 1076947 Change-Id: I2aab34bceaf786c65b5b3521ecce7147a9f51d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202528 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769026}
-
Liquan (Max) Gu authored
Context: Devguides suggest against doing any concrete things in constructor since it's harder to test and prone to reading confusion. Before: IsReadyToPayServiceHelper did the service binding in the constructor. After: IsReadyToPayServiceHelper did the service binding in query(). Change: * Move the service binding part from constructor to query(). Change-Id: Ibbc9adae00e64e01cbf1fe15298736b3d83d7950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198651 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#769025}
-
Devlin Cronin authored
Add a specialization of the settings overridden dialog for extensions that override the New Tab Page. This involves adding a generic controller for the settings overridden dialog to handle extension- controlled settings (which will be re-used for additional controlled settings) and an NTP-specific provider to handle the NTP bits. Add unit tests for both the NTP-specific provider and the generic extension-controlled settings dialog controller, and a UI browser test for the NTP overridden dialog. Currently, this is only used in testing; it is not hooked up to any production codepaths. Bug: 1079364 Change-Id: I1f360bd603b6514fb492acc0b065d1b6d5236a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186642Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769024}
-
Preethi Mohan authored
This is follow up to the CL https://chromium.googlesource.com/chromium/src.git/+/c26b06c7500c2ecf63b138ed893edf3c89faad77 Bug: 1050838 Change-Id: I48ce1674a96ede2bfc9b66293195c7eaac6b5e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194483Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#769023}
-
Chris Harrelson authored
Bug: 1008483 Change-Id: Ic8f47c6038fa8cc0a375731b179542fd56ba1eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202681 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769022}
-
Hazem Ashmawy authored
Make AwNonembeddedUmaRecorder an implementation of the base.metrics.UmaRecorder interface and set it as a delegate in the CacheUmaRecorder during the startup of WebView non-embedded process. This will make using RecordHistogram class possible inside WebView non-embedded processes. Bug: 1001185 Test: out/Debug/bin/run_webview_instrumentation_test_apk Test: out/Debug/bin/run_android_webview_junit_tests Change-Id: Ia324f30f45a334a61bf46a1bf64d69715ad7118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176771 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#769021}
-
Wan-Teh Chang authored
Override operator<< of struct StaticColorCheckParam to std::ostream to make the error messages of test failures human-readable. Bug: 960620 Change-Id: Ia4da2578485cdfdcd0078003ca25d52e68d8321f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196923Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#769020}
-
Steven Valdez authored
This updates Trust Token in Chromium to use experiment_v1, which updates the SRR structure and changes the curve to P384, along with other optimizations. Change-Id: I654b5b487b4d9005771979f94d37e8b4a54babbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198649 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#769019}
-
Peter Kotwicz authored
This CL fixes WebAPK share target POST which regressed as a result of https://chromium-review.googlesource.com/c/chromium/src/+/2148380 BUG=1082895 Change-Id: Ib2ab90d70e11d82ede07a67186e8b2a865934783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203017 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#769018}
-
Robbie McElrath authored
This CL hooks up a skeleton Site Settings UI, which for now just shows a single string. The focus of this CL is hooking up the RemoteFragment. Hooking up the UI Fragments themselves will be in a followup. Bug: 1049683 Change-Id: Ie9d79d928655067565a90ef96b5cc49dba591c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199986Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#769017}
-
Tim Song authored
BUG=1073536 Change-Id: If5988a47ff11f0bc15021c558039c3465e1a3b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198602 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#769016}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/db592f10d318..ae9bd93fb5cc git log db592f10d318..ae9bd93fb5cc --date=short --first-parent --format='%ad %ae %s' 2020-05-14 bsheedy@chromium.org Ignore .dat files when pulling CrOS dumps Created with: gclient setdep -r src/third_party/catapult@ae9bd93fb5cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1082255 Tbr: nuskos@google.com Change-Id: If37c8a0bdf66b6b1a37a7ddecb86e35c4c883986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769015}
-
Chris Lu authored
Bug: 1071914 Change-Id: Ifd26c511e4011d4d14b01839d294259552b2ad0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199692Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#769014}
-
Zentaro Kavanagh authored
- Fixed some #includes - Used default where appropriate - Used auto where appropriate Bug=None Test=None Change-Id: I870d9ba95f5e65bb4f6846b308aa0e25e842bbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202962Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#769013}
-
Moe Ahmadi authored
Bug: 1079040 Change-Id: I913f809e0906858cd925f38c628d99d0f7d6758c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202504Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769012}
-
yilkal authored
This cl normalizes a url before checking if it has been whitelisted. This is required because a smart user can circumvent the blocking page by using a whitelisted url in the query part of a url that the user wants to visit. Bug: 1082817 Change-Id: Iba1a09c6870582bfc4af77a3f5975c41c546705f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199994Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#769011}
-
Jacques Newman authored
This change allows us to defer sending events to improve performance during the initial page load. EventScheduleMode determines if we schedule events with a delay or not. EventScheduleStatus replaces ack_pending_, and tracks what state we are in with regard to event scheduling. This is based on: CL 1691523: Large batch accessibility event processing during page load Bug: 976849 Change-Id: I74cd5f31102199f8c5752e0ef5d0eb623fdbd9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123310Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#769010}
-
Garrett Beaty authored
Bug: 1056428 Change-Id: If9dc68ce95b45a79faa2992294d46d53e252293b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197601 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#769009}
-
Ghazale Hosseinabadi authored
This is the last CL to remove NOTIFICATION_EXTENSIONS_READY_DEPRECATED. Bug: 411566 Change-Id: I69937ae19ed42e259509ac0587d5285a33cb56b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199874Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#769008}
-
Wei-Yin Chen (陳威尹) authored
Add "quick" and "pinned" modes to Finch parameter "omnibox_scroll_mode" to make the omnibox in Start surface omnibox-only variation more visible. The default mode requires scrolling all the way to the top for the omnibox to re-appear. "Quick" mode makes omnibox re-appear when scrolling up anywhere in the recycler view. "Pinned" mode makes omnibox pinned at the top and never hide. Bug: 1082664 Change-Id: I4b593019940a9c7d51ce9a5a1ee5df6dda180502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199934 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#769007}
-
Xiaohui Chen authored
Bug: b:154268518 Change-Id: I50639eb364d74c3c7cfc42842b85dd915850015f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199993Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#769006}
-
Daniele Castagna authored
This reverts commit a79f5b3b. Reason for revert: Enabled the optimization on the wrong platforms and it causes flickering (crbug.com/1082947) Original change's description: > viz: Re-enable ignore_undamaged on platforms using GL buffer queue > > SurfaceAggregator has an option to output only the quads that > intersect the damage rect computed by SA itself. > > This optimization was disabled on devices with HW overlays or where > the renderer might expand the damage, since SA would not know the > final damage rect. > > This CL re-enables the optimization on devices where we can estimate > a bounding rect of the renderer expanded damage. > > This is achieved by asking to the renderer for a bounding rect that > represents the maximum area that can be expanded. > SurfaceAggregator will aggregate the boundingrect union the damage. > > The damage on the root render pass will be unchanged, so that HW > overlays damage computation won't be affected. > > > Bug: 1077210 > Test: viz_unittest (new test and Display tests) > Change-Id: Ie94d1f09923959e2e025845f89a9b3eae759a64a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179763 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768572} TBR=dcastagna@chromium.org,sunnyps@chromium.org,kylechar@chromium.org Change-Id: Id7453435c8b50981e5b7752855e3fd2190076676 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203219Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#769005}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/053213d049fa..176bf641480b git log 053213d049fa..176bf641480b --date=short --first-parent --format='%ad %ae %s' 2020-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@176bf641480b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ice51f7ccc42785e85fb2a9647515174c4b62f942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202488Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769004}
-
Wenyu Fu authored
Add two more metrics to track the number of times HomepagePromo is seen until user take action or dismiss the promo. Bug: 1068831 Change-Id: Iddb9777ef58289d4a97708dd1c61b30f316a056a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199931Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#769003}
-
Andrew Walbran authored
This is a licensed third-party controller for the Nintendo Switch. It doesn't support vibration, and doesn't report valid calibration data for the joysticks so default values are used instead. BUG=1077889 Change-Id: If5fdecf5a9a3d92ffd85ac67a6c2ccd438c8428c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188611 Commit-Queue: Andrew Walbran <qwandor@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#769002}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e272a6a2895..446c499de196 git log 8e272a6a2895..446c499de196 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 tmathmeyer@chromium.org Match some color schemes to the other parts of devtools Created with: gclient setdep -r src/third_party/devtools-frontend/src@446c499de196 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id98f594e3cbaf5af9265a6379e1af21c9e09903b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769001}
-
Moe Ahmadi authored
Adds the ability to render the *full* version of autcomplete matches (including entities) and handle interactions with them such as: 1. showing and hiding matches in a suggestion group. 2. removing a match using the RHS remove button. 3. navigating to a match via click. 4. updating the realbox icon/favicon as the match selection changes. Bug: 1041129 Change-Id: Iee5d8192cd0b2b122a4c9b22a7860278fa5d37be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199361 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769000}
-