GitLab

The final if condition in
PushMessagingServiceImpl::DidGetNotificationsShown is always true.

This patch replaces the if with DCHECKs to make the code more
understandable.

Review URL: https://codereview.chromium.org/1086393005

Cr-Commit-Position: refs/heads/master@{#326811}

BUG=480999

Review URL: https://codereview.chromium.org/1109553002

Cr-Commit-Position: refs/heads/master@{#326810}

These are no longer part of the mojo repo, but we want to persist them
when rolling to chromium.

This also brings over the small utils module that the script
depends on, with some minor adjustments. Rather than taking
the chromium path as an arg and inferring the mojo path, we
now do the reverse.

BUG=None
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1102043002

Cr-Commit-Position: refs/heads/master@{#326809}

Add new helper method to construct an HistoryDatabaseParams for a FilePath
on iOS. Constants used for DownloadInterruptReason are based on the values
from content/public/browser/download_interrupt_reasons.h.

BUG=370850

Review URL: https://codereview.chromium.org/1106763002

Cr-Commit-Position: refs/heads/master@{#326808}

This CL adds a connection finder class. The connection finder scans for
Bluetooth Low Energy devices advertising a given target service.

The current version only works when the remote device advertising the
target service is sending all its primary services UUID.

BUG=479673
R=msarda
TBR=tengs

Review URL: https://codereview.chromium.org/1094273003

Cr-Commit-Position: refs/heads/master@{#326807}

BUG=none

Review URL: https://codereview.chromium.org/1101243002

Cr-Commit-Position: refs/heads/master@{#326806}

Export kTestDownloadInterruptReason{None,Crash} and use them in
history_unittests.cc to remove dependency on content::DownloadInterruptReason.

Remove unused #includes.

BUG=370850

Review URL: https://codereview.chromium.org/1107683003

Cr-Commit-Position: refs/heads/master@{#326805}

This patch removes sharing tiles from tilings. Previously, tiles
that were not invalidated were shared between the pending and
the active trees. With this patch, tiles that are exist on the
active tree and are not invalidated are not created on the pending
tree, resulting in fewer overall tiles. This improves performance
of updating and managing tiles.

Also, this patch opens up opportunities for a lot of code clean
up that can otherwise be confusing when two trees are involved.

R=danakj, enne

Review URL: https://codereview.chromium.org/1051993002

Cr-Commit-Position: refs/heads/master@{#326804}

Fixes some

[chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition.

warnings and also makes the code more correct.

BUG=303818,467287
TBR=avi

Review URL: https://codereview.chromium.org/1103713003

Cr-Commit-Position: refs/heads/master@{#326803}

BUG=470993

Review URL: https://codereview.chromium.org/1090413005

Cr-Commit-Position: refs/heads/master@{#326802}

Yeah, I forgot to update test in the previous patch :/
https://chromium.googlesource.com/chromium/src/+/0c71fc50716dcf2fef839bde83ef09287c64202b
(which changed the element to which show-spinner class was applied)

BUG=479757
TEST=Run the test locally

Review URL: https://codereview.chromium.org/1105783002

Cr-Commit-Position: refs/heads/master@{#326801}

Summary of changes available at:
https://chromium.googlesource.com/chromiumos/platform/system_api/+log/beb5547..42cdfaa

BUG=407773
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/1088093009

Cr-Commit-Position: refs/heads/master@{#326800}

Revert of Take GetCharacterFromKeyCode() out behind the barn. (patchset #4 id:60001 of https://codereview.chromium.org/1072193004/)

Reason for revert:
MenuControllerMnemonicTestMnemonicMatch.MnemonicMatch failure in http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/32987
https://code.google.com/p/chromium/issues/detail?id=480638

BUG=480638,444048

Original issue's description:
> Remove GetCharacterFromKeyCode().
>
> Remaining uses of GetCharacterFromKeyCode() are replaced with
> DomCodeToUsLayoutMeaning() to make explicit that the mapping uses a
> fixed US English layout and not the user's current layout, and to use
> ui::DomCode in preference to the legacy Windows-based ui::KeyboardCode.
>
> BUG=444048
>
> Committed: https://crrev.com/121b8680676123f617ebc69770cbb114c030fbd3
> Cr-Commit-Position: refs/heads/master@{#326553}

TBR=sadrul@chromium.org,wez@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444048

Review URL: https://codereview.chromium.org/1085733007

Cr-Commit-Position: refs/heads/master@{#326799}

Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) in the following directories: chrome/browser/password_manager components/password_manager

BUG=457697

Review URL: https://codereview.chromium.org/1083083007

Cr-Commit-Position: refs/heads/master@{#326798}

It looks like TestGuestViewManager can live in components but it had a bunch of
unnecessary includes. This CL removes those includes.

BUG=444869

Review URL: https://codereview.chromium.org/1090153005

Cr-Commit-Position: refs/heads/master@{#326797}

PushMessagingBrowserTest.PushEventEnforcesUserVisibleNotification
is flaky, because it doesn't wait for RequireUserVisibleUX etc to
finish when it runs OnMessage. This patch fixes that.

BUG=480413

Review URL: https://codereview.chromium.org/1062913005

Cr-Commit-Position: refs/heads/master@{#326796}

The entire code base prefers c++ style casting, but there is
the only occurrence of C++ cast (a static_cast), the rest
of this file is using C-cast style.

So we go the other way round and converted everything from
C to C++ way of casting.

BUG=None
TEST=base_unittests --gtest_filter=MD5*
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1044423007

Cr-Commit-Position: refs/heads/master@{#326795}

V8 dump provider needs to access the isolate to get memory statistics.
When proxy_resolver causes the isolate to switch between threads, the
dump provider cannot access it from the correct thread. This CL adds a
field to IsolateHolder to tell the dump provider if it needs to use a
lock to access the isolate.

BUG=476013

Review URL: https://codereview.chromium.org/1100743004

Cr-Commit-Position: refs/heads/master@{#326794}

XCallbackParameters holds the information about an x-callback request from
another application.

BUG=429756

Review URL: https://codereview.chromium.org/1095203006

Cr-Commit-Position: refs/heads/master@{#326793}

This is part of a suite of four patches:
Part 1: https://codereview.chromium.org/1097383006
Part 2: https://codereview.chromium.org/1099943003
Part 3: https://codereview.chromium.org/1100163002
Part 4: <this>

BUG=475141

Review URL: https://codereview.chromium.org/1056633003

Cr-Commit-Position: refs/heads/master@{#326792}

[ozone] Keep the queue of surfaceless buffers inside gl_surface_ozone and only dispatch them when the page flip ack callback for the previous one has been been called.

We previously had 2 queues, one in gl_surface_ozone one in the platform
display controller. Remove one of them since it shouldn't be necessary.

BUG=

Review URL: https://codereview.chromium.org/1091253003

Cr-Commit-Position: refs/heads/master@{#326791}

BUG=478090

Review URL: https://codereview.chromium.org/1086073006

Cr-Commit-Position: refs/heads/master@{#326790}

The remote command framework requires the remote job implementations
to call the callback asynchronously. Post task to the message loop
of current thread to fix this issue.

BUG=480982

Review URL: https://codereview.chromium.org/1102023002

Cr-Commit-Position: refs/heads/master@{#326789}

This is going to allow testing of permissions changes.

BUG=475141

Review URL: https://codereview.chromium.org/1101153002

Cr-Commit-Position: refs/heads/master@{#326788}

This issue landed here: https://codereview.chromium.org/1097553002/
And was reverted here: https://codereview.chromium.org/1072193012/
Because it failed flaky, due to second profile's history service not being initialized.

This CL relands the original, with a modification line 474 of app_controller_mac_browsertest.mm to call WaitForHistoryToLoad.

BUG=477392

Review URL: https://codereview.chromium.org/1102833002

Cr-Commit-Position: refs/heads/master@{#326787}

The VSyncProvider does not guarantee that the callback is ever called.
On Ozone-GBM, the VSyncProvider relies on CRTC information to determine
when the vsync deadline will occurr. Since we're headless, that
information cannot be use, so the callback will never be called.

BUG=471550

Review URL: https://codereview.chromium.org/1060433002

Cr-Commit-Position: refs/heads/master@{#326786}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2761548..6682798

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1109533002

Cr-Commit-Position: refs/heads/master@{#326785}

BUG=476648,479710

Review URL: https://codereview.chromium.org/1100413002

Cr-Commit-Position: refs/heads/master@{#326784}

Also added a TraceDataEndpoint class that I'm thinking can be used to decouple the creation of the final trace (since there's some special logic in there for adding '{}'s and some specific names like 'traceEvent') from where it gets written. This is used right now by the new BackgroundTracingManager for Slow Reports and Deep Reports, but we could also refactor the existing String and File sinks this way as a follow up CL (WIP here: https://codereview.chromium.org/1002103004/).

Then for Deep Reports we can specify the data sink like so:

TraceController::DisableRecording(
  TraceController::CreateCompressedStringSink(
    TraceController::CreateFileEndpoint(...)));

Review URL: https://codereview.chromium.org/1088673003

Cr-Commit-Position: refs/heads/master@{#326783}

For incremental conversion of iOS code from BrowserContextKeyedServiceFactories
to BrowserStateKeyedServiceFactories, iOS uses cross-dependencies between both
types of factories.

This CL had two virtual methods to KeyedServiceBaseFactory to convert a context
to the correct type (content::BrowserContext or web::BrowserState) and back so
that we can have BrowserStateKeyedServiceFactories registered into a
BrowserContextDependencyManager (temporary).

Implement the method in all derived classes and refactor the implementation
of GetAssociatedPrefRegistry that no longer needs to be virtual.

BUG=459020,478763

Review URL: https://codereview.chromium.org/1090373003

Cr-Commit-Position: refs/heads/master@{#326782}

BUG=

Review URL: https://codereview.chromium.org/1076443002

Cr-Commit-Position: refs/heads/master@{#326781}

In cases where a SpecialStoragePolicy is set, the channel id store could still
incorrectly persist some newly-added IDs to disk if their writes did not commit
before the store was destroyed.  This CL fixes the bug by forcing a commit of
all pending writes before issuing any policy-mandated deletes.

BUG=
TEST=

Review URL: https://codereview.chromium.org/1015233002

Cr-Commit-Position: refs/heads/master@{#326780}

I forgot the WebAudio case when I increased the silence lead-in;
increase that time by five seconds also.

BUG=480798,477653

Review URL: https://codereview.chromium.org/1105853002

Cr-Commit-Position: refs/heads/master@{#326779}

Cr-Commit-Position: refs/heads/master@{#326778}

BUG=470746,479171
TEST=manual

Review URL: https://codereview.chromium.org/1063753004

Cr-Commit-Position: refs/heads/master@{#326777}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb3d77a..2761548

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1093973003

Cr-Commit-Position: refs/heads/master@{#326776}

Because base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/1092923006

Cr-Commit-Position: refs/heads/master@{#326775}

The CL does the following:

1. Replace GuestViewManager::FromBrowserContext with GuestViewManager::CreateWithDelegate.
2. Rename GuestViewManager::FromBrowserContextIfAvailable to GuestViewManager::FromBrowserContxt.
3. Creates a GuestViewManagerDelegate interface and ExtensionsGuestViewManagerDelegate.
4. GuestViewManager is created with a particular delegate implementation.
5. GuestView permission checks and registration is moved to the ExtensionsGuestViewDelegate.
6. owner_extension_id() is renamed to owner_host().

After this patch the following classes can be moved to Components (once GuestViewEvent is decoupled from EventRouter):

1. GuestViewManager
2. GuestViewManagerDelegate
3. GuestViewBase
4. GuestViewMessageFilter
5. GuestView

BUG=444869
TBR=noms@chromium.org for chrome/browser/profiles, nkostylev@chromium.org chrome/browser/chromeos/login, thestig@chromium.org for chrome/browser/printing.

Review URL: https://codereview.chromium.org/1066563006

Cr-Commit-Position: refs/heads/master@{#326774}

Packed relative relocations do not currently participate in
relocation of shared RELRO pages into a service process's load
addresses.  This undermines RELRO sharing, by reducing the
number of swapped RELRO pages (often to zero).

Fix by processing packed relative relocations a second time when
relocating shared RELRO pages.  Also, tidy up and rationalize
some duplicated code through use of templates.

BUG=385553

Review URL: https://codereview.chromium.org/1099253002

Cr-Commit-Position: refs/heads/master@{#326773}

https://folio.googleplex.com/login-m44/Redlines

BUG=478449
TEST=manual

Review URL: https://codereview.chromium.org/1100623003

Cr-Commit-Position: refs/heads/master@{#326772}