GitLab

Make sure there is no text output when converting from PDF to PS for
text with size 0.

BUG=767343,827748

Change-Id: Id788b1f936d4f97b2201b7171a756a7ec2892bf1
Reviewed-on: https://chromium-review.googlesource.com/989299
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547779}

We probably already have enough crash reports from this that it won't
be useful to keep around, and there are good reasons not to keep uses
of dump-without-crashing around for too long.

Bug: 824024
Change-Id: Id02cd3eb11f436559b409df484ec204bfe6312aa
Reviewed-on: https://chromium-review.googlesource.com/991464Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547778}

This is to keep up to date with the logic change that the DBus service
uses. The logic has changed to use hard coded release version and
channel due to a bug in Finch.

BUG=chromium:800120
TESTED=manually tested.

Change-Id: Ic5c33d97c2100592732df4a0a14ab744197ec377
Reviewed-on: https://chromium-review.googlesource.com/987100Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547777}

Add a developerPrivate API function to install a file that was dragged
and dropped on the calling web contents, and add tests for the same.
This will allow us to move the MD extensions page away from using
chrome.send for this functionality.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id2b4f5417a94c330c516d4eb1432c59c89c31e32
Reviewed-on: https://chromium-review.googlesource.com/981119Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547776}

Recent regression from 1796079a

Bug: 827844
Change-Id: Ia29d752c0144d60e5e0fe74d6170671412375f0d
Reviewed-on: https://chromium-review.googlesource.com/991409Reviewed-by: Joy Ming <jming@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547775}

bustamanate@ reports occasional hanging on tests that use the
emulation server. This CL adds a timeout to ensure that a test
run doesn't totally hang because of a flake here.

Bug: 823776
Change-Id: I28bc040be9f9ae606f6b75481d2bf8dc21cc6957
Reviewed-on: https://chromium-review.googlesource.com/993272
Commit-Queue: Robert Ogden <robertogden@google.com>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547774}

BUG=827329

Change-Id: I3ae863360df1b0374e367c094ca2c0d724c615c9
Reviewed-on: https://chromium-review.googlesource.com/986740Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547773}

This Cl annotates parameters to the SearchResult ctor. It only adds
comments. There's no logic changes.

Bug: None
Change-Id: Icb625ce10e6fb61216250c96e62057e1d7c9091b
Reviewed-on: https://chromium-review.googlesource.com/991397Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547772}

Allow extended mouse buttons to be injected via the automation code.

BUG=680741

Change-Id: I2a9936e813abf9e5d0d5d3ee6dc98d44477f47f5
Reviewed-on: https://chromium-review.googlesource.com/986469
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547771}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df968af49923..5e34303e0ea1

$ git log df968af49..5e34303e0 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib5275c5feee22740503048f4459e9ec282dd0145
Reviewed-on: https://chromium-review.googlesource.com/992882Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547770}

This CL previously landed as
https://chromium-review.googlesource.com/c/chromium/src/+/842306
It was reverted because TabLifecycleUnits were not always
destroyed when tabs were closed, which caused invalid memory
accesses. This was solved by
https://chromium-review.googlesource.com/c/chromium/src/+/980587

TabManager discards tabs, but also ARC processes.
LifecycleUnit is an abstraction to help us having one
code path for all discards.

TBR=chrisha@chromium.org,thestig@chromium.org

Bug: 775644
Change-Id: Ib7f3dfd8b7e9b43ad75020c65e12d94229ba1a07
Reviewed-on: https://chromium-review.googlesource.com/980742Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547769}

This CL adds extra space above the search controls to make vertical
padding symmetric.

Screenshot: https://imgur.com/a/Txjbq

Bug: nonw
Change-Id: I1d8151a8320897c40b621f32d8c6960dab8d977b
Reviewed-on: https://chromium-review.googlesource.com/981174Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547768}

Change-Id: Idc2861dd0880697c385bf5b13cd48fd04f995a49
Reviewed-on: https://chromium-review.googlesource.com/982617
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547767}

The origin view location is now communicated via NamedGuides.

This is patch 1 of a 3-way patch.

Bug: 805123
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I44c595341907b27f81a58b02895746c6cf284250
Reviewed-on: https://chromium-review.googlesource.com/981777
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547766}

Bug: 800033
Change-Id: I53c2b05a204f30b187efa4b703525c76a5a9dfb9
Reviewed-on: https://chromium-review.googlesource.com/940331
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547765}

Its pool's got 30 bots. Should hopefully be enough for 50% of a
compile-only bot.

Bug: 731962
Change-Id: I7d27a8edf66170442ec6fcc66575e83ee355f9c4
Reviewed-on: https://chromium-review.googlesource.com/993154Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547764}

This is the first translation screenshot to be used by
http://go/chrome-translation-screenshots. This CL adds the SHA1
hash of the actual image which is stored in the Google Cloud
Storage bucket at gs://chromium-translation-screenshots

The screenshot can be downloaded using the gsutil tool like so:
gsutil cp gs://chromium-translation-screenshots/378650e81625e476126a1a3d4b6ff559df54ef7c ~/translation.png

Bug: 814897
Change-Id: I95bff8b6ac41be48a13212ad2bc9b4dcd5c4518b
Reviewed-on: https://chromium-review.googlesource.com/976950Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547763}

The |if| statement's condition is always false, since |level| is set to
|inline_box->BidiLevel()| in L165.

Note: The code was originally introduced in crrev.com/edfe20, which
already contains this redundant branching.

Bug: 771398
Change-Id: If83f178b8ab91f15fcc7176e429541e69a681b15
Reviewed-on: https://chromium-review.googlesource.com/991604Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547762}

https://chromium.googlesource.com/breakpad/breakpad.git/+log/ac4a549e29fb..adcc90ddb8c9

$ git log ac4a549e2..adcc90ddb --date=short --no-merges --format='%ad %ae %s'
2018-04-02 thestig Linux: Write out si_code for SIGBUS exceptions.
2018-03-27 tikuta Add missing header for free function
2018-03-09 ted Allow minidump_dump to print module lists that would normally be rejected for being too long.
2018-02-23 bratell Fixing incorrect include guard (missing #define)
2018-01-31 lv Fix Travis build by running tests as root
2018-02-02 adamharrison Fix crash when an NSException is thrown.

Created with:
  roll-dep src/third_party/breakpad/breakpad

Change-Id: I22af38b45e0526afc5539a05d67d2795589535ec
Reviewed-on: https://chromium-review.googlesource.com/992995Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547761}

Using wpt-import in Chromium 02de1dcf.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15340

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams

TBR=ajuma

No-Export: true
Change-Id: I77a008c5077e22979fc93d487960dd93cbe8d0e6
Reviewed-on: https://chromium-review.googlesource.com/992692
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547760}

Updates the gn args --list command with an additional --json flag, which
emits the same information as the normal --list command but in json
format.

Intended to be used to generate structured documentation for GN build
arguments. The --markdown output is nice, but we want to do more
processing than that to get it into good shape to integrate with our docs.

Also updates the GetContextForValue function to get the file and the
line number separately, rather than as one string, and updates the
callsites with the new parameters.

Change-Id: Id1240c37f835a18a12a6e4f5be58b9f8c7a663d1
Reviewed-on: https://chromium-review.googlesource.com/978423
Commit-Queue: Julie Hockett <juliehockett@google.com>
Reviewed-by: Roland McGrath <mcgrathr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547759}

The problem was the constructor was posting a task to a different thread, which could execute before the constructor returns and a reference is held.

This was seen in
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ASan_LSan_Tests__1_%2F44439%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FMSE_ExternalClearKey__x2f_EncryptedMediaTest.Playback_VP9Video_WebM_Subsample__x2f_0%2F0

Bug: 825242
Change-Id: Ib851536adc57bfab14748e1f7324b143aff55033
Reviewed-on: https://chromium-review.googlesource.com/992876Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547758}

Instead of doing an assignment within one of the expressions, just use the
constant being assigned to. This also fixes a warning produced by GCC:

    ../../chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc: In function ‘void {anonymous}::RecordTokenChanged(const string&, const string&)’:
    ../../chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc:95:16: warning: operation on ‘transition’ may be undefined [-Wsequence-point]
         transition =
         ~~~~~~~~~~~^
             (new_token ==
             ~~~~~~~~~~~~~

              MutableProfileOAuth2TokenServiceDelegate::kInvalidRefreshToken)
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 ? TokenStateTransition::kRegularToInvalid
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 : transition = TokenStateTransition::kRegularToRegular;
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: I8ea1dbd6ca499f3ba13a36dce41e152dc8263917
Reviewed-on: https://chromium-review.googlesource.com/992323Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#547757}

Scheduler classes are being renamed as part of scheduler
architecture refactoring.

Bug: 826203
Change-Id: I1f59849cdb83bbc861cc3110b87d4f0bec901761
Reviewed-on: https://chromium-review.googlesource.com/989528Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547756}

Before this change, when the user clicks on the button to dismiss the
Extension Popup, the popup would dismiss and destroy. Next, the
incoming mouse-up would note that the popup is already gone and show
the popup.

We want the popup to stay closed if it was dismissed by clicking the
action button.

The Views Browser doesn't have this problem because MenuButton tracks
the last time the locked state was released and suppresses any
activation if it occurs too soon.

This change simply carries similar logic from Views MenuButton to
Cocoa BrowserActionButton.

BUG=825866

Change-Id: I089f0ab8658277ae8cbf71e2813e62aeb3c5505f
Reviewed-on: https://chromium-review.googlesource.com/991596Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547755}

MediaStreams added to an RTCPeerConnection using the legacy addStream()
API is wired up such that the RTCPeerConnection is informed when tracks
are added or removed from the MediaStream so that the corresponding
sender can be added/removed from the PC.

OnStreamAddTrack/OnStreamRemoveTrack was wired up to call addTrack() and
removeTrack(), the crash occurred if these operations were to throw an
exception even though we just want to suppress any exceptions thrown.
The ExceptionState is updated to allow an exception to be thrown before
being cleared. This fixes the referenced bug.

Bug: 814139
Change-Id: I7798d7cf43bb71d42b7b8108f40ffba36dc95946
Reviewed-on: https://chromium-review.googlesource.com/992321Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547754}

Bug: 731759
Change-Id: Ied650ef11b381acf050fb606a06670fe78e187de
Reviewed-on: https://chromium-review.googlesource.com/920682Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547753}

Bug: b:77282340
Change-Id: I88ea25128043ec69ec88357f36babfae36fe88fd
Reviewed-on: https://chromium-review.googlesource.com/986921Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#547752}

Bug: 790142
Change-Id: I24385ce8be54b9d36bbbeb87a963aff18818e72d
Reviewed-on: https://chromium-review.googlesource.com/989300Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547751}

The new LocationBarVoiceRecognitionHandler was using Tab's #getActivity
instead of using WindowAndroid's #getActivity. In the search widget,
Tab's getActivity returned null and exited #startVoiceRecognition
early.

This fix just gets the WindowAndroid from the Tab first and then uses
its activity and all is well.

Bug: 828309
Change-Id: I05b68b0228d1c5f962ee1ee2fa23675ccaa5b6db
Reviewed-on: https://chromium-review.googlesource.com/992992Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547750}

Disable this test as it consistently failed on Win10 and Win7.

Tbr: irisu@chromium.org
Bug: 828042
Change-Id: I5366a98999fca0911ae018a94ca479a3e6a308d9
Reviewed-on: https://chromium-review.googlesource.com/992881Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547749}

Currently, on every hover event we are creating a deep copy of the
event for offsetting purpose. Actually this is needed when any of the
(x,y) offset is updated prior to it. If not updated creating a deep copy
for a 0.0f offset is additional overhead for nothing. Hence doing offsetting
only when either x or y offset is non-zero.

Change-Id: I1f39b4058cad217769ea6ba02b7b87c222420fd9
Reviewed-on: https://chromium-review.googlesource.com/989595Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com>
Cr-Commit-Position: refs/heads/master@{#547748}

Bug: 823359
Change-Id: I62707b079f9ee899feb7c624a498c5f16f6fe061
Reviewed-on: https://chromium-review.googlesource.com/988226Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547747}

When a device registers to use the CryptAuth back-end, it must provide
an ID during the enrollment process. Since EasyUnlock was the first CrOS
feature using CryptAuth, this logic was originally implemented as part
of EasyUnlock. At a later point, some of this code was copied to
ChromeCryptAuthService, so there were multiple versions of this code
living in various parts of the code base.

This code is now moved to a single location and is shared among clients.
Implementation is split between a pure-virtual CryptAuthDeviceIdProvider
class living in //components/cryptauth and an implementation which
relies on browser local storage in //chrome/browser/chromeos/cryptauth.
This separation is necessary so that a future CL, which will rely on the
device ID from within //chromeos, will be able to access this code
behind an interface.

Bug: 824568, 752273
Change-Id: I4155d49dbf7ab55afb0245bd595a1c033db68ee2
Reviewed-on: https://chromium-review.googlesource.com/989018Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547746}

Also corrects the scroll distance to fix iPhone X tests.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I516c19f8343eaa21f5dcd9ce4e6e35e1fcd62640
Reviewed-on: https://chromium-review.googlesource.com/991574
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547745}

This test:
  fast/text/international/combining-marks-position.html
passes on Windows but fails on Linux and Mac. It renders Arabic
using LinLibertine, which is a Latin font, and that falls back
to system fallback.

LayoutNG added an expectation to pass at one point where it passed,
probably due to some errors. Now it fails as in the current layout
engine, which is expected.

TBR=drott@chromium.org, atotic@chromium.org, bashi@chromium.org
NOTRY=true

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I93b33c96ed1ead3baa1ec535f86610425ae1fd4c
Reviewed-on: https://chromium-review.googlesource.com/992712
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547744}

Do not create the volume slider on the new media controls
as we don't need it. Also, avoids adding elements to the
DOM that are permanently hidden.

BUG=821961,821414

Change-Id: Ia0e334b6079450d4a3b084371629f6b6ba37176c
Reviewed-on: https://chromium-review.googlesource.com/991293
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547743}

Since the constructor of RTCDTMFToneChangeEvent is exposed,
creating such events with other names than "tonechange" is possible.
No reason to discriminate against such.

Also adds tests for constructor.

Bug: chromium:822799
Change-Id: I4b36f3094acee200dd4200c4d24f6b46e10a06e6
Reviewed-on: https://chromium-review.googlesource.com/992038Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547742}

This test installs a MockNetworkChangeNotifier that starts out in the
disconnected state. It then switches to WIFI and ensures
VariationsService did a request.

BUG=826930
TEST=covered by test

Change-Id: I8d193647689e8f67dfc9674bd81bd0d6da9e056b
Reviewed-on: https://chromium-review.googlesource.com/990728
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547741}

BUG=827748

Change-Id: Id011527d001ffbb70130bfee085e4a21b80c8100
Reviewed-on: https://chromium-review.googlesource.com/989287
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547740}