- 13 Apr, 2018 40 commits
-
-
Devlin Cronin authored
Manifest v1 extensions have been deprecated for a long time. Stop loading these extensions unless a special (existing) commandline flag is present. There are a few straggling tests (which rely on packaged extension resources, like .crx files) that still need to be updated; use the commandline flag (or a runtime variant) in those tests. These will be cleaned up in follow-up CLs. Reland note: This was reverted because of a conflict with https://crrev.com/fef93a84a5b56945d02cada97f4ec886ae34c0e2. This has been fixed. TBRing original reviewers: TBR=lazyboy@chromium.org TBR=pastarmovj@chromium.org TBR=qinmin@chromium.org TBR=stevenjb@chromium.org Bug: 831909 Change-Id: I9141db4a15452c9cd601b279f7880e10a08c0a8c Reviewed-on: https://chromium-review.googlesource.com/1011572Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550632}
-
Ella Ge authored
Remove flaky expectation for layout test virtual/mouseevent_fractional/fast/events/mouse-event-buttons-attribute.html Can't reproduce the failure locally in both Win, Mac and Linux. Bug: 825046 Change-Id: I529606bed85ddc59e09e9937c0b784af51ffdc5a Reviewed-on: https://chromium-review.googlesource.com/992891Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#550631}
-
kylechar authored
This CL implements logic from GLES2CommandBufferStub::Initialize() in InProcessCommandBuffer::InitializeOnGpuThread(). Some differences are not addressed and I've left TODOs instead. Bug: 832243, 811979 Change-Id: I1139a33f594280ea4c17b3a7223391e33bc15ad6 Reviewed-on: https://chromium-review.googlesource.com/1006038Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#550630}
-
Rouslan Solomakhin authored
Before this patch, any iframe could install a Payment Handler by calling `paymentManager.instruments.set()`. This patch checks for the feature policy "payment" before allowing any operations on `paymentManager.instruments`. After this patch, a cross-origin iframe will reject all operations on `paymentManager.instruments` by default. The parent context can explicitly allow the iframe to use the Payment Handler API through feature policy. This can be accomplished via the iframe attribute `allow="payment"`, for example. Note that the same feature policy controls access to Payment Request API as well. Discussion: https://github.com/w3c/payment-handler/issues/281 Spec change: https://github.com/w3c/payment-handler/pull/282 Payment Handlers are behind a flag: chrome://flags/#service-worker-payment-apps Manual test: https://rsolomakhin.github.io/pr/apps/iframe/ Bug: 828948 Change-Id: I0259555692fa0b215d3700c233b3687724e665cb Reviewed-on: https://chromium-review.googlesource.com/1005275 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#550629}
-
Gauthier Ambard authored
This CL fixes the test suite, fixing the test that should pass and disabling the one for the features not yet implemented. Bug: 832638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2138a74a73b18c40ebdee6b22432541d7bc27a91 Reviewed-on: https://chromium-review.googlesource.com/1012104 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550628}
-
Ian Vollick authored
The issues now seem to be resolved. Bug: 832650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Id43bc440805fb4ed74d430ed7384eed78bce289f Reviewed-on: https://chromium-review.googlesource.com/1011678Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550627}
-
rbpotter authored
Bug: 812097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic15ae3735c82875759bf67be8e64bd5beeb7ecb0 Reviewed-on: https://chromium-review.googlesource.com/996301 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550626}
-
Tatiana Gornak authored
This CL implements the wrapper for the POST request to the FCM server. BUG=801985 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibba578f7181920e24b39c633111d47b717eb7bb1 Reviewed-on: https://chromium-review.googlesource.com/911108 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550625}
-
Tommy C. Li authored
This CL tests that double-click triggers unelision of steady state elided URLs with the proper portion selected afterwards. This unelision occurs on the second mousedown. It also tests that triple-click triggers unelision and ends with everything selected. Bug: 797354 Change-Id: I3174242ad5f188ef0808a859a376bc0393a76faf Reviewed-on: https://chromium-review.googlesource.com/1008866 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550624}
-
Xida Chen authored
Right now touch_action_browsertest.cc has two tests only, one for auto which is the default, and one for none. This CL adds more test cases with janky main thread. There is a special test case where touch ack timeout is triggered, which should allow all gesture event. Bug: 772130 Change-Id: Ifabcb8356cb2526ad55313be01e24ea959ab2330 Reviewed-on: https://chromium-review.googlesource.com/1007864Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550623}
-
Devlin Cronin authored
Add an origin access blacklist that takes priority over the origin access whitelist. If both the blacklist and the whitelist match an origin, access is not granted. This will allow us to specify a wildcard whitelist while maintaining a list of exceptions which will be off-limits. Add unittests for the same. Bug: 826946 Change-Id: I651cc1e35d05bf20b8ea6e07f34b4b034c297844 Reviewed-on: https://chromium-review.googlesource.com/1011241Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550622}
-
Alex Moshchuk authored
Changes from original attempt at https://crrev.com/c/999182: - fix flakiness in two additional ChromeOS login tests - fix CSP WPT tests to not depend on ordering between iframe's onload and postMessage - see https://crbug.com/832319. Previously, we sent the IPC to forward a cross-process postMessage immediately. This caused a behavioral difference from the same-process case where the postMessage is always scheduled. Namely, in a scenario like this: frame.postMessage(...); doSomethingThatSendsIPCsToFrame(frame); the IPCs from JS following the postMessage would've been ordered incorrectly, causing |frame| to see their side effects after the postMessage dispatch in the cross-process case, whereas they would be seen before the postMessage dispatch in the same-process case. One example of this is frame.focus(), and another is a frame element onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after a postMessage dispatched from an inline script while the frame was still loading. To resolve these ordering concerns, this CL changes cross-process postMessage to do a PostTask on the sender side before sending the message to the browser process. This improves the current state of the world, but does not yet achieve a perfect match for the IPC ordering in the same-process case - see discussion on the bug. Bug: 828529 Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07 Reviewed-on: https://chromium-review.googlesource.com/999182Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550284} Reviewed-on: https://chromium-review.googlesource.com/1011287 Cr-Commit-Position: refs/heads/master@{#550621}
-
rbpotter authored
Make the close buttons appear again in the Print Preview cr-dialogs. Bug: 827579 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64999ea9e56ba34509040294dc7178c47facadd3 Reviewed-on: https://chromium-review.googlesource.com/1007626Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550620}
-
Emily Hanley authored
Bug: 832081 Change-Id: I9e14993b3a771657cc4d7dfc43ba518f4d345ebb Reviewed-on: https://chromium-review.googlesource.com/1010723 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550619}
-
Gauthier Ambard authored
When reporting an issue, the ReportAnIssue module is taking a screenshot of the page. The popup menu needs to be hidden before taking this snapshot. This CL hides the popup menu before taking the snapshot. Bug: 831136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7e908b04359453cf1f3d790c712435b3d27fa6d2 Reviewed-on: https://chromium-review.googlesource.com/1009745 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550618}
-
Aga Wronska authored
Make frequency of status reports upload a parameter of the StatusUploader to allow easy customization. Bug: 826894 Change-Id: Id37890fb5e65d83bb9877decdc23a5e1b9d09de2 Reviewed-on: https://chromium-review.googlesource.com/1000415Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#550617}
-
Joe Medley authored
Change-Id: I4cacf95b98f3f4dbe17c49f4ae566849cbafc4b1 Reviewed-on: https://chromium-review.googlesource.com/1002658Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550616}
-
Mihai Sardarescu authored
This CL records the following histograms: * Signin.SigninCompletedAccessPoint.WithDefault * Signin.SigninCompletedAccessPoint.NotDefault * Signin.SigninCompletedAccessPoint.NewAccount Bug: 832066 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I42ecf6be254dcf51133d565e90df56ae1f69ef93 Reviewed-on: https://chromium-review.googlesource.com/1010362 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#550615}
-
Mirko Bonadei authored
If Abseil is compiled with -fexceptions ABSL_HAVE_EXCEPTIONS will be defined and Abseil will be able to throw. Since exceptions are forbidden in Chromium's code, this CL removes the possibility to enable them. Abseil automatically sets ABSL_HAVE_EXCEPTIONS here: https://cs.chromium.org/chromium/src/third_party/abseil-cpp/absl/base/config.h?l=207&rcl=f4f0f0e2af28098ac58f8548b13d1a1f46d7c846 Bug: webrtc:8821 Change-Id: I82e19abbe62f332173d977b5ea93f9040232572b Reviewed-on: https://chromium-review.googlesource.com/1012074Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#550614}
-
Mihai Sardarescu authored
This CL records the user actions: * Signin_Impression_FromAvatarBubbleSignin. * Signin_Impression{With|No}Account_FromAvatarBubbleSignin Bug: 819432 Change-Id: Ica6334eb9fbe63ed9db285379095d7a5613b4370 Reviewed-on: https://chromium-review.googlesource.com/1007442Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#550613}
-
Douglas Creager authored
This JSON copy of the data will let us show the current contents of the Reporting cache in the net-internals page. Bug: 829353 Change-Id: I005f642e506d9c70e58c1b5799263931327c4a1f Reviewed-on: https://chromium-review.googlesource.com/996883 Commit-Queue: Douglas Creager <dcreager@google.com> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#550612}
-
Jérôme Lebel authored
Replacing +[UIColor colorWithRed:green:blue:alpha:] by UIColorFromRGB(). It should have been done with: crrev.com/c/995417 Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie8e0c81c0ce351d24fadf20970a08e27d2a02021 Reviewed-on: https://chromium-review.googlesource.com/1012076Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#550611}
-
kylechar authored
Move InProcessContextProvider into viz service directory where it's used. It didn't belong in components/viz/common. Also rename it VizProcessContextProvider to better describe the class and to avoid confusion with the other InProcessContextProvider implementation. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2af04eda873d8b157befe2b277186483f583f266 Reviewed-on: https://chromium-review.googlesource.com/1010605 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550610}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53a115e67e50..54a81e45ddfc $ git log 53a115e67..54a81e45d --date=short --no-merges --format='%ad %ae %s' 2018-04-12 kkinnunen Add support for downloading Windows VS toolchain from a HTTP URL Created with: roll-dep src/third_party/depot_tools BUG=chromium:830569 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I891b5ae2d18128cdd16a03343ea05136c498974c Reviewed-on: https://chromium-review.googlesource.com/1011666Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550609}
-
Hans Wennborg authored
Bug: 828582 Change-Id: I85864722c577268d9c95a0d9c37cf7197b04e5d3 Reviewed-on: https://chromium-review.googlesource.com/1012028Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#550608}
-
David Roger authored
Dice Milestone 2 was enabled by default in CL: https://chromium-review.googlesource.com/c/chromium/src/+/975561 However this is causing issues when signing into Google properties on the web, because the new server endpoint rejects most of the client IDs. This restores the previous behavior. Bug: 829220 TBR: jwd Change-Id: I3d7c22cb10f0d900c8d897369b063ac236f12146 Reviewed-on: https://chromium-review.googlesource.com/1011620 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#550607}
-
Rune Lillesveen authored
If the default font-size changed, and media queries have font relative lengths, then media query evaluations may have changed. Bug: 830119 Change-Id: I912adddcdbd05b729678cff14d16245a35bca3e1 Reviewed-on: https://chromium-review.googlesource.com/1000852 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550606}
-
stkhapugin@chromium.org authored
Modifies the format types passed to the URL formatter in GetURLForDisplay() on iOS to trim after host. Bug: 821801 Change-Id: Ib744a161d0488b5e0f3ee8e0d81947da17bb22cb Reviewed-on: https://chromium-review.googlesource.com/1007079 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550605}
-
Francois Doray authored
The browser/ and renderer/ subdirectories no longer exist in components/task_scheduler_util/. There is no good reason to keep the common/ subdirectories, everything can be moved directly to components/task_scheduler_util/. This is the last phase of the clean up planned in https://crbug.com/810049 TBR=asvitkine@chromium.org Bug: 810049 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If5d000edfd1bd689950ab8f8a6992ecbfbb93c78 Reviewed-on: https://chromium-review.googlesource.com/1005788 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550604}
-
Egor Pasko authored
The strings present in kCommandNames needs to be handled in ExecuteCommands(). Also fix a random typo. There is a not-landed patch to use the batch mode: https://codereview.chromium.org/2112013003/ Due to a bug in this patch the command 3 was never passed to cachetool, and hence this problem was not noticed. Bug: None Change-Id: I0f5dbdf96e0e771b265400f5b87eee356722ccd4 Reviewed-on: https://chromium-review.googlesource.com/1010290Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550603}
-
Kuo-Hsin Yang authored
https://crrev.com/c/980742 replaces EstimatedMemoryFreedKB() with GetEstimatedMemoryFreedOnDiscardKB() which always returns 0. It confuses Chrome OS Tab Manager and all tabs except the front tab are discarded. It's a quick fix to make tab discard work on Chrome OS. Bug: 832517 Change-Id: Ic72be7a7535bf6e0a48a6f6efa9afc28635813c8 Reviewed-on: https://chromium-review.googlesource.com/1011885 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#550602}
-
Maksim Ivanov authored
* Store the challenge-response key information in KeyDefinition; * Support the new challenge-response user key class in the to/from cryptohome protos conversion code. This is preparatory work for implementing the smart card sign-in in Chrome OS. This CL alone is expected to bring no change of behavior. Some more details for the context: This CL is part of effort for allowing signing in via a cryptographic token (e.g. a smart card) instead of a password. The actual secret passphrase (used for protecting the local cached data) isn't shared with the browser anymore. Instead, all structures related to the user's key in the browser memory and in the D-Bus protocol are containing only the *public key information*. When an authorization using such key takes place (e.g., when mounting the user's cryptohome), the cryptohomed daemon will issue a challenge request to the browser, and the browser has to respond with the signature of the challenge. Bug: 826417 Test: chromeos_unittests --gtest_filter=CryptohomeUtilTest* Change-Id: I7ef230a8f9829ffd88e4489338ff84d91466de31 Reviewed-on: https://chromium-review.googlesource.com/1000492 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#550601}
-
Charlie Harrison authored
This will make it less cumbersome to add more tools or add subdirectories. TBR=jochen@chromium.org Bug: None Change-Id: Id6c1a41087ea4a3b9f25b9ea41905149b3580ac9 Reviewed-on: https://chromium-review.googlesource.com/1011683Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#550600}
-
Friedrich Horschig authored
This is the first step of shaping the keyboard accessory into a MVC-component as proposed in the Clank rearchitecture. It only introduces the model and the controller of this component and tests to verify the rudimentary design. The wiring to the view (which technically exists as KeyboardAccessoryView but needs to be restructured as well) will follow in the next CL. Bug: 828832 Change-Id: I791cf4a0a59671c5d674e50a6912d7242350290b Reviewed-on: https://chromium-review.googlesource.com/1007084 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550599}
-
tzik authored
This method should be a const method to be consistent to NowTicks() in base::TickClock, which is also converted to a const method at http://crrev.com/821f0e338ebbe420 Bug: 789079 Change-Id: I6b5c9bcee2d730214298ae7a7136ea6b312ad079 Reviewed-on: https://chromium-review.googlesource.com/1001213 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550598}
-
Gauthier Ambard authored
This CL adds a state to the toolbar button. This new state, "Spotlighted" is used to put emphasis on a button in the toolbar. It can be used to show that the page is bookmarked, or to indicate to which button the popup menu displayed is linked (done in a future CL). Bug: 817752 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I954cb0b26a577212ca8e3d8840b99f5be4aa1a2d Reviewed-on: https://chromium-review.googlesource.com/1000785 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550597}
-
Owen Min authored
Building the protobuf based on Input from extension API: 1) Machine name 2) OS information (x86/x64) 3) OS User 4) Chrome Profile and its extensions/plugins Other information that is stored in Chrome. 1) OS Information (Platform name and its version) 2) Browser version/channel. 3) Current profile ID based on its path 4) All policies affect the current profile. Please note that only one profile will be added into the report. Change-Id: I703ff554932388611c9839473b7dcadcf0cac3c1 Reviewed-on: https://chromium-review.googlesource.com/986946 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550596}
-
Ramin Halavati authored
Disables: WebviewLoginTest.StoragePartitionHandling WebviewProxyAuthLoginTest.ProxyAuthTransfer Bug: 832608 Change-Id: Ie5e2d9c8b0fd99fd3c018a004f8b7b0c567d8c38 TBR: achuith@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1012036Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550595}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/70bb7daa4183..b5d17629393d $ git log 70bb7daa4..b5d176293 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 weigua Add rtanalytics to cras group. Created with: roll-dep src/third_party/chromite BUG=chromium:831250 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib9c500c47360820e455d31ad23024bd67808710e Reviewed-on: https://chromium-review.googlesource.com/1011665Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550594}
-
Kent Tamura authored
"run_benchmark dromaeo" doesn't use this directory. Bug: 829695 Change-Id: I4389a8cf6845c9cb02ac2fc5da0866acfbf6ea52 Reviewed-on: https://chromium-review.googlesource.com/1009343Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#550593}
-