- 07 Aug, 2020 40 commits
-
-
Maxime Charland authored
Subtitles should use the Subheadline Font Style instead of Footnote, which is a little too small. Bug: 1098328 Change-Id: I4ffe669b9709fbd8143d00c1f16a393b723c5160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341172Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#795901}
-
Vasilii Sukhanov authored
Tbr: wenbinzhang@google.com Bug: 1114120 Change-Id: I2618139c009a29558fe87ba549f6de6fb3eac4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341643Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795900}
-
Mark Pearson authored
Bug: 1104960 Change-Id: If70555a29c443d76d8bda8b168930ff881bd726e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340348Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#795899}
-
Alice Wang authored
This CL sets up the sign-in in progress state view once the user clicks on the |Continue as ...| button. Bug: 1102784 Change-Id: I811f195dc11fbd3ad0c2685baa67040ea0120f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339351Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795898}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2cc251fd9b34..045adb564e19 2020-08-07 mtklein@google.com Revert "Reland "Switch GN defs on Mac and iOS to use frameworks, take 2."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I25494b3e463167efb9582a846b02e30303ddd001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795897}
-
Vasilii Sukhanov authored
Tbr: eseckler@chromium.org Bug: 1113964 Change-Id: Ia9df40d1a781403a3ba2bc988a1c4eb559da9ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343034Reviewed-by:
-
Rainhard Findling authored
* Extends the |Settings.SafetyCheck.Interactions| histogram and introduces two users actions for recording when users click the button in the Chrome cleaner child of safety check. Bug: 1087263 Change-Id: I9565c86590277ad641a7562bb1101f1780a7f6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302640Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795895}
-
Dominique Fauteux-Chapleau authored
This reverts commit 92c9e3b1. Reason for revert: Breaks linux-chromeos-rel and linux-chromeos-chrome, see crbug.com/1114140 Original change's description: > OOBE: Restore disabled OobeConfigurationTest tests > > Seems that changes made in recent month made testing code more > stable, so tests are not flaky anymore. > > TEST=run tests with --gtest_repeat=25 --gtest_break_on_failure with > affinity to 2 codes + simulated CPU load on same cores > > Bug: 997685 > Change-Id: I687e0191bddfe569d5a9fcdf60761c66024e7476 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339989 > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795872} TBR=antrim@chromium.org,rsorokin@chromium.org Change-Id: I1d820d0b038f2b5bbf536b916475ff3261f11f24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997685, 1114140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343224Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#795894}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e69d5b2de943..56f14dabfe99 2020-08-07 hjd@google.com Merge "ui: Split listTracks into it's own file" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4ee64a2e35e868e52b2ac2156748b6133c0db120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343049Reviewed-by:
-
Alexei Svitkine authored
This enables the allowlist feature implemented here: https://chromium-review.googlesource.com/c/chromium/src/+/2324172 Bug: 1111941 Change-Id: Id0110e18b277e2750f9b0a7a2e995ec6be0649f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341893Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#795892}
-
Tanmoy Mollik authored
This reverts commit 21c89bbc. Reason for revert: This cl is causing failures in different bots. See the bug to failed bot links Original change's description: > Fix accessible name for input type=file > > A file picker control (<input type=file>) is exposed as > a button in the accessibility tree. Previously the > filename chosen was only exposed in the accessible value, > like with other input elements - but most screen readers > were not reading the value, since it's not normal to > read the value of a button. So users couldn't tell what > file was chosen, or whether a file was chosen at all. > > Fix this by making the accessible name include both the > filename (as already exposed in the value) and the > text of the "Choose File" button. > > Add a test to confirm this is working correctly when a > file is selected. > > Bug: 903655 > > Change-Id: Iaa22ee66e21079014999e8af3d762ee481c85c54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340163 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795655} TBR=dmazzoni@chromium.org,aleventhal@chromium.org Change-Id: I06b265ba4e46e428ac62e17bb186f711f3226224 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339627Reviewed-by:
-
Alice Wang authored
This CL sets tag variables to private in AccountManagementFragment. This is only a refactoring and it does not change any code behavior. Bug: 1039672 Change-Id: I8751b9cb51aeda3ebdd245fcc030b215c6b921be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343027Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795890}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99589a53ddd5..27c7933767aa 2020-08-07 wolfi@chromium.org Fix issues banner button background color on focus If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1068116,chromium:1096481 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia267ae82dc5294a0b6319bc74e770a8d85539797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343047Reviewed-by:
-
Gauthier Ambard authored
The tests were probably flaky because of a delay between the tap in the popup menu and the appearance of the Reading List. This CL adds a delay and also add a more explicit error message in case it reproduces. Fixed: 1109202 Change-Id: I9678642e45722375409cc4cb7612434a324b70c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343032 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#795888}
-
Peter E Conn authored
This CL builds on: https://chromium-review.googlesource.com/c/chromium/src/+/2324172 Change-Id: I5bb5544411ce5e88f8f5dd7dd3fe5aeb2c27f5e5 Bug: 1111941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338934 Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795887}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57fe7caa9699..005aa46e0e2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:942445 Tbr: vasilii@google.com Change-Id: I461806641b5a77d180225b1b4ce23f7431537218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342763Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795886}
-
Marc Treib authored
This reverts commit ada5164b. Reason for revert: Test is still flaky Original change's description: > Enable SingleClientSessionsSyncTest.NavigationChainAlteredDestructively > > It was disabled for flakiness ~6 months ago; let's see if that is still > accurate. (Likely it is, but at least the flakes don't repro locally.) > > Bug: 1043899 > Change-Id: Iaad54efee9a2548cca72c33adb6c5160b8b2d19d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338734 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Auto-Submit: Marc Treib <treib@chromium.org> > Reviewed-by: Victor Vianna <victorvianna@google.com> > Cr-Commit-Position: refs/heads/master@{#794977} TBR=treib@chromium.org,victorvianna@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043899 Change-Id: Ic4bde1adfe3bbfa2e3dfe610a07a4111bc3556d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339352Reviewed-by:
-
Minoru Chikamune authored
We are going to remove ipc_task_queue, ipc_task_runner, cleanup_task_queue and cleanup_task_runner. The scheduling policy of these queues are the same as the default task queue. We can simply use the (per-isolate) default task queue instead of these queues. [related design doc section] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#bookmark=id.eeuir8g768ou Bug: 1105403 Change-Id: I691347a0eb0ed5c992bf454544b2482a7d207879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342527Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#795884}
-
Ewann authored
This CL adds a check flag before initializing the CookiesStatusMediator. This prevents the mediator to update a cell that doesn't exist. Bug: 1114047 Change-Id: I7f9908a9045092e83786c31f8902131f04dc751f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343069Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#795883}
-
Javier Ernesto Flores Robles authored
If Biometrics Reauth for Filling Passwords is enabled, choosing a password from Manual Fallback will now require the user to re-authenticate with the device. This authentication is valid for 60 seconds and after it expires, Reauth will be triggered again. If there is no passcode / FaceID / TouchID set up, then an alert is presented asking the user to set up one. This alert has a "Learn More" action that opens in a new tab Apple's instructions to set one. Fixed: 1113117 Change-Id: Ieadd269f67fb0c2267fdc2766e2102cb14713fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332824Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#795882}
-
Javier Ernesto Flores Robles authored
Adds a new WaitForUsernameReason to stop prefilling passwords when EnableAutofillPasswordReauthIOS is enabled. The decision is made on PasswordManagerClient::RequiresReauthToFill and overridden in IOSChromePasswordManagerClient. Bug: 1113119 Change-Id: Ic8cd1f1cc6e544502e2b6c1c5d9e9b10027bedb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339746 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
David Jean authored
For some reason in MW, going down 200 makes it 'Translate' visible but un-tappable. This CL adds 50 more unit down, Bug: 1108400 Change-Id: I9ba2f910e45b70d977eac1013e6566baf271e70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335283 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
arthursonzogni authored
This reverts: https://chromium-review.googlesource.com/c/chromium/src/+/2332265 and adds a comment. Not creating a CrossOriginOpenerPolicyReporter prevents accesses checks from being made, which prevents the ReportingObservers's events from being emitted. The current COOP specification requires not to send ReportingObserver reports when no network endpoint are defined. The previous behavior was unexpectedly to me correct. Bug: 1112263 Change-Id: Id3cec5893e2952887cc86c9d1c850b7747835828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340916Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795879}
-
Richard Knoll authored
Some languages need a different translation if the attachments part of the message is plural vs singular. This changes those messages to use ICU syntax to allow different translations based on the count. Skipping screenshot check as there are no changes to the current ones. Bug: b/162851946, b/162948024, b/162872467 Change-Id: I892bae4766dc4cb727a7b6b319e456eabaae9dc8 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343064Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795878}
-
Vasilii Sukhanov authored
Tbr: dbertoni@chromium.org Bug: 1112903 Change-Id: Icb1ceab780ac171bbe6b9eb7271f39a5f412255b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343104Reviewed-by:
-
Eric Willigers authored
All tests in system_web_app_manager_bookmark_apps_unittest.cc now have equivalent tests that use Bookmark Apps without Extensions (BMO). TestPendingAppManagerImpl now has SetPreInstallCallback(), allowing tests to decide if an install will proceed. Bug: 1082880 Change-Id: Id8e39f7f221f2e08846644db977187f8e281261c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340422Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795876}
-
Benoit Lize authored
ParkableStringsToDisk depends on compression being enabled. This is not an issue in most cases, since compression is enabled by default. It is however disabled in some environments, such as some headless cases. If the two features are not tied in the code, this will cause issues once ParkableStringsToDisk is enabled by default. Bug: 1029320 Change-Id: I78a1053d54dcd4103f3017cd512428753b75e537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342849Reviewed-by:
-
Eleonora Rocchi authored
This CL adds the logic to fill the text describing the status of the last/current check. It also adds tests to verify the correct messages are displayed. IDS_PASSWORD_CHECK_STATUS_MESSAGE_ERROR_OFFLINE.png.sha1 image: https://storage.cloud.google.com/chromium-translation-screenshots/fcb59be745a5ffbb21fcd8f78f1608f6817910d7 IDS_PASSWORD_CHECK_STATUS_MESSAGE_RUNNING.png.sha1 image: https://storage.cloud.google.com/chromium-translation-screenshots/7ed062035e44451197ebccfc7a52e9297e669c40 IDS_PASSWORD_CHECK_STATUS_MESSAGE_SUCCESS_NO_LEAKS.png.sha1 image: https://storage.cloud.google.com/chromium-translation-screenshots/693aefb5231f2fa632d467c4febe56e5f4cd28b4 IDS_PASSWORD_CHECK_STATUS_MESSAGE_SUCCESS_WITH_LEAKS.png.sha1 image: https://storage.cloud.google.com/chromium-translation-screenshots/f49f6f620eb105d574ea8b989701a56f6ec02b8b Bug: 1109691, 1092444 Change-Id: I41144279472e00062fd12b91e8c645c3a283bf61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322486 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795874}
-
Himanshu Jaju authored
- Implements code to reject an incoming connection - Adds checks in tests for data written to remote connection Bug: 1085068 Change-Id: Ic8b1220b881b2adc20b0cd14793b38a1be50732e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332707 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795873}
-
Denis Kuznetsov authored
Seems that changes made in recent month made testing code more stable, so tests are not flaky anymore. TEST=run tests with --gtest_repeat=25 --gtest_break_on_failure with affinity to 2 codes + simulated CPU load on same cores Bug: 997685 Change-Id: I687e0191bddfe569d5a9fcdf60761c66024e7476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339989 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795872}
-
Eleonora Rocchi authored
This CL adds to the mediator the logic to handle updates of the status needed for the UI of the status header. Two new properties are added to the model: - Timestamp of the last check completed - Progress of the current check (if running) It also adds tests to check that the model is being correctly updated. Bug: 1109691, 1092444 Change-Id: I07daefc8df1dff609a86505618483f4eefa2646a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320835 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
-
Vikas Soni authored
1. This CL implements a zero copy path for video playback on webview. 2. It is enabled only when AImageReader is supported. 3. Added a finch flag to roll out this feature via finch. 4. Currently it is implemented and enabled only for MCVD. TBR=rsesek@chromium.org Bug: 1091945 Change-Id: I7b6a2cd71c0c82d0eaff08fbbac0cfa60ccfcd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294347 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795870}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter.This CL passes |Profile#getLastUsedRegularProfile| to |getIdentityManager| function. Using always regular profile is safe, since code block is only called for regular profile, while there is no plan to be called for off-the-record profile. Bug: 1041781, 1075562 Change-Id: I8253a9c6baf4b5f5d9034e61ff180da37102ae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339660Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#795869}
-
Eleonora Rocchi authored
This CL adds an icon/progress bar to the header of Check Passwords. It also adds the tests to verify the correct visibility of the elements of the header. Screenshot in the linked bug. Bug: 1109691,1092444 Change-Id: I329f9a21904288f1042417a67be9cb57583355f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317875 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
-
Ramin Halavati authored
Deprecated function is removed and all use cases are updated. Bug: 1023759 Change-Id: I1b085e1a796af0f7745ca35c7b4ddb5632cd1e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340050Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
-
Stephen Nusko authored
This is failing consistently since being added so disabling and will assign to benchmark owner. Bug: 1114112 Change-Id: Ib58444d46f5ee43f0cc55f6298c6aa02119c77d6 No-Try: True TBR: johnchen@chromium.org CC: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341641Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#795866}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3546945795af..99589a53ddd5 2020-08-07 patrick.brosset@microsoft.com Grid: Turn the v1 grid overlay ON If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0109e1a06f9cb8af5201728b4e0c9da02d4d3972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343044Reviewed-by:
-
Saurabh Nijhara authored
As part of UI review, feedback is received to replace 'device' in the strings with actual device type as 'Chromebook' or 'Chromebox'. This can be found in the launch bug (1048607) linked in the below mentioned bug for this CL. This CL incorporates this feedback. Additionally, it migrates some feature strings to plural format. Screenshots: 1) Update required screen https://screenshot.googleplex.com/Pogoq9YYYi7 https://screenshot.googleplex.com/WvS4mrKGsdY 2) Settings https://screenshot.googleplex.com/6upicf2NxKD https://screenshot.googleplex.com/ydJ1q9j2TRu 3) Notifications End of Life (days) - https://screenshot.googleplex.com/FJ06EmTTeE8 End of Life (weeks) - https://screenshot.googleplex.com/B5PKaOyMPSL Metered network (days) - https://screenshot.googleplex.com/MHL7EbHkjaN Metered network (weeks) - https://screenshot.googleplex.com/XU6FKf9ooCZ No network - https://screenshot.googleplex.com/dXVm4RdDRpj Bug: 1113263 Change-Id: I7d22e09183594d024510a45e797a1c9d0f362169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339480 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#795864}
-
Brian Manthos authored
Change-Id: Id7dc42ffdf40842e09e11a1a7434a0e9ed503b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341815 Commit-Queue: Brian Manthos <brianman@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795863}
-
Vasilii Sukhanov authored
Tbr: apotapchuk@chromium.org Bug: 1106305 Change-Id: I031bbc3160cb9dc6510b56ccc80773abb0125a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339750Reviewed-by:
-
