- 21 Mar, 2018 40 commits
-
-
Steven Bennetts authored
Bug: 819148 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idc7a6a4c695c4a6b53989689c245fa704b6b3204 Reviewed-on: https://chromium-review.googlesource.com/973920Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544906}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b8537cad03a0604c85260cddd2eed7f3dbf92ba Reviewed-on: https://chromium-review.googlesource.com/974541Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#544905}
-
Jiaquan He authored
This commit removes more dead codes due to app list refactoring, especially those under app_list::features::IsFullscreenAppListEnabled which is always true. Bug: 733662 Change-Id: Id83447b1e7d918d0c97eb6b841b4d8d9c264040f Reviewed-on: https://chromium-review.googlesource.com/972442 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544904}
-
https://skia.googlesource.com/skia.git/+log/ca37f32c7014..4d4b3aaa20e1 $ git log ca37f32c7..4d4b3aaa2 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 mtklein small ABI + narrow/wide code updates 2018-03-20 bsalomon Remove deprecated version of SkImage::MakeFromAdoptedTexture that does not take SkColorType 2018-03-21 liyuqian Remove legacy precision boundary 2018-03-21 csmartdalton ccpr: Use a more stable formula to find quadratic coordinates Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I2f41b26cb2a6d9bae7db94b163663a83ad85a99b Reviewed-on: https://chromium-review.googlesource.com/974104Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544903}
-
Bill Orr authored
This test stores a single pixels value in a file, then reads from the file. BUG=808232 Change-Id: I2573a1f98188d232f25ff2ceb11cc15e67cc768f Reviewed-on: https://chromium-review.googlesource.com/963317Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544902}
-
Mike Meade authored
This cl adds a new test step to exercise the browser with chromedriver. This allows us to verify correct operation of the browser after an install. This cl also adds the mini_installer_test build target and moves test-specific dependencies to the chrome/test/mini_installer directory. This is a merge of https://chromium-review.googlesource.com/c/chromium/src/+/907952 and https://chromium-review.googlesource.com/c/chromium/src/+/953122 Bug: 461856 Change-Id: I70992a74cb2d06d8472f757f3128b259ddf7cf58 Reviewed-on: https://chromium-review.googlesource.com/953122 Commit-Queue: Mike Meade <mmeade@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#544901}
-
chaopeng authored
The EF_PRECISION_SCROLLING_DELTA flag was fill in wrong flag in previous CL. That will cause scroll animation. Bug: 779372 Change-Id: I82494721d53886b7c094d6bf006b26f0b2075bd9 Reviewed-on: https://chromium-review.googlesource.com/973742Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544900}
-
Conley Owens authored
This change attempts to address a crash occurring in BluetoothClassicWrapper::FindFirstRadio. Specifically, we occasionally trigger a Close() on an already closed handle when we call opened_radio_handle_.Set. The theory this change operates on is that BluetoothFindFirstRadio may be occasionally giving us garbage radio handles. Here we do a CHECK so that if our theory is correct, we will get a more direct error. BUG=820864 Change-Id: Iecf56d004452978301ff49ae884ea2d59c5ee9f7 Reviewed-on: https://chromium-review.googlesource.com/969609Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#544899}
-
Zhongyi Shi authored
Bug: 817496 Change-Id: Ic382ff347fdec75093019954c75c25fbe17ee0e2 Reviewed-on: https://chromium-review.googlesource.com/972423Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544898}
-
Malay Keshav authored
Display preferences for chrome OS stores the display zoom value only upto a precision of 2 decimal point. This patch adds a check of precision to ensure that in the future if any changes are made to the way display zoom values are generated then those changes keep in mind this precision that is used by display prefs. Bug: 823922 Change-Id: I8370415041bcaeac55c4afef9a4e4125979559b4 Component: Display Util Test Reviewed-on: https://chromium-review.googlesource.com/974264Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#544897}
-
Ran Ji authored
The gms core version is used to determine if a crash happens due to gms core update. This change will save the previous and current gms core version during startup. When a crash happens, it compares the two versions and report the crash if the two versions are same (which means gms core is not updated and it's a real crash) Bug: 785306 Change-Id: I18ab68d7b1c1e227f82645fba5e742ad1da0f4a0 Reviewed-on: https://chromium-review.googlesource.com/971407 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544896}
-
Nicolás Peña authored
Bug: 498037 Change-Id: I8f0e72da2aac76e5ff8ac0b4ffffd8b228e0ac42 Reviewed-on: https://chromium-review.googlesource.com/970047Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#544895}
-
Kent Tamura authored
Entries like: "+core", should be updated to "+third_party/blink/renderer/core", Bug: 578345 Change-Id: I2763a859946fc31338875690b54f4b1e8b8750e3 Reviewed-on: https://chromium-review.googlesource.com/970124Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#544894}
-
Eric Holk authored
V8's API for enabling trap-based bounds checks for WebAssembly changed in https://crrev.com/c/963179. This CL updates Chrome to use the new API. Bug: v8:5277 Change-Id: I0c191b76833c8d4356da4d0d9325ee5267a886f4 Reviewed-on: https://chromium-review.googlesource.com/965017Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#544893}
-
Dominick Ng authored
This CL moves LocationBarView's color calculations to OmniboxTheme, preparing for the implementation of the Touchable Chrome color spec. There should be no functional changes. BUG=801583 Change-Id: If8a4e71fc210af5b5807ea266e6cb985a552536a Reviewed-on: https://chromium-review.googlesource.com/970062Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#544892}
-
Roman Sorokin authored
Now it is displayed for Active Directory users even though sync does not work for them. BUG=chromium:814777 TEST=manual Change-Id: I34ca96cc84f6a630947d9224b954522fface1af1 Reviewed-on: https://chromium-review.googlesource.com/970912 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#544891}
-
James West authored
Avoids downcasting CastDecoderBuffer to DecoderBufferBase in multizone code. Bug: internal b/62147653 Test: cast_media_unittests Change-Id: I4b0fe09bd6aee26c5372405a9052252c39be36e5 Reviewed-on: https://chromium-review.googlesource.com/972429 Commit-Queue: James West <jameswest@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#544890}
-
Chong Zhang authored
'loading.desktop.network_service/Rambler' is causing flakiness to the Mojo Linux Perf bot. Disabling all related tests since there is no reference data in loading.desktop. Sample Log: ``` ERROR:edid_parser.cc(180)] invalid EDID: human unreadable char in name ``` https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf.fyi%2FMojo_Linux_Perf%2F4945%2F%2B%2Frecipes%2Fsteps%2Floading.desktop.network_service_on_NVIDIA_GPU_on_Linux%2F0%2Fstdout Bug: 805115 Change-Id: I6a285497302efe5a7562c99683a3f3da74bb2368 Reviewed-on: https://chromium-review.googlesource.com/974170Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#544889}
-
Dmitry Gozman authored
Bug: 820250 Change-Id: I102e083d01c66e374dc345345363dc2ef5ade62d Reviewed-on: https://chromium-review.googlesource.com/965390 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#544888}
-
Peng Huang authored
Also pass the flag to viz via RendererSettings. This CL is part of CL https://crrev.com/c/947047 which makes SkiaRenderer use Skia DDL to render frames. Bug: 824382 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I1d9487afd4fd15925acad234916ebedf6292e7bb Reviewed-on: https://chromium-review.googlesource.com/973802 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544887}
-
Reid Kleckner authored
This frequently flakes on our Windows Clang ToT bots. TBR=vabr@chromium.org BUG=804398 Change-Id: I1d67c8de3df9b6868c9444403bd72aae1bc5fade Reviewed-on: https://chromium-review.googlesource.com/974283Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#544886}
-
Henrique Nakashima authored
There are ScrollY() and ScrollX() methods, so one would imagine Scroll(point) is the combination of both. In reality, ScrollY() and ScrollX() send a message to the js, which moves the viewport and calls Scroll(). Change-Id: If4e75f537e1d08eb6c7b7095a0a14107cef7b515 Reviewed-on: https://chromium-review.googlesource.com/974169Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#544885}
-
Elly Fong-Jones authored
This switch is similar to the existing --wm-window-animations-disabled switch, which is Aura/Ash-specific, but more tightly scoped and available only on Mac. This allows tests to disable closure animations for modal dialogs, which take a few hundred ms each and introduce test flake. Bug: 817408 Change-Id: Id6d2703d58b25f0efa34085d34f467ad1bf5a912 Reviewed-on: https://chromium-review.googlesource.com/973463 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#544884}
-
rbpotter authored
Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If137f14a5bd9cb23585629710b62e9b018cced96 Reviewed-on: https://chromium-review.googlesource.com/969704 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#544883}
-
Kevin Bailey authored
ZeroSuggestProvider::OnMostVisitedUrlsAvailable() can be called back multiple times asynchronously from the respective ::Start() calls. (TopSites::GetMostVisitedURLs() will happily queue up infinite requests.) Currently there's only a single state variable protecting against late replies. This change adds a counter to remember the last valid request, and adds a test to challenge it. It also cleans up the inconsistent scoping of the enumerations. This reland initializes the counter in question, to pass MSAN, even though it isn't strictly important which value it starts with. Change-Id: Ie43feffd25c83319e04fc17b32d87e4037a6e7a3 Reviewed-on: https://chromium-review.googlesource.com/973185Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544882}
-
Malay Keshav authored
This patch moves the display zoom state for a display from display manager to the display's corresponding ManagedDisplayInfo. Bug: 823922 Change-Id: Ib50e5d62102987900e80a1a866fc29f696e5482b Component: ManagedDisplayInfo, Display Manager, Display Zoom Reviewed-on: https://chromium-review.googlesource.com/972428 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#544881}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab2ca46a..8943d0bd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib4fa3f68926daac7ab18965292216bebe06e574c Reviewed-on: https://chromium-review.googlesource.com/974117Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544880}
-
Mitsuru Oshima authored
TBR=afakhry@chromium.org BUG=735078, 823634 TEST=None Change-Id: I6351b02d21fd3d64ca0963204f22fdd97910dc4b Reviewed-on: https://chromium-review.googlesource.com/974293Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#544879}
-
https://chromium.googlesource.com/angle/angle.git/+log/40b1c77070fd..3395c8b96333 $ git log 40b1c7707..3395c8b96 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 cwallez Make infra.cq to point to new Mac configs. 2018-03-21 ynovikov Revert "Skip TransformFeedbackLifetimeTest.DeletedBuffer on Win Intel GL" 2018-03-20 lucferron Vulkan: Support of npot textures Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I8ffc6d5277866416ccb29112d967d3f0f1c11917 Reviewed-on: https://chromium-review.googlesource.com/974063Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544878}
-
btolsch authored
Chromebooks have an additional hardware button that allows them to toggle windows fullscreen. This bypasses the ExclusiveAccessManager, which is only tied to the normal platform shortcut (e.g. F11). This change adds a window observer for Chrome OS to watch for fullscreen changes outside the ExclusiveAccessManager. Bug: 809682 Change-Id: I021815dd4aff07bc1b389286d24d85380f380e0e Reviewed-on: https://chromium-review.googlesource.com/905447 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544877}
-
Veranika Liaukevich authored
Also retires legacy URL for downloading Canary cleaner version. Bug: 786964 Change-Id: I0026545eee940501f38c6b65a76e03dc2427481a Reviewed-on: https://chromium-review.googlesource.com/965943Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Cr-Commit-Position: refs/heads/master@{#544876}
-
https://pdfium.googlesource.com/pdfium.git/+log/36bbc24e2d7e..19a33e4ece99 $ git log 36bbc24e2..19a33e4ec --date=short --no-merges --format='%ad %ae %s' 2018-03-21 hnakashima Rewrite CPDFXFA_DocEnvironment::GetPopupPos. 2018-03-21 thestig Add functions to convert various FPDF_ types. Created with: roll-dep src/third_party/pdfium BUG=chromium:820106 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icbc4e87948a22899f2b3ae2102629eb5f9402f34 Reviewed-on: https://chromium-review.googlesource.com/974103Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544875}
-
Troy Hildebrandt authored
Since SearchActivityLocationBarLayout built off of LocationBarLayout, it looked fine on tablets but the URL text/buttons overlap problem still existed for phone. This is caused by a discrepancy in the LayoutParams used for calculating the URL bar margin between the different location bar layouts. This CL makes #getUrlContainerMarginEnd generic so we can use LinearLayout.LayoutParams where necessary instead of FrameLayout.LayoutParams. It also adds #getUrlContainerViewsForMargin, and puts the onus on LocationBarTablet to override this and provide its unique set of views to be taken into account for margin calculation. Tested on tablet and phone, in browser and search widget, no more overlap (including with voice icon always showing in omnibox on phone) Bug: 822136 Change-Id: I73915be984d96e5e4613601b5f6b75ef82afff61 Reviewed-on: https://chromium-review.googlesource.com/966597Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544874}
-
Robert Liao authored
A "MAYBE_" was lost in the shuffle. BUG=823543 TBR=ellyjones@chromium.org This missed the https://chromium-review.googlesource.com/c/chromium/src/+/972329 train. Change-Id: I74a9037f6a8e35350203eae8136f9e9b6295501e Reviewed-on: https://chromium-review.googlesource.com/974163Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544873}
-
Jinsuk Kim authored
The API |isScrollInProgress| is defined in ContentViewCore while scroll-related state handling is spread across GestureListenerManager and SelectionPopupController. This CL tidies it up by moving the API to GestureListenerManager, and making it the main class that takes care of all the scroll stuff. Bug: 598880 Change-Id: Ib5abdddd361b93b823465b978aabfe9903d7cf68 Reviewed-on: https://chromium-review.googlesource.com/965863Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#544872}
-
erikchen authored
VM regions are necessary to symbolize mixed stacks. Change-Id: I90571853483f33ed448b36fd061e57d8c9c8d7bc Reviewed-on: https://chromium-review.googlesource.com/969334 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#544871}
-
Xianzhu Wang authored
Previously the function was a static function which didn't know the current paint offset so was unable to calculate the accurate pixel snapped border box rect, so used a conservative border box rect which caused some unnecessary OverflowControlsClip() whose change of existence was not updated. Now make it a method of FragmentPaintPropertyTreeBuilder to return the accurate needs, so the change of needs is covered by existing SetNeedsPaintPropertyTreeUpdate conditions. Bug: 823935 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I07578033d202af3c996004a88f25711eaac245a2 Reviewed-on: https://chromium-review.googlesource.com/974167Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#544870}
-
Peter Boström authored
Replaces message_center_style::{kActiveButtonColor,kInactiveButtonColor} with kMenuIconColor and kMenuIconColorDisabled respectively. Also replaces message_center_style::kActionIconSize with kMenuIconSize. Bug: None Change-Id: I52aefb39f9bbeb82d09b746d96f16b820faae0ef Reviewed-on: https://chromium-review.googlesource.com/973910 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#544869}
-
Varun Mohan authored
This signal will be used to implement proactive tab discarding. Bug: 727353 Change-Id: If4ea5bf5ee93de61d933f87385dc9595900f9cf9 Reviewed-on: https://chromium-review.googlesource.com/973699 Commit-Queue: Varun Mohan <varunmohan@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#544868}
-
Jacob Dufault authored
Some autotests require this, such as login_SameSessionTwice. Bug: 784495 Change-Id: I140aa2824f8a536c85c8f1f7ce5bc8e06748cb55 Reviewed-on: https://chromium-review.googlesource.com/973888 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#544867}
-