- 24 Sep, 2019 40 commits
-
-
Wei Lee authored
This issue is introduced by this CL: https://crrev.com/c/1722167 Since it makes camera_app.mojom depends on camera_intent.mojom but did not add camera_intent.mojom into the CCA's dependency, CCA will complain when launching. Bug: 980812, 967611, b/131809655, b/134635999 Test: Tested on Soraka and CCA could launch successfully with this CL Change-Id: Icb43a6e83ec13e391dd82fa281a52d99244de618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817872Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699178}
-
Yun Liu authored
Bug: 1005003 Change-Id: I888e625183fcde0bb1cf2ac529374f8334f3dd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809745 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#699177}
-
Alan Cutter authored
As of CL https://chromium-review.googlesource.com/c/chromium/src/+/1803018 The OmniboxPageActionIconContainerView supports a superset of the icons supported by ToolbarPageActionIconContainerView. This CL dedupes the PageActionIconView handling between the two container classes as a single PageActionIconContainerView. Effective renaming: OmniboxPageActionIconContainerView -> PageActionIconContainerView ToolbarPageActionIconContainerView -> ToolbarAccountIconContainerView ToolbarAccountIconContainerView now uses a PageActionIconContainerView for its PageActionIconViews. Incidentally this CL fixes crbug.com/1005031 where the "save card" dialog would not show due to Layout() not being called when the icons updated inside the account icon container. With this dedupe they now Layout() as needed. Bug: 1005031, 788051 Change-Id: Icd5746a8c44221826e11246662f2251840c5d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816244 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#699176}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c5b0621faea0..e849e6783d9f git log c5b0621faea0..e849e6783d9f --date=short --no-merges --format='%ad %ae %s' 2019-09-24 rharrison@google.com Add logging missing failures to spvc test script (#815) Created with: gclient setdep -r src/third_party/shaderc/src@e849e6783d9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Iaf5eb41309842e67747a43fadb7bb4df0e7d7b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699175}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0da04baa78c2399b603cd87d54003af86b615d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820199Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699174}
-
Miyoung Shin authored
This CL converts SensorProvider{Ptr, PtrInfo, Request} in device, services, content and blink to the new Mojo types. SensorProviderPtr -> Remote<SensorProvider> SensorProviderPtrInfo -> PendingRemote<SensorProvider> SensorProviderRequest -> PendingReceiver<SensorProvider> Binding<SensorProvider> -> Receiver<SensorProvider> BindingSet<SensorProvider> -> ReceiverSet<SensorProvider> Bug: 955171, 978694 Change-Id: I318a2b0651b6dac993acf1ba29ed53c86f864048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809046 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#699173}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/27a35eb2a938..41f8aa550b43 git log 27a35eb2a938..41f8aa550b43 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 bryan.bernhart@intel.com Return Dawn result upon submit. Created with: gclient setdep -r src/third_party/dawn@41f8aa550b43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: If52a300e3b7ef4deffa8f392e45a0aa336730662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820095Reviewed-by:
-
Peter Kotwicz authored
This CL removes unused: - WebContents#reloadLoFiImages() - WebContentsObserver::DidReloadLoFiImages() BUG=1004173 Change-Id: If561b0ce731b1eb4a12063159f804ff53cfd3a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805717Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#699171}
-
Ian Struiksma authored
Two sites had mixed content (http & https) when recorded by wpr: cdbaby bed_bath_and_beyond Looks like the sites have fixed this, and thus live sites don't reflect these issues. Re-recorded the sites and updated the CIPD version to the new version which has the updated files. Bug: 1006377 Change-Id: If7900716b203a72ef8e660bcc7adeaa4d855d46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819570 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#699170}
-
Donn Denman authored
Limits the sheet height to 95% of a tab's full height. Updates the touch highlight area of the Bar to limit height under the new layout. BUG=1005558 Change-Id: I57f4bfb6cca53096e93e00679098ef6b3933671b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812245Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#699169}
-
Julie Jeongeun Kim authored
This CL converts CallStackProfileCollectorPtr and CallStackProfileCollectorRequest to new Mojo types. It uses Remote, PendingReceiver, and Receiver instead of CallStackProfileCollectorPtr, CallStackProfileCollectorRequest, and binding. Bug: 955171 Change-Id: Iafc17945a133946713e11359ee806e0bfb184ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810174Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699168}
-
John Z Wu authored
- Make it work with python3's bytestring semantics. - Not sure why, but looks like libcpp is compiled as big endian now? Change-Id: Ia73fd960472606b0f72970674b80200a1ae467d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816642 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#699167}
-
Mike Jackson authored
This change updates the version of axe-core to the latest released version. As part of picking up the latest version, the following additional changes were made: 1) axe-core removed the 'href-no-hash' rule, so that been removed from the test list. 2) Several 'link-in-text-block' tests started failing with axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but are disabled as part of this change. - CrManagementA11yTest.SimpleTest_link_in_text_block - CrManagementA11yTestWithExtension. ExtensionSection_link_in_text_block - CrostiniAccessibilityTest.CROSTINI_link_in_text_block - CrExtensionsA11yTest.NoExtensions_link_in_text_block - MultideviceA11yTest.MULTIDEVICE_link_in_text_block - MultideviceFeaturesA11yTest. MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block 3) One 'heading-order' test started failing in v3.0.0 (and later). This tests does pass in V2.4.2, but is disabled as part of this change. - CrExtensionsA11yTestWithMultipleExensions. WithExtensions_heading_order 4) Several DevTools a11y tests were failing. This change either updates the baseline or excludes the rule depending upon the test/rule itself. - http/tests/devtools/a11y-axe-core/basic-a11y-test.js - http/tests/devtools/a11y-axe-core/console-a11y-test.js - http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js - http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js I spent some time investigating the test failures, and it looks like axe-core is highlighting legitimate product issues. Change-Id: I0ef08cdace91250936f83705fb3cd0fbb35bed4b Bug: 984817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809407 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#699166}
-
Nate Fischer authored
Miscellaneous edits to the netlog documentation: * Don't refer to chromium scripts in the manual section; the user may not have a chromium checkout * Fix the script output (the line of output requires --verbose) * Explain how to clean up the flags file * Cross-link to the commandline-flags page * Link to the online netlog viewer, rather than its README file Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ib2d0027b58266fa39d2c0400567adb3d113cada6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820090Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699165}
-
Fabrice de Gans-Riberi authored
This is a reland of bbd8d150, now that the peer-component's implementation of the UrlRequestRewriteRulesProvider really actually works correctly! Original change's description: > [fuchsia] Handle UrlRequestRewriteRulesProvider in CastRunner. > > * Implement handling of the > chromium.cast.UrlRequestRewriteRulesProvider API in CastRunner. > * Remove handling of the fuchsia.web.AdditionalHeadersProvider API in > CastRunner as it is deprecated. > * Adapt the integration test to use the new API. > > Bug: 976975 > Change-Id: If1e97c474f79a4b6f3f0c03428b85557e3e73460 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770434 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695766} TBR=fdegans Bug: 976975, b/141305604 Change-Id: I5e96abb44c167e64c2dbb32b596a6ce4550f61b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820198Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#699164}
-
Kinuko Yasuda authored
TBR=jam@chromium.org Change-Id: Ifeebeeb58cef6cf10a18dd6ea3a398553c977aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784260Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#699163}
-
dpapad authored
Specifically - Converting PDFScriptingAPI, PDFViewer, ViewportScroller classes. - Fixing newly revealed type errors (only happening with classes which are @struct by default). Bug: 1005029 Change-Id: I15490634db5c3e3c395facc4e57b4106eab3b494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820101 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#699162}
-
Julie Jeongeun Kim authored
This CL converts UrlCheckNotifierPtr and UrlCheckNotifierRequest to new Mojo types using Remote, PendingRemote, PendingReceiver, Receiver, and ReceiverSet. Bug: 955171 Change-Id: Ia15d76bcbed7ff3761d640710a27e8ba475cb08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815811Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699161}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce9b13eb99e1..3da5033009ec Created with: gclient setdep -r src-internal@3da5033009ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib27fbcbaaee34a86a854adfac6edabd894f3ab3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820157Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699160}
-
Robert Liao authored
Quick cleanup for NativeAppWindowViews in preparation for Layout changes in http://crbug.com/1005568. BUG= Change-Id: I7fcc633917ce81496750740501a1ca1b88edf0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819913 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#699159}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8330c31fd4f8..8669b37aa2b0 git log 8330c31fd4f8..8669b37aa2b0 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 simonhatch@chromium.org Pinpoint - Move migrate endpoint auth to api_request_handler Created with: gclient setdep -r src/third_party/catapult@8669b37aa2b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1006658 Change-Id: I17e756e8db904e835e48687a4b729f519644f36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820260Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a905cbcdc21b..6d625bfe6e8a git log a905cbcdc21b..6d625bfe6e8a --date=short --no-merges --format='%ad %ae %s' 2019-09-24 ynovikov@chromium.org Skip ComputeShaderTest.UniformDirty on Linux Intel Vulkan 2019-09-23 timvp@google.com Vulkan: Disable Line Rasterization Emulation for Android 2019-09-23 jmadill@chromium.org Capture/Replay: Force capture on Context teardown. Created with: gclient setdep -r src/third_party/angle@6d625bfe6e8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I8dfbc7f6d00927d4154e8861dafdd0a841bcea90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820257Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/a9e27d5c7f1b..3651f6c52037 git log a9e27d5c7f1b..3651f6c52037 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 raul@tambre.ee tools/elf_fuzzer.py: Convert use of has_key Created with: gclient setdep -r src/native_client@3651f6c52037 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=mseaborn@chromium.org Bug: chromium:941669 Change-Id: Id9c928094241cb8e01fb174b11cf8a016e9c7d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819116Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3841eaa164c2..ba5bc99b6ab9 git log 3841eaa164c2..ba5bc99b6ab9 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 ehmaldonado@chromium.org auth: Use luci-auth to get credentials. Created with: gclient setdep -r src/third_party/depot_tools@ba5bc99b6ab9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001756 Change-Id: Iad07c439b73e6b264cf32225dfaed54a98762b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820259Reviewed-by:
-
Scott Haseley authored
Cleaning a few things up in response to post-landing reviews of crrev.com/r/1735774 and crrev.com/r/1737169. The CL makes the following changes: - Split out the task.result mega web test into separate tests. - Add new task.result tests for error handling and cancel order. - Rename ResolveOrRejectPromiseIfNeeded to LazilyResolveOrRejectPromiseIfReady. - Add more comments. - Make TaskQueue's cached TaskRunner pointer const. Bug: 979017 Change-Id: I9c44ed09a0c20ce59717ee9a9a1251fd8185b04c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764753Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts apps::mojom::AppServicePtr and apps::mojom::AppServiceRequest to new Mojo types using PendingRemote or Remote, PendingReceiver, and ReceiverSet. Bug: 955171 Change-Id: I24b7d9daa8d558e68f1635020135305a1f6abebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818006Reviewed-by:
-
Yuly Novikov authored
Often fails 3 flaky retries, so marking as Failure. TBR=zmo Bug: 1003481 Change-Id: I97546b7d681b326571caf1840fc229c0f0966a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820086Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699152}
-
Steven Bennetts authored
Bug: 1002462 Change-Id: Ic59144cdf3940b76b32770f187949860f5709c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819973 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699151}
-
Alex Moshchuk authored
This is in preparation for requiring WARN_UNUSED_RESULT on NavigateToURL() usage in tests. Bug: 425335 Change-Id: Ie5621f0c778169ccb37263c60f026dc522b531c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815664Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699150}
-
Ahmed Mehfooz authored
Bug: 909101 Change-Id: Ie37bed4e4bee9b5ac2a144cae54f3fc1f63dde28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808493 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#699149}
-
nancy authored
This CL is the follow up for crrev.com/c/1804095, integrating AppService to LauncherContextMenuTest. BUG=1002351 Change-Id: Ia7e2d45e65acb19e60130fb3ad9b998c737edae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816245 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699148}
-
Steven Bennetts authored
We will need to maintain the networkingPrivate api tests for networkingOnc (which is just an alias of a subset of networkingPrivate) even with the mojo api. This fixes the one disabled flaky test. Bug: 927450 Change-Id: Ia76c1de42adeb31c20c02990054278c5d867d8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820099Reviewed-by:
-
Kyle Horimoto authored
Change-Id: Ib7323c7127dd51103b7f43744dd68d170536bb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819948 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#699146}
-
Brandon Wylie authored
Adjusts the omnibox padding both for the animation and for resting states. * Adjusts calculations for omnibox animations. * Adjusts the NewTabPageLayout's layout params to match. * Adds new dimensions for these changes. All hidden behind the OmniboxSearchEngineLogo flag. Bug: 986584,988883 Change-Id: I12d774c8e17c7627dfaa226e3ba41b2ad0856000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764343 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#699145}
-
John Rummell authored
As CdmFileIO writing is now asynchronous, it is possible for a write() call that is cancelled by calling close() before the write callback is called to actually succeed (or partially succeed). Normally that is not a problem as the implementation of write creates a temporary file, writes to it, and then renames the file to the actual file name as a final step. However, if the write() is part way through the process when it is cancelled, it may leave a temporary file around. Next time write() is called, it will overwrite the existing temporary file. If the new contents are shorter than what is in the file, then extra data will be returned when the file is read later. The fix is to truncate the temporary file if it exists. So in the rare case that a temporary file is left around, it will be reset to 0 bytes before writing to it. This CL also updates all the FileIO tests that do this (call close() immediately after calling write() without waiting for write() to succeed). They will now check for one of the two buffers to be returned on the next read(), as the second write() may have actually succeeded before close() was called. This should fix the code, so re-enabling the browser_tests that were flaky. Bug: 999421,997953 Test: Re-enabled tests succeed Change-Id: Ib1772b678c7e89f588e81cc40055650478e6a9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793722Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#699144}
-
Xianzhu Wang authored
Bug: 1005868 Change-Id: Ice99c87d4eff6306baa14fbfe91e859295169786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819563 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699143}
-
Ryan Hansberry authored
Store a flag in local state that tracks if the 'Signin with Smart Lock is disabled' tooltip message has been shown to user yet. If it has, do not display it. If the user re-enables Signin with Smart Lock, reset the flag so that it will redisplay if the user ever disables Signin with Smart Lock again. This pref is different from other Smart Lock prefs in that its source of truth must be in the local state, as opposed to the regular user prefs, because the pref must be written to from the signin screen context (which is outside the regular user session). Bug: 848893 Change-Id: Iff62a7595bd0fd67bf9039d3ba37cdccb3454b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814837Reviewed-by:
-
Sangseok Jang authored
App shim was not considered in the current implementation so, SetZOrderLevel wasn't work in PWA application. This CL is re-implementation considering app shim process. Bug: none Change-Id: Ie647b5f57c7d6b56d11d9a936f5dd44287062d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794322Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sangseok Jang <sangseok.jang@navercorp.com> Cr-Commit-Position: refs/heads/master@{#699141}
-
Eric Willigers authored
The AppRegistrar method IsShortcutApp was recently added. WebAppBrowserController::CreatedForInstalledPwa() now calls IsShortcutApp(). Bug: 966290 Change-Id: Ic081748fccf4570b92f1abf00d1e2dbd3ae68c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818000 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#699140}
-
Alex Danilo authored
Adds more aria-labels on the feedback panel area to identify the area itself and describe the operations in progress as the feedback area is navigated. Improves the 'cancel' button aria-label to include the activity being cancelled. Bug: 989324 Change-Id: I2dffec41ddafb7627d8e888c14a98db3c9e8ecec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815798 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#699139}
-
