GitLab

We are using the value of the property
BottomToolbarModel.PRIMARY_COLOR before it has ever been set. The
default value of the property key is 0 and is not correct. This CL sets
the property to the normal modern color. This should be correct since
the app never starts off in incognito mode.

Bug: 878564, 879076
Change-Id: Icb310e93bd2aa12d99ea8644ea559565ece7aa07
Reviewed-on: https://chromium-review.googlesource.com/1196167
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587622}

Add dialog sheets and the underlying logic to enable turning the BLE
adapter on automatically/manually in the WebAuthn dialogs.

This also necessitated adding some plumbing to:
 1) Allow sheet models to be mutable, as well as add notifications to
    trigger updating the dialog view state when the model changes.

 2) Notify sheet models when the Bluetooth adapter state changes.

Bug: 849323
Change-Id: Id93b3d2fbae70daa0d8ff3609c4cca3c9d33d098
Reviewed-on: https://chromium-review.googlesource.com/1196371
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#587621}

Feed component adds a significant amount of code that's not used yet
for users. See Feed DEPS rolls for current size impact.

Change-Id: I2c77f9f8d640b46c58602b29a3f79357f7cb1140
Reviewed-on: https://chromium-review.googlesource.com/1188596Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587620}

This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/browser/browser_state.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=sdefresne@chromium.org

Bug: 874080
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I84da700fb1fc68393c2f5483c96895e8cc6b4d63
Reviewed-on: https://chromium-review.googlesource.com/1191141Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587619}

Makes sure all toggles are hidden for ALL_SITES and USE_STORAGE.

Bug: 854737
Test: Add one test case.
Change-Id: I1a174246a79bcefdc63489a7f6997e0bc3c8eace
Reviewed-on: https://chromium-review.googlesource.com/1188494
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587618}

This queues a report through the Reporting API whenever
navigator.requestMIDIAccess is invoked from a frame in which the 'midi`'
feature is not allowed according to feature policy.

Bug: 867471
Change-Id: Ib7966a3721067fcf7a325d75377178caaa4b327a
Reviewed-on: https://chromium-review.googlesource.com/1195703
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587617}

- Vertically center the radio button
- Use android:textAppearance for text properties

For the record, here's the instruction to test "confirm import sync
data" dialog:
0) Make sure you have at least two accounts on the device.
1) Go to Chrome settings.
2) Click on your Account name.
3) Click on "Sync (Syncing to peter@example.com)"
3) Click on "Sync to (peter@example.com)"
4) Pick a different account.

Screenshots on the change on "confirm import sync data" can be found
at https://photos.app.goo.gl/hriUs5o8ZKBrqiQ28

Bug: 854737
Test: Manually checked all use cases of RadioButtonWithDescription
Change-Id: I93d3a40d55811dc43a7a0191870e85d01735dcff
Reviewed-on: https://chromium-review.googlesource.com/1187652
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587616}

https://chromium.googlesource.com/angle/angle.git/+log/f0d0408a355e..80aa5592d9dd


git log f0d0408a355e..80aa5592d9dd --date=short --no-merges --format='%ad %ae %s'
2018-08-30 oetuaho@nvidia.com Clean up TextureD3D_2DMultisample


Created with:
  gclient setdep -r src/third_party/angle@80aa5592d9dd

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ic9e7dad2f8d3035c0ed4dc2b767b227b0cc9450b
Reviewed-on: https://chromium-review.googlesource.com/1196843Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587615}

If everything is zero, we can save some work. This accounts for 2-3% of
the total time of the flexbox-with-stretch-layout.html perf test.

R=eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie1a1f0df9a79aedd9e526b58e62a5f3b2b716a12
Reviewed-on: https://chromium-review.googlesource.com/1196585
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587614}

Sets the value of the new Autofill prefs "once" to the value of the now
deprecated Autofill master pref once all profile prefs are registered.
This is required for those users who had Autofill disabled before
introduction of the new prefs.

Bug: 870328,877801
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iac4c1f7325c3a058b3d0fda0af0500a0ff23106a
Reviewed-on: https://chromium-review.googlesource.com/1194598
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587613}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie1fe2de0b618f042fcd3c0cc6d332fa6759cf689
Reviewed-on: https://chromium-review.googlesource.com/1196242Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587612}

Add support for the key derivation method field in the NigoriSpecifics
proto in SyncEncryptionHandlerImpl. Persist the key derivation method
chosen for new passphrases in NigoriSpecifics. If updating from a remote
NigoriSpecifics, respect the key derivation method stored there. The
change is limited to cases when the passphrase type is
CUSTOM_PASSPHRASE.

A rationale for the change follows.

Prerequisite: if the custom passphrase key derivation method is set to
PBKDF2 (or UNSPECIFIED), the behavior of all decryption is exactly the
same as in previous versions.

Let "happy paths" be the encryption and decryption code paths which a
keystore-enabled client (referring to a client released after the
support for keystore migrations was introduced) will be able to hit
starting from a fresh account, if only other keystore-enabled clients
are syncing to that account.  Since legacy encryption methods are out of
scope for the change, we need to change the behavior only in these
"happy paths", and keep the behavior identical in others.

In ApplyNigoriUpdateImpl, we will read the key derivation method from
Nigori and save it in the class member.

In "happy paths", we will always know what key derivation method will be
used, and we will always know when we'll end up in a CUSTOM_PASSPHRASE
state. We will remember the key derivation method in the class as a
member when applicable. In particular, there are two such paths. Both
are short-circuits that are much easier to follow than the alternative,
legacy code paths:

1. |IsNigoriMigratedToKeystore() == true| case in
SetEncryptionPassphrase(), which calls SetCustomPassphrase() (only call
site). Here, it is us who are making the decision, so this is obvious.

2. |IsNigoriMigratedToKeystore() == true && ...| case in
SetDecryptionPassphrase(), which calls
DecryptPendingKeysWithExplicitPassphrase() (only call site). Here, we
will use the key derivation method from the member. Since we can't reach
this path in SetDecryptionPassphrase() without a valid Nigori node, we
assume that ApplyNigoriUpdateImpl() was called and has saved the key
derivation method from Nigori in the member.

Since we write the passphrase type to Nigori *only* in
AttemptToMigrateNigoriToKeystore, we will also write the custom
passphrase key derivation method *only* there. If the key derivation
method member is not set at that point (but the passphrase type we are
writing is CUSTOM_PASSPHRASE), that means we have reached the
CUSTOM_PASSPHRASE state through some other, non-"happy" path. In this
case, we will write PBKDF2 as the key derivation method. This will
ensure that decryption for these cases works the same way as in older
versions, no matter what.

The only thing that remains is converting an UNSPECIFIED key derivation
method in Nigori to PBKDF2. We will also do this in
ApplyNigoriUpdateImpl(), which is called when we receive a remote
Nigori. Because we expect to set the key derivation method explicitly
whenever we decide what it is, this will ensure that we use every chance
we can to set an explicit (rather than UNSPECIFIED) key derivation
method in Nigori.

Bug: 876408
Change-Id: Ia793f53f8777ed61af5edda9d8fa21090ad6da43
Reviewed-on: https://chromium-review.googlesource.com/1187148
Commit-Queue: David Davidović <davidovic@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587611}

Before this patch, if a user attempted to open a second PaymentRequest
UI in a separate tab or window, the .show() promise would be rejected
with "AbortError: Request cancelled." This generic error message created
confusion about the reason why the PaymentRequest UI could not be
opened.

This patch keeps the AbortError, but makes the web developer visible
error message more specific to this error condition.

After this patch, if a user attempts to open a second PaymentRequest UI
in a separate tab or window, the .show() promise is rejected with
"AbortError: Another PaymentRequest UI is already showing in a
different tab or window."

Bug: 878453
Change-Id: I5d27171e21b69cfd5fc95a0a72cb6efce343ea5d
Reviewed-on: https://chromium-review.googlesource.com/1195650
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587610}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/android/shortcut_helper.cc.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=dominickn@chromium.org

Bug: 874080
Change-Id: I4555e73ef3bfcb18745bb578d495198908c88609
Reviewed-on: https://chromium-review.googlesource.com/1191789Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587609}

Change-Id: I362b1135d28fd1dfc8686ec7f1c42d0d8540691d
Bug: 871221
Reviewed-on: https://chromium-review.googlesource.com/1196450
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587608}

I remove the dagger-android dependency (https://google.github.io/dagger/android).
It is supposed to simplify injection into Activities and other Android components, however it's questionable that it actually makes things simpler.
It seems, we can do very well without it and remove the extra bloat that it brings.

This also takes care of the problem with .info files not having been properly added when introducing dagger 2 in https://chromium-review.googlesource.com/1183903, which was then worked around in https://chromium-review.googlesource.com/1183903.

TBR=jochen

Bug: 787005
Change-Id: Ie6c0de694a7e73303be784dea25ccc0805c4a3f8
Reviewed-on: https://chromium-review.googlesource.com/1193362
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587607}

No need for the vector here

R=yosin@chromium.org,kojii@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I420acd918a937b1a01071f5fe9ada44db16a1d53
Reviewed-on: https://chromium-review.googlesource.com/1196369Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587606}

The new values are:
- RollbackAndRestoreIfPossible: always roll back, but try to save and
  restore data if possible.
- RollbackWithRestoreOnly: only roll back if it's possible to save and
  restore data.

Bug: 878736
Change-Id: I0455ee4c38537430cb27a86befe51d09d6e312ef
Reviewed-on: https://chromium-review.googlesource.com/1194124Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587605}

The latter is simpler, and allows for some code removal.

BUG=none

Change-Id: Ifaf2fd855e07c2c56cbc13920f17acd29055b9ed
Reviewed-on: https://chromium-review.googlesource.com/1196233Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587604}

This CL adds RecordHitTestData in SVGImagePainter to compute touch
action rects during paint. A layout test is also added.

This CL also put the RecordHitTestData in SVGModelObjectPainter
so that both SVGImagePainter and SVGShapePainter can call.

Bug: 876468
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6aabbad8ac10fc4fb25e4ec16b7a53cbc6cfff27
Reviewed-on: https://chromium-review.googlesource.com/1196903
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587603}

Update clang_version from 7.0.0 to 8.0.0 and remove the code to remove
the old library directory.

Remove the _LIBCPP_HIDE_FROM_ABI define, it is no longer needed.

R=hans@chromium.org,thakis@chromium.org

Bug: 871418, 872926
Change-Id: Ibf6734500aa75a349fa772b225b8b15fddfe3661
Reviewed-on: https://chromium-review.googlesource.com/1194698Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587602}

This CL changes the way the frame of the WebView is changed, moving the
implementation to the FullscreenMediator.

Bug: 836730
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Idc8b339ea61d4024268549789f18ec10c64f0d54
Reviewed-on: https://chromium-review.googlesource.com/1194226
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587601}

Nobody reads these params, and one is passed by non-const ref.

Change-Id: I6913edb40e9bdf5cb3e58b5827d49dd48861540c
Reviewed-on: https://chromium-review.googlesource.com/1188636Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587600}

While prefixes for integer encoding were always at least 4 bits long in HPACK,
QPACK needs a 3-bit prefix, see Sections 5.4.2.4. and 5.4.2.5. at
https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#rfc.section.5.4.2

This change is a no-op, because every line changed is test, or comment,
or making a DCHECK more premissive.

The encoding and decoding logic is generic enough that it does not need to be
changed.

This CL lands server change 209625672 by bnc.

BUG=488484

Change-Id: Ia4e046221b3e960827582f964a386d3027ce1797
Reviewed-on: https://chromium-review.googlesource.com/1190322
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587599}

Migrate from BrowserDistribution to install_static. No functional
change.

BUG=none
R=zmin@chromium.org

Change-Id: I3d10e621d223ccff16edeb39bdb3ad6322c5901b
Reviewed-on: https://chromium-review.googlesource.com/1196016Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587598}

This change updates the Windows Advertisement Payload for Cable to match
a more recent version of the Cable spec.

TBR=arnarb@chromium.org,kpaulhamus@chromium.org

Bug: 837088
Change-Id: Id670a6534c9d23cdeea241c364e3350f6c05cf1e
Reviewed-on: https://chromium-review.googlesource.com/1196512
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587597}

Fix a bug in which hitting the delete key
while an autocomplete suggestion was displayed
deleted the autocomplete suggestion and the
previous character.

Bug: 878485
Change-Id: If7e5486c098d3e9ce1c742dd4ed7ed228187160d
Reviewed-on: https://chromium-review.googlesource.com/1194988Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#587596}

The detectFilesToExtract was returning a list of paths to assets files.
Such path included a directory within assets (e.g. locales/en-US.pak)
but the code that is checking file existense is expecting just name here
(e.g. en-US.pak). This mismatch caused existense check to always fail.

BUG=877033

Change-Id: I93f2e2cdc529ae7f4bf15aac21730853e1ef265e
Reviewed-on: https://chromium-review.googlesource.com/1186465Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587595}

Replaces the "default app" boolean with an enum. If the enum has a
kFromPolicy value, the InstallationTask marks the installed app as
"policy installed" which means that the app will behave like other
policy installed apps e.g. won't sync, user won't be able to uninstall
them, etc.

Bug: 876173
Change-Id: I37821523387cdccd4150ac3c600c94dd9c510050
Reviewed-on: https://chromium-review.googlesource.com/1195181
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587594}

Using wpt-import in Chromium 60647a0f.
With Chromium commits locally applied on WPT:
b4c81942 "Upstream image_capture tests to WPT"
85f4b309 "Notify andruud on changes to wpt/css/css-properties-values-api."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23661

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I88c8432c656df9ac15a171755c06a7d1ab60ffce
Reviewed-on: https://chromium-review.googlesource.com/1196904
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587593}

The algorithm that performs the test between browser language preference
and the systemLanguage value has been modified
to implement a language-tag match based on the prefix,
making it consistent with BCP 47's basic filter operation and
as specified in the SVG 1.1 spec.

The previous behavior was:

- Tests whether the value of the attribute (e.g., "en-us") is a prefix
of the user preferred language (e.g., "en")
(which would evaluate to false)

The test was modified to compare in the opposite manner,
now user preferred language must be a prefix of the value.

- If the language tag length was not 2, the language tag
was not matched, (e.g. It did not match "en-us" to "en-us").
This check has been removed.

- The algorithm did not check for a trailing hyphen ("-").
We do not want langtag "it" matching langtag "ita",
but it is ok for "it" to match "it-it".
Now it does.

------------

The algorithm that performs the test between browser language preference
and the systemLanguage value has been modified
to implement a case insensitive language-tag match:

"en" matches "EN".

The previous behavior was case sensitive.

------------

Add Luca Di Domenico to AUTHORS

------------

Bug: 872378, 869440
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibe767644b5a92e8d79ffe4b7777f5f51851b3883
Reviewed-on: https://chromium-review.googlesource.com/1188314
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#587592}

This makes sure extension internal keep_alive_count counter decrement
when user clicks "Close" button on the Picture-in-Picture window.

Bug: 878743

Change-Id: I4a82ba3e0fa3c3de7241e73352ced30e14c59ca1
Reviewed-on: https://chromium-review.googlesource.com/1193877Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#587591}

The 'available offline content on net error page' experiment, we want to
hide the normal error text, and show it on a popup instead. See these slides for
context: (internal link)
http://slides/14nEG6dYBf0Cb3srp8by0g9Pw_hwM-1TTXQ836xnYvaY#slide=id.g3b90c04859_0_54

Bug: 852872
Change-Id: Id5c8d5d09bb3098a29f8564d30f15ea7f5f748dd
Reviewed-on: https://chromium-review.googlesource.com/1194261
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587590}

TBR: tedchoc@chromium.org
Bug: 879165
Change-Id: I3641bcb810ac915e837d469f0612bd37623fe076
Reviewed-on: https://chromium-review.googlesource.com/1196516Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587589}

This is an attempt to get rid of rare runtime crashes
in this function (see relevant bug entry for details).

The main idea is to get rid of the /proc/self/maps
parsing step in each WriteLinkMapField() invokation.
Since the page to be modified cannot be PROT_EXEC, simply
forcing it to PROT_READ|PROT_WRITE unconditionally
with mprotect() should be equivalent. And because the
function is now much faster, this should reduce the
chances of a racy conflict with the system linker.

Alas, it is not possible to completely remove races
here.

Also note that the previous code didn't handle the case
where the mprotect() failed, and would try to write to the
page nevertheless. This is fixed in this patch.

BUG=831403
R=pasko@chromium.org, rmcilroy@chromium.org, agrieve@chromium.org

Change-Id: Iafeb9e78af3cac5a0335dd9ba1950477566ecd0b
Reviewed-on: https://chromium-review.googlesource.com/1196505Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587588}

Bug: 847933
Change-Id: I8cd925a86d7c5eb15dc36dd67d639d13ed041541
Reviewed-on: https://chromium-review.googlesource.com/1194490
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587587}

This is to prevent the popup from growing on very long password fields.

TBR=rouslan@chromium.org

Bug: 873121
Change-Id: Ia45a59003405181f968897d2d333969b20c3f127
Reviewed-on: https://chromium-review.googlesource.com/1194010
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587586}

Bug: 877493
Change-Id: Ic7b2fafd81aa6b6d46bd390a560c26a4fd0f1c4f
Reviewed-on: https://chromium-review.googlesource.com/1191463Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587585}

Remove some unused code.  Rename and inline new method.

This CL lands server change 209092546 by bnc.

BUG=488484

Change-Id: Ief87a170554fe3829b5b1fe9e9d470af183889fe
Reviewed-on: https://chromium-review.googlesource.com/1190323
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587584}

This queues a report through the Reporting API whenever send() is called
on a synchronous XMLHttpRequest object from a frame in which sync-xhr is
not allowed according to feature policy.

Bug: 867471
Change-Id: If778ea5517fb5728992fe8287b278d1af729902f
Reviewed-on: https://chromium-review.googlesource.com/1191404Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587583}