- 30 Aug, 2019 40 commits
-
-
Hiroshige Hayashizaki authored
We'll name worker/worklet-related things across the tests consistently, with worker/worklet prefixes. This CL renames source context names. Bug: 906850 Change-Id: I0f31cd65c43e4a0bbb51efd4ead141e84ac5b1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777110Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#691914}
-
Bill Budge authored
- Changes return type of bytes() getter to base::span<const uint8_t>. This makes it possible to construct uninitialized inline BigBuffers, avoiding an unnecessary zeroing. Bug: chromium:992991 Change-Id: I9a8d345fd85a1f3195adabb81073d2b54139b302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775726 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#691913}
-
Brandon Wylie authored
Bug: 997343 Change-Id: I409ad9cac4adcea324c7625f8a1123fd9afaf686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772063Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691912}
-
Xiaohan Wang authored
This is to prevent abnormal cases from happening. Bug: 999311 Test: Tested w/ shaka player demo and existing unit tests pass Change-Id: Icef06d979351f16386cf3cbb177971a57a1e264c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777139 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#691911}
-
Matthew Denton authored
Converts all usages of bare new that: (1) construct base::RefCounted objects, (2) use public constructors, (3) are in an extensions directory, and (4) wouldn't cause changes in non-extensions directory to use base::MakeRefCounted instead. Bug: 919580 Change-Id: Ia6def2e499e5195640695b577004df2cd6d95300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772133 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691910}
-
Chisoon Jeong authored
This change performs bitmapDraw() only if dithering is necessary to avoid bitmapDraw() call that causes less responsiveness on low performance ARM devices. Canvas' bitmapDraw() was performed on a webOS ARM device on decoding image for images that don't need dithering when converting its color type. For example converting color type between RGBA8888 and BGRA8888, which is related endian, dithering is not necessary. Therefor these cases can be processed by SkPixmap's readPixels() that is more efficient than Canvas' bitmapDraw() for responsiveness of webpage. Change-Id: Ib33c062519b16429a83445bafa376f2540030425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763523Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#691909}
-
Jinsuk Kim authored
https://crrev.com/c/1743432 didn't take care of BottomSheet in dark mode properly. This CL sets the sheet background color right, and also handles the navigation sheet in dark mode (arrow bubble color). Bug: 993498, 985644 Change-Id: I584438e89e04f1727123dc116f7278ca89d7cadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772944Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691908}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc8238875e84..ab1d1a8d60dd git log fc8238875e84..ab1d1a8d60dd --date=short --no-merges --format='%ad %ae %s' 2019-08-29 chrome-bot@chromium.org Update config settings by config-updater. 2019-08-29 saklein@chromium.org GetChromeVersion: Add endpoint for the chrome version. Created with: gclient setdep -r src/third_party/chromite@ab1d1a8d60dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I87c40ae81f04993e5b87b558c822fc2b1d5b941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691907}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aae21ef6adf6..120b61d34ba8 git log aae21ef6adf6..120b61d34ba8 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 lujc@google.com Use ShaderProgramID in place of GLuint handles Created with: gclient setdep -r src/third_party/angle@120b61d34ba8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I5b513c9cf5e9523788102e4cb657463ab55b7c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777080Reviewed-by:
-
Mike Wasserman authored
The list of blocked paths may include nested entries. Apply the child-blocking setting of the narrowest ancestor path. Eg. If /foo blocks children, but /foo/bar doesn't, allow foo/bar/baz. Bug: 996230 Test: Chrome OS allows Native FS access to files in Downloads, etc. Change-Id: I4a0132f30c85328f543c6758aa76e1625dd21515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777102 Commit-Queue: Michael Wasserman <msw@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#691905}
-
Kuo Jen Wei authored
Bug: None Test: By instrumented test code. Change-Id: I7af7ada02e2a2bf09a7f174af03dd8c29e46c85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775686 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#691904}
-
Keishi Hattori authored
When CooperativeScheduling runs a nested loop, it should not run any tasks from the yielded EventLoop, as this will change the order of task execution. To stop all task queues belonging to a EventLoop, this CL registers the frame schedulers to the EventLoop. Documents with ContextDocument should not register their schedulers as they share the context document's scheduler, and would cause duplicated registration. Bug: 804661 Change-Id: Iec2d772090c39740337400d7ff547465aeb582c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743290 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691903}
-
Lily Chen authored
Previously CookieInclusionStatus was just an enum with one value for inclusion and a number of other values for exclusion due to different reasons. This changes CookieInclusionStatus to hold multiple exclusion reasons, with inclusion represented as a lack of any exclusion reasons. This is implemented as a bit vector with each exclusion reason represented as a single bit. This also adds warnings to CookieInclusionStatus, which indicate when warnings should be emitted about a cookie (regardless of inclusion or exclusion). This removes the need for the previous hack which indicated warnings by making a duplicate of the cookie with a different CookieInclusionStatus. Bug: 993843 Change-Id: I8f4f76ea5c7225cd01342786b20f9e0b05f582c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756157 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#691902}
-
Andrew Grieve authored
Bug: 999007 Change-Id: Iaef942233a4c34cd6740b1362ab7b798cfa95860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777087 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691901}
-
Matt Reynolds authored
In macOS 10.15, Game Controller API added support for Xbox Wireless Controller and Dualshock 4. In Chrome, these devices are already supported through XboxDataFetcher and GamepadPlatformDataFetcherMac. When GameControllerDataFetcherMac also enumerates them, a duplicate gamepad is added to the gamepad list. To prevent this, GameControllerDataFetcherMac will skip these devices during enumeration. 10.15 added a new productCategory property to GCController which allows applications to detect these newly-supported devices. This CL uses productCategory when available, and compares the device's vendorName against known values when it is not. BUG=971801 Change-Id: Ie937f341d1f3c3c1c3a81d6717da2f15d6f6b993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773708Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#691900}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7449a2b. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia1d33b9e6d8378ff74b927351f2ad7cf0a9a61e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772646Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691899}
-
Leszek Swirski authored
Bug: 865098 Bug: 945321 Change-Id: I557f5b6a2d2ed8f3d24add92830120a6b294878b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774456 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#691898}
-
Kai Ninomiya authored
Bug: 475095, 478572, 479260, 606096, 610951 Bug: 772651, 792210, 798117, 844311 Bug: 857644, 903903, 906742, 945903, 949249 Bug: 951628, 951771, 957644, 974347, 979444 Bug: 979641, 981579, 983142, 986808 Bug: angleproject:1007, angleproject:2708 Bug: angleproject:2722, angleproject:2909, angleproject:2910 Bug: angleproject:2911, angleproject:2912, angleproject:2913 Bug: angleproject:2918, angleproject:2919, angleproject:2920 Bug: angleproject:2922, angleproject:2929, angleproject:2931 Bug: angleproject:2987, angleproject:3343 Change-Id: I7007f383bf625b2d67081d3428958cd187649ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773437Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#691897}
-
rbpotter authored
Bug: 721073 Change-Id: Iaef46bc33ba84563942b68d44a8684d8571914b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762544 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#691896}
-
Robert Sesek authored
Using global defines pollutes the build. The preferred method for feature defines are to use buildflags, which are scoped to the targets and files that require them. Change-Id: Ib583735e21f83b5a0084e52282bfba0f06a4ec71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775876Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#691895}
-
K Moon authored
Drops PDFiumPage constructor arguments that are mutable after construction. Long lists of constructor arguments are less clear than named calls, and callers can avoid setting arguments they don't care about. For example, the page rectangle can be initialized by a layout calculation, rather than at construction time. In the same spirit of removing undesirable degrees of freedom, the set_available(boolean) method has been replaced with a one-way MarkAvailable() method. (It doesn't make sense for an available page to become unavailable.) Bug: 885110 Change-Id: I98cf558320b4b752d7d7b8da2144d70a36b80a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771042 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LayoutText::SetTextWithOffset()| to reduce text shaping by reusing |ShapeResult| of before and after replaced range for improving performance, 10% to 15% faster but 3 times slower than legacy layout. (Profile data: http://bit.ly/33B9rfg) From this patch, |SetTextWithOffset()| does: 1. Get offset mapping to map DOM offsets to text content offsets for replaced range. 2. Collect inlines into |text_content| and |NGInlineItem| to get newly inserted text. 3. Copy before and after |ShapeResult| from current data to |NGInlineItem| list in step 2. 4. Call |NGInlineNode::ShapeText()| with |NGInlineItem| list to reuse |ShapeResult|. This patch gets rid of NGInlineNodeTest.InvalidateSetTextWithOffset because new test case replaces this test and this test call |SetTextWithOffset()| with wrong parameter. It shoulbe |SetTextWithOffset("baftere", 1, 4)| as result of |"before".replaceData(1, 4, "after")|. Note: This is reland of http://crrev.com/c/1729330 TBR=yosin@chromium.org Bug: 707656, 998507,998683, 999005 Change-Id: I016180de37b7afcb71998658ad66c001482029fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775647Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691893}
-
Joel Hockey authored
Supports only CLIPBOARD selection and not PRIMARY (for now) since ozone only supports a single clipboard. Regisers to receive XFixesSetSelectionOwnerNotify events and prefetches and caches supported mime types whenever ownership changes. Also prefetches clipboard contents as 'text/plain' since that is the most likely type to be requested. If clients request a different type, it will be fetched at the time of requesting. Converts text/plain[;charset=utf-8] <=> [UTF8_]STRING to allow interoperability with other applications which do not use the same mime types as chrome. This code can be patched into linux-chromeos (chrome os running on a linux desktop) by modifying the build file: sed -i s/is_desktop_linux/is_linux/ ui/base/clipboard/BUILD.gn Bug: 985187 Change-Id: I4277f903ab8f11e0f5ad14d095eb099cf775f771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736619Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#691892}
-
Nandhini authored
Bug: 999272 Change-Id: If23c397fc23a657e09b2291ab9ea1c12b319ee35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776609 Commit-Queue: Nandhini Raman <nraman@google.com> Reviewed-by:
-
Adam Langley authored
The HID code was correctly ignoring messages for unknown channels, but only if they fit in a single frame. For multi-frame messages, the first frame was ignored and then the continuation was considered to be an initial frame again and would generally cause a parse error. Bug: 998452 Change-Id: Ia21ee44b7c690c897c1cca52d94e0c4e88eb16db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776985 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#691890}
-
Caleb Rouleau authored
See bug for context. Bug: 997257 Change-Id: I884668d55e28c2b0df7253467abe125cea71c431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773513Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691889}
-
Adam Ettenberger authored
AXObjectCacheImpl::GetOrCreate(LayoutObject*) can return a nullptr if the node is an area element. This change makes sure that the AXObject is valid before calling |IsAnchor|. Bug: 996460 Change-Id: I63b966615aec010c6df03292addbcd0a71e405ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772283Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691888}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bad3985ba95f..f7919e0eeb73 Created with: gclient setdep -r src-internal@f7919e0eeb73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idac521bb4452e349dace51c83e0ff3ab30a17c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776852Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691887}
-
Jinsuk Kim authored
With a new haptic response for navigation added by https://crrev.com/c/1772780, UX recommends the one for navigation sheet triggering be removed. Bug: 998943 Change-Id: Ibae6cf53227762036bb4413c177d5db76d10cf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772870Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691886}
-
Matt Reynolds authored
This CL avoids a crash when disconnecting a Joy-Con Charging Grip gamepad. The Joy-Con Charging Grip is a USB-C device that docks with two Nintendo Switch Joy-Cons and allows them to behave like a single USB gamepad. When disconnecting, NintendoDataFetcher::RemoveDevice decomposes the gamepad representing the charging grip into its Joy-Con subcomponents (composite_left_ and composite_right_). The parent device is then shut down, which may trigger a "stop vibration" command. This causes a null dereference when it tries to forward the vibration command to the subcomponent. To fix, the vibration command is sent before the subcomponents have been removed from the parent device and additional checks are added to ensure the subcomponents are not dereferenced after the parent is decomposed. BUG=995548 Change-Id: I1d82e423b134ab3c99dd1e98a6615555cfadd47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758980Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#691885}
-
Kyle Horimoto authored
Previously, we would only connect when Enter was pressed on the password field. However, for networks with no password, the Enter key did not trigger a connection when pressed in the SSID field. Bug: 999106 Change-Id: I5996b1c31d1026a2a294e469da6c54c346e14f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776939 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691884}
-
Erik Chen authored
Previously, the class was keeping a raw pointer to a WebWidget object. While we would eventually like the lifetime of RenderWidget and WebWidget to be synchronized, they are not yet. This CL updates the pointer to be to a RenderWidget object, guaranteed to outlive the WebWidgetLockTarget. Bug: 999243 Change-Id: I9a2a546823b658a24d25fc9ae7a2d4e7e61ad5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776981 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This reverts commit 6caf7e08. Reason for revert: the Settings can be nullptr, see https://crbug.com/999333 Original change's description: > Hook up animations to ValidationMessageOverlayDelegate > > ValidationMessageOverlayDelegate hosts an internal blink::Page > which is not properly integrated into the normal BeginMainFrame > flow. As such, it needs to be manually prodded in various places. > Integration already existed for layout and paint - this CL adds > animations as well. > > This previously worked because blink::AnimationClock would advance > its own time (against the spec), and so the internal Page would see > advancing time and the animation would keep ticking. When we fixed > blink::AnimationClock to be by the spec, we also broke this. > > This CL also makes sure that the animation used by > ValidationMessageOverlayDelegate is not composited; the internal Page > has no compositor so composited animations will not work. > > Bug: 990680 > Change-Id: I16aaddbfa57eaefadfb557fc9cb435d94672e637 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763162 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691673} TBR=flackr@chromium.org,pdr@chromium.org,smcgruer@chromium.org Change-Id: If639ac736d0f00ea673f432e93ffd00440289dd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777083Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#691882}
-
Avery Musbach authored
The present CL follows up after [1] about overview not stealing focus from a window snapped in split view. The present CL makes the solution simpler and less error prone. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1756550 Test: ash_unittests TabletModeControllerTest.StartSplitViewAndThenOverview Bug: 993403 Change-Id: I9c25fbdfa8fd63050769817e1e2b4380389bd015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768833Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#691881}
-
Thomas Guilbert authored
The following commit: 3483b4af Added or renamed a series of tests that time out on the Webkit Linux Msan bot. This CL disables the ones that are causing failures due to timing out. TBR=robertma Bug: 856601 Change-Id: Ic68e86201a79e53732c767321d53f25bd2c33d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777076Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#691880}
-
Albert J. Wong authored
RenderWidgetHost::GetVisualProperties() was doing 3 separate things (1) Actually calculating the VisualProperties (2) Checking against the last stored VisualProperties to determine if the stored copy needs updating. (3) Determining if an ack should be expected if an update is eventually sent with the result of this function. This CL breaks it out into 3 new functions: GetVisualProperties() - Generates the VisualProperties. This should be const but too much of the call chain underneath it did not annotate their getters with const that annotating would be too annoying. DidVisualPropertiesSizeChange() - Helper function that extracts a common query used by DoesVisualPropertiesNeedAck() and StoredVisualPropertiesNeedsUpdate(). DoesVisualPropertiesNeedAck() - Returns true if sending the given VisualProperties update to the renderer will generate an ack. StoredVisualPropertiesNeedsUpdate() - Returns true if the stored copy of the VisualProperties is different enouhg from the incoming one that it needs an update. Bug: 998273 Change-Id: Ie8fee3ddedc1ea8b492765cb5b35e7bda99234de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773878 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#691879}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6431d3a8dd5f..fc8238875e84 git log 6431d3a8dd5f..fc8238875e84 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 mmortensen@google.com Implement DevInstall binhost uploads in the Build API. 2019-08-29 yueherngl@google.com chromeos_config_boards: add kevin-arc64 board 2019-08-29 evanhernandez@chromium.org packages: Small fix for sample PUpr hack Created with: gclient setdep -r src/third_party/chromite@fc8238875e84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I30d160e324033162aa18dd7900c9d78b0b43d847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777039Reviewed-by:
-
Yi Xu authored
In OffscreenCanvasPlaceHolder, placeholder used to refer to both Canvas and OffscreenCanvas. This updates all function names to avoid ambiguity. Change-Id: Ia272c3b9e6f978c8c4f638cc7a8b1606d4a2b29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776405Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#691877}
-
Julian Watson authored
Bug: 990117 Change-Id: I272428fd2c32fd0fddb84dc97ad88693a704f539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775951 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#691876}
-
Kevin Ellis authored
This is a speculative fix for 997076. Animation::ContextDestroyed sets a flag to indicate that the animation is finished and prevents propagation of the finished event. With the code health refactoring in 1739386 and 1773536, the updates could continue after an execution context is destroyed. Bug: 997076 Change-Id: I81d80b45428801abde61ad4122c2027ffe15efc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776732 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
