- 17 May, 2019 40 commits
-
-
Scott Violet authored
It's still used by test_ws (and tests), but no longer used by ash/chrome. BUG=964460 TEST=covered by tests Change-Id: Iaeb601bae144b775b710b8e80ff2a8ed9bf5e1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618063Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#661066}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/662a859f9bb3..c9cf972dcae3 git log 662a859f9bb3..c9cf972dcae3 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 sadrul@chromium.org rendering: Fix handling unsual traces. Created with: gclient setdep -r src/third_party/catapult@c9cf972dcae3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964187 TBR=simonhatch@google.com Change-Id: I77bb88a16f90d7758182941f10c41f4d5cd8468f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661065}
-
Jun Cai authored
This CL removes the unnecessary include file in bluetooth_scanning_prompt_controller.cc Bug: 953075 Change-Id: Ie1fb4efdeaced43308aed0782775ee295c6b48db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614708Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#661064}
-
Henrique Grandinetti authored
This widget is being create to facilitate the usage of the Parent Access views in WebUI pages. With the widget it is possible to instantiate the view without a pre-existing view hierarchy. We will start using this in a follow up cl. Bug: 921145, 921142 Change-Id: If57a14aac63a45c0da46766ce191ef392c322aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610818Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#661063}
-
Henrique Nakashima authored
This CL creates the following new metrics: - Android.BackgroundTaskScheduler.TaskLoadedNative.ReducedMode - Android.BackgroundTaskScheduler.TaskLoadedNative.FullBrowser They represent Android.BackgroundTaskScheduler.TaskLoadedNative broken down into two cases: loading Reduced Mode and loading Full Browser. These histograms will inform whether the behavior is in line with our expectations for each task type. Bug: 962577 Change-Id: Ic58b5b0ef45713377bc53a559c93c0ac65b86507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611656 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#661062}
-
Yuwei Huang authored
This CL makes the IT2ME non-delegated code path use MuxingSignalStrategy and the new support host registration API. I'm able to connect to the IT2ME host through XMPP but I couldn't verify if it works on FTL since the website doesn't synthesize the `from` and `to` fields yet. Bug: 962765 Change-Id: I8db9834cbc149ada0527ca0c2cd45264553e5782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616385 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#661061}
-
Danan S authored
This is needed for apps launched from the Settings Parental Controls. For the ARC equivalent, we map this to arc::UserInteractionType::APP_STARTED_FROM_SETTINGS Bug: 937995 Change-Id: Ie953e6309bb705ca7be17be284050bbca0880b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613960 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#661060}
-
Dan Harrington authored
******************************Resource Sizes Diff****************************** Specifics: +77,856 bytes main lib size +562,136 bytes main dex size +64,120 bytes secondary dex size +1,019,376 bytes normalized apk size InstallSize: +393,902 bytes APK size +1,126,622 bytes Estimated installed size (Android Go) +2,923,976 bytes Estimated installed size InstallBreakdown (+2,920,885 bytes): +4,021 bytes Native resources (no l10n) size +2,776 bytes Non-compiled Android resources size +77,856 bytes Native code size +793 bytes Package metadata size +2,807,307 bytes Java code size +28,132 bytes Compiled Android resources size Dex: +3,248 entries fields +4,765 entries methods +1,353 entries types +2,835 entries strings Bug: 948739 Change-Id: I39a56c41e0d386e4da772dbc7bb65f485aefdc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613779Reviewed-by:Dan H <harringtond@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#661059}
-
Sujie Zhu authored
If the user goes through checkout flow several times without closing the tab, the local card migration manager won't be re-created which leads to the case that the variable supported_card_bin_ranges pre-exist before GDFSC calls. We do not filter the unsupported cards during GetMigratableCreditCards(). We only call FilterOutUnsupportedLocalCards() when OnDidGetUploadDetails() for checkout flow. We remove the local var of the supported bin ranges. If later any usage of FilterOutUnsupportedLocalCards() outside OnDidGetUploadDetails, we need to add back the local var. Add some comments about these two functions to make it clearer. Bug: 954367 Change-Id: I7fc7cbdecf76d25b34737ef6ddc25737f7540657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614456Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#661058}
-
Lucas Tenório authored
This change adds a webview to the supervision onboarding screen and adds code that authenticate fetches made by this webview. The whole flow for displaying a Supervision Onboarding page is: - Fetch access token scoped to supervision servers. - Add listeners to webview requests to we can add the access token and inspect their HTTP responses. These listeners only fire for requests to the URLs that we want. - Start the request and wait for the webview to finish loading. - Return all occurrences of the supervision custom HTTP header found in the responses. - Onboarding controller now decides if it should exit the flow or continue showing the page based on the custom header values. Some notes on implementation choices: - We want to keep most of the logic that controls the flow in the Onboarding controller. We plan on reusing this controller to power a dedicated WebUI that will provide the same flow outside of the OOBE/Login. - For now, all the server configuration is being done by switches. This is necessary since the Supervision server is still being built, so the switches make development easier with local dev servers. When the server is done these switches will be deleted and become constants. - I had to divide the login:closure_compile target because I needed to add the chrome_extensions.js externs file. There's a full explanation why that was a problem in the BUILD file. - Tests are incoming! They are actually ready but I wanted to keep this change simple. See the related change if you're curious. Bug: 958995 Change-Id: Iedb39bc7fb76fb8fdc516171e1e6d094c248561a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611786Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#661057}
-
Yuwei Huang authored
The ME2ME authenticator will make sure the signaling message comes from a sender with an expected JID. Currently for non-gmail account that JID will be a GAIA JID that is different than the user's actual email. This works for XMPP connections but won't work for FTL since FTL always uses the user's actual email for message routing. This CL makes the authenticator always use the user's actual email when connecting through FTL. Bug: 964165 Change-Id: I424435888a81a095e944d02decb49d52cec57e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618018 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
-
Pavel Yatsuk authored
In this change: - Only show "Add to my apps" for items that support it. - Add "Add to my apps" menu item for site suggestions. R=wylieb@chromium.org BUG=963655,959317 Change-Id: If101cf8ea892852e4c68db5f3974515174a690f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618051Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#661055}
-
Kyle Milka authored
This gives the attribution link the proper context menu. Screencast: http://go/scrcast/NTkxNDI0NDY2MDg1NDc4NHwyOGZhZTViMy1jMQ Bug: 963399 Change-Id: Iadccc1a9457b3c7ac6f1093197c937190815821b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616998Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#661054}
-
Danan S authored
This was mistakenly omitted from https://crrev.com/658192 Bug: 957832 Change-Id: I735dfee7d44e771b42e34503e69a67a81d8061e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617209 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#661053}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e6f19dda56ee..238d886eb99c git log e6f19dda56ee..238d886eb99c --date=short --no-merges --format='%ad %ae %s' 2019-05-17 saklein@chromium.org ArtifactsService: Cleanup BundleAutotestFiles method. Created with: gclient setdep -r src/third_party/chromite@238d886eb99c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ib0d16aeee83353ae576ca173f1ca2fc276db558f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617888Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/52bfbd35fc96..cd3011fb0654 git log 52bfbd35fc96..cd3011fb0654 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 jonahr@google.com Fix formatting issue in generate_stats Created with: gclient setdep -r src/third_party/angle@cd3011fb0654 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I115dff3a713affed149122cc93310a860673ecc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617887Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ca7ce3f76a5..25331bfed596 git log 1ca7ce3f76a5..25331bfed596 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@25331bfed596 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1daf6c1e840ac16706d1773827d5cb57ac4bbb42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617688Reviewed-by:
-
Rakib M. Hasan authored
Currently the gpu_integration_test_adaptor.py script takes the test filter which comes in Typ's test filter format, and then transforms it into a regex, which is what telemetry browser tests expected before crrev.com/c/1503875 was landed. This CL will make it use Typ's --test-filter format. It also adds a unit test for the --test-filter command line argument for GPU tests. Bug: chromium:698902 Change-Id: I8a86dd540f3ff528b2579524769d5f52c8212343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610511Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#661049}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If09cbb1d81e9e95579d6ef3e813766902a0d6fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617886Reviewed-by:
-
Leonard Grey authored
Bug: 956241 Change-Id: I70e6195b0b297eba77a7952714de3e348e251f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599669 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#661047}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85e6c29b6f88..f17fbca40861 Created with: gclient setdep -r src-internal@f17fbca40861 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:850199,chromium:913040,chromium:955936,chromium:954336,chromium:963172 TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ice6e1e6b63a309e8671fb367dd43092e85fbac67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661046}
-
Alex Clarke authored
Implements Then and Catch on top of AbstractPromise as well as ManualPromiseResolver<> which is needed for testing at this stage (PostTask doesn't yet return a promise). It's also necessary for promises to interface with old style callback based libraries which are extremly common in Chromium. Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit Bug: 906125 Change-Id: Id7206698f37c59cfc201f3970cbf66a2ef89ee4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599620 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#661045}
-
Yun Liu authored
JSON format defined by code coverage tool proto: https://cs.chromium.org/chromium/infra/appengine/findit/model/proto/code_coverage.proto Bug: 843307, 961806 Change-Id: I077fbad4693946b9238c7768a8b9346526aa0099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614713 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#661044}
-
Sam McNally authored
Replace TopicSet in most places with Topics, a map from Topic to metadata for that topic, currently containing just whether it's public. Populate this when converting from ObjectIdSet, using InvalidationHandler::IsPublicTopic(). Bug: 912281,939039 Change-Id: I1b980ddb31ab2f21a0ef5f239ef98359aa8375fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570963Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#661043}
-
Becky Zhou authored
Bug: 925562 Change-Id: Ied102c3e8f15c2ee15f9e4a7eb3d87a2d433e5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617084Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#661042}
-
Godofredo Contreras authored
Bug: b/132795052 Test: Manual and CQ Change-Id: I57deb7bd5867f57226436f05185be6a1903550c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611312Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Godofredo Contreras <godofredoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#661041}
-
Robert Flack authored
Now that all of the unit tests construct real elements with a computed style we should never ask to start an effect on an element without a computed style. Bug: 961686 Change-Id: I6ca2148994ed84cd3d4df9e77aae5576a29154d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618064 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#661040}
-
Ryan Hansberry authored
In logs from Smart Lock bug reports, I have observed remote devices being 'successfully' set in EasyUnlockServiceRegular and ProximityAuthSystem, quickly followed by a message from ProximityAuthSystem 'User... does not have a Smart Lock host device'. This change improves logging around setting remote devices in order to better diagnose the issue if it's observed again. Bug: 953027 Change-Id: Id46c62aba4e441b3fcb4c32332b392a77e947cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617086 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#661039}
-
Bailey Berro authored
This change introduces a notification that will be displayed when a user plugs in a USB printer that requires manual configuration. Clicking the notification will open CrOS settings so the user can manually configure the printer. - Subsequent CL will call ShowConfigurationNotification() to show the notification. Bug: 951139 Change-Id: Ibff4d415de9c3ccf8eda45f470cfa30513468bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606193Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#661038}
-
Philip Rogers authored
This patch adds links to the "Debugging blink objects" doc to the renderer/core/paint/README.md file. Change-Id: I1397bbb171892aa0f3438927cfb1e1666dabfb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615370 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#661037}
-
Kevin Marshall authored
Moves named_message_port_connector.js to a common location so it can be used by more platforms than just Fuchsia. Bug: 953958 Change-Id: Iabcab36f6f1fc421f0afb77ca88eb499d3a29bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610602Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#661036}
-
Joel Einbinder authored
There was a missing } Change-Id: I609a0e16968091f5fc5d487ad23059204299bd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617204Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#661035}
-
Henrique Nakashima authored
DownloadServiceFactory and PrefetchServiceFactory are currently BrowserContextKeyedServiceFactories (BCKSFs). This CL makes them SimpleKeyedServiceFactories (SKSFs), so they can be used in Service Manager Only mode. Both need to be changed at the same time because they have circular dependencies on each other through OfflinePrefetchDownloadClient. Helper GetForBrowserContext() methods have been left in both factories to control the breadth of this CL. I'll send a follow-up to change all callers to GetForKey(). Bug: 943724, 953918 Change-Id: I6ae3404bc301f6bcb3c5665dbc59457e53d8a07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600839 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
-
Darren Shen authored
We currently start the VK in an UNKNOWN state. When we enable the VK, we first transition to INITIAL and then immediately transition to LOADING_EXTENSION. When we disable the keyboard, we reset to the INITIAL state. This is kind of weird. We might as well start at INITIAL state and transition to LOADING_EXTENSION when we enable the keyboard. The only impact would be on the UNKNOWN -> INITIAL transition for metrics, but the number of UNKNOWN -> INITIAL transitions should be the same as INITIAL -> LOADING_EXTENSION anyway. Bug: 845780 Change-Id: I39c6190a73daf9d9b4349916bfc0d1c825812ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616824Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#661033}
-
Rohit Rao authored
Registers an NSPrincipalClass in the test bundle's Info.plist, which provides the name of a class that is automatically instantiated when the test bundle is loaded into the test runner process. We can use this class, along with the XCTestObservation protocol, to run startup code before any tests are run. In this CL, we copy pak files into the test runner's bundle and initialize the ResourceBundle at startup, which allows EG2 tests to use string resources as needed. BUG=922813 Change-Id: I348ed41be3939aea2a7525205969a538bbaaefa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618024 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661032}
-
Collin Baker authored
This reverts commit 0cf7d62e. Reason for revert: likely cause of WebKit MSAN failures: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20MSAN/14589 Original change's description: > DevTools: Make Preferences Settings Pane Accessible > > Preferences pane had following accessibility issues and is fixed as follows: > - The top heading was in h3. > > Fix: Updated h3 to h1 > - Subcategories was missing heading role of h2 and group roles for subcategories was missing > Fix: Added role heading of level 2 > Fix: Added role group to each sub categories > - Label for drop-downs were not linked with select element so, screen reader wasn't reading out for drop-downs. > Fix: Added 'for' attribute in label with id value of drop-down select element > Change-Id: I64d433522c814b8f65ced29958524ac175d987ac > > Bug: 963183 > > Video showing Preferences pane after this change https://imgur.com/caUMd46 > > Change-Id: I64d433522c814b8f65ced29958524ac175d987ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600533 > Reviewed-by: Erik Luo <luoe@chromium.org> > Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#660890} TBR=einbinder@chromium.org,luoe@chromium.org,jeffish@microsoft.com,jalissia@microsoft.com,ambake@microsoft.com,juxiao@microsoft.com,chshrest@microsoft.com Change-Id: Ie904d53939015381c962e50e310f4ceaae484e49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618170 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#661031}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3fa60010e45..efb9f14aba03 git log f3fa60010e45..efb9f14aba03 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 robertphillips@google.com Add testing of mipmaps to backend allocation test 2019-05-17 bsalomon@google.com Revert "Make SkSurface::asyncRescaleAndRead use kStrict constraint" 2019-05-17 jvanverth@google.com Fix matrix layout in Metal. 2019-05-17 mtklein@google.com Revert "byte align everything in SkSLInterpreter" 2019-05-17 reed@google.com Experimental SkVideoDecoder, to wrap calls to ffmpeg 2019-05-17 mtklein@google.com byte align everything in SkSLInterpreter 2019-05-17 michaelludwig@google.com Force snapBackImage() to N32 for image filters 2019-05-17 bsalomon@google.com Make SkSurface::asyncRescaleAndRead use kStrict constraint Created with: gclient setdep -r src/third_party/skia@efb9f14aba03 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I36b82379876dc84bc79108a5d489b9cfaad35da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618102Reviewed-by:
-
Collin Baker authored
This reverts commit b8296ec2. Reason for revert: reverting to allow revert @ crrev.com/c/1618170 Original change's description: > DevTools: Make Settings Blackboxing Pane Accessible > > This change provides fixes for these issues: > Problem: The content title was heading role > Fix: Added heading role of level 1 > Problem: Aria-label was missing in drop-downs > Fix: Added aria-label in drop-downs > > Tested keyboard navigation > - navigate up/down drop-down items using arrow keys > - Checkbox is checked/unchecked using space bar > - Tab into/out (no tab traps) > > Tested screen reader > - reads checkbox label > - reads items selected from the drop down list > > Bug: 963183 > > Change-Id: Iaab2dd37323427215f765b3d7bbef885861c210f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605506 > Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660991} TBR=einbinder@chromium.org,luoe@chromium.org,jeffish@microsoft.com,jalissia@microsoft.com,ambake@microsoft.com,juxiao@microsoft.com,chshrest@microsoft.com Change-Id: I043b25bb968124defd01edd2058bb2603bc1e386 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618026Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 964341 Change-Id: Id669a728089030cfb7f638eaa38668ac15e2bad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617442 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#661028}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/63d0bc4ae8dc..da26cdbf3574 $ git log 63d0bc4ae..da26cdbf3 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 rch gfe-relnote: Fix a bug in QuicSpdyClientStreamBase. Protected by --gfe2_reloadable_flag_quic_eliminate_static_stream_map_3 2019-05-17 fayang gfe-relnote: In QUIC, ignore bad bandwidth samples. 2019-05-17 dschinazi Prevent include failures of quic_flag_utils 2019-05-16 rch gfe-relnote: n/a - Remove unused includes in quic_toy_client.cc 2019-05-16 nharper Renumber QUIC streams when there is no crypto stream 2019-05-16 fayang gfe-relnote: In QUIC, only vlidate destination_connection_id_length and source_connection_id_length when should_update_expected_connection_id_length is false. No functional change expected, not protected. 2019-05-16 rch gfe-relnote: n/a - Remove overly broad include from quic_toy_client.h 2019-05-16 fayang Add logging only ack_frame accessor. 2019-05-15 rch gfe-relnote: n/a - Add missing include for quic_flag_utils.h in quic_packet.cc 2019-05-15 nharper Add QUIC_BUG_IF to QuicUtils::GetCryptoStreamId 2019-05-15 rch Move virtually all the toy client logic out of quic_client_bin.cc and into a new QuicToyClient class which can be used in chromium. 2019-05-15 wub gfe-relnote: (n/a) Delete use_stateless_rejects_if_peer_supported from QuicCryptoServerStream's constructor. No behavior change, not protected. 2019-05-15 dschinazi Replace a DCHECK with a parse failure in connection ID parsing 2019-05-15 rch Move drop_response_body from QuicClient to QuicSpdyClientBase to share with chromium 2019-05-15 rch Extract the FakeProofVerifier from quic_client_bin.cc to facilitate sharing with Chromium. 2019-05-15 dschinazi Add QuicFramer Probe methods 2019-05-15 vasilvv Remove .impl() method from QuicSocketAddress and QuicIpAddress. 2019-05-15 quiche-dev Change QuartcClientEndpoint to handle client-side version negotiation. 2019-05-15 wub In quic_client_bin.cc, print the "Request (succeeded|failed)" messages in stdout instead of stderr. 2019-05-15 fkastenholz Have separate uni- and bi-directional stream limits for IETF QUIC 2019-05-15 wub Fix a use-after-free in quic_client. 2019-05-14 quiche-dev Project import generated by Copybara. 2019-05-14 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_fix_termination_packets. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src [Reland https://chromium-review.googlesource.com/c/chromium/src/+/1616941 with Fixes] Change-Id: I5236123890aefa12a6f1c09c9ce4c3db021580e4 TBR=steveanton@chromium.org Change-Id: I5236123890aefa12a6f1c09c9ce4c3db021580e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618019Reviewed-by:
Brad Lassey <lassey@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#661027}
-
