- 19 Jul, 2018 12 commits
-
-
Alex Moshchuk authored
Bug: 865206 Change-Id: Id94f5a610b31a5e63c494030a792fe168583d95d Tbr: rsorokin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1142702Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576277}
-
Luke Halliwell authored
I noticed this used by mistake in a couple CLs recently. The define isn't set in gn, misleadingly makes people think their code is tested on cast_shell bot. TBR=slan@chromium.org Bug: None Test: None Change-Id: Ie4b16ca4b1bb565fe8d45598f7cc0601277907d9 Reviewed-on: https://chromium-review.googlesource.com/1139214 Commit-Queue: Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#576276}
-
Fady Samuel authored
RenderWidgetHostViewBase::GetFrameSinkId passed the viz::FrameSinkId by value and was not a const method. This CL returns a const ref of FrameSinkId and makes GetFrameSinkId a const method so it can be accessed even if the caller has a const pointer or reference to the RenderWidgetHostViewBase object. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5142a75f21a1c0396ba868bf66699a2fb85a2c33 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1141985 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576275}
-
Daniel Murphy authored
R=pwnall@chromium.org Bug: 857464 Change-Id: I58218cf3f4831842f5fddaca480523e5c9169f35 Reviewed-on: https://chromium-review.googlesource.com/1142474 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#576274}
-
Orin Jaworski authored
Weather answers with °F will have TOP_ALIGNED text ranges, and this CL detects them to raise the text, improving readability. Bug: 864798 Change-Id: I3a2dff9fc0e28283bdeaaa2413d261d076737a8f Reviewed-on: https://chromium-review.googlesource.com/1142385Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#576273}
-
Xu Xing authored
BUG=NONE Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4626621916085e01fec25150da5ea1fba9cd63a8 Reviewed-on: https://chromium-review.googlesource.com/1139579Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#576272}
-
Ryan Tseng authored
These have migrated to luci Except for heartbeat, which has been deleted. Bug: 790703, 790614 Change-Id: Ida1e02c3b1671471a07bfa8f11bda407f0a0d7a6 Reviewed-on: https://chromium-review.googlesource.com/1142615Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#576271}
-
wutao authored
This patch adds an about flag for continue reading. Bug: 843839 Test: manual. Change-Id: Icb0856b54936f7cf1a507abc80441260b4956fa5 Reviewed-on: https://chromium-review.googlesource.com/1140525 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#576270}
-
Christian Fremerey authored
This CL is part of a series, see Design Doc at https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing Test: capture_unittests --gtest_filter=VideoCaptureDeviceFactoryLinuxTest Bug: 768887 Change-Id: I91c8f3ccd30663532437a62410a2f8bc6536308e Reviewed-on: https://chromium-review.googlesource.com/1123655 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576269}
-
Raymond Toy authored
Measure the output of the destination to determine if the output is audible or not. Also keep track of the total duration of when audible output was played. Bug: 855069 Change-Id: Icec9aa3d3b853bb5b4b9287ce9350d2e16cd383e Reviewed-on: https://chromium-review.googlesource.com/1102664 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576268}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 09223a46. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21541 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources kpaulhamus@chromium.org: external/wpt/webauthn panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing TBR=foolip No-Export: true Change-Id: I42d16bad7549e3d5c73860342a9cfb557033932b Reviewed-on: https://chromium-review.googlesource.com/1142436 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576267}
-
Yue Li authored
- Add separate flag (kActivityControlAccepted) to determine opt-in flow completion. This flag will also be used to control opt-out mode UI. - Remove runtime opt-in(when "Enable" button pressed and when Assistant key pressed). Assistant should be in opt-out mode in these cases. - No longer disable Assistant if user decline the activity control in opt-in flow. - Enable Hotword by default. Bug: b/111569973 Test: Manual Test Change-Id: I11c018b3149fe21b5d6dde4a410ea422f8391e3d Reviewed-on: https://chromium-review.googlesource.com/1141346Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#576266}
-
- 18 Jul, 2018 28 commits
-
-
Zhongyi Shi authored
QUIC Connection Migration: clean up the code before disabling connection migration before handshake. This change also changes to use session's netlog instead of separate netlog to log connection migration event if connection migration will be aborted early. Bug: 790547 Change-Id: I7a53bc315953fd57bfad3d0d249f90b200844051 Reviewed-on: https://chromium-review.googlesource.com/1141177 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#576265}
-
Peter Kvitek authored
Change-Id: Id112e69693cf40f3e1dc2980a690ac4e5153d8d4 Reviewed-on: https://chromium-review.googlesource.com/1135765 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576264}
-
Shubhie Panicker authored
Now freezing of loading should be triggered by the master flag: StopInBackground, and doesn't need its own flag. Bug: 775761 Change-Id: I1d899fb63b9ac6d6bb032a5d065437ebd47eb200 Reviewed-on: https://chromium-review.googlesource.com/1140905 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576263}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/30688fb1c434..f22b4e2f6682 git log 30688fb1c434..f22b4e2f6682 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 hnakashima@chromium.org Use casts to deduplicate implementation of const/non-const methods. 2018-07-18 hnakashima@chromium.org Fix skia_paths build. Created with: gclient setdep -r src/third_party/pdfium@f22b4e2f6682 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7903d1431cc219136b5a5379b40815faf4dca2a5 Reviewed-on: https://chromium-review.googlesource.com/1142326Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576262}
-
Roberto Carrillo authored
R=hinoka,vadimsh Change-Id: I14bd0fdb4b2960d28d906dc83bcc89ed5a3d2213 Reviewed-on: https://chromium-review.googlesource.com/1142605Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#576261}
-
Evan Stade authored
- don't toggle visibility of back button and window icon, which only exist for non-tabbed windows. Those windows hide the entire header in overview and don't need to explicitly hide individual components. - get rid of the settings window icon workaround that prevented setting the window icon on settings windows (designed to preserve the override from SettingsWindowObserver). All window icon logic is located in BrowserView. Bug: 854704 Change-Id: I84106b7a4a1f8f78c8fc76a9be682422d41c9a45 Reviewed-on: https://chromium-review.googlesource.com/1140520 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#576260}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/799e075abeea..639bc9086732 git log 799e075abeea..639bc9086732 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 jmadill@chromium.org Vulkan: Pass Renderer to FramebufferVk init. 2018-07-18 tobine@google.com Roll Vulkan repos fwd as of 7/17 2018-07-18 jmadill@chromium.org Vulkan: Fix size_t warning in TextureVk. 2018-07-18 geofflang@chromium.org Vulkan: Support multiple depth stencil formats for backbuffers. Created with: gclient setdep -r src/third_party/angle@639bc9086732 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6dd778f3ba650958f38fcb93e1ba7674309fcf01 Reviewed-on: https://chromium-review.googlesource.com/1142265Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576259}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/941ac6857d71..26d6aff1b57b git log 941ac6857d71..26d6aff1b57b --date=short --no-merges --format='%ad %ae %s' 2018-07-18 dtu@chromium.org [pinpoint] Add `android-pixel2-perf` config. 2018-07-18 nednguyen@google.com Remove stray debug print in page_test_results.py Created with: gclient setdep -r src/third_party/catapult@26d6aff1b57b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860091 TBR=sullivan@chromium.org Change-Id: I3c3c08e18bde2a25e9565965cea0a9e4bac8e734 Reviewed-on: https://chromium-review.googlesource.com/1142012Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576258}
-
Joshua Peraza authored
CrashDumpObserver is used to observe information about child process exits, including non-crashes, so ChildExitObserver more accurately reflects what this class does. Also move ChildExitObserver and ChildProcessCrashObserver to the crash_reporter namespace as part of the move away from breakpad. TBR=sanfin@chromium.org Bug: crashpad:30 Change-Id: Ib480af7fbf800afd63beccee90bbee01f9ec7610 Reviewed-on: https://chromium-review.googlesource.com/1138727 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#576257}
-
Alexander Alekseev authored
Offline Gaia did not have dedicated API, so it crashed when trying to sign-in as non-existing user. This CL adds a dedicated API which displays error message to user. Bug: 863847 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8354a88befb7cb99a64519c3f3d07449ead8fc4d Reviewed-on: https://chromium-review.googlesource.com/1141654 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576256}
-
Trent Apted authored
Since AppKit coordinates are flipped, NSWindowDelegate may not send move changes when the top-left corner of the window moves relative to the screen. Similarly, it will send a move when resizing a window vertically via the bottom edge, which other platforms do not class as a move. To fix, track the top-left window corner relative to the top-left of the screen and ensure the toolkit is notified when it changes. OnWidgetMove() had no test coverage, so add a cross-platform widget test. The test exposes a discrepancy on Windows only, which is likely a bug to investigate in a follow-up. Bug: 862217, 864938 Change-Id: I1fb0a6c2b463ea7cbd823fbe4d65545991564d50 Reviewed-on: https://chromium-review.googlesource.com/1141555Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576255}
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/000f2f686d60..369ab2088d3f $ git log 000f2f686..369ab2088 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 johannkoenig cmake: fix formatting typo 2018-06-20 yuec Enable rdmult tuning for deltaq mode 2018-07-13 jonathan.matthews lightfield_tile_list decoder: allow obu format 2018-06-08 birkbeck Add denoiser & noise estimation in the encoder. 2018-07-17 yunqingwang Output the error message for unsupported options 2018-07-18 ravi.chaudhary Modify encoder multi-threading unit tests 2018-07-12 ddvfinite Opt convolve avx2 2018-07-17 yunqingwang Set the default number of encoder threads to 1 2018-07-13 vigneshv obu: align the reader before reading tile group 2018-06-29 grant.hsu Merge drl modes search into function handle_inter_mode 2018-07-17 grant.hsu Skip redundant compound search 2018-06-28 urvang Transform stats: Add rdmult and rdcost. 2018-07-17 urvang Add ML model for RDCost of transform block. 2018-07-17 wtc Allow the bit reader to read only obu_size bytes. 2018-07-16 ravi.chaudhary Initialize skip flag in reset_partition 2018-07-17 ravi.chaudhary Fix in initializing mi pointer grid at frame level 2018-07-17 binpengsmail Fix error reported by valgrind 2018-07-17 wtc Do not set error_code after aom_internal_error. 2018-07-11 urvang Improve BDRate and encode speed at cpu-used >= 2 2018-07-16 deepa.kg Refine the decode job dispatch logic (...) Created with: roll-dep src/third_party/libaom/source/libaom Change-Id: I1a5e87e678dca59544ada55b1755cbf0cde3deb5 Reviewed-on: https://chromium-review.googlesource.com/1142391Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#576254}
-
Peter Mayo authored
This flag specifically improves the results of layout test compositing/masks/mask-with-added-filters.html Bug: 865039 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8589dacff3c77b42931e58bc3d39c0360f93aa9e Reviewed-on: https://chromium-review.googlesource.com/1142237 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576253}
-
Justin Donnelly authored
This eliminates the need for special layout in the > 1 display scale case. Bug: 853355 Change-Id: I5c4a30cee3b8ad05bed1bad094678351ec728ea5 Reviewed-on: https://chromium-review.googlesource.com/1142440 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#576252}
-
David Black authored
Was previously circumvented for development purposes. Bug: b:79120852 Change-Id: I68cf1fea763dd84ab886cf7e3e5df7cadfe616a5 Reviewed-on: https://chromium-review.googlesource.com/1142288Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#576251}
-
Sammie Quon authored
This reverts commit f00acd85. Reason for revert: crbug.com/863795 Original change's description: > Reland "overview: Hide title bars before animating into overview mode." > > This is a reland of a663e7fd > > The original cl causes some flaky tests with stack trace: > > [16202:16202:0709/211202.910243:FATAL:single_thread_proxy.cc(237)] Check failed: task_runner_provider_->IsMainThread(). > #0 0x7f9b36f8672d base::debug::StackTrace::StackTrace() > #1 0x7f9b36c9d3fc base::debug::StackTrace::StackTrace() > #2 0x7f9b36d06dfd logging::LogMessage::~LogMessage() > #3 0x7f9b2b5692e8 cc::SingleThreadProxy::SetNeedsCommit() > #4 0x7f9b2b45ecef cc::LayerTreeHost::SetNeedsCommit() > #5 0x7f9b2b467426 cc::LayerTreeHost::SetMutatorsNeedCommit() > #6 0x7f9b0fd29981 cc::AnimationHost::SetNeedsCommit() > #7 0x7f9b0fd1962d cc::Animation::SetNeedsCommit() > #8 0x7f9b0fd41151 cc::KeyframeEffect::KeyframeModelAdded() > #9 0x7f9b0fd44e6c cc::KeyframeEffect::AddKeyframeModel() > #10 0x7f9b0fd17fbc cc::Animation::AddKeyframeModelForKeyframeEffect() > #11 0x7f9b0fd71a6d cc::SingleKeyframeEffectAnimation::AddKeyframeModel() > #12 0x7f9b28c83a95 ui::LayerAnimator::AddThreadedAnimation() > #13 0x7f9b28c7498e ui::(anonymous namespace)::ThreadedLayerAnimationElement::RequestEffectiveStart() > #14 0x7f9b28c71113 ui::LayerAnimationElement::Start() > #15 0x7f9b28c7cbe3 ui::LayerAnimationSequence::Start() > #16 0x7f9b28c84287 ui::LayerAnimator::StartSequenceImmediately() > #17 0x7f9b28c81251 ui::LayerAnimator::StartAnimation() > #18 0x7f9b28c80eb6 ui::LayerAnimator::SetTransform() > #19 0x7f9b28c6122e ui::Layer::SetTransform() > #20 0x7f9b28ded831 aura::Window::SetTransform() > #21 0x7f9b22b732df ash::ScopedTransformOverviewWindow::SetTransform() > #22 0x7f9b22b73f69 ash::ScopedTransformOverviewWindow::OnCompositingStarted() > #23 0x7f9b28c4d734 ui::Compositor::DidSubmitCompositorFrame() > #24 0x7f9b2b56cd05 cc::SingleThreadProxy::DoComposite() > #25 0x7f9b2b56e835 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() > #26 0x7f9b2b3736fd cc::Scheduler::DrawIfPossible() > #27 0x7f9b2b36dbdc cc::Scheduler::ProcessScheduledActions() > #28 0x7f9b2b36d5fd cc::Scheduler::OnBeginImplFrameDeadline() > > This cl makes that test skip waiting for composit when entering overview, like the tests > in ash. > > Original change's description: > > overview: Hide title bars before animating into overview mode. > > > > The title bars should not visible while animating overview mode. This cl > > hides the title bar if needed and waits until the next paint before > > animating the windows. This will hide the title bar as expected while > > keeping the benefits of DeferPaint. > > > > Test: manual > > Bug: 843851 > > Change-Id: I99cf7ca39fd1ae14314ac406abd0fec999e2c024 > > Reviewed-on: https://chromium-review.googlesource.com/1112774 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#573552} > > TBR=oshima@chromium.org > > Bug: 843851 > Change-Id: I3a538250d5f6d42d6c73e218445080af533b54dc > Reviewed-on: https://chromium-review.googlesource.com/1131874 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574209} TBR=msw@chromium.org,oshima@chromium.org,sammiequon@chromium.org,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843851 Change-Id: Ib2744c7f677be40004b70a714cebe0a337f7c60b Reviewed-on: https://chromium-review.googlesource.com/1142304Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#576250}
-
Dominic Mazzoni authored
Whenever we post a change to the accessibility tree affecting an element, if that element isn't block-level we should walk up to the nearest block-level element and serialize the whole thing. The reason is that we have fields like nextOnLine and previousOnLine that depend on the line layout, which can change when changes happen to inline elements. Eventually I'd like to have a better concept of marking part of the accessibility tree "dirty" as a way of cleaning up this logic, but in the meantime this is hopefully a good fix with a test that can potentially help fix some real bugs now. Bug: 843746, 651614 Change-Id: I411a13c63b0c88ab225393b5287cb87a5887565b Reviewed-on: https://chromium-review.googlesource.com/1062661Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#576249}
-
Weidong Guo authored
1. Set a mask layer to create a rounded rect background. 2. Change the corner radius based on app list height. Specs: https://screenshot.googleplex.com/xVbKhQhE9xf Bug: 860822 Change-Id: I3db9f1ebb29978b1dd0804afbb8accf253db2751 Reviewed-on: https://chromium-review.googlesource.com/1138636Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#576248}
-
Boris Sazonov authored
This CL adds ConsentBumpFragment and the corresponding layout file. The fragment will be wired up in subsequent CLs. Bug: 814728 Change-Id: I5daf9eed75d10a0ef292874bb8eea06f888c609e Reviewed-on: https://chromium-review.googlesource.com/1140719Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#576247}
-
Zhongyi Shi authored
Add a new QUIC error code for connection migration, which will be used to close the connection when migration is triggered before handshake is confirmed. Manually merge internal change: 205108882 Bug: 790547 Change-Id: Id337b125c38b9d06d892a9f3a235f61d10f3eaf4 Reviewed-on: https://chromium-review.googlesource.com/1142379Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576246}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7b61abe..2c1fd401 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb09331da891874aaba4544acd90c7e6a821e4d9 Reviewed-on: https://chromium-review.googlesource.com/1142285Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576245}
-
erikchen authored
The test AcceleratorsCocoaBrowserTest.MainMenuAcceleratorsInMapping had an incorrect early return, where it intended to use a continue. The first attempt to land this CL changed the early return to a continue. This broke the test. This CL fixes the test by: * Not performing any checks on menu items without tags, as they may just be macOS menu items added by the OS that we don't care about. * Adding missing accelerator combinations to AcceleratorsCocoa. This CL also removes some dead code in accelerators_cocoa.mm > ui::Accelerator had a member platform_accelerator() which was only used on > macOS, and provided redundant information. This CL removes the member. > > Bug: 846893, 702823 > Reviewed-on: https://chromium-review.googlesource.com/1135644 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575429} Change-Id: I195bd174a96da58bff96e22495c5ea5b5bfe8549 Bug: 846893, 702823 Reviewed-on: https://chromium-review.googlesource.com/1140211 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576244}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/764a58f972be..ed4c83aac3f1 git log 764a58f972be..ed4c83aac3f1 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 chrome-bot@chromium.org Update config settings by config-updater. 2018-07-18 dgarrett@google.com chromeos-config: Migrate Chrome PFQ master to swarming (again). Created with: gclient setdep -r src/third_party/chromite@ed4c83aac3f1 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7732c988d977829dfd737bcbeacb611bec757d3d Reviewed-on: https://chromium-review.googlesource.com/1142011Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576243}
-
Tiger Oakes authored
Continuation of work in bug 646094. Preparing to activate an errorprone check to flag context#getApplicationContext calls. The goal is to prevent storing the resulting context as a class property, and instead use ContextUtils. This CL replaces two others: https://chromium-review.googlesource.com/c/chromium/src/+/1095986 https://chromium-review.googlesource.com/c/chromium/src/+/1095999 Bug: 846456 Change-Id: Id7ed38c318d97b7370938d32677bcf73b85c3314 Reviewed-on: https://chromium-review.googlesource.com/1141933Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#576242}
-
Chris Harrelson authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iac377bceee1a0aab36e9d70c854f4e1d82dc4631 Reviewed-on: https://chromium-review.googlesource.com/1141216Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576241}
-
Sky Malice authored
As part of adding histograms, it seems that the preferred way to emit enum histograms is with a kMaxValue sentinel and let the enum macro detect that. All of the scheduler and user classifier histograms were converted from SHOUTY_CASE to kCamelCase to facilitate a kMaxValue. Bug: 831648 Change-Id: Ib24791fdb7bcafcfeb6cf754736fe6ba7298c7d7 Reviewed-on: https://chromium-review.googlesource.com/1133687 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#576240}
-
Marcin Wiacek authored
Change-Id: Ie684317904482f3f2629c8cd613008fdd76a5b3d Reviewed-on: https://chromium-review.googlesource.com/1142405Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#576239}
-
Marcin Wiacek authored
Change-Id: Ibca3a219a21281cf573a963732a1ef7220be1ffd Reviewed-on: https://chromium-review.googlesource.com/1142410Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#576238}
-