- 28 May, 2019 40 commits
-
-
Nazerke authored
Currently, when the top suggestion is a suggestion from history (with URL), we show the favicon for that page in the popup. If the favicon doesn't exist, then the omnibox will use a fallback when it can't load the favicon, but the fallback will be the history icon, the icon for the suggestion, instead of the globe. Fixed: When omnibox suggestion is a history type, then the icon is fallback to the globe in this case. Bug: 966347 Change-Id: I9c8210b55c6818facf4034abbd20be3386da46ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625996 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#663734}
-
Leszek Swirski authored
Change-Id: I84340afa4357764155d92279aa53cef63db3d1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632237 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#663733}
-
Stephane Zermatten authored
This CL reports to the server the time it took to run each action, so we have more precise tracking of run time than what is currently visible from the server. Bug: b/129665463 Change-Id: I5aadded949479a1d324042b574deddb10cde4e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611689 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#663732}
-
Kush Sinha authored
In the event of a revocation of a token associated with a device id, Gaia revokes all tokens associated with that device id, including the ones that may have been issued only recently. This is a bug for Device Account token updates in Chrome OS Account Manager. If the user ends up at the online Gaia re-auth screen, revoking the old Device Account token invalidates the current, newly minted token too, causing the user to be re-directed to online Gaia auth at next login and the cycle keeps repeating. Please check the attached bugs for context. Fix this by skipping token revocation for Device Accounts. Gaia has a clean up cron that clears up old, unused tokens attached to a device id. Bug: 952570, 865189 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Change-Id: I631d14c2d6cc65fbd5f57576cbf2787513efedaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631278Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#663731}
-
Polina Bondarenko authored
Content-Type header is not changed if request_body is not empty in WilcoDtcSupportdWebRequestService::PerformRequest BUG=b:133733514 TEST=unit_tests Change-Id: I6ab7ff53a69396007993173fd85acf2e35a83504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631695Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#663730}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/213aa46af167..cf49b6472020 git log 213aa46af167..cf49b6472020 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 bsalomon@google.com Define SK_GL in Flutter. Created with: gclient setdep -r src/third_party/skia@cf49b6472020 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I138d0046085ef736e4637583aaf68b665a4c0525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663729}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f2e9cab3835c..9ab520e24bb9 git log f2e9cab3835c..9ab520e24bb9 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 minyue@webrtc.org Reland "Avoid encrypting empty audio packet." 2019-05-28 ilnik@webrtc.org Use ';' to escape '/' characters in path to dumped received video stream 2019-05-28 sprang@webrtc.org Add field trial for selecting potentially useful packets as padding. 2019-05-28 hta@webrtc.org Deprecate functions returning cricket::DataContentDescription. Created with: gclient setdep -r src/third_party/webrtc@9ab520e24bb9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/132861665,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7736a8e50a5186e69fa407b77f8b6ae5114a5144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632413Reviewed-by:
-
Jordan Demeulenaere authored
- Before: https://screenshot.googleplex.com/LG9DBrd21We.png - After: https://screenshot.googleplex.com/uONtfqZx37R.png Screenshots: Change-Id: I25ddcef07fbe74a0a7f42d897b788f06ba752a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631696Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#663727}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26af0d34d281..778c7f117aee git log 26af0d34d281..778c7f117aee --date=short --no-merges --format='%ad %ae %s' 2019-05-28 iannucci@chromium.org Make tryserver API only update the presentation of its own steps. Created with: gclient setdep -r src/third_party/depot_tools@778c7f117aee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:910369 TBR=agable@chromium.org Change-Id: I72c7bd662cad0470cddbbc9eaaf73a35bee5ccdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632411Reviewed-by:
-
Ludovico de Nittis authored
//src/dri.c needs to be included in the minigbm build because it is required when using the "use_amdgpu_minigbm" flag. Bug: 967346 Change-Id: I5dc1407eecacc96d49cde4e793b40dc9e766ae75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631382 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#663725}
-
Jonathan Backer authored
Removing the lightweight ref will call ~gles2::Texture, if there are no outstanding gles2::TextureRef. What happens in certain viz_unittests when running with Vulkan is the following. 1) ~InProcessCommandBuffer releases the current GLContext. 2) SkiaOutputSurfaceImplOnGpu::ReleaseSkImages releases an ExternalVkImageBacking. This may call ~gles2::Texture with no GL context current, which causes a crash. More video tests pass with this change (e.g. out/release/viz_unittests --enable-vulkan --use-gpu-in-tests --gtest_filter="VideoRendererPixelTest/1.FullyTransparentYUVARect") Bug: 960797 Change-Id: Ice8c85a5cb4c63b8b45c8fa7fc27adccba90a5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631730Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#663724}
-
Moe Ahmadi authored
Makes TableViewTextItem adjust its font size for Dynamic Type Bug: 957688 Change-Id: Id3522bb1419ba2c7036481fb6cc90015f346c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630973Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663723}
-
Lukasz Suder authored
Whole traffic will be divided by the experiment_id it belongs to. The experiment_id comes from the caller (GWS) and is available within intent. For traffic outside of GWS there will be no experiment_id. Registering Synthetic groups: cr/249817984 Bug: 806868 Bug: b/133124492 Change-Id: I9b1cccf10b6d442966c2f60ee34870a6e3d9686e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630480Reviewed-by:
-
Mathias Carlen authored
Screenshot: https://screenshot.googleplex.com/Z35iGAApM0v.png Bug: crbug/806868 Change-Id: I0a05fce05136d9d7fa1cfa3362f1ce9ec9009079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632234Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#663721}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ee3ebdb611f..4c66b67119b9 Created with: gclient setdep -r src-internal@4c66b67119b9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Ifa9b1123921dd3e46a10f3c37985161526742ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663720}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/18c0f8891333..1b6aded661de git log 18c0f8891333..1b6aded661de --date=short --no-merges --format='%ad %ae %s' 2019-05-28 aleino@nvidia.com Test D3D11 GetDimensions driver workaround for textureProjOffset Created with: gclient setdep -r src/third_party/angle@1b6aded661de The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I66ff1089ca67c70ec5c2ece14df1cb97c018d50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632282Reviewed-by:
-
Victor Costan authored
The LLVM project moved from SVN to git, and lld's version information does not include SVN revisions anymore. This CL makes the version parsing in download_lld_mac.py permissive enought to accept git commit hashes. Bug: 897796 Change-Id: I0d11703f6982172dd64e7d7c9a64dcaa2fe6757f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630811 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#663718}
-
Carlos Caballero authored
This helper will be useful when migrating code away from PostAfterStartupTask. Some callsites would otherwise need a trampoline as they need to post to a given task runner. This helper is only needed until we have sequence-funneling in place. This patch is a split of https://crrev.com/c/1571661. Refer to this if you need more context for this change. Bug: 887407 Change-Id: I122f837e6a7b509903055798deb0f2b6eb215bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628725 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#663717}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d82354acc2f0..71c012b1b956 git log d82354acc2f0..71c012b1b956 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 capn@google.com Fix interpolating z when using FragCoord builtin Created with: gclient setdep -r src/third_party/swiftshader@71c012b1b956 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133325267 TBR=swiftshader-team+autoroll@google.com Change-Id: I456331424d75ed3e72e5f9fda0534da45db71415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632281Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6fb0eb821ce6..6c8f0250717b git log 6fb0eb821ce6..6c8f0250717b --date=short --no-merges --format='%ad %ae %s' 2019-05-28 mnissler@chromium.org Mark guado as experimental Created with: gclient setdep -r src/third_party/chromite@6c8f0250717b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I072aac17855c39bda2ec400786f511c88bd50d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632279Reviewed-by:
-
Dominik Röttsches authored
Observations in issue 960263 showed that running the font scanning task highly parallel in background can lead to priority inversions. As a resolution, resort to running the DWrite worker tasks in BEST_EFFORT but with ThreadPolicy::MUST_USE_FOREGROUND to avoid the priority inversion. Increase the timeout to 5 minutes since BEST_EFFORT will schedule us less frequently. Bug: 960263 Change-Id: Iacb9aec513b16a47143be635ad09e6c03423567b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595867 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a call to autofill::IsFillable to PasswordAccessoryControllerImpl::RefreshSuggestionsForField(). This was missed in r662790. Bug: 957532 Change-Id: I4fa429606944a6a3d016601156fa6e6d123958a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631692 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#663713}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8e1bc6ae..b42d4c7a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic143ed623b2812a5aa33ff94aca69ef3f2e1b7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631966Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663712}
-
Yi Su authored
This CL moves all session related files into //ios/web/session and //ios/web/public/session. Bug: 942244,956511 Change-Id: Ib45abcc9e4abddfa6425b3bdccf5995c82829bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628729 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#663711}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d1ca5984045..1ee3ebdb611f Created with: gclient setdep -r src-internal@1ee3ebdb611f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Ibbf69a8332a7dbc4a2823bcfb9134ca5a28f7158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632277Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3a072de0d28f..f2e9cab3835c git log 3a072de0d28f..f2e9cab3835c --date=short --no-merges --format='%ad %ae %s' 2019-05-28 terelius@webrtc.org Fix BWE simulation graph in event log visualization 2019-05-28 eladalon@webrtc.org Allow both LNTF to coexist with NACKs and key frame requests Created with: gclient setdep -r src/third_party/webrtc@f2e9cab3835c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I751499364681279c9628f11b056d17837bb2745d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632275Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia6bc98a510aa131af882143f709aea50639bdc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632270Reviewed-by:
-
Jordan Demeulenaere authored
Change-Id: Ia24afdc120726c6487875d65e6dcf5bf6f17a3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627354 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/710fcd517ea4..d82354acc2f0 git log 710fcd517ea4..d82354acc2f0 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 swiftshader.regress@gmail.com Regres: Update test lists @ 710fcd51 Created with: gclient setdep -r src/third_party/swiftshader@d82354acc2f0 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Idf6eea6561ae5c82041a723c2793d6d193ee641e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632273Reviewed-by:
-
Yi Su authored
This CL moves all web-frame related codes into //ios/web/js_messaging and //ios/web/public/js_messaging. Bug: 942244,956511 Change-Id: I152034134fffd24a0e8bcf5cf2bec2de698df369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627388Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663705}
-
Henrique Ferreiro authored
Bug: 939691 Change-Id: If81e2e23ef270440f8d2a39dda3bfff99744be1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631656 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#663704}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8fbbe5dd41c..7d1ca5984045 Created with: gclient setdep -r src-internal@7d1ca5984045 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Ia06aed33a1666b7da5810d8c09caf3938e60c829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631563Reviewed-by:
-
Ulan Degenbaev authored
This sets the expiration date to one year from now instead of M77. The histograms will be used in upcoming Finch experiments for V8 GC heuristics. Change-Id: I81311455ccc2582a02c5eb1c8fb7e54f845c08d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628731Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663702}
-
Victor Hugo Vianna Silva authored
We change the condition for disabling autofill wallet data so that we catch both DiCE Web Signout and persistent auth error state. Bug: 819729 Change-Id: I7f8deac38f1852ba02aa7849329e83ab45d03493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631658 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#663701}
-
Sylvain Defresne authored
Both {syncer,ntp_tiles}::JsonUnsafeParser are both interfaces that mimic data_decoder::SafeJsonParser but do the parsing in-process. They appear to have been added to support testing code that gets injected a callback wrapping data_decoder::SafeJsonParser to allow using the code on iOS (which cannot parse JSON out-of-process). Also remove a separate implementation of an asynchronous JSON parser in ios_chrome_content_suggestions_service_factory_util.cc. Instead, allow iOS to use TestingJsonParser, port the test code to use TestingJsonParser, and move the JsonUnsafeParser in an iOS specific directory and rename it to InProcessJsonParser. Bug: 828833 Change-Id: I08a3550c3c9ccb9ad5e4e2bcb85847d86bd68105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614187Reviewed-by:Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#663700}
-
Daniel Bratell authored
Some jumbo builds noticed that cookie_manager_service_ in SigninManagerBase was unused and since we compile with -Werror,-Wunused-private-field, that detection resulted in a compile error. Other builds probably had too little information to trigger the warning/error. Bug: 814787 Change-Id: Iea252513eef26fae0e3f865d398494781c16f356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631387 Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cc383806..8e1bc6ae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib441fb0bfca902b92c33a38a2e6d2ca80ef92471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631761Reviewed-by:
-
David Roger authored
This is no longer a simple getter. Bug: 863347 Change-Id: Ida792540d1d107289385dbc919a9b3477d495ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631400 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#663697}
-
David Roger authored
Several classes were taking both a SigninClient and a URLLoaderFactory. However, SigninClient has a GetURLLoaderFactory() method, and this was leading to a situation where code had access to two instances of URLLoaderFactory, and would use one or the other in a random fashion. In production, these factories were the same in practice, but in tests this was not always the case. As a result, it was not clear what the test were doing, and it also made the code harder to understand. This CL removes this confusion, by always using the factory from the client when it is available. It also removes the unnecessary url_loader_factory parameter from SigninClient::CreateGaiaAuthFetcher. TBR=eugenebut Bug: 863347 Change-Id: Ie47b56226b126fbdc753cfd170c7fead65d6952b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569137Reviewed-by:
-
Yannic Bonenberger authored
The service worker spec mandates that update() fails immediately if called from within service workers that are currently installing (i.e. if update() is called in the |install|-event-handler). This change implements this behavior and updates the WPT to match the spec. Bug: 895845 Change-Id: Ie07563e5ac8260554ef0947be4cb020124cfeddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626600 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#663695}
-
