GitLab

the registrar.  Only seems to have shown up on two download
tests, curiously.

BUG=81985
TEST=PrerenderBrowserTests.*

Review URL: http://codereview.chromium.org/7057031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86301 0039d316-1c4b-4281-b951-d872f2087c98

HostContentSettingsMap cleanup: Remove obsolete kBlockNonsandboxedPlugins preference; don't send CONTENT_SETTINGS_CHANGED notifications when preferences change.

BUG=none


Review URL: http://codereview.chromium.org/7026004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86300 0039d316-1c4b-4281-b951-d872f2087c98

current tab where they are swapped in.
R=dominich@chromium.org
Review URL: http://codereview.chromium.org/7059019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86299 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6961032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7059018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86297 0039d316-1c4b-4281-b951-d872f2087c98

Increases code reuse a bit. To make this work, give MenuButton a
-menuRect function, since ProfileMenuButton is larger than the
area it draws in.

Also potentially addresses the problem described inhttp://waffle.wootest.net/2007/08/07/popping-up-a-menu-in-cocoa/
which might be 10.5-only.

xib changes: Remove the old popup button-based PopupMenuButton, re-add
it by duplicating the new tab button, changing the resize anchor to the
upper-right corner, and changing the cell to ClickHoldButtonCell.

BUG=83169
TEST=none

Review URL: http://codereview.chromium.org/7061001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86295 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed a "connecting" attribute not properly set problem.

BUG=chromium-os:15596
TEST=Verify fix for chromium-ls:15596. i.e. Blue strip shows up on hovering "not configured" networks. Also "connecting" network now will show up in a lighter blue (compared with "connected" networks) box with no hovering and no buttons.

Review URL: http://codereview.chromium.org/7004050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86293 0039d316-1c4b-4281-b951-d872f2087c98

Also moved 'enable-screen-lock' disabling logic into chromeos specific
area and add similar logic to disable 'change-picture-button' in guest
mode.

BUG=chromium-os:10020
TEST=Verify fix for chromium-os:10020

Review URL: http://codereview.chromium.org/7057030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86292 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6990037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86291 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkNodeFaviconChanged and makes it so we send it instead of
BookmarkNodeChanged if the favicon changes.

BUG=51501
TEST=see bug
R=tim@chromium.org
TBR=phadjan.jr@chromium.org, erikkay@chromium.org, maf@chromium.org, erg@chromium.org, ben@chromium.org

Review URL: http://codereview.chromium.org/7055021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86290 0039d316-1c4b-4281-b951-d872f2087c98

Don't send a reference to a string that goes out of scope.  Send a reference to a string on an object that lives longer than the callback which uses the string.

Committed because the change is simple, and fixes failures on the waterfall.  Antony, I would be happy to roll back if you feel this is not the correct solution.

TBR=asargent
BUG=83592
TEST=sync integration tests on mac

Review URL: http://codereview.chromium.org/6974011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86289 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7019040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86288 0039d316-1c4b-4281-b951-d872f2087c98

The Search provider calls back into the AutocompleteController and then on to the other providers multiple times during the processing of an autocomplete but it is not necessary for the HQP to handle these calls.

BUG=83186
TEST=Times recorded for about:histograms/Omnibox are reduced dramatically.
Review URL: http://codereview.chromium.org/7056030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86287 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig
BUG=none
TEST=URLFetcherTempFileTest.*

Review URL: http://codereview.chromium.org/7051036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=clang

Review URL: http://codereview.chromium.org/7062006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86285 0039d316-1c4b-4281-b951-d872f2087c98

While testing the chromeos password changed dialog, I noticed that the dialog
was clipped at the bottom, so that the text field to enter the old password
was not fully visible.  This was with and without my change.  To fix, I
increase the height of the dialog, hence the locale_settings.grd change.

BUG=None
TEST=Make sure all uses of radio buttons in chrome, on all platforms including
chromeos, work as expected.  The look may be slightly different, but the
behaviour should be the same.  To test the password changed dialog on chromeos,
login and then logout with a given account.  Change the password of that
account (with another computer for example) and then log back in using the
new password.  The text field at the bottom should not be clipped.
Review URL: http://codereview.chromium.org/6955002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86283 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asargent
BUG=None
TEST=Compiles on clang builder, ExtensionUpdaterTest.*

Review URL: http://codereview.chromium.org/7062005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86282 0039d316-1c4b-4281-b951-d872f2087c98

It returns the correct menu model depending on the state of download_item().

BUG=28978
TEST=None

R=dmazzoni@chromium.org,asanka@chromium.org

Review URL: http://codereview.chromium.org/6974005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86281 0039d316-1c4b-4281-b951-d872f2087c98

Darin, this is based on your recommendation from http://codereview.chromium.org/6904057/ .

BUG=82568
TEST=URLFetcher*Test.*:ExtensionUpdaterTest.*

Review URL: http://codereview.chromium.org/6969067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83357
TEST=browser_tests

Review URL: http://codereview.chromium.org/6961017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86279 0039d316-1c4b-4281-b951-d872f2087c98

Also adapted the unit_tests.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7057009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86278 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83203
TEST=Steps to reproduce the bug, or web_data_unittests.

Review URL: http://codereview.chromium.org/7051003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86277 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7019038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86276 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15526
TEST=Manual


Review URL: http://codereview.chromium.org/7049002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86275 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=jschuh

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86274 0039d316-1c4b-4281-b951-d872f2087c98

To run Chrome:
HEAP_PROFILE_ALLOCATION_INTERVAL=1000000 HEAPPROFILE=heapprof out/Debug/chrome

To analyze:
pprof --text out/Debug/chrome  heapprof.21026.0039.heap
pprof --gv out/Debug/chrome  heapprof.21026.0039.heap
(pprof is slooow)
Review URL: http://codereview.chromium.org/6532051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86273 0039d316-1c4b-4281-b951-d872f2087c98

Disjoints update screen controller part (UpdateScreen) from it's views part (UpdateView) via UpdateScreenActor interface.

BUG=chromium-os:11632
TEST=browser_tests

Review URL: http://codereview.chromium.org/7039042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86270 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86269 0039d316-1c4b-4281-b951-d872f2087c98

Update test expectations temporarily after execScript removal.
Review URL: http://codereview.chromium.org/6990033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86268 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=QuotaManager.*

Review URL: http://codereview.chromium.org/7056006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=jschuh

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86265 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7060004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86264 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83354
TEST=none

Review URL: http://codereview.chromium.org/7038036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86263 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7058004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86262 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a new unit test that verifies we can decode a JPEG image that does not have DHT markers. (This is a unit test for r85600 <http://crrev.com/85600>.)

BUG=none
TEST=JPEGCodec.DecodeMotionJPEG
Review URL: http://codereview.chromium.org/7012034

TBR=hbono@chromium.org
Review URL: http://codereview.chromium.org/7059009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83566
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/7051031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82278
TEST=disabled
TBR=bauerb
Review URL: http://codereview.chromium.org/7051030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86259 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a new unit test that verifies we can decode a JPEG image that does not have DHT markers. (This is a unit test for r85600 <http://crrev.com/85600>.)

BUG=none
TEST=JPEGCodec.DecodeMotionJPEG
Review URL: http://codereview.chromium.org/7012034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83565
TEST=none
TBRu=bauerb
Review URL: http://codereview.chromium.org/7058005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83564
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/6990032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86256 0039d316-1c4b-4281-b951-d872f2087c98