- 19 Jun, 2020 40 commits
-
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I7262adc376491acdf85f0f97d9bf7e8b4eecb14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250071 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#780461}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592582404-8222a440e7e5a063efaa22c6430adc77286858ae.profdata to chrome-win64-master-1592585969-c70917dc3124c4b50e9e9ae9a9c8ca3f9c90b67e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I85eaa764f5494fc8061512307200f02980b8ecb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254839 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780460}
-
Charlene Yan authored
Bug: 1018230 Change-Id: Ie015fdd3b162830f98a56b73bf6af19d2341b030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252844Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780459}
-
Daniel Nicoara authored
This broke the Chromecast build since the EGL/GLES ANGLE libraries are not whitelisted in the GPU sandbox. BUG=1097320 TEST=Ran on device Change-Id: I372e7e722eaef6217c2749a3ab8972d3c0e2e58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254529Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#780458}
-
Xi Han authored
In this CL, we add the following histograms: 1. "Startup.Android.SingleTabTitleAvailableTime.Instant (.NoInstant)" to record the time of the title of the single tab shown on StartSurface for both instant start or regular start. 2. "Startup.Android.FeedsLoadingPlaceholderShown.Instant" to record the time of Feeds loading placeholder shown. The histograms are recorded on onDeferredStartup() once if StartSurface is shown when Chrome is launched from cold start. Bug: 1092931 Change-Id: If4d2f0377d1d2af3cd95a475c3cb675de048d7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239298 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780457}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I36a2cdc31d2b641f3ba3d13cefcdaa9d942ed9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254126 Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#780456}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb20536fca26..5ff7ad23ae08 2020-06-19 pkasting@chromium.org Remove lint checks for non-const references. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I1381b3631cab99c4d4193b454f46e2a32f44899b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254840Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780455}
-
Liquan (Max) Gu authored
Change: * payment_request_optional_total_test.cc comment update: Since the flag name is no longer called optional total, the comment has to be updated. * payment_request.h comment update: Make it explicit that this file is for desktop only. Change-Id: If95e0bf7ed2b0445a754b30ea7c7e320cd22d1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254525Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#780454}
-
rbpotter authored
Refactor the Unpack method to call a single method to unpack each resource that has been parsed from the pak file. This allows for more comprehensive testing, without needing to generate fake pak files. Also add tests for 3 different common resource unpacking scenarios: - Non-generated resource - Generated resource - Shared generated resource, which should not be unpacked and is excluded using the new "excludes" argument. Bug: 1093405 Change-Id: I566ae9dba493931ca39756706df4239f68437c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254702 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#780453}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f18c0ac2f735..50e7bb530903 2020-06-19 joselea@microsoft.com DevTools personalization - Make Security tab closeable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1074732 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7c9e849593b6811f631686e5495677343f807844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780452}
-
Sorin Jianu authored
This target has been sparsely populated and a constant source of dependency cycles with //chrome/updater:base. Bug: 1097123 Change-Id: I57048675026ad3df7ce0f0d7c4c97d65e47c72f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254094Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780451}
-
Gang Wu authored
Add params for OmniboxEnableClipboardProviderImageSuggestions Change-Id: Ia53e4629a5e90f9226cc38af34b80d57028c8f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254085Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780450}
-
Livvie Lin authored
Makes sure that the URL remains elided if the context menu option is removed, especially if the "Always Show Full URLs" pref was previously turned on. Bug: 1095975 Change-Id: Id5ab1d5c384483286bebb3e3e36cf5880db975d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252932Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780449}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: If8491a48b188182c4faf21ef2a77105aa849c2b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254660 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#780448}
-
Annie Sullivan authored
Bug: 1089355,1089356 Change-Id: I9c7560933813ca89ea4fe2a2558fba83f3614fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254528Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780447}
-
Leonid Baraz authored
No changes in semantics, only readability improvement. Bug: b:153364303 Change-Id: I3f7e2b102c9ee5b34492e39872d506b205af0be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254465Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#780446}
-
Becca Hughes authored
Since we are the only ones using protobuf JS this adds a test proto file to the public repo so our build doesn't get broken by accident. BUG=1087037 Change-Id: I349c80e98d1b9e9d9cd414a418852eb2f899a7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254523 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#780445}
-
Sigurdur Asgeirsson authored
Bug: 1096543 Change-Id: Ife6342aaaf70dcecd1da2712ac50b8a934163a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254079Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780444}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: If603687117132c2449e3088e2bb28566431aed9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254149 Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#780443}
-
Ali Juma authored
This CL sets a reload URL in |load_time_data|, matching the change made for SSL interstitials in crrev.com/c/2248450. Not setting this value can break back/forward navigations to a Safe Browsing warning page for the case where a page has an unsafe subframe. A test for this case is being added in crrev.com/c/2246995. Bug: 1093510 Change-Id: I44e564343a683db66948d46b2cd3f514121dd9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254581Reviewed-by:
Livvie Lin <livvielin@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#780442}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I9d778ccfee365bc3203cf57813688b5607369932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254662 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#780441}
-
Tien Mai authored
Change-Id: Ib59e7384ad52409fbeb7ee32e8742810858b41b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254458Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#780440}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Ie7d23361d3fdf85452b0147ba0b67149c1b8b5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254030 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#780439}
-
Kyle Horimoto authored
New test cases verify that each section/subpage/setting has an associated enum. This will ensure we never accidentally forget to add an enum value in the future. Change-Id: I34facbca8cad75be6a2c9253cee71832279f530d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254360 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780438}
-
Chris Lu authored
This change adds SaveCardInfobarModalInteractionHandler and SaveCardInfobarModalOverlayRequestCallbackInstaller to handle banner responses. SaveCardInfobarInteractionHandler is added to fully configure all SaveCard Interaction Handlers. Mock delegate and InteractionHandler classes are added to allow for testing of the added classes. Bug: 1071914 Change-Id: I06d26d73ba47be3ab715c6ebb5f1b32d615ca098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252839 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#780437}
-
James Cook authored
This class logs a single boolean histogram with "true" for lacros-chrome builds. We intend to use that histogram to filter UMA metrics on the dashboards, so we can tell them apart from other Linux and Chrome OS builds. Bug: 1096268 Test: metric appears in about:histograms after waiting a minute Change-Id: I245bc290c75569a3fa9d788a3f0323a3358849ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250829Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#780436}
-
Patrick Monette authored
This is a new mode for the intensive wake up throttling that allows well behaving page/workers to retain the precision on their timers. Bug: 1075553 Change-Id: I9b92dee2f9c3fd43ee48e27c728eeb3ad9de0f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249377 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#780435}
-
Ben Pastene authored
The two pools are identical now, so this moves them out of the temporary *.template pool. Bug: 812428 Change-Id: Ie385486de9915c8f8de43b6f8ef7c87970bf3d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254667 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#780434}
-
Robert Ogden authored
When the user navigates to a link that was prerendered, the following sequence of events happens: 1) OnNavigationStart, the TabHelper informs the relevant SubresourceManager that it is being navigated to. 2) The SubresourceManager records the navigation event as a member bool so that the next time its MaybeProxyLoaderFactory is called it will proxy the factory. 3) The proxying factory is passed a set of URLs that were successfully loaded during the prerender. 4a) When the proxying factory gets a request for a resource that was prefetched, it is directed to the isolated network context. 4b) When the proxying factory gets a request for a resource that was not prefetched, it is directed to the normal profile's network context. Notes: * The URLLoaderFactory used for NSP needs to have its isolation_info set, otherwise nothing will be cached. There's a small change to do that plumbing through a repeating callback. * The browser test's origin changed to a.test to take advantage of a valid cert for that name in EmbeddedTestServer. Not done: * Ensuring the subresource is cacheable. This will be addressed in the next CL. * UMA Bug: 1082505 Change-Id: I6aa5ab9e7dc24e1a1cc26c022155c8876f94da7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249046Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#780433}
-
Yang Guo authored
R=bmeurer@chromium.org Fixed: 1095988 Change-Id: I6ebbe3de665d308d0a30ede1c6c27e5745f484e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248626Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#780432}
-
Bruce Dawson authored
This is a reland of 4a4f53a7 The original patch would fail to build on the mksnapshot step on Windows 7 (and server equivalents). This was due to two APISet DLLs that are required for the new dbghelp.dll. This change copies the two of them during gn gen. In order to have them as part of the isolates for cdb and in order to avoid dangerous ambiguity they are now required, which means that when this change lands the new SDK will be required. This is slightly disruptive for developers who aren't using our toolchain, but it seems unavoidable. Developers who don't have the latest SDK installed will hit this error message during gn gen: Exception: api-ms-win-downlevel-kernel32-l2-1-0.dll not found in "..." You must install the "Debugging Tools for Windows" feature from the Windows 10 SDK, the 10.0.19041.0 version. Original change's description: > New toolchain for Windows 10 19041 SDK > > This change updates the toolchain package used to build Chromium with > the 10.0.19041.0 (2020-04) SDK and VS 16.6.1. The d3dcompiler_47.dll > DLLs for x86 and x64 were swapped out for the 10.0.17134 versions (as > usual). > > The Debuggers directory was not swapped out this time because the > problem with loading dbghelp.dll on Windows 7 > (https://crbug.com/1021650) has been resolved. > > The output for the cdb copy step was updated because one additional UCRT > DLL is now copied. > > Packaging was done on a Windows Server 2019 VM, cleanly created for this > purpose. > > The package was created by downloading the VS Professional 2019 > installer from https://visualstudio.microsoft.com/downloads/ > (free trial, not preview) and then running the installer like this: > > $ PATH_TO_INSTALLER.EXE ^ > --add Microsoft.VisualStudio.Workload.NativeDesktop ^ > --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ > --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ > --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ > --includeRecommended --passive > > Then the latest Windows 10 SDK was downloaded and installed from > https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/ > > Then the packaging script was run like this: > > python3 depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.19041.0 > > Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid > shipping that (https://crbug.com/920704) the final packaging step was to > unzip the package, copy over the two copies of that DLL from the > previous toolchain's win_sdk\Redist, and then repackage the toolchain > with: > > python3 package_from_installed.py --repackage=<full-path-to-toolchain-dir> > > UWP and ARM64 support and Python 3 compatibility were previously added > to package_from_installed.py. > > Future changes will require the new SDK, but for now the previous SDK > can also be used to build Chromium. > > The failures on the win*msvc* bots are unrelated. This was proven by > creating crrev.com/c/2245914 which is a NOP toolchain test. The existing > toolchain was repackaged with a single text file added and that caused > identical failures. > > Bug: 920704, 1014701, 10216507, 1089996 > Change-Id: Ie496354582458aa8c1292ed4ef63d949ee2eb15d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225224 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Henrik Andreasson <henrika@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778924} Bug: 920704, 1014701, 10216507, 1089996, 1095767 Change-Id: I75e7653d57964e2929106e41b3f50594d3969e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249394Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#780431}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/5174eb5b9236..769129fb29fc $ git log 5174eb5b9..769129fb2 --date=short --no-merges --format='%ad %ae %s' 2020-06-18 marpan vp9-rtc: Fix to resetting drop_spatial_layer 2020-06-17 marpan vp9-rtc: Fixes to resizer for real-time 2020-06-16 marpan vp9-svc: Add svc test for denoiser and dynamic resize Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: Ic46eb8d417f4f9949f8b17bd12d4bb7e100831de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253133Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#780430}
-
Ian Struiksma authored
These tests record traffic from a particular moment in time and override the time in the browser on replay to the recorded time. This change also has the replay override the AutofillClock so that tests will continue to work even if credit card info or other info is past the real life time. Bug: 1090042 Change-Id: I8964ae1818b9a64c9a7417a7aec628d053a8bfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248346 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#780429}
-
James Long authored
Somewhat glitchy filtering has been added. * Type in a package name (exact match) and click "Add" to add to filter. * Click on any filter in the list to remove it. Known issues: * Locked nodes no longer appear locked when a filter is added/removed. * Zoom/pan is reset when a new filter is added/removed. These issues are mostly because of the way we interact with the d3 graph. A big upcoming TODO is to rework `renderGraph` into an API of sorts which will give us finer control over what parts of the graph to rerender, if nodes should keep their metadata (position, lock) upon rerendering, etc. This commit also pulls in and uses Vue.js via a CDN for the current prototyping work. We will likely install via npm in the future. Bug: 1093962 Change-Id: Ide0b6a649424deac56e2f4d8121b0029d9286e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252378 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#780428}
-
Majid Valipour authored
TimeTicks::Now() is fairly cheap but not calling it twice is even cheaper. This CL is expected to have no functional impact. Change-Id: I3b230d1ff22d29e88b594205c825bcbe68b6f558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252746 Auto-Submit: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#780427}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I1c26806fd85d59246594b2d206267b9575f3cf8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254761 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#780426}
-
Xiyuan Xia authored
Hide the controls when the lock screen is created as a result of closing lid and in suspend state already. Bug: 1097101 Change-Id: Ifb1f92bc054c7278992d95c13d5f5e5d750c94c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254468 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780425}
-
Nate Chapin authored
These functions provide a way to get at a LocalDOMWindow/LocalFrame that works for attached Documents and Documents loaded via HTML imports, but not other Documents (e.g., Documents created by document.implementation.createHTMLDocument). A few callers genuinely require this distinction between HTML import Documents and other non-attached Documents, but most don't. Bug: 1029822 Change-Id: I7bc23df7eca2b8bd1872e99b06249c1753c6af3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242384Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#780424}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Ib0673654853166ba85d84113357d1dbf40ef466f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252147 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780423}
-
chrome://resources/mojo/skia/Kyle Horimoto authored
This fixes an issue where both the New Tab Page and Chrome OS Settings independently included generated .mojom files from the same directory, which in some cases caused a race condition which broke the build. Fixed: 1096255 Change-Id: I68c6bff99167025aea68effcecb1fc22d29e61fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251163 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#780422}
-