- 10 Dec, 2019 40 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4c855c79362924fb96e04ef171c61f7363a82909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960178Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#723519}
-
Kevin Qin authored
Current OpenXr implementation has DXGI_FORMAT_R8G8B8A8_UNORM format, but DXGI_FORMAT_R8G8B8A8_UNORM_SRGB should be used. OpenXR's swapchain format expects to describe the texture content. The result of a swapchain image created from OpenXR API always contains a typeless texture. On the other hand, WebGL API uses CSS color convention that's sRGB. The RGBA typelss texture from OpenXR swapchain image leads to a linear format render target view (reference to function D3D11TextureHelper::EnsureRenderTargetView in d3d11_texture_helper.cc). Therefore, the content in this openxr swapchain image is in sRGB format. Fixed: 1020392 Change-Id: Id1526e4b3061c81dfb48b5b9fd4bdced7831fd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894049 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#723518}
-
Scott Haseley authored
This CL removes the priority-based anti-starvation logic from TaskQueueSelector. Anti-starvation has been disabled both in the browser and for the main thread in Blink, so this CL should not result in any additional behavior changes. This CL also replaces the backing data structure (SmallPriorityQueue) with a simplified ActivePriorityTracker, which is a wrapper around an integer representing which priorities are active. This also cleans up various unit tests: - Remove parameterized tests (with/without anti-starvation) - Fix PrioritizeCompositingAndLoadingInUseCaseLoadingTest in main thread scheduler unit tests. This was not running because it was missing an INSTANTIATE_TEST_SUITE_P, and the test was missing a comma causing it to fail. - Replace the TaskQueueSelector starvation unit tests and test for different orders of posted tasks. These were modified to be a bit more future proof/general and to test all priorities. - Remove the unit tests that test the starvation score logic. Bug: 1031336 Change-Id: I1ff8d83617d33c7510c33c08b78b1abc1a148683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954760 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#723517}
-
shrekshao authored
TBR=kbr@chromium.org Bug: 1027776 Change-Id: I5c3b6003187fcebc8e32c9d1a3d760b8d4091353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959934Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#723516}
-
Erik Chen authored
memlog_browsertests is now run as part of android_browsertests. There is no need to run these same tests in chrome_public_test_apk. Change-Id: Id058589bb87d0acf2d121f66f27b3f090b67a945 Bug: 970205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959052 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723515}
-
Danan S authored
This is needed in order to include the view of extension permissions in other dialogs, for example the upcoming parent-permission dialog for child extension installation. Bug: 1019908 Change-Id: I82bbf76cb8622fa555c968fd2e6a1f473033c534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952525 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723514}
-
Sergey Ulanov authored
GPU process was crashing due to NOTREACHED() being reacheable when playing video on Fuchsia. Removed NOTREACHED(). Bug: 1031793 Change-Id: I7b8e5ab9b155fe3661276871c658ec335a121960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957903 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#723513}
-
Peter Kotwicz authored
BUG=1032377 Change-Id: I54750edf0b3884cb7fde57e50c4670be6c8d2e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959416 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#723512}
-
Kevin Qin authored
Convert OpenXR test static variables to constexpr according to the code style guide. Bug: 1027794 Change-Id: Ic915a14d85df8f65baba3e363a9827b28f14bb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957130Reviewed-by:
-
Dana Fried authored
GetAvailableSize() is now present on View and LayoutManager. Followup CLs will implement and add support for all LayoutManagerBase layouts including having AnimatingLayoutManager use this information to correctly plan animations. Bug: 995448 Change-Id: Iaf50c9816af1b830e348f5019f30309147cd2c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958589 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723510}
-
Bettina authored
Previously we used to not differentiate between first sign-in and password change events for signed-in non-syncing cases because password protection only worked for Sync users. Since we're expanding it to signed-in users, differentiating them would allow us to read metrics better. Bug: 1032683 Change-Id: I801087383416e8f2d823da7c01850f8d27701098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958652Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#723509}
-
Bettina authored
Previously, SaveProtectedPasswordHash did not log a metric when a password is saved into the hash manager on first signed in. Bug: 1032322 Change-Id: I66fca65496ccd5866536d954f60e4773d66d3a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959046Reviewed-by:
-
Chris Mumford authored
Bug: 1007835 Change-Id: I3594e8a89bc8d424c708f54393797c3d77e9451e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951064Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#723507}
-
danakj authored
Also the derivative DownloadTargetDeterminer::CompletionCallback. R=avi@chromium.org Bug: 1007763 Change-Id: I8b943005e144826311e3d1b3c339c424f0cc1584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958895Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#723506}
-
Jérôme Lebel authored
Bug: 987646 Change-Id: I2ca468c58553ce7008467cacb36a26536986bdbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959028 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723505}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f60da87424a4..351307eba332 git log f60da87424a4..351307eba332 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 davidben@chromium.org Fix potential indexing into an empty vector in ANGLE tests 2019-12-10 b.schade@samsung.com Vulkan: Add options to select more device types Created with: gclient setdep -r src/third_party/angle@351307eba332 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032552,chromium:923166 Tbr: ianelliot@google.com Change-Id: If3998989530ca1091006abc1f27f14dffe7c6ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960399Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723504}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/39a8168c4ee5..be497359b6c9 git log 39a8168c4ee5..be497359b6c9 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 chiur@google.com Merge "Reland: Add proto for recording VkDebugMarkerSetObjectNameEXT" Created with: gclient setdep -r src/third_party/perfetto@be497359b6c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I615aa361326aa04dae2439231f287b0eff3f3b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960765Reviewed-by:
-
Francois Beaufort authored
This CL makes sure "infrared" is included in the Camera2 device name to help differentiate facing front cameras with the same name. Screenshot: https://photos.app.goo.gl/qDSaDc91LfTq9Z4W9 Test: https://webrtc.github.io/samples/src/content/devices/multi/ Change-Id: Ie5569c8d4e4f93de2e0f16c462465abfa5a7810d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960152Reviewed-by:
-
Istiaque Ahmed authored
Calling StopAllServiceWorkersForOrigin and DeleteForOrigin on a SW context can result in ServiceWorkerRegisterJob::OnStartWorkerFinished for a job that is already in COMPLETE phase. This CL bails out setting phase in this case. Bug: 1031764 Change-Id: I863320d4dbf8606c52d8e55af017dae05d011d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959525 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#723501}
-
Lambros Lambrou authored
The launchd helper tool shows the permission wizard for all non-root users, even if the host was disabled. This CL fixes this, so that the launchd service exits immediately if the host is not set up. So the wizard is no longer shown during first installation, and will first appear when the user sets up a host. The wizard is still shown during upgrade if the host was enabled but permission was not granted. This may be harder to fix, because the helper tool (launchd service) cannot easily tell whether it was started by the installer or some other cause. Bug: 1032164 Change-Id: I3e8c742f4caf5520cc494b0322bd0f084d5fa881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960582 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#723500}
-
Raphael Kubo da Costa authored
IWYU. Follow up to commit 2b2ea3c0 ("[cros search service] Move shared string matching functions to //chrome"), which broke the libstdc++ build: ../../chrome/common/string_matching/fuzzy_tokenized_string_match.cc:199:14: error: no member named 'pow' in namespace 'std' std::pow(partial_match_penalty_rate, long_start - current - 1); ~~~~~^ Bug: 957519 Change-Id: I66f61cb4f93cfa0bfa3d1b00ba391ddd8f31a7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960310 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#723499}
-
Oystein Eftevaag authored
At some point ScopedDeferTaskPosting got moved to go out of scope while |lock_| is held, which can cause priority inversion errors if PostTask is used. Added a AutoLockWithDeferredTaskPosting class which automates both taking the lock, and adding a ScopedDeferTaskPosting to the scope. Change-Id: Iaa50e980663804c83808b7dc6895a92aec3f74dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955959 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Auto-Submit: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#723498}
-
Nate Chapin authored
All it does is cancel a timer and restart it when unpausing, which is unnecessary as the underlying task queue will be paused, too. HTMLDocumentParser had recently been made a ContextLifecycleStateObserver, which had caused a substantial slowdown in perf_tests/parser/tiny-innerHTML.html. This CL removes that inheritance and reverses the slowdown. Bug: 1030905 Change-Id: I4c296869b60db8c152c14cf1619051c21918ef82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955849 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#723497}
-
Sean Gilhuly authored
Refactor GpuDataManagerImplPrivate to decide upfront the strategy for GPU process fallback by pushing valid states onto a stack. Then, during fallback, pop the stack to get the new state, or crash if none are left. Add some unit tests to verify that fallback states occur in the right order. This is meant to make fallback behaviour more straightforward to help set up for fallback from Vulkan to GL, with no functional changes. Bug: 1005383 Change-Id: I9644bceaabf834a98dc2a712445045f18010a8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949007Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#723496}
-
Yi Su authored
LegacyNavigationManagerImpl is deprecated and should be removed. Bug: 1029306 Change-Id: I15ecaba4b21d49f5c2b60945d27aeb774cf823b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959030Reviewed-by:
-
Becca Hughes authored
This test is breaking the ios_simulator builds. TBR=ajuma@chromium.org BUG=1032652 Change-Id: I9b0368d3eb8ffae51cec06875a8254c8e50a516f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960768Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#723494}
-
Yi Su authored
WebStateObserver::NavigationItemsPruned is part of the legacy navigation and is already cleaned up in https://crrev.com/c/1953765. This CL cleans up remaining usage in //ios. Bug: 1029306 Change-Id: I5e96c868f44100f28a13b7cba2ba797b8c938644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960449Reviewed-by:
-
Ken Rockot authored
This is a strictly mechanical move of SessionStorageMetadata out of Content and into Storage Service. Also moves SessionStorageDatabase (a test-only helper used by SessionStorageMetadata tests) into the service's test_support library, renamed to TestingLegacySessionStorageDatabase. Bug: 1000959 Change-Id: Ie852fc1b2b8f94e116e92f8d513086328555a85d Tbr: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958429 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#723492}
-
Kurt Horimoto authored
In addition to adding an application-level open URL utility, this CL also converts the WebState visibility check to a unittest. Bug: 987646 Change-Id: Ia2c99573dcabf64db0b06c094c95d5aa6d44c3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900690 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Rohit Rao authored
This reverts commit 98f067d3. Reason for revert: The following tests are newly failing on EG1 devices: TabUsageRecorderTestCase/testEvictedTabReloadBackgrounded TabUsageRecorderTestCase/testEvictedTabReloadSettingsAndBack TabUsageRecorderTestCase/testEvictedTabSlowReload https://ci.chromium.org/p/chrome/builders/ci/ipad-device/6112 The following tests are flaky on EG2 simulator: TabUsageRecorderTestCase.testPageRedirect TabUsageRecorderTestCase.testLinkClickNavigation https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/1392 Original change's description: > [EG2] Convert tab_usage_recorder_egtests > > Note: the tests that were disabled are still disabled. > > Change-Id: Id39fe6a8342d379539b84c1d8a60f2e9ce053c19 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928788 > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722917} TBR=eugenebut@chromium.org,olivierrobin@chromium.org,stkhapugin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1a61a746bdcfe5646e266a0a7e85e9810ddec31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959933Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a58b81f6720d..f013e8b39651 Created with: gclient setdep -r src-internal@f013e8b39651 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1030676,chromium:984162 Tbr: jbudorick@google.com Change-Id: I439e48acf1b8389546dd136882c46799942b567e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960689Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723489}
-
Ian Wells authored
Manual merge from https://chromium.googlesource.com/feed/+/8415ae95f9d6c4b1e8f118937743c6eec95bdf20 Bug: 1031666 Change-Id: I8ae830a2b9283b11c17e77b97794ac4a6adf90b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956069Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#723488}
-
kyle Ju authored
Subtest name being appended twice when running only failing subtests through --isolated-script-test-filter flag. Bug: 1026134 Change-Id: Iaae4449a462d15a2ef5e859865f075843977f2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929534 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#723487}
-
Gavin Williams authored
-Most select elements have an associated text label to explain the element's purpose. To be in line with the overall Settings page a11y strategy, the labels will be marked as aria-hidden so ChromeVox navigation will skip over the label and navigate directly to the select element. -This CL is primarily adding aria-hidden to the labels and in a few places correcting/adding the select element aria-label. Fixed: 1015899 Change-Id: Ibc0a18498bdcdbba7bc3f824a24831a13716f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947194Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#723486}
-
Daniel Clark authored
When the controls refresh is enabled, LayoutThemeMacRefresh is used instead of LayoutThemeMac. The former inherits from LayoutThemeDefault but implements no functionality of its own, whereas the latter inherits directly from LayoutTheme and implements various mac-specific styling. Most of LayoutThemeMac applies to the old form control implementations, and will eventually be discarded in favor of platform-agnostic implementations in LayoutThemeDefault. However, text selection color is also specified in LayoutThemeMac, and this was not replicated in LayoutThemeMacRefresh, with the result that switching on the controls refresh flag changes text selection color. This CL resolves the issue by reproducing the non-controls-related theming functions from LayoutThemeMac in LayoutThemeMacRefresh. The code duplication looks suspicious at first glance but should be acceptable for the time being because all of LayoutThemeMac is destined for deletion once the new controls have been permanently enabled. Bug: 994290 Change-Id: I1b881b2ca2fe718cd89a49535e36dd99ea65b9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947443Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#723485}
-
Jonathan Backer authored
This CL switches to using new Skia API for GPU accelerated readback with the Vulkan backend. Subsequent CL will also switch over GL backend from (GLRendererCopier). Bug: 1022495 Change-Id: I0b9a3556ef1610e3520bd5caef105f732d925312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949180 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
-
Yuchen Liu authored
No one use it. Remove. Bug: None Change-Id: Id65c425b74149dc85658820d88192684f60e9c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959787 Auto-Submit: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#723483}
-
Elly Fong-Jones authored
These have not been looked at for a long time, and as of r722561 are not gathered any more. Bug: 496955 Change-Id: I4457fb6bafad9324b99017ae1a344183bd1e099a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954257 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#723482}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72bbbb91. With Chromium commits locally applied on WPT: a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." eb00b4d6 "LazyLoad: move invisible-image.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ericwilligers@chromium.org: external/wpt/css/motion NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Iee4c9cf73d8a58f2d0021385ad6f4b860aaa92c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960527Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723481}
-
Thomas Guilbert authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/fa04e15e1ad6..68b4dfdbd607 $ git log fa04e15e1..68b4dfdbd --date=short --no-merges --format='%ad %ae %s' 2019-12-04 tguilbert README.chromium file 2019-12-04 tguilbert GN Configuration 2019-12-03 hwrenx lavc/libxavs2.c: optimize error descriptions 2019-12-03 hwrenx lavc/libxavs2.c: fix code style - spaces 2019-12-03 hwrenx lavc/libxavs2.c: avoid recomputations of pointers in xavs2_copy_frame* functions (...) 2019-10-22 andreas.rheinhardt avformat/mpeg: Don't free unintialized pointer 2019-10-23 ramiro.polla mpegvideo_enc: add intra_penalty option for p frames 2019-10-23 andreas.rheinhardt avformat/icoenc: Add deinit function 2019-10-23 andreas.rheinhardt avformat/aiffenc: Use better error codes 2019-10-22 andreas.rheinhardt avformat/mpeg: Add padding to extradata Created with: roll-dep src/third_party/ffmpeg Bug: 1031252 Change-Id: Ie4dce5c2112c018b9353b7244391e1682ed37134 TBR: tmathmeyer Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956258Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#723480}
-
