- 06 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/c6345ca36de9..f88c00e45a2f 2021-01-06 wl@gnu.org * meson.build: Add summary. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I1b25a429bbe73812ca67f68ec0ff9a8f834c3f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840758}
-
Joe Mason authored
This creates a simple accessor in RenderFrameHost to check whether a frame is cross-origin isolated. It allows features that are gated behind this policy a way to assert that they are only being invoked when allowed. Currently not all the information needed to determine this is available in the browser process so the accessor returns kNotIsolated or kMaybeIsolated. This also adds such a check to WebMeasureMemory, which is invoked from a renderer with OnWebMeasureMemoryRequested. It terminates the requesting renderer if it is definitely not cross-origin isolated. Based on http://crrev.com/c/2574730 by chrisha@chromium.org, which added IsCrossOriginIsolated to RenderProcessHost instead. BUG=1085129 Change-Id: I2d9d1dd344c85c9358d549fc775282e9736df580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578083Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#840757}
-
Hassan Talat authored
Enabling the Web Share APIs (navigator.Share) on macOS and have it disabled by default. Bug: 1144920 Change-Id: I2d00691f136ced6a8dc85b0478fb69dfeec5a9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607980 Commit-Queue: Hassan Talat <hatalat@microsoft.com> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Hassan Talat <hatalat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840756}
-
Matt Reynolds authored
This CL addresses two issues: In HidServiceWin, |platform_device_id_map| is initialized incorrectly for devices that do not use report IDs. The item added to the map incorrectly has an empty |report_ids| vector which effectively means that the corresponding device ID will never be used. To fix it, the |report_ids| vector is initialized with a single element with value 0, indicating that the corresponding device ID should be used for all reports. In HidConnectionWin, when the connection is closed the |transfers_| list is cleared. If |transfers_| was non-empty, this will invoke the destructor of any PendingHidTransfer objects that were in the list. If the callback calls UnlinkTransfer, the DCHECK is hit since |transfers_| is already cleared. To fix it, the callbacks should check |signaled| and only call UnlinkTransfer when the file handle was signaled by the OS. Bug: 1163277 Change-Id: Ic7897a9373afdd0a2045c8bc89bce7478f9ddf29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612505Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#840755}
-
Evan Stade authored
Since these classes depend on blink types, they're moved to //components/site_engagement/content. In the future, for the purposes of ios support (bug 775390), these classes will likely need to be refactored to remove that dependency and move from content to core. Bug: 1147274 Change-Id: I1aae22152029a2e4ea52909137d555cb8e738ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599932Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#840754}
-
Nick Diego Yamane authored
So far, only WaylandToplevelWindow supports drag'n'drop, by implementing ui::WmDragHandler, which prevents, for example, Chrome's Bookmarks DND features from working as expected. Dragging a bookmark from the bookmark bar into a folder makes the folder content to be shown in a popup/menu window, which must get notified about the drag/drop events so the menu controller can determine when to open/close menu items accordingly. This CL address it by moving WmDragHandler impl to WaylandWindow base class. Also, unit tests are added to make sure the DND events are properly propagated to drag/drop handlers attached to non-toplevel windows. Bug: 1143707 Test: ozone_unittest --gtest_filter='*WaylandDataDragControllerTest.*' Change-Id: Icef2cc1e66851edfa21fa5d890ca0398aceeed51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595087 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#840753}
-
Hui Yingst authored
This CL removes uses of VectorFromPPPoint() since it no longer has a caller, and replaces PPPointFromVector() with a pp::Point constructor. Change-Id: I773be154d1eb844325832ff1248147a890c36f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604953 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#840752}
-
Sunny Sachanandani authored
TBR=kbr@chromium.org Bug: 1157136 Change-Id: I87d0c0ed495f9d63de622ebeafab8232d90262ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612838 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#840751}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4dde23fea599..cee13faaf357 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib2d9e5eaa8fcbf42f17710db3833e22a0e66620b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613237Reviewed-by:
-
Collin Baker authored
Bug: 1163620 Change-Id: I51d56b0650f62d5b96a5166cc0c4eaef7e5e081d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613534Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840749}
-
Peter Wen authored
Targets that explicitly disable the bytecode checker do not need desugar to warn about missing classes either, it is known that they have missing deps in their classpaths. Remove the desugar ignore list. Add one entry as it's a special dep from doubledown. The missing class is a final class so it does not affect interface desugaring. The other entry is specific to jacoco coverage being turned on. D8 desugaring does not work well with DexSplitter for the moment, will use follow-up CLs to fix that. This is possibly due to D8 no longer desugaring default/static interface methods on API 24+. Original CL: https://crrev.com/c/2593760 Fix: - Add not_needed for dex template. Bug: 1015559 Change-Id: Iff85fd31f47d7ad84d7c3e18c871e25b313c19af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611957 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#840748}
-
David Black authored
The Files app chip appears in the pinned files section of holding space UI when the user has not yet pinned a file. Bug: 1163365 Change-Id: I39412de8f8e40a231ddf1fec81a0b91149ca479b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612118 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#840747}
-
Aleks Totic authored
Percentage rows were being treated as empty rows. Change-Id: Ie7cec07f9fadd237afd0ab72949f3004d7dfd66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612026 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#840746}
-
Collin Baker authored
This reverts commit f08bc1d7. Reason for revert: test failures on all builders https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/112556 https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/78710 https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel/13023 Original change's description: > [GridNG] Computation of static offsets edges and grid area for out of > flow items > > 1. Function ResolveOutOfFlowItemGridLines: The column and row span of > the grid area for the out of flow item is obtained through > GridPositionResolver, and the grid lines of the out of flow item are > computed. > > 2. Refactor of CacheItemSetIndices: For in flow items, computation of > the set indices remains the same. To compute the indices for out of flow > items we take into account the following: > a. If both the start and end line of the out of flow item are not > 'auto', then the indices are computed as if they were in flow items. > b. If either is 'auto', then its value is kNotFound. > c. If either is attempting to create a new line in the grid, then they > are treated as 'auto'. > > 3. Helper method ComputeOffsetAndSize: the computation of the offset and > size of each item was generalized to include the cases where either or > both of the set indices are auto in out of flow items. Additionally, > inline and block edges are computed. > > Bug: 1045599 > Change-Id: I15b680d1866cdb81b42d626bcd6948ae1b7132ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567573 > Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840701} TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,schenney@chromium.org,kschmi@microsoft.com,janewman@microsoft.com,ethavar@microsoft.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,ansollan@microsoft.com Change-Id: I1a5390db7657202f12cea3a9fb31a95d4ce5788a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613550Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840745}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3da30cd29fe3..2ca6ad8ed38e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC collinbaker@google.com,tinazwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: collinbaker@google.com,tinazwang@google.com Change-Id: I18b4fa33dd6e38172b5da63fcd88f20a564bfdfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612491Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840744}
-
Basia Zimirska authored
Also, move language_usage_metrics* code to components/language/core/browser This Cl is just is a name change / move refactor. Bug: 1150230 Change-Id: I41220046df505b2320d6e83a28988758f5d7e9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604948Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Commit-Queue: Basia Zimirska <basiaz@google.com> Cr-Commit-Position: refs/heads/master@{#840743}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609934346-e8075e70051f1cf5498240cc23c791e5411fb4de.profdata to chrome-linux-master-1609955739-6b0df8082f85d23ee00a8173801024bf5e32803c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id88cd159b83e852a92f875aae9b3ad3689edbb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611414Reviewed-by:
-
Bin Du authored
The disabled reasons cover sync service, Chrome sync and Chrome OS sync. Bug: b:175067939 Change-Id: I4e4da45a8f992a211209b5a9ec8b82d1ea23b8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612149 Commit-Queue: Bin Du <dubin@google.com> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#840741}
-
Sorin Jianu authored
Bug: 1163583 Change-Id: Iad8fccb8adceec3d22680d4af460ee22f3428a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612269Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#840740}
-
Lan Wei authored
After we automate some input event manual tests, there are some unused JS files. I clean the unused files in this CL. Bug: 1145677 Change-Id: Ibf719eb3cb2fc01c708da41d02598488be69a459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533691Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#840739}
-
Alexander Surkov authored
generated by tests or by ax_dump_tree tool Local position is relative the content area and useful for testing because it doesn't depend on browser position or browser UI. It's also useful to compare browser trees via ax_dump_tree tools for the very same reasons. Bug: 1133330 Change-Id: Ice9dd20d9eb7e518d3a58703c7cff12bb11dbdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605345 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840738}
-
Xi Han authored
In this CL, we introduce a new flag "keepTab" for a Tab with launch type FROM_START_SURFACE. When this kind of Tab is selected from the carousel Tab switcher on the Start surface, or from grid tab switcher, the "keepTab" is set to be true. This guarantees the tab won't be auto deleted from the TabModel when the back button is tapped. More details see doc: https://docs.google.com/document/d/1mZXgQ0fi_b96vcwy1DkgWunl0FutkFwyt-7PrU-Pgjc/edit# Bug: 1155139 Change-Id: Ib1e2ce917b0396bbd147ada2ebfc470cffd4718a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585822 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840737}
-
Peter McNeeley authored
By default Lacros-chrome is using OneCopyRasterBufferProvider for UI rasterization. This does software rasterization (slow) and then uses gl commands to upload and copy the resulting textures. On extremely rare occasions there is a gpu context race and the UI textures are not properly uploaded. By enabling gpu rasterization, Lacros returns to being equivalent to ash-chrome and we avoid this context bug. More information on raster buffer providers can be found here: https://source.chromium.org/chromium/chromium/src/+/ master:docs/how_cc_works.md Bug: 1157602 Change-Id: Ife3104268fec75ffb62c87a626d8ff64999a53b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606132Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#840736}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Icff41f1a1612fe8f8b5b588af1b85fc739c2323f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612037Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840735}
-
Martin Kreichgauer authored
To better reflect that it now handles ChromeOS as well. Also make the has_recognized_platform_authenticator_credential field in TransportAvailability a base::Optional to reflect that it will be unset if we're not making a GetAssertionRequest with a present platform authenticator. Bug: 1157651 Change-Id: I2fd7d1e88c237c198250cf2e2c5eb0309d014cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587559 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#840734}
-
Nicolás Peña Moreno authored
Bug: 1161464 Change-Id: I324c4ea7e1dde8e40de4f320cb2ddf49ace0dc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611184 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#840733}
-
Benjamin Beaudry authored
In CL:2577757, we allowed fragmentation for abspos positioned using the bottom property and with `height: auto`. There was one remaining issue with the abspos fragment when a child of his had a break-rule - its height was off, giving the impression that it didn't encompass all its children. This CL resolves this issue. The behavior of expanding the height to encompass all children will cause the bottom property to be off from where it was originally intended to be. That's a downside widely discussed offline between Rossen (co-author of the CSS Fragmentation spec), Alison and I, but a solution relatively acceptable to a problem that isn't NP-complete. Gecko seems to do the same as well. Bug: 1156250 Change-Id: Ie67f7aff9a64e7d813f346ad83cd6d4bcd5186e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597957 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#840732}
-
Dave Tapuska authored
Use the disconnect handler instead of listening to a direct instance deleted message. BUG=1157519,1137580 Change-Id: If875905804238b0f7c1d75880a5fd73f4b7ddcbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587428 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840731}
-
Tina Wang authored
TBR=smcgruer@chromium.org TBR=collinbaker@chromium.org Bug: 1163172 Change-Id: I462c897e3271e80588abfd73d9f259e01f20dd78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611956Reviewed-by:
Tina Wang <tinazwang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/393f02dd00ba..cbab637962d0 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d630e5f8c10c to 37c03859de9e (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 2468aa9630c2 to 98382948dfea (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 1bb80d2778a3 to d630e5f8c10c (1 revision) 2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 9325cc013e3d to f77085c307fc (1 revision) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 57255a663ed9 to 2468aa9630c2 (1 revision) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 1f0c7868a438 to 9ba835885ffe (1 revision) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 56a96658b750 to 57255a663ed9 (3 revisions) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 294480cb7f3e to 1f0c7868a438 (1 revision) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 7554321b88ae to 4cc0932495ec (2 revisions) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 66a23ac8c566 to 294480cb7f3e (1 revision) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 85470b32ad5d to 9efc4a631161 (1 revision) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from aa076dae88e2 to 56a96658b750 (25 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I45b30af7ac543aecdb92de93f923a39049387a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611995Reviewed-by:
-
Peter Kasting authored
Originally these assumed only colors were affected. That's not true. Update the font list and line height properly. Bug: none TBR: elainechien Change-Id: I4d908744bb0bc0ac46c469594c2950421cf61b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612086Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#840728}
-
Vladimir Levin authored
This patch ensures that if we have a hittest result that has a locked node, we don't try to recurse into its subtree. This can happen when we do a PositionWithAffinity check. R=chrishtr@chromium.org Bug: 1162131 Change-Id: I357bd7032c6c2b6c9405bf26c49a36bda22d6a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611453Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840727}
-
Gauthier Ambard authored
This CL prevents a crash happening on stable where the app will crash when receiving a redirect while the |context| is nil. We know that there are multiple places where the |context| can be nil, we don't know why. We should treat this in the same way as we treat other places with no context: by returning early. Fixed: 990499 Change-Id: Ia80ad38c58d1b52022163990857d98e9745dd5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611708Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#840726}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca7d9ee2a720..1bd38fed1b9e 2021-01-06 fmayer@google.com Merge "Add tests for rest of Client API functions." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ica9fcd5d912d7bf278f5542a58703cee3d0f968b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611411Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3a03505a9fd6..b631a88c6eeb 2021-01-06 sokcevic@google.com Run git fetch with --prune on failed git cl upload If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1149640 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8c0b5872d8974dd7d7b3dd02867bb1cefe13a43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611409Reviewed-by:
-
Adam Langley authored
The caBLE UUID should only appear in adverts. However, should future APIs expose BLE adverts more directly this blocklist will hopefully still apply. Therefore add the caBLE UUID. Also submitted to the WebBluetoothCG list: https://github.com/WebBluetoothCG/registries/pull/26 BUG=1002262 Change-Id: I91cda6bc31a52b87a6a3a029fb26d12996199146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612030 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
The histogram was never recorded as far as I can tell. Change-Id: Ia9f8465af9519577625cb12a243b26ac4eedb541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612089 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#840722}
-
Thomas Guilbert authored
This CL converts OriginStatusMap, StatusMapCallback and ListCallback to OnceCallbacks. It also deletes the unused RemoteVersionsCallback and DownloadVersionCallback. The CL also changes CallbackTracker to support OnceCallbacks only, which is in line with the guarantees offered by CallbackTracker. There are also a few opportunistic clean ups to use std::make_unique, instead of calling "new". Bug: 1152272 Change-Id: I4fc28eabd10f61297be62edd0a1c00f473bb45b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606713 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#840721}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. Bug: 1145565 Change-Id: I3b4e6b16d6a0159547e90538ce6d573869f71ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613146 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
ssid authored
The tests no longer seem flaky form local testing. Bug: 1145008 Test: 100 runs on release and 100 runs on debug build, x86 device. Change-Id: I084c630015b3602dd249617fd868b09cbf031c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603419 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840719}
-
