- 11 Jul, 2018 40 commits
-
-
erikchen authored
This matches other macOS application like Safari, Terminal, etc. All existing hotkeys will still work. This CL uses the same hotkey for "previous tab" that Safari and Terminal use, which is [ctr + shift + "Horizontal Tab"]. This also causes tests to pass. However, pressing that key combination actually generates [ctr + shift + "End of Medium"], which renderers in the Main Menu as a backwards tab. This CL updates NSMenuItem(ChromeAdditions) to check for this special case. This CL removes two incorrect DCHECKs from render_widget_host_view_cocoa.mm. I regularly hit both of them when running Chromium on a local build. They both rely on the false assumption that keyEquivalents in the main menu must have the command modifier. Bug: 851714 Change-Id: I90c643870f9bc7dd87369496eec9ab62a1685e07 Reviewed-on: https://chromium-review.googlesource.com/1106659 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574211}
-
kristipark authored
- Favicon size increased from 16dp to 24dp. - Icon background size increased from 40dp to 48dp. Bug: 855194 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8a9e9bede375da1b0ffa7050f97a1de1dd1162ac Reviewed-on: https://chromium-review.googlesource.com/1132527 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#574210}
-
Sammie Quon authored
This is a reland of a663e7fd The original cl causes some flaky tests with stack trace: [16202:16202:0709/211202.910243:FATAL:single_thread_proxy.cc(237)] Check failed: task_runner_provider_->IsMainThread(). #0 0x7f9b36f8672d base::debug::StackTrace::StackTrace() #1 0x7f9b36c9d3fc base::debug::StackTrace::StackTrace() #2 0x7f9b36d06dfd logging::LogMessage::~LogMessage() #3 0x7f9b2b5692e8 cc::SingleThreadProxy::SetNeedsCommit() #4 0x7f9b2b45ecef cc::LayerTreeHost::SetNeedsCommit() #5 0x7f9b2b467426 cc::LayerTreeHost::SetMutatorsNeedCommit() #6 0x7f9b0fd29981 cc::AnimationHost::SetNeedsCommit() #7 0x7f9b0fd1962d cc::Animation::SetNeedsCommit() #8 0x7f9b0fd41151 cc::KeyframeEffect::KeyframeModelAdded() #9 0x7f9b0fd44e6c cc::KeyframeEffect::AddKeyframeModel() #10 0x7f9b0fd17fbc cc::Animation::AddKeyframeModelForKeyframeEffect() #11 0x7f9b0fd71a6d cc::SingleKeyframeEffectAnimation::AddKeyframeModel() #12 0x7f9b28c83a95 ui::LayerAnimator::AddThreadedAnimation() #13 0x7f9b28c7498e ui::(anonymous namespace)::ThreadedLayerAnimationElement::RequestEffectiveStart() #14 0x7f9b28c71113 ui::LayerAnimationElement::Start() #15 0x7f9b28c7cbe3 ui::LayerAnimationSequence::Start() #16 0x7f9b28c84287 ui::LayerAnimator::StartSequenceImmediately() #17 0x7f9b28c81251 ui::LayerAnimator::StartAnimation() #18 0x7f9b28c80eb6 ui::LayerAnimator::SetTransform() #19 0x7f9b28c6122e ui::Layer::SetTransform() #20 0x7f9b28ded831 aura::Window::SetTransform() #21 0x7f9b22b732df ash::ScopedTransformOverviewWindow::SetTransform() #22 0x7f9b22b73f69 ash::ScopedTransformOverviewWindow::OnCompositingStarted() #23 0x7f9b28c4d734 ui::Compositor::DidSubmitCompositorFrame() #24 0x7f9b2b56cd05 cc::SingleThreadProxy::DoComposite() #25 0x7f9b2b56e835 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() #26 0x7f9b2b3736fd cc::Scheduler::DrawIfPossible() #27 0x7f9b2b36dbdc cc::Scheduler::ProcessScheduledActions() #28 0x7f9b2b36d5fd cc::Scheduler::OnBeginImplFrameDeadline() This cl makes that test skip waiting for composit when entering overview, like the tests in ash. Original change's description: > overview: Hide title bars before animating into overview mode. > > The title bars should not visible while animating overview mode. This cl > hides the title bar if needed and waits until the next paint before > animating the windows. This will hide the title bar as expected while > keeping the benefits of DeferPaint. > > Test: manual > Bug: 843851 > Change-Id: I99cf7ca39fd1ae14314ac406abd0fec999e2c024 > Reviewed-on: https://chromium-review.googlesource.com/1112774 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573552} TBR=oshima@chromium.org Bug: 843851 Change-Id: I3a538250d5f6d42d6c73e218445080af533b54dc Reviewed-on: https://chromium-review.googlesource.com/1131874 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#574209}
-
David Michael Barr authored
We only need to format the files generated by cmake. This causes no change to the current configuration. This facilitates upcoming changes to the generator. Bug: 783519 Change-Id: If8e51f082881728c46a8ee9924db5d2c3ac13d11 Reviewed-on: https://chromium-review.googlesource.com/1132267Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#574208}
-
Adolfo Victoria authored
Add ToLocalizedString() function to WeeklyTime for later use in the UI for DeviceAutoUpdateTimeRestrictions. BUG=chromium:852860 TEST=unit tests Change-Id: I85db9b19a3f1a1b589c26c064c221fe8e2137123 Reviewed-on: https://chromium-review.googlesource.com/1119392 Commit-Queue: Adolfo Higueros <adokar@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#574207}
-
Lei Zhang authored
Change-Id: Idba04cf28ac6ece89f23e9b83005d508b37818c8 Reviewed-on: https://chromium-review.googlesource.com/1132566Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#574206}
-
Nektarios Paisios authored
The user facing bug is that NVDA speaks the names of buttons twice. According to the HTML spec, there are three types of input form controls when it comes to how they expose their value attribute: 1. Expose the value attribute itself 2. Expose their checked state and 3. Expose their contents converted to text after sanitization, e.g. a date converted to a string. Only the third type should be exposed to accessibility. The first type exposes their value attribute as their name, if not overwritten by the accessible name calculation, so exposing it a second time as part of the value attribute would make NVDA speak the name of the control twice. The second type exposes their checked state using other accessibility attributes, e.g. "checkable=true". R=aleventhal@chromium.org Tested: manually with NVDA, browser tests Change-Id: I64579a15973fbfa8058e341d7ad32b2f30113dd3 Reviewed-on: https://chromium-review.googlesource.com/1121526 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#574205}
-
Hongchan Choi authored
For the future DevTool integration, we need a unique identifier for each BaseAudioContext. This CL generate a UUID for BaseAudioContext at its construction time. Bug: 862411 Change-Id: I2dda45611af21d57820e1539b22091deb8ddf443 Reviewed-on: https://chromium-review.googlesource.com/1132419 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574204}
-
Anna Malova authored
Bug: 859125 Change-Id: Ib8e85897d5059ec421ed9ddc63921a6005b37c9d Reviewed-on: https://chromium-review.googlesource.com/1133175Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#574203}
-
Xunran Ding authored
Update the code directory to use the dedicated Origin type instead of URL. The next step would be storage/browser/fileapi. Bug: 598424 Change-Id: I5dab8c9b7c097eb163d7565149b577f73850381d Reviewed-on: https://chromium-review.googlesource.com/1128796Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#574202}
-
Nicolas Pena authored
This is a reland of 699ed793 Original change's description: > Add QueueingTimeEstimatorPerfTest > > This CL adds a microbenchmark for QueueingTimeEstimator that runs lots > of tasks and computes ExpectedQueueingTime on them. The test is DISABLED > as it takes 6 seconds to run and will only be used manually to compute > improvements. > > Bug: 860246 > Change-Id: I50d5471ed4628bf144b3da35b66d597ce6eac3c3 > Reviewed-on: https://chromium-review.googlesource.com/1126444 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573012} Bug: 860246 Change-Id: I9828081556326ae76f81b48ef65ad29812e65ad2 Reviewed-on: https://chromium-review.googlesource.com/1127962 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574201}
-
Scott Violet authored
Indentation was wrong in this file. BUG=none TEST=none (only a reformat of code) Change-Id: Iddb81936e13026c2bbcbfd617837fd9784410043 Reviewed-on: https://chromium-review.googlesource.com/1133423 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
David Tseng authored
Bug: 851654 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic3ef45567f53eef44a92e0adb51ef592a9e5bfe2 Reviewed-on: https://chromium-review.googlesource.com/1132117Reviewed-by:
-
chcunningham authored
Use new IdentityManager and utils. SignInManager is deprecated. Also cleans up some stale includes. Bug: 797952 Change-Id: I4ee9dc7f480319dff277ddf71e1776f081082ccb Reviewed-on: https://chromium-review.googlesource.com/1131675 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#574198}
-
Peter Kasting authored
This is unnecessary, since the new tab button width doesn't change, and is stored in |new_tab_button_bounds_|. We can simply read that directly. Bug: none Change-Id: I7bc1305f3e366b07f78a79cfa3e2b4cf340c792f Reviewed-on: https://chromium-review.googlesource.com/1132559Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#574197}
-
David Bertoni authored
Bug: 836412 Change-Id: Iace2aff72b8bfe065ef270593bf9c47d02fd62fd Reviewed-on: https://chromium-review.googlesource.com/1116065 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574196}
-
Peter Kasting authored
Also moves the separator to have 8 DIP between its trailing edge and the NTB, instead of between its leading edge and the NTB. This parallels how it's positioned when the tabs are drawing it in the other two NTB positions. Bug: none Test: Run with --force-ui-direction=rtl --new-tab-button-position=trailing and ensure a separator is visible next to the new tab button Change-Id: I7e58485626c5ebab5dd477cefada5825479bdcb4 Reviewed-on: https://chromium-review.googlesource.com/1132484Reviewed-by:
-
Tiger Oakes authored
Changes so far: - Improved reading of a node in a screen reader - Added checkboxes and radios into tab flow - Settings starts expanded instead of hidden - Arrow immediately rotates when expanding a row - Added "Select all" and "Select none" buttons for types - Query parameters equal to the defaults are hidden - Types are shown as a single string in the query - .bss is no longer checked by default - Fetch requests are cancelled when a new one is started Demo: https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-07-10/ Bug: 847599 Change-Id: I366ff2746a331e846dc0c683757a2a5bfa43d96a Reviewed-on: https://chromium-review.googlesource.com/1132132 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574194}
-
Michael Thiessen authored
This changes removes the black overlay with an animation after the orientation change is completed and the GvrLayout is the correct size. Bug: 860764 Change-Id: I8e0f1a0bc3779905d6259ecfcae0e487341f8ff6 Reviewed-on: https://chromium-review.googlesource.com/1132315 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#574193}
-
Raphael Kubo da Costa authored
This makes //tools/license.py stop complaining that this third-party component is missing a copyright file. Change-Id: Iad66f77a7881945c2048c13f2293a6377146d235 Reviewed-on: https://chromium-review.googlesource.com/1133005Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#574192}
-
Becca Hughes authored
MediaControlSliderElement is causing a ClusterFuzz error because we are casting a float to an int that could overflow. BUG=852364 Change-Id: Ic454a79ebf6ef8d40f85e054a70cb87030c6db9c Reviewed-on: https://chromium-review.googlesource.com/1131921 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#574191}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b1a4db5551ca..e7e454da8e38 git log b1a4db5551ca..e7e454da8e38 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 art-snake@yandex-team.ru Do not store cross ref v5 obj within document. 2018-07-11 vmiklos@collabora.co.uk Add FPDFFormObj_CountObjects() API 2018-07-11 thestig@chromium.org Check GetObjDefnID() in various JS functions. Created with: gclient setdep -r src/third_party/pdfium@e7e454da8e38 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:810768,chromium:862059 TBR=dsinclair@chromium.org Change-Id: I5cdecfe75e8069f179eca07f9eb873cfa875c756 Reviewed-on: https://chromium-review.googlesource.com/1133338Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574190}
-
Olivier Robin authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib146d46a7b50ed06ee26434fdcbd7166672141fa Reviewed-on: https://chromium-review.googlesource.com/1118549Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574189}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0ee8d2d8. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21175 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations TBR=foolip No-Export: true Change-Id: I711be3ceae60227e3a91d1dd3b6f2202d6ee4fcd Reviewed-on: https://chromium-review.googlesource.com/1133122 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574188}
-
Christopher Cameron authored
Whenever the ui::Layer for BridgedNativeWidgetMac is hidden, also lock the ui::Compositor ("lock" in this sense means "disable drawing new frames"). This ensure that we won't draw any blank frames (which is what would result in a blank frame). Bug: 712244 Change-Id: Ia8c17742e6a48190b9a3aead6443102a585d1f7d Reviewed-on: https://chromium-review.googlesource.com/1129320 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#574187}
-
Etienne Pierre-doray authored
This creates and uses AutofillProfileEnabled flag to disable profile autofill. This affects: - PersonalDatamanager - FormDataImporter - AutofillManager AutofillProfileEnabled will be added as a policy as a follow up CL. Bug: 860526 Change-Id: Ied9a29c9ada7b7e564f1ba19fa738854fab7b17e Reviewed-on: https://chromium-review.googlesource.com/1127344 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#574186}
-
John Z Wu authored
This avoids a DCHECK. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If764659a3b0d12955e79d155f1408e44db10277d Reviewed-on: https://chromium-review.googlesource.com/1129962 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#574185}
-
Sylvain Defresne authored
Converting the method to a free function allows to decouple AccountInfo from AccountId, eventually allowing to move it to services/identity/public/cpp or even converting to the mojo structure. Bug: none Change-Id: I020dad29ae286cd9da23c819ce0f32c57da3fb8c Reviewed-on: https://chromium-review.googlesource.com/1124453Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#574184}
-
Paul Meyer authored
Every intervention report should have a human-readable id, as specified in the Reporting spec. https://w3c.github.io/reporting/#dom-interventionreportbody-id Bug: 564071 Change-Id: I82d1237fe9b45f28691e0772abd6d9995833e1ee Reviewed-on: https://chromium-review.googlesource.com/1129469Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2229b76258f7..4ec72f7cc745 git log 2229b76258f7..4ec72f7cc745 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 ruiqimao@google.com added skeletal animation support to GPU backend Created with: gclient setdep -r src/third_party/skia@4ec72f7cc745 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I3835858a733fb33db6c6626cc991633c077ae01c Reviewed-on: https://chromium-review.googlesource.com/1133239Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574182}
-
Scott Violet authored
This also removes mash_ash_unittests as it's no longer applicable. There is a lot of cleanup that can happen, but I'm leaving that for future patches in hopes of not making this one too big. BUG=855767 842365 840391 TEST=covered by tests Change-Id: If97385dc0e0b65974b8773043da55d576ff3d1fb Reviewed-on: https://chromium-review.googlesource.com/1131924Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574181}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8885d8b2..c3ce505d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iadfe747543fd01e9c2711b0f9f23c15d43bc17da Reviewed-on: https://chromium-review.googlesource.com/1133121Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574180}
-
Wez authored
This is a reland of 1afbb0e4, tweaking the DevToolsManager test to use quit-when-idle, to ensure that timeout tasks have all had a chance to run before we quit each RunLoop. Original change's description: > Migrate //content unit tests off of QuitCurrent*Deprecated(). > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: If5cf7d3dcda8dc411c6c90de31885dca683354d8 > Reviewed-on: https://chromium-review.googlesource.com/1130656 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574006} TBR: boliu Change-Id: I97a36101e145457d5ad9f99a4a0b83a55ab62f2d Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1133178Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#574179}
-
Michael Thiessen authored
Bug: 824487 Change-Id: I52782aed08ad8990585cccda751ddf42a61b9dbd Reviewed-on: https://chromium-review.googlesource.com/1128175Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#574178}
-
Shu Chen authored
Bug: 861875 Change-Id: Ie6d0976b1e71a637b12c330323b876bfcb95cc27 Reviewed-on: https://chromium-review.googlesource.com/1130572Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574177}
-
Mounir Lamouri authored
Bug: 862505 Change-Id: I1bcb2019be64dbb91081e1f8d607aca4cb0fbdc5 TBR: apacible@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1133306Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 7708 7710 7714 7718 7725 7731 7736 7737 7748 7753 7766 7768 7779 7787 7789 7795 7800 TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I761ca3f56c837bced01e481537c996cbe4c3ad7c Reviewed-on: https://chromium-review.googlesource.com/1129600 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#574175}
-
Shenghuai Ji authored
This CL only move only move some component build related targets into a condition check without changing the config in the targets. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I9d32580da7b156e803b804f0179766e23373f842 Reviewed-on: https://chromium-review.googlesource.com/1122145Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Shenghuai Ji <shenghuai@google.com> Cr-Commit-Position: refs/heads/master@{#574174}
-
Joshua Bell authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/e2fg_-Ha-AE/discussion Chrome Status Entry: https://www.chromestatus.com/feature/5712361335816192 Bug: 161072,862455 Change-Id: Ibdab33ae6dabe97b9f1fffeed413c09690e56bea Reviewed-on: https://chromium-review.googlesource.com/1132384Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#574173}
-
Aldo Culquicondor authored
This CL ensures that a backspace is threated as a user gesture, so that it causes the autofill popups to refresh. Bug: 839518 Change-Id: Iaca3206c5da2b7ab35271bbeeb85b77c6d27bc09 Reviewed-on: https://chromium-review.googlesource.com/1130104Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#574172}
-
