- 10 Apr, 2019 7 commits
-
-
Suman Kancherla authored
Added following tests covering - * indicators when their respective devices become in-use. Since this feature depends on hardware/system capability, all except location permission test have been commented by an '#if 0' * indicators displaying the permissions already granted. This is not dependent on hardware/system, and so, testable on any machine. A few permutations of {allow, block, ask} are applied to {microphone, camera, location} permissions Things to explore/add are - * to try and run the second category of tests on all possible permutations * add bluetooth, midi, usb and screen capture to the above mix * add tests involving external prompt, timeout spinner UI and indicators Bug: 908925 Change-Id: Ide7e03716d9992372991fc2c66354e8276189182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555356 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649332}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1424ef650142..f0aa9d5ab738 git log 1424ef650142..f0aa9d5ab738 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 sugoi@google.com Query implementation 2019-04-09 sugoi@google.com No border for compressed cube images Created with: gclient setdep -r src/third_party/swiftshader@f0aa9d5ab738 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4b3005ca4a8d861ecf163631cd9320232469d707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649331}
-
Sammie Quon authored
Test: manual Bug: 950730 Change-Id: Id278b7b77a48603e4451293710e7f376a323fab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559876Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#649330}
-
Justin DeWitt authored
Since the NoTouchActivity is a single tab activity, there might be media playing in it while the user is doing something else. Don't stop the media by navigating to the NTP if it is playing. Bug: 937429 Change-Id: I153d93056bb76ff1d8195d660c12c2c784a2ac9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558055Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#649329}
-
Adam Langley authored
Previously, FidoDevice::Cancel would cancel any and all requests outstanding, and could corrupt a multi-frame message that was in the process of being sent. This change fixes that and augments the API to allow specific requests to be canceled. This is important for resident keys because we want to ensure that resident creation requests are effectively canceled once moot. Bug: 941120 Change-Id: Ie219c89fcfebe5be61fa77fff40201f06c1b328d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554110Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#649328}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/825bcc75..59a29d88 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3adb56920964eaa8235c43a611b624aa977e7e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559361Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649327}
-
Collin Baker authored
This reverts commit c3e3793b. Reason for revert: Still causing test failures: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/32641?blamelist=1#blamelist-tab Original change's description: > Reland "Increase coverage for EULA browser tests" > > This is a reland of 426df2be > > Original change's description: > > Increase coverage for EULA browser tests > > > > Adds tests for: > > * Clicking on "System security settings" button in EULA screen > > * Accepting and rejecting usage stats collection > > * Clicking on "Learn more" button in EULA screen > > > > Removes dead code from EulaScreen class. > > > > Adds a HelpApp extension manifest to use in tests and modifies > > HelpAppLauncher class to allow tests to set the extension id. > > > > Adds a HelpAppTestHelper class to facilitate writing tests that > > open HelpApp dialogs. > > > > Change-Id: Id7841be5bf3faabb067d3a75d3b034bdf0e00e32 > > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/src/+/1554123 > > Commit-Queue: Tony De Luna <tonydeluna@chromium.org> > > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648759} > > TBR=hashimoto > > Bug: 947358 > Change-Id: I23865c1957f300f55812f3275e830772aa27c32d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560146 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Tony De Luna <tonydeluna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649258} TBR=hashimoto@chromium.org,tbarzic@chromium.org,alemate@chromium.org,tonydeluna@chromium.org Change-Id: Id84e11a36c78c355cac699a1d9a4c48c5863659d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560493Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649326}
-
- 09 Apr, 2019 33 commits
-
-
Collin Baker authored
This reverts commit c3314088. Reason for revert: speculative revert for WebGPUDecoderTest.Dummy failures - https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/41527 - https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/41528 Original change's description: > Enable use_dawn by default on Mac > > Mac is the first platform where WebGPU is implemented. Enabling use_dawn > there makes sure that dawn-related tests are run on the CQ, and allows > developers to use Mac Canary to test WebGPU. > > BUG=chromium:852089 > > Change-Id: Ic076afbe4d6d9efe97bee7bb56f0d375a35bec5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559319 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649264} TBR=ellyjones@chromium.org,kbr@chromium.org,cwallez@chromium.org Change-Id: I125e6f63941fdf0007b42da1673f641a7b32de5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560530Reviewed-by:
-
Lucas Tenório authored
The AppControllerService notifies the AppControllerClient of any app changes that might happen. These new tests cover which notifications are sent or filtered. It also covers cases where previous information used to inform the client is not available anymore, like Android package names. Bug: 927809 Change-Id: I0006a4cb898bb08894ad4388b9d95bfbd3983a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558793 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
Also: 1. Removed --qemy-require-kvm flag from the runner script since run_web_tests.py doesn't support that flag. Instead KVM requirement is handled by the runner script directly. 2. Disabled sharding when running layout tests on Fuchsia, including on FYI bots: it doesn't make much sense to shard these tests since we run only smoke tests and sharding overhead is comparable to the time it takes to run all tests on a single bot. Bug: 778467 Change-Id: Ice7a11ebf5c51c84550745e8e88cd71cd300b0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549585 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#649323}
-
Alexey Baskakov authored
Allow concurrent installs. WebAppInstallManager owns all install tasks. This CL introduces no behavior changes. Bug: 901226 Change-Id: Ib231faeb7b3749f3f68436ac01d872075c4e6cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556659Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#649322}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c75ce35aa1a7..44034bca7d3e git log c75ce35aa1a7..44034bca7d3e --date=short --no-merges --format='%ad %ae %s' 2019-04-09 tsepez@chromium.org Make CXFA_TraverseStrategy_ViewLayoutItem private to cxfa_layoutpagemgr.cpp. 2019-04-09 thestig@chromium.org Prevent out of bound access inside CXFA_LayoutPageMgr. 2019-04-09 tsepez@chromium.org Rename CXFA_ContainerLayoutItem to CXFA_ViewLayoutItem. 2019-04-09 thestig@chromium.org Switch from vector to deque for some CXFA_FFDocView members. 2019-04-08 tsepez@chromium.org Correct hierarchy description in xfa/fxfa/README.md Created with: gclient setdep -r src/third_party/pdfium@44034bca7d3e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:925787 TBR=dsinclair@chromium.org Change-Id: I2b1c7473324b228a52aff4aada9295baa0c10833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560393Reviewed-by:
-
Jun Mukai authored
The hosted_app_buttons should be invisible when the caption buttons (i.e. maximize/minimize/close buttons) are invisible. Bug: 951068 Test: browser_tests Change-Id: Ic944b6d90c3cda4397f38f34d5de86e2a26ca070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560314Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#649320}
-
Yue Zhang authored
Add ComponentCallbacks in TabListMediator to listen to orientation changes and change span count of GridLayoutManager accordingly. TODO: * Fix the problem of landscape Thumbnail showing incorrectly in portrait mode. * Dynamically set span count base on screen width, min width of cards and paddings. Bug: 945740 Change-Id: I961274492e35c097e6440caeaff78ae7cd7d83db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559238Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#649319}
-
Jeffrey Kardatzke authored
This removes the restriction for including bluetooth logs in feedback reports from nocturne/eve only. It is now enabled for all boards. Bug: 872403 Test: BT logs appear in feedback report from kevin Change-Id: Ifeee8e1dc9c86fe2f3a05a34f24da0824ae344de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560254 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649318}
-
Christian Fremerey authored
This is a reland of ca79d9d8 Reason for revert was a too strict expectation in a test case, which has been fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1559125 Original change's description: > [Tab Capture] Simplify reuse of already captured content > > Before this CL, class FrameSinkVideoCapturerImpl uses a somewhat > hard-to-follow protocol with InterprocessFramePool for resurrecting > video frames in case that the source content did not change. > > This CL changes this protocol to a simpler-to-follow mechanism, which > also can reduce the cases where content is re-captured even though > it is already available in a previously captured buffer. > > Change-Id: I635e3cf0dce61f704a6b613702791f03ff0c217a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479154 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648688} Change-Id: I07b3899b104eb78b039519791384f024bec30388 Bug: 951069 TBR=miu@chromium.org Change-Id: I07b3899b104eb78b039519791384f024bec30388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559333 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649317}
-
Kurt Horimoto authored
The previous TestBrowser constructor took a TabModel, which required tests that require a Browser to construct complicated OCMocks to construct the TestBrowser. This CL adds a second constructor that instead takes a WebStateList, and can be used to create TestBrowsers for objects that don't use the deprecated TabModel interface. Bug: none Change-Id: I306e536621f932f8d6b4ed22d3d149de2649fda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559766 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#649316}
-
Sébastien Séguin-Gagnon authored
Bug: 949612 Change-Id: Ibe0d0781df2398d7358ece7c657b29bbc7553c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555246 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649315}
-
Rohit Rao authored
This file is compiled as an EG2 test-side helper and removed from the eg_app_support+eg2 target. BUG=922813 Change-Id: Ia842d0c0feb9f662419a07e6d79761e71184e309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559383Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649314}
-
Ian Wells authored
Adds fetching and storing of favicons to the prefetching pipeline for Feed only. Also adds snippet and attribution columns to the INSERT query in AddPageTask as this was missed in the schema update CL. NOTRY=true Bug: 841516 Change-Id: I04d0e1468ae55c7739360c040490e934efca9dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534293 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#649313}
-
John Lee authored
and enable spellcheck for all languages when spellcheck is turned on Bug: 848536 Change-Id: I99f814b559fb591f85eda6012cca94d4a1c81635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559232 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#649312}
-
Collin Baker authored
TBR=nyquist@chromium.org Bug: 951141 Change-Id: Ia3352c9de1d8fc418a46076ffa08d41594a3bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559360Reviewed-by:
-
Shakti Sahu authored
After native AutoResumptionHandler is set into effect, we should be very careful that downloads long back from history shouldn't be resumed. In this CL, we are addressing that issue by setting the auto-resume count of history downloads to a max value. Change-Id: Iedb037da21c8a93e468f9c64fa1614fd0cf6c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559454 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649310}
-
Yann Dago authored
Add a search field to the toolbar that redirects to the settings page on each search. Bug: 948259 Change-Id: I5c81ef285fdb2f9042d5d1d843129589af428937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548137 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649309}
-
Victor Hugo Vianna Silva authored
We unite histograms that distinguish first-time/subsequent synchronization (Sync.ServiceInitialConfigureTime,Sync.ServiceSubsequentConfigureTime) and histograms that distinguish based on the configuration result status (Sync.ConfigureTime_Long.{OK,ABORTED,UNRECOVERABLE_ERROR}) into a single set of histograms. Bug: 169053 Change-Id: I757a86e50b907edf7ace2137d9a34a34f8495dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552827 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:Brian White <bcwhite@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#649308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de427f13cef6..6e6256a3131d Created with: gclient setdep -r src-internal@6e6256a3131d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Icad91c8ddfd6db199fbc5680827bc25aa7dbd4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560228Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649307}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d39e2c83b730..2af5dcbe9ec3 git log d39e2c83b730..2af5dcbe9ec3 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 benwright@webrtc.org Reland "Refactor FrameDecryptorInterface::Decrypt to use new API." Created with: gclient setdep -r src/third_party/webrtc@2af5dcbe9ec3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I91d39fbef69b5551602cdbb4c154a110fc1f8917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560392Reviewed-by:
-
Ian Prest authored
1. Added a new generated event (SUBTREE_CREATED) that is fired whenever a new node is added. 2. BrowserAccessibilityManagerWin now fires UIA structure-changed events in response to SUBTREE_CREATED (new) and CHILDREN_CHANGED (existing). 3. BrowserAccessibilityManagerWin overrides OnNode/SubtreeWillBeDeleted in order to fire "node-removed" events. -- We can't just have the event-generator add an event to its queue, because in that case the nodes have been deleted before the events get fired. -- Moved the MSAA implementation here, from UpdateStep3FireEvents; this will make it easier to move to the platform-nodes in the future. 4. UIA event-recorder now records & logs structure-changed events. -- And update existing unit-tests and event-tests were with new expectations. 5. Some events were being fired on IFRAMEs that hadn't yet been added to the tree, which would later result in crashes. -- ShouldFireEventForNode was updated to prevent this scenario. 6. We weren't checking the command-line flag prior to running some UIA specific code in response to the kEndOfTest event; fixed. Bug: 928949 Change-Id: I9f9b1bbeb522451d4c7b8046f21eb91cc8543d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539141 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649305}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/201b3752e642..ff4fb3335bb7 git log 201b3752e642..ff4fb3335bb7 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 ethannicholas@google.com ComposeShader GPU implementations 2019-04-09 jvanverth@google.com Add RG format to Metal 2019-04-09 mtklein@google.com extract ToolUtils::colortype_depth() Created with: gclient setdep -r src/third_party/skia@ff4fb3335bb7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I8b4085d87dda9ee23a975f301e2aef2387baac23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560391Reviewed-by:
-
Hongchan Choi authored
When AudioWorklet.addModule() activates the worklet thread, it re-starts the destination handler even when the context is suspended. This CL fixes the bug by restarting destination only when the context is in the "running" state. Bug: 950997 Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html Change-Id: I0b44e3fca23bd069fac21f709fc665e8eacc4dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560140 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#649303}
-
wutao authored
It is possible that assistant service is not available when searching in the Launcher. This patch adds the check before directing the search to Assistant. Bug: 950149 Test: manual Change-Id: I136d0a8852c49b91315724b16a51bcbdb5890047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559352 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649302}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I40e13e96ba23ccf901d9243cd2cfab29fbe01134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560441Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649301}
-
Lucas Tenório authored
This second batch of tests cover the LaunchHomeUrl method. One small change was made to the AppControllerService to make the tests simple: We no longer read the URL prefix during initialization, instead we do it on demand when trying to launch home URLs. This makes it easier to override the prefix when testing the same service instance. Bug: 927809 Change-Id: I5460b055f6d423cd196b3c5b4b06d723e6abfd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558411Reviewed-by:
-
Corentin Wallez authored
This implements SyncTokens for the WebGPU interface by sharing implementations with the raster and gles2 interfaces. All interfaces now inherit from the abstract InterfaceBase class. BUG=chromium:948613 Change-Id: I54cde299d465bdbd7ed9176761ce1a59d4fb3313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550829Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#649299}
-
Xing Liu authored
NotificationCompatBuilder.build() may throw exception on Android M and L. Possibly when there is no Android user profiles. We don't know the reliable way to reproduce this crash. This issue might be Android bug. This CL adds a try catch block on the crashed function. Also fixed a couple of places where we assume notification object is non-null. We also calls startForeground() with a notification object, currently all Android versions has try catch block inside Service.startForeground() and no Android check to assert notification is not null. Bug: 949794 Change-Id: I9df1aeee3cf0f13168b40bb610042681f9acb657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555053 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#649298}
-
Justin Cohen authored
In some cases, an transientContentView may be displayed when the CRWWebControllerContainerView has no window. When the CRWWebControllerContainerView is put back in a window and the main webViewContentView is restored, it will obscure the transientContentView. Instead, always keep the transientContentView on top. Bug: 949204 Change-Id: Ifa992620958ac3b7cfeb85d4451e2d13beee7810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559894 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Yuwei Huang authored
This CL implements FtlSignalingPlayground for testing JingleSessionManager::AcceptIncoming() and JingleSessionManager::Connect(). The test currently ends once the session is authenticated. This also changes some spammy VLOG(0) logs to VLOG(1) so that signaling messages are easier to read. Bug: 947337 Change-Id: I33c84c6e06a311ecdf58d3aad7ad6111bc52ef13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554480 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#649296}
-
Eugene But authored
The test is not failing if slim-nav is not enabled. Bug: 950263 Change-Id: I71e226e6bc04dff6fa02553aeb69b202d9601007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560370 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2d4c66d2b865..b4b3ea05ebde git log 2d4c66d2b865..b4b3ea05ebde --date=short --no-merges --format='%ad %ae %s' 2019-04-09 enga@chromium.org Reland "Rename texture.createTextureView to createView to match WebGPU" Created with: gclient setdep -r src/third_party/dawn@b4b3ea05ebde The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877147 TBR=cwallez@chromium.org Change-Id: I227c6a396e1a207f6f541c65efcf6735cc1a164d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560226Reviewed-by:
-
John Budorick authored
Bug: 950789 Change-Id: I7af3cd1abf47022f1d95b1b3b66a13bb9984b706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559461Reviewed-by:
-
