GitLab

ash: Make sure the focus-border in the tray paints correctly, and tray-view should not be focusable.

BUG=137757
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10815082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148337 0039d316-1c4b-4281-b951-d872f2087c98

In case the window is already maximized/fullscreen, then restore the
window first before snapping.

BUG=138874
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10820005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132423
TEST=Manual, encoded video can be looped


Review URL: https://chromiumcodereview.appspot.com/10823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136949
TEST=Manual, see instructions below

Run chrome with --force-device-scale-factor=2 --highlight-missing-2x-resources
Ensure that the file type icon in the download bar shows up red

Review URL: https://chromiumcodereview.appspot.com/10703173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148334 0039d316-1c4b-4281-b951-d872f2087c98

No code change.

TBR=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10829010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148333 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148332 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TEST=none
TBR=mark@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10820012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10832007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148329 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TEST=none
TBR=mark@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137139, 137137, 137136
TEST=See issues. Ensure web notifications look and appear properly.
For ash grd change:
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10815075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148326 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org
BUG=124445
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10825008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148325 0039d316-1c4b-4281-b951-d872f2087c98

TEST=views_unittests
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10790115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148324 0039d316-1c4b-4281-b951-d872f2087c98

No code change.

TBR=cmp@chromium.org


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121420
TEST=Make a change to the browser action command on Chrome on GTK. Make sure it takes effect immediately.
Review URL: https://chromiumcodereview.appspot.com/10690042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148322 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jchaffraix@chromium.org
BUG=77766
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10828010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148321 0039d316-1c4b-4281-b951-d872f2087c98

All these targets have come online for iOS, and build successfully.

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10832006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148320 0039d316-1c4b-4281-b951-d872f2087c98

Similar to http://crrev.com/148150, but only triggers when uploading.

TBR=aa@chromium.org
BUG=111465,92466
TEST=Uploading CLs that update the extensions docs don't trigger the warning anymore


Review URL: https://chromiumcodereview.appspot.com/10830007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148319 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach@chromium.org
BUG=97818
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10827006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148318 0039d316-1c4b-4281-b951-d872f2087c98

R=erg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10818027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138866
TEST=see bug

Review URL: https://chromiumcodereview.appspot.com/10805055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148316 0039d316-1c4b-4281-b951-d872f2087c98

vector does not have a virtual destructor, see Item 7 from of Effective STL from
Scott Meyers for a detailed explanation.

BUG=135335
R=markusheintz@chromium.org,willchan@chromium.org
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10796081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138930

TEST=content_unittests


Review URL: https://chromiumcodereview.appspot.com/10826007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148313 0039d316-1c4b-4281-b951-d872f2087c98

These tests are suppressed downstream, syncing those suppressions
upstream.

BUG=138933
TEST=ui_unittests


Review URL: https://chromiumcodereview.appspot.com/10834003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148310 0039d316-1c4b-4281-b951-d872f2087c98

Now it monitors mouse/touch/gesture events and hides the tooltip if necessary.
Previous CL (crrev.com/148079) was reverted since it causes use-after-free error.
It happens when the 'LauncherTooltipBubble' widget exists but LauncherTooltipManager
is already released.  In that case, the widget's release will cause WindowClosing()
which calls host_->OnBubbleClosed(), but host_ is already released.
Thus I'd make sure to introduce a method to set host_ to NULL in case that
LauncherTooltipManager explicitly clean-up the Bubble.

R=derat@chromium.org
BUG=137678
TEST=manually checked on linux, aura_shell_unittests passed with asan


Review URL: https://chromiumcodereview.appspot.com/10808102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148308 0039d316-1c4b-4281-b951-d872f2087c98

r147862 added dependencies on CoreText and CoreGraphics to foundation_utils,
so those frameworks now need to be linked on iOS.

TBR=
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10821009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138228
TEST=


Review URL: https://chromiumcodereview.appspot.com/10807089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148304 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148303 0039d316-1c4b-4281-b951-d872f2087c98

Remove code for histograms which aren't yielding additional useful
info.  Cleanup naming slightly.

BUG=71832
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10802098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148301 0039d316-1c4b-4281-b951-d872f2087c98

 We probably want to change this for window dragging and/or drag&drop.

BUG=123160
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10826005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148300 0039d316-1c4b-4281-b951-d872f2087c98

Intending to use this to track down suspected memory corruption.

BUG=71832
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10818042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148299 0039d316-1c4b-4281-b951-d872f2087c98

Added debug only shortcut to activate screen locker.

BUG=123160
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10800095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148297 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=138857

R=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10820008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148296 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mihaip@chromium.org,rsesek@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10820010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138873
TEST=ash_unittests:BaseLayoutManagerTest.BoundsAfterRestoringToMaximizeFromMinimize

Review URL: https://chromiumcodereview.appspot.com/10821008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148294 0039d316-1c4b-4281-b951-d872f2087c98

It turned out these shortcuts were accidentally added to the global shortcuts.
This CL reverts the part of adding keyboard shortcuts in the CL below.
http://src.chromium.org/viewvc/chrome?view=rev&revision=147127

TBR=xiyuan@chromium.org
BUG=137708
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10809088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148293 0039d316-1c4b-4281-b951-d872f2087c98

first, we don't create file on disk when it is selected anymore (since we can't really know exact file path for drive files), we just setup permissions for the file.

second, we have to give read permissions for drive cache paths as well in order to enable file reading. 

TEST=existing
BUG=138089

Review URL: https://chromiumcodereview.appspot.com/10664002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148292 0039d316-1c4b-4281-b951-d872f2087c98

(Separated from a bigger patch: https://chromiumcodereview.appspot.com/10810053)

BUG=138022
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/10817006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148291 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=92148

Also, while I'm here, don't include the webkit .cur files on
platforms other than windows.

BUG=137588
TEST=Cursors show up fine in component builds.

Review URL: https://chromiumcodereview.appspot.com/10817031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148290 0039d316-1c4b-4281-b951-d872f2087c98

The details was a boolean indicating whether this is the last browser window closing. As part of this change the logic for saving pinned tabs has been changed to not use the boolean in the details, and has been updated to handle the case where a user exit or closing of the last window is cancelled by an onbeforeunload event.

Also as part of this change, both the pinned tab and multi profile features have been updated to handle cases of the browser process not being closed due to background mode or (in the future) packaged apps, and then more browser windows being opened.

BUG=None
TEST=Test shutdown 


Review URL: https://chromiumcodereview.appspot.com/10800031

TBR=benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148289 0039d316-1c4b-4281-b951-d872f2087c98