GitLab

This reverts commit 742a867b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Fix Toolbar content for Focus Mode Window
> 
> Toolbar is not showing correct content for Focus Mode Window when the
> site is not secure. This cl resolve this issue by processing an UI
> update after tab inserted to browser.
> 
> Change-Id: I35c4baf20ba6c90c85a03f471c51356853e8f165
> 
> Bug: 961820
> Change-Id: I35c4baf20ba6c90c85a03f471c51356853e8f165
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603768
> Commit-Queue: Yining Wang <yiningwang@google.com>
> Reviewed-by: Dana Fried <dfried@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#658820}

TBR=avi@chromium.org,dfried@chromium.org,yiningwang@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 964900
Change-Id: I92344a883c4497830268b9e7dce2ebf605075560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656031
Commit-Queue: Yining Wang <yiningwang@google.com>
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668493}

Each use of native module functionality needs to be conditional on both
the feature it pertains to, and the global switch that turns native code
modules on and off.

TBR'ing agrieve - trivial change to not-yet-enabled code.

TBR=agrieve@chromium.org

Bug: 874590
Change-Id: I0743af75e1534fb4c0771623b9082d1c6feb54b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654520
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668492}

Bug: 891908
Change-Id: I2107c9975d3605a4937d4e6946d8ea716fab2789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652391
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668491}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b2fc666bf9c..7d984193c8c4


Created with:
  gclient setdep -r src-internal@7d984193c8c4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=haraken@google.com,tangltom@google.com,flackr@google.com

Change-Id: I660224da904d51cb3f29c707def2e8b0dc17f318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656013Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668490}

- Increase touch target size of the checkbox. Making the sizing of the
check box to use proportional dimensions.
- Fix bug where the opt in text doesn't respond to default font size
changes. The flex box wrapper causes this problem, switching to grid
layout fixes this.

Bug: 968171,968189
Change-Id: I45d4ca0cf9ebfe441817bb820d29d7fa11e9c359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655868Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668489}

The User Timing L3 specification requires TypeErrors to be thrown when
calls to `performance.measure()` are malformed. The User Timing L2
specification used SyntaxErrors for similar error conditions.

This CL changes our use of SyntaxError to TypeError when L3 conformance
is active.

Bug: 953960
Change-Id: I87bb0717687f4a3b149eaeb6fc190fa9a98d1f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647342Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Auto-Submit: Tom McKee <tommckee@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668488}

Bug: 967793
Change-Id: Ic6585b524e6e3d20c415619a2e811b8d03af0d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650083Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668487}

https://skia.googlesource.com/skia.git/+log/d62d406aa24c..072e6fc374db


git log d62d406aa24c..072e6fc374db --date=short --no-merges --format='%ad %ae %s'
2019-06-12 brianosman@google.com Remove version string from Viewer's "highlight" SkSL shader
2019-06-12 mtklein@google.com remove moot comment
2019-06-12 nifong@google.com Minor optimization to serialization of SkPictures with many subpictures.


Created with:
  gclient setdep -r src/third_party/skia@072e6fc374db

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@google.com

Change-Id: Icbdd8cad3e937dd8b4373612a8989dbeacb2dee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656012Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668486}

This test does a navigation to an extension URL as part of test setup,
but does not wait for the navigation to finish before attempting to
download a filesystem URL for that extension.  This results in a race
between granting proper privileges to the extension process and the
download request checking for those privileges.  See bug for more
details.  The fix is to wait for the initial navigation to the
extension URL to commit.

Bug: 973271
Change-Id: Icada285b20e9ec3efefc1a39cc65481070f83352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654430
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668485}

Bug: 969810
Change-Id: I48acc58094ca38cc251cbeee83603ba1ecfad52f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650537
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668484}

A few years ago, we added ios-device to the try jobs run on clang rolls,
in #493848.

At some point, that bot disappeared, and after the luci switch non-existent
bots on a try invocation are apparently ignored silently. So we never noticed
that this bot stopped doing anything, but we _did_ notice clang rolls breaking
iOS device builds more frequently.

Remove the defunct ios-device bot and add the new and (for now) funct
iphone-device and ipad-device bots, which will hopefully catch iOS device
issues caused by clang rolls before the rolls land.

Bug: 754829,967387
Change-Id: I5cf9ff2bbb9458c547e1a0427fcc31ff788a3759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652541
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668483}

This is a reland of this change, with a fix for symbol_level=0:
https://chromium-review.googlesource.com/c/chromium/src/+/1589457

To do so, this CL also adds support for the x86 toolchain in an x64
build.

Instead of generating one DLL, we now generate 2 DLLs in the root
out-dir:

- browser_switcher_bho.dll (x86)
- browser_switcher_bho_64.dll (x64)

The one that is cross-built (i.e. bitness doesn't match the host) is
built in a sub-directory, and then copied to the root out-dir.

Bug: 952897
Change-Id: Ie18544fb97ba3091bc8113932e634c539d6d7502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653660Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668482}

exec file name might be the same when test method is the same but for different classes, in this case existing exec file will be replaced when new file pulled out with the same name.

exec file will not be generated on device when coverage_directory wasn't created before, error like below:
W  205.072s run_tests_on_device(ZX1G22LL36)  Failed to handle coverage data after tests: (device: ZX1G22LL36) adb pull /sdcard/chrome/test/coverage /usr/local/google/code/clankium/src/out/Coverage/coverage: failed with exit status 1 and output:
- adb: error: remote object '/sdcard/chrome/test/coverage' does not exist


Bug: 961808
Change-Id: Iaa0a59881ad7af1f9d0cda4d3544561e425485c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654049
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668481}

*.xml must be excluded from the grit generated source_set.  This is necessary
because gn would otherwise error-out because adding a binary file (anything
that's not .cpp, .h, etc.) to a source set (like .xml) is a no-op.  No effect on
generated build files.

The process_version gn template generates data files from template files
(eg. myfile.h.in -> myfile.h).  The gn template automatically adds a source_set
with the generated files in it, but it may be useless if only binary files were
generated, and in fact gn will now error-out if any binary files are added.
Adding "process_only=true" disables creation of the source_set, so we add this
in cases where the output files are all binary files.

BUG=964411
R=sky

Change-Id: I0c170564c89d52168da1facbe9dfde408b21374c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652569Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668480}

If we fail to initialize the GLSurface associated with an ANativeWindow
the error is propagated to the browser so we can retry with a new
window. Add tracking to detect consecutive failures with this retry
to avoid a perpetual retry loop.

R=boliu@chromium.org, ericrk@chromium.org

Bug: 972667
Change-Id: Ieaf0a7c7454f12ffbfa068e7c17c452857776ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654233
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668479}

Reland: Returns optional values from any AXNode related API that might fail and drops the use of int32_t from countable arguments

The only difference from the previous patch that got reverted is a change to how table row and column indices get reported in accessibility dump tree tests on Linux.
In the reland, row and column indices are reported as -1 when the accessibility object is not a legal table cell, as per the Linux ATK documentation.

1. Certain APIs exposed by AXPlatformNodeDelegate, AXPlatformNode and automation might fail.
For example, asking for the number of rows when not inside a table object, or asking for the PosInSet of an object that is not part of a set.
2. Certain APIs do not conform to our C++ Style Guide by exposing int32_t arguments and thereby
infect the whole codebase that uses them.

This patch uses base::Optional as the return type of any API that might fail and
removes the use of int32_t from any API arguments that refer to something countable, e.g. a row_index or a set_size.
Intentionally, we don't remove the use of int32_t for representing AXNode IDs, because
node IDs should be treated as an opaque data type and no numeric calculations should be performed on them.

This patch has uncovered some bugs in the IAccessible2 table implementation, which have been fixed.
Specifically, if a row or column argument is out of range, E_INVALIDARG should be returned from get_columnExtents, get_rowExtents, get_rowDescription and get_columnDescription, instead of S_FALSE.
Also, get_rowDescription and get_columnDescription should return the header cell if called on a header cell.

R=dtseng@chromium.org, aleventhal@chromium.org

Bug: 953443
Change-Id: Iab56ab2ae92bda6aff445f84b57ff1a7371d3c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655673
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668478}

This reverts commit 0ba83000.

This was the wrong fix, which caused another bug. The correct fix has
been landed and merged:
https://chromium-review.googlesource.com/c/chromium/src/+/1647138

Original change's description:
> overview: Fix minimized window not showing correctly in overview.
> 
> Test: manual
> Bug: 966682
> Change-Id: I9671e9922c9b300806afa8feb9e10cf4ba53f763
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628968
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#663250}

TBR=xdai@chromium.org,sammiequon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 966682, 973070
Change-Id: Iee06da25c4f0bebf7e0c94459aecf1530444cdaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653412Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668477}

R=etiennep@chromium.org

Bug: 965717
Change-Id: Ie7185cd0afc819d612368c6ce168a1544b2a64af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654271
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668476}

CreateExtraView() is called only once and should return
the requested views as std::unique_ptr<View>.
This makes ownership of the view more clear as it is moved around.

Bug: 961660
Change-Id: I1bec9bf29b3326320f51a386d330bd837bedfa0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645715
Commit-Queue: Yeol Park <peary2@gmail.com>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668475}

This Cl allows the tab title to be automatically updated based on user language selection.

Complete revert button in advanced view to reset language to default.

Bug: 963148
Change-Id: I69dfecbee8818bb7e130e293227b382ad592bf83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653575Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Alexandre Frechette <frechette@chromium.org>
Commit-Queue: Haohao Wang <hhw@google.com>
Cr-Commit-Position: refs/heads/master@{#668474}

No changes to generated ninja files, except that chrome_exe_version_manifest now
does not generate an empty source_set.

chrome/app/version_assembly/BUILD.gn:
  The process_version gn template generates data files from template files
  (eg. myfile.h.in -> myfile.h).  The gn template automatically adds a
  source_set with the generated files in it, but it may be useless if only
  binary files were generated, and in fact gn will now error-out if any binary
  files are added.  Adding "process_only=true" disables creation of the
  source_set, so we add this in cases where the output files are all binary
  files.

chrome/credential_provider/gaiacp/BUILD.gn:
gcapi_dll_version.rc.version already listed in inputs in [1].

chrome/installer/mini_installer/BUILD.gn:
chrome.release already listed in inputs in [2].

chrome/installer/setup/BUILD.gn:
setup_exe_version.rc.version is already listed as the template_file of a
process_version_rc_template in [3].

chrome/test/BUILD.gn:
  chrome_version.rc.version is already listed as the _template_file in
  process_version_rc_template as appropriate in [4].  Likely odd code left over
  from gyp->gn conversion.

  *.cur: Implicitly added by grit rule for ui_unscaled_resources.grd in [5].

NOPRESUBMIT necessary to avoid header checks for com_imported_mstscax.h

[1] https://cs.chromium.org/chromium/src/chrome/credential_provider/gaiacp/BUILD.gn?q=gaia_credential_provider.rgs&sq=package:chromium&g=0&l=189
[2] https://cs.chromium.org/chromium/src/chrome/installer/mini_installer/BUILD.gn?rcl=56a647b2510baf3b314fab1130dbe08c191c9072&l=140
[3] https://cs.chromium.org/chromium/src/chrome/installer/setup/BUILD.gn?type=cs&q=setup_exe_version.rc.version+file:%5C.gn&sq=package:chromium&g=0&l=120
[4] https://cs.chromium.org/chromium/src/chrome/process_version_rc_template.gni?type=cs&q=chrome_version.rc.version+file:%5C.gn&sq=package:chromium&g=0&l=45
[5] https://cs.chromium.org/chromium/src/ui/resources/ui_unscaled_resources.grd?type=cs&q=aliasb.cur&sq=package:chromium&g=0&l=12

BUG=964411
NOPRESUBMIT=true

Change-Id: I74549063376162091d7422c3769c1c3cb2ae4e67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652512Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668473}

This reverts commit f2d80002.

Reason for revert: crbug.com/972554

Original change's description:
> [System Web Apps] Enable System Web Apps by default.
> 
> This CL enables the System Web App Manager by default, which will install
> Settings as a System Web App, and make Discover and OS Settings use
> System Web Apps if their respective flags are enabled.
> 
> The fallout from enabling this is that all tests that are interested in
> the Settings Window on ChromeOS must call InstallSystemWebAppsForTesting.
> 
> Bug: 948298, 836128
> Change-Id: Ia5e4aab86665c968f181601a61a6722b15d77dd2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556816
> Reviewed-by: Alexey Baskakov <loyso@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: calamity <calamity@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666582}

TBR=ellyjones@chromium.org,jamescook@chromium.org,calamity@chromium.org,loyso@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 948298, 836128
Change-Id: If78158a09f52bf7033a35e9bcdea222efff0e8a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655710Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668472}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/889ec0706417..53cfcd3219c1


git log 889ec0706417..53cfcd3219c1 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 dburger@chromium.org Add moblab-generic-vm-postsubmit to list of ignoreds for skew check.


Created with:
  gclient setdep -r src/third_party/chromite@53cfcd3219c1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I344c6ef63e8795a98347fd9e3f1a652e8a40b278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655973Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668471}

Fix a bug that with "new popup ui" flag but without the DSE favicons
flag, the omnibox loads a favicon if it's available. It should fall
back to the search loupe icon.

Bug: 973366
Change-Id: Id27dcb737f161c1047d8bebd2e1a6baf2abe87de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655473
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#668470}

https://webrtc.googlesource.com/src.git/+log/e794243650a0..08fa95371129


git log e794243650a0..08fa95371129 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 danilchap@webrtc.org Reland "Delete TestAudioDeviceModule factory which uses GlobalTaskQueueFactory"
2019-06-12 ssilkin@webrtc.org Create rate allocator after codec bitrates are set.
2019-06-12 sprang@webrtc.org Add new RtpPacketPacer interface, with callback.


Created with:
  gclient setdep -r src/third_party/webrtc@08fa95371129

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I78811a022c490a6d48f5e02fca867dd10bec7fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654978Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668469}

The img tag for the regulatory info contains role="presentation" which
makes the screen reader skip the alt tag. This tag was originally added
because the a11y tests were failing
(https://chromium-review.googlesource.com/c/chromium/src/+/1345127).

The original issue of test failures was actually because regulatory
info is asynchronously filled in, so when the page is loaded,
regulatoryInfo_.text which is used as the alt tag is empty. This makes
the a11y tests fail since it expects a non empty string as the value.

This change fixes the tests by setting the regulatory info text through
the fake browser proxy, and removes the role="presentation" tag since
it's not needed anymore to make the tests pass.

BUG=950842

Change-Id: I136456fab06c15b9d13f0d7827f251062d242c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653085Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: May Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668468}

This will make sure everything underneath is completely occluded, so
nothing gets drawn.

Test: manual
Bug: 961549
Change-Id: I5124f8ffcee607964b8460f7214d962092a2e697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642370Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668467}

This reverts commit ecb3164a.

Reason for revert: Accidental no-try submission of the original revert! Reverting to be safe.

Original change's description:
> Revert "Use AddLocalizedStringsBulk() on version_ui to reduce code size."
> 
> This reverts commit 7d8834bd.
> 
> Reason for revert: Crash in ui::ReplaceTemplateExpressions (crbug.com/972995)
> 
> Original change's description:
> > Use AddLocalizedStringsBulk() on version_ui to reduce code size.
> > 
> > Refactored to use AddLocalizedStringsBulk() instead of
> > source->AddLocalizedString() to reduce code size and separated
> > data strings from localized strings.
> > Follow up of changes https://crrev.com/c/1591712 and
> > https://crrev.com/c/1628757
> > 
> > Bug: 957201
> > Change-Id: I9f9e01468ac8eedfbaf035b03f9bacbd7e4efcf2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630467
> > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#667625}
> 
> TBR=droger@chromium.org,thestig@chromium.org,michaelpg@chromium.org
> 
> Change-Id: I7cfd452ad6176d657cfddfe1de78585e6c98a33b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 957201,972995
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653313
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668465}

TBR=droger@chromium.org,thestig@chromium.org,michaelpg@chromium.org,henrique.ramos.limas@gmail.com

Change-Id: Iebf60be5f684a8576dfbada96005b9184956fe42
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 957201, 972995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656030Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668466}

This reverts commit 7d8834bd.

Reason for revert: Crash in ui::ReplaceTemplateExpressions (crbug.com/972995)

Original change's description:
> Use AddLocalizedStringsBulk() on version_ui to reduce code size.
> 
> Refactored to use AddLocalizedStringsBulk() instead of
> source->AddLocalizedString() to reduce code size and separated
> data strings from localized strings.
> Follow up of changes https://crrev.com/c/1591712 and
> https://crrev.com/c/1628757
> 
> Bug: 957201
> Change-Id: I9f9e01468ac8eedfbaf035b03f9bacbd7e4efcf2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630467
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#667625}

TBR=droger@chromium.org,thestig@chromium.org,michaelpg@chromium.org

Change-Id: I7cfd452ad6176d657cfddfe1de78585e6c98a33b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 957201,972995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653313Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668465}

- Over 46kB of resources not used on Android
- webui/favicon_source previously compiled but never used
- Remove webui/favicon_source from Android builds

TBR: trivial unit test change
Bug: 799078
Change-Id: I91a99f893d2f9503f5baaeaf199d51d475241916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651114
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668464}

This reverts commit 98846b50.

Reason for revert: Appears to have broken android-cronet-asan-arm-rel.

Original change's description:
> Update asan_device_setup.sh to r351636.
> 
> Improves support for running 32-bit binaries on the N5Xs, at least.
> 
> Bug: 790202
> Change-Id: I2a870d3b5a1e88992d8908358e21f159d1740fce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648665
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#667692}

TBR=martiniss@chromium.org,rspier@google.com,bpastene@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 790202
Change-Id: I9bc4e05b818ec56b0255d3debfbb5c666958ee4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655989Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668463}

This CL is adding code to detect when GDI Handles (HFONT)
are going to high because too many gfx::Font exists.

There is a plan to fix the incorrect uses of gfx::Font
and these dump will help tracking the source of these leaks.

Bug: 972689
Change-Id: I326938c3751766e01b3c318b5397ef8f4d4f9ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648398Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668462}

Bug: 970224

Change-Id: I4a12a8fd723399db7d12b62f33f62d7ec25c3ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654688Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668461}

It has launched to M75:
https://chromiumdash.appspot.com/commit/31293e8ee41e25575ff9fafdaac23554851c9fcf

Bug: 906494

Change-Id: I26ac098f53cf57267990429d6b1fa9d2a7ed9f6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653418Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668460}

This is already enabled on Chrome for Android. This CL also enables
it on WebView.

Changes:
- Check IsPerOriginProvisioningSupported() instead of checking persistent
  license support in both MediaDrmBridgeFactory and MediaDrmBridge.
- Register cdm::MediaDrmStorageImpl in WebView's PrefService (provided by
  AwBrowserContext). Also mark it to be persistent across runs in
  kPersistentPrefsWhitelist. Persistence is preferred here to avoid
  having to provisioning MediaDrm frequently.
- Hook up CreateMediaDrmStorage() for WebView, using the PrefService
  provided by AwBrowserContext. Note that the returned origin IDs are
  not provisioned. MediaDrmBridge in the GPU process will trigger the
  provisioning process.
- Add logs.

Tested with Shaka player demo and made sure per-origin provisioning is
used. Test log is at go/eme-webview-test-log.

Bug: 493521,947286
Test: See above.
Change-Id: Ie260b917571f37712ff223030567709b8f97bf31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588518
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668459}

The recorder is created in constructor, so only scenario that I can
think of is that resizer is destroyed during SetBounds.

I also added CHECK to catch the scenario where the resizer is destroyed
during resize for other reasons. I'll remove the code once fix is confirmed.

Bug: 970911
Test: None. Repro step is unknown and this is speculative fix.
Change-Id: I58e20fe916664867b776d36b7720a2a2fb5ee357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655968Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668458}

The reordering gesture must be canceled when closing all tabs in the
tab switcher.

Bug: 961045
Change-Id: I595761b90e9bf896668922c36a9933446b846c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654409Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668457}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/602da62c..ece78714

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8435a21b7bf1d56a62d6a02a4cf3bdc5930a8d08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655037Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668456}

This CL makes SkiaOutputSurfaceImpl use Skia's YUV readback API instead
of doing an RGB readback and a conversion afterwards. This CL also adds
a feature to always use Skia's API for readback instead of
GLRendererCopier, which is useful for testing Skia's GL readback and
doing finch trials later on.

Bug: 898595
Change-Id: I493edc8f2a406f0b015b1dfa580d41c97a088f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643501
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668455}

The exit_on_context_loss GPU driver bug workaround shouldn't be applied
when the GPU process is already exiting since it can trigger a
use-after-free.

Bug: 971904
Change-Id: I775c9fd29b1f9bdb71c28f0cb428951718001973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655340
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668454}