- 28 Jun, 2019 40 commits
-
-
Tanmoy Mollik authored
Enable UnifiedConsent for ArticleSnippetsTest and update goldens for personalized sign-in promos. Bug: 936986 Change-Id: Ia058e6c2a18a5c49c13b019522ecc09067df5082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679754Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#673352}
-
Maksim Moskvitin authored
NigoriSyncBridge now respects custom_passphrase_derivation_method and custom_passphrase_scrypt_salt fields and supports decryption with keys derived using SCRYPT method. If the remote update contains an unsupported key derivation method (or SCRYPT, while kSyncForceDisableScryptForCustomPassphrase is enabled), the bridge reports ModelError (which means sync becomes inactive). This CL doesn't support migration, which fills custom_passphrase_derivation_method for old CUSTOM_PASSPHRASE users, but fills it if user just enabled CUSTOM_PASSPHRASE. The complete migration code will be added in follow-up CLs. Bug: 922900 Change-Id: I87bacd54d8b22b9f53868161e1196398bb966661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676710 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#673351}
-
Philip Rogers authored
Bug: 979389, 979380, 979367 Change-Id: I69039de5179152c3ab4a021243f50ebad3050401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682008Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#673350}
-
David Bokan authored
The fallback cursor determines scroll modes based on the location within the current scroller. The location and size of the scroller are compared in root frame coordinates (i.e. the page's coordinate system). However, for the root scroller, we need to account for zooming. When the page is zoomed, the scroller's (visual viewport's) bounds shrink within the root frame. This means we need to convert the root-frame-relative point into the visual viewport so that we're computing locking relative to the visual viewport. Bug: 978214 Change-Id: Ib995aa9171ae818dd43a5b6208dd061ec6892eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681271Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#673349}
-
Peter Kasting authored
To avoid decreasing the supported platforms from today, this expands enable_hidpi from Linux (incl. CrOS)/Mac/Win to also include iOS. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1670357 , which was reverted since a direct dependency on ui_features.gni breaks external projects. Bug: 564112 Change-Id: I2426ccae4eaf300a1fe8df77bccb3ec2e932ee01 TBR: rohitrao, sadrul Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681302 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#673348}
-
Scott Violet authored
GetStateForTabSwitch() was previously called before the active WebContents changed. It's now called *after* the WebContents has changed. As GetStateForTabSwitch() may access the WebContents to determine state, this change broke some behavior. To fix it, this patch avoids querying for state from the WebContents, and instead handles the one case this cared about after the switch. BUG=923290 TEST=covered by test Change-Id: Ia8e4ccdeb5c90577783630c271909b5e633ca4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670151Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#673347}
-
Ella Ge authored
TBR=nhiroki@chromium.org No-Try: true Bug: 979593 Change-Id: I24b412334c6fe64338bc2e0e3b467c0e8d5f12cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681874Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#673346}
-
Mathias Carlen authored
This patch introduces a new action to display message popups (bubbles) in the bottom sheet anchored at the icon. R=arbesser@google.com Bug: b/132863319 Change-Id: I51d2d885937e6e50e8273217c481b606be7a91d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681771 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#673345}
-
David Bertoni authored
Extensions may register service workers at multiple scopes, but only the script specified in the manifest's background data is given bindings. Bug: 961836 Change-Id: I03ab866842e00c198f2a6f0b2d150ed671302a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606188Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#673344}
-
Andy Paicu authored
This allows flash to be used in incognito as well if the user chooses to. Bug: 974721 Change-Id: Ibbc825df65b2a0a6b48944cad2bad82cc733eb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681762 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#673343}
-
Charlene Yan authored
This will be used for TabGroups interactive tests since they will have varying number of tabs. Change-Id: I1de27a149cd9f94c04701ddf0e2f7392d87c2bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680654Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#673342}
-
Xiaocheng Hu authored
Current code uses weakly-typed CalcOperator enum for arithmetic operators, and casts them between chars interchangeably. This makes it hard to read, and prevents extending the operators with more math functions. Hence, this patch changes CalcOperator to a strongly-typed enum, stops all the direct casting between chars, and renames it to CSSMathOperator as a preparation to add new math functions. Bug: 825895 Change-Id: Ie2ea58163f800cf5f480ac34a9c49a3e677e1946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680294Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#673341}
-
Steven Bennetts authored
I missed migrating a couple of CrPolicyNetworkBehavior calls from html in https://chromium-review.googlesource.com/c/chromium/src/+/1669093. The symptom was the policy indicator missing from the list of wifi networks (now fixed). Bug: 853953 Change-Id: Ie6e786bb22cebd7033c3fdfdb794721853520392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680998Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673340}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/825aad13dcf4..a47ba4119f27 git log 825aad13dcf4..a47ba4119f27 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 eladalon@webrtc.org Get rid of deprecated version of NackSender::SendNack [1/2] 2019-06-28 asapersson@webrtc.org RateControlSettings: add option to set min pixels per frame for libvpx vp8. 2019-06-28 alessiob@webrtc.org NetEQ: BackgroundNoise::Update returns true when the filter is updated Created with: gclient setdep -r src/third_party/webrtc@a47ba4119f27 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4149b09597f6613f38c83e732c0360d701a2d0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673339}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30c1bb6efcde..923582ce437a Created with: gclient setdep -r src-internal@923582ce437a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: Ib2761db346ac44d170d2b6de19b77fc7de2d3a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673338}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/40495290dceb..74561df3e679 git log 40495290dceb..74561df3e679 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 swiftshader.regress@gmail.com Regres: Update test lists @ 40495290 Created with: gclient setdep -r src/third_party/swiftshader@74561df3e679 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I1c61b70a30f97e1696613aa841a641274f48cd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681987Reviewed-by:
-
Henrique Nakashima authored
savePageLater() was moved from OfflinePageBridge to RequestCoordinatorBridge. Migrate the deprecated call so it can be deleted from RequestCoordinatorBridge. This CL is the chromium part of step 2 in refactoring RequestCoordinatorBridge out of OfflinePageBridge. Bug: 978871,959957 Change-Id: I55c920de7fccf70b01b963e308559ac24e5c1cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678289Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#673336}
-
Mehran Mahmoudi authored
This fixes an issue in Protected Media settings that happens on small screens when using keyboard input. It prevents focusing the TriStateSiteSettingsPreference items using directional keys. Bug: 974413 Change-Id: I8c432774ba92dc9a2419ccdbd57946e69c11db9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680832Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#673335}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Icf5ca321de51256ceef45900548f36bc29fd7205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660387 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#673334}
-
Luke Zielinski authored
Bug: 937369 Change-Id: Iccfe46ee026e77dd826f6b132cf3e72fd0500246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680604 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#673333}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6580f3fa. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." bc7ec548 "MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ibf7b692f6268f0d8e10d22bec49b02b2ffb1f0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680694Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673332}
-
Hitoshi Yoshida authored
In compiling Web IDL, we want to modify AST-based definitions. IRs are internal representations for IDL definitions to manage in IDL compilation. This CL defines skeltons of IRs, and they will be implemented in follow-up CLs. Bug: 839389 Change-Id: I614901109c4aec9c42a8986b919d6b7184ef309e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681446 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#673331}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f5a4989c..5d13106e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic61d58161495aef0af7fcdb75e8e5d6dc41f64c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681421Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673330}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f51c389d79a4..6d47875c4c50 git log f51c389d79a4..6d47875c4c50 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 taylori@google.com systrace: Update traceconv version Created with: gclient setdep -r src/third_party/catapult@6d47875c4c50 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Change-Id: Ic10575628169ac2b5c58cafc0f1e43f0733c42ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681364Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iea4dbe7cce88e05a8f066a9c65c4c49be508f579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681365Reviewed-by:
-
Xianzhu Wang authored
Bug: 524134, 931486, 923429, 962191, 979369 Change-Id: Ibc32e3816b23cc18acd54952469b5c88b989c2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680512 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#673327}
-
Bryan McQuade authored
We return early in cases where an element doesn't move in its parent's coordinate space, however it's possible that an element moves within the parent space but stays in the same position within the viewport. To address this, we check to see if the element moved in viewport space, as well. Bug: 976920 Change-Id: I98175e3cbf2c551cdf6ed2de599e84da454439e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673132Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#673326}
-
Fredrik Söderquist authored
Creating this object for each call represents a significant part of the entire function. Using a singleton instead reduces the runtime of the testcase "usingSetAttribute" from the referenced bug's comment #5 by around 20% locally. Bug: 978513 Change-Id: I5d3447baf04706e2c23da4ed07cb0197d0349ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681766Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#673325}
-
Alex Khouderchah authored
Bug: 974973 Change-Id: Ie6cb88130e7ceddaafed59419e030443454c9671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680864 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c272b7eda7b3..30c1bb6efcde Created with: gclient setdep -r src-internal@30c1bb6efcde The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: Ib778840fa4e0717a467f5fb93b3a19a6718584a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681928Reviewed-by:
-
Alex Khouderchah authored
Bug: 974953 Change-Id: Ic4d76253d3cf5144a1352704c6df0330fc869245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680103 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Eric Stevenson authored
This reverts commit 5a2cccc8. Reason for revert: Broke webrtc roller. Original change's description: > Reland #2: "Trichrome Proguard: Fix locale pak selection." > > This is a reland of 8209b4f7. > > In the reland: Fixed webview_instrumentation_apk not setting available > locale paks. > > Original change's description: > > Reland "Trichrome Proguard: Fix locale pak selection." > > > > This is a reland of beea44ce > > > > Fixed the package name of the generated file being incorrect for Webview in > > chrome_public_apk_tmpl.gni. > > > > Original change's description: > > > Trichrome Proguard: Fix locale pak selection. > > > > > > This CL moves the arrays of locale pak files out of BuildConfig.java > > > into a new file, LocaleConfig.java. > > > > > > This file is generated with a unique package which allows Chrome > > > and Webview to have different versions in Trichrome. > > > > > > Bug: 960025 > > > Change-Id: I906d0c7e6c1540bfaa5f89e7bd9adbd9f97c8262 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610255 > > > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > > Reviewed-by: Richard Coles <torne@chromium.org> > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#662209} > > > > TBR: dtrainor@chromium.org, torne@chromium.org > > Bug: 960025 > > Change-Id: Id8ffe2e02c461ccff1b23d5328972c893415f05b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625375 > > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#662324} > > Tbr: torne@chromium.org # //android_webview/ unchanged from original CL > Bug: 960025 > Change-Id: Id11873246c7ee10198fbe625717a1364fbe0a5fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627638 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672538} TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 960025 Change-Id: I931c15d8bc1571fd6d8c29a4127001957c09d7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681868Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#673321}
-
Sean Gilhuly authored
Some of the masks tests pass by making the pixel comparator slightly fuzzier. Also run the masks test suite with more raster modes for Skia GL. Bug: 948128 Change-Id: I18063107f306743da91a38963d9de98ab4ccd15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680291Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#673320}
-
Miyoung Shin authored
This CL replaces the use of std::vector and std::set of std containers and std::string with WTF::Vector, blink::WebVector, blink::HashSet and WTF::String in graphics/*. Bug: 952716 Change-Id: Ic0fcc03bce54f5490ceda2596206c243b339e155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681720Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#673319}
-
Miyoung Shin authored
This CL replaces the use of std::vector and std::queue of std containers and std::string with WTF::Vector, blink::WebVector and WTF::String in loader/*. Bug: 952716 Change-Id: I2f93adcf4cdce37b7fdcc4cf3bc3e43fd37bac5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681718Reviewed-by:
-
Mohamed Amir Yosef authored
This reverts commit e877970f. Reason for revert: I will land it again after splitting into two patches since one of them should be merged to M76 Original change's description: > [Sync::USS] Fix USS Bookmarks deletions > > Before this CL: > The ModelTypeWorker were unconditionally setting the title in the > BookmarkSpecifics, if the SyncEntity.name isn't empty. > However, the production server sets the name to "tombstone" for > tombstones and hence the worker would actually set the title in > the specifics. > As a result the specifics are never empty. Empty specifics are used > further in the pipeline to identify remote deletions, and hence > remote deletions are always ignored. > > After this CL: > The ModelTypeWorker would only assign the title for non-tombstones. > It would also adjust the Loopback server behavior to be more aligned > with the production server. > > Bug: 979150 > Change-Id: I3ddebcfb8989b53cd6ddd2e2d3f6f0c7d2020463 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680400 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672936} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: I0ef0dc733a6e2eef52d01e99e51d479d2e79f6a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 979150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681772Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#673317}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It adds RefreshToken{Available,Revoked}Callback to DeviceOAuth2TokenService and DeviceIdentityProvider registers them instead of adding observer. DeviceOAuth2TokenService observers the refresh token status as it inherits from OAuth2TokenService and DeviceIdentityProvider gets the status through the callback. It eliminates DeviceIdentityProvider inheriting from OAuth2TokenServiceObserver. Bug: 967598 Change-Id: I786d82d26db942f03c5bf907d6aa4f83cc00c6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681440 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#673316}
-
Colin Blundell authored
This CL is part of setting up the reorganization of //components/signin. It moves account_info_util.* into the "internals" target as it's used only by the files in that target. Bug: 952788 Change-Id: I197a010d3c4dfef7da5ad17f8754a60a406a1c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681582 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#673315}
-
chrome://flagsJustin Cohen authored
This reverts commit 5f5495bb. Reason for revert: Don't wait for keyboard animation. Original change's description: > Revert "[ios] Dismiss keyboard when navigating to chrome://flags in test." > > This reverts commit 99473df8. > > Reason for revert: Not always working. > > Original change's description: > > [ios] Dismiss keyboard when navigating to chrome://flags in test. > > > > On iOS 13 chrome://flags presents the keyboard which does not allow > > tapping on back button. > > > > Bug: 977707 > > Change-Id: Ia0da9e063b894da4fbfccfb12d7d839774c3b230 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666731 > > Commit-Queue: Eugene But <eugenebut@chromium.org> > > Auto-Submit: Justin Cohen <justincohen@chromium.org> > > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#673082} > > TBR=justincohen@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org > > Change-Id: Ia4a2f62f4bbd3a9ab46f314b209d09d0f0cb5b61 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 977707 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681438 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673179} TBR=justincohen@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org Change-Id: I6fe54aa0a434fa9d837a04df7ed6853e4f62a1c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681442 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#673314}
-
Sebastien Marchand authored
Bug: 961336 Change-Id: I91c40d8d6a603ab6ea7fdef31b2fb76a01ee28b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659468 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#673313}
-
