GitLab

Bug: 1007974
Change-Id: Icc17b93647324cc347aae12cb4679461a2922077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883075
Auto-Submit: Christoph Schwering <schwering@google.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709945}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ebba8d75bf65..27eb01c35517

git log ebba8d75bf65..27eb01c35517 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 ehmaldonado@chromium.org Revert "gerrit_util: Refactor ReadHttpResponse and add more tests."

Created with:
  gclient setdep -r src/third_party/depot_tools@27eb01c35517

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1016601
Change-Id: I728ab7d58a999296f3135e1223b66eee5783ecd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883777Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709944}

This involved adding a mojom type corresponding to ContentSettingsType. I went
with just using '[Native]' after exploring a variety of ways of moving the
definition of this enum to mojom. There's a lot of dependencies on the existing
c++ header, including an auto-generated java definition. This step seems best
left for another CL. My solution is to move the param_traits for this type
from //chrome/common to //components/content_settings.

As part of this CL, I discovered that we do not use the 'details' parameter
sent by the renderer via ChromeViewHostMsg_ContentBlocked, so I removed all of
the plumbing for that parameter.

Change-Id: I0fc42ca9bfb9ec07805aa728ab929506154134cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879791Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709943}

These histograms will be removed. They were introduced to monitor the
deprecation of the linux native backends, which is now complete.
- PasswordManager.StorePerformance.*

This histogram will be maintained, since it monitors health issues. Some
of these issues could be ongoing.
- PasswordManager.StoreDecryptionResult

Bug: 1006986
Change-Id: I21dacd9860ef4a6205fa7f75f0a4ae6e7fb77b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872104
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Auto-Submit: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709942}

Activate the SetLocation command in w3c mode. This is not part of the webdriver spec, but this is a valuable function for testing.

Bug: chromedriver:3180
Change-Id: If379b56891f5326b7a6bdf51ec6044d192d485c5
Fixed: 3180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881479Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709941}

This CL removes usage of LzmaFileAllocator and tries to write unpack
result directly in the output file.
When uncompressing a folder that maps directly to a file, this is
possible and a memory mapping is used. In practice, this is always
the case. Support for folder containing multiple files is kept as
fallback and uses a pre-allocated file buffer, which is then copied in
individual files.

For running full setup install from chrome.packed.7z (Kb)
Before:
Setup.Install.PeakPagefileUsage 19748
Setup.Install.PeakWorkingSetSize 250528
GetCumulativeDiskUsageInBytes 761134
After:
Setup.Install.PeakPagefileUsage 19720
Setup.Install.PeakWorkingSetSize 250512
GetCumulativeDiskUsageInBytes 297818

The difference in memory is not significant, but improvement
are expected mostly for disk usage.

Bug: 933975
Change-Id: I26c1b118fc512d2caaa8112d3da37e6db460486b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845956
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709940}

Remove deprecate test that would require new code to be migrated.
Update and enable keyboard disappear test.
Create app interface to interact with a shared instance of the observer
in the app.
Remove OCMock usage in the test.

TBR=eugenebut@chromium.org

Change-Id: Iaa5384f241e63b95ee516d4666b2e2adf65b7da6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881566
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709939}

This reverts commit 15cb261d.

Reason for revert: causing compile error on linux-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/12634

Original change's description:
> media: Add ENABLE_CDM_PROXY BUILDFLAG
> 
> CdmProxy is still under development and will not be enabled on all
> platforms. Hence, this CL adds a new buildflag so it's not enabled by
> default.
> 
> Tbr: nasko@chromium.org
> Bug: 785563
> Change-Id: Id1a1b65032e15f4d31a7755b01912deac0b3766d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869561
> Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> Reviewed-by: John Rummell <jrummell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709933}

TBR=nasko@chromium.org,xhwang@chromium.org,jrummell@chromium.org

Change-Id: I09d36127e7b47a390ce19a7ef28e63c2fe9c27e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881637Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709938}

CheckCompleted moves to mojo. There already is an implementation on
LocalFrame so this uses that same signature for implementation.

BUG=1008432

Change-Id: I23381f935f06290cebf0181bc6c6af462323ab28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877130
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709937}

Now that WebVR has been removed from Chrome, we can get rid of the WebVR
-specific gamepad code from the OpenVR runtime. WebXR has a different
way of sending gamepad data to blink.

Bug: 1017851
Change-Id: I46afcb68205a127e1802f374e7e4b2b7dbcb0ea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880568
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709936}

CI builders:
- Android ASAN (dbg)
- Android arm Builder (dbg)
- Android arm64 Builder (dbg)

Try builders:
- android_clang_dbg_recipe
- android_compile_dbg
- android_n5x_swarming_dbg
- android_arm64_dbg_recipe
- android-oreo-arm64-dbg
- android-pie-arm64-dbg

Schedule of migration:
https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0

Bug: 950413
Change-Id: Ib7db8b4b6e0712153b05bcc97e7dc82085e44b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875857Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709935}

Bug: 989067
Change-Id: Id78c1b2fe89373629d74da52fa159b32cc26a4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883721Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709934}

CdmProxy is still under development and will not be enabled on all
platforms. Hence, this CL adds a new buildflag so it's not enabled by
default.

Tbr: nasko@chromium.org
Bug: 785563
Change-Id: Id1a1b65032e15f4d31a7755b01912deac0b3766d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869561
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709933}

This reverts commit 81d68aa6.

Reason for revert: Breaks quite a few win CI/CQ builders (crbug.com/1018731, crbug.com/1018749)

Original change's description:
> Reland: Update disable-blink-features=LayoutNG
> 
> This is a reland of crrev.com/c/1882249 because the path
> names of some -expected.png were too long on Windows.
> 
> * 3 crashes in native-file-system.
> * Mostly image rebaselines where scrollbar buttons became
>   grayed when the scroll position is at begin/end. Probably
>   someone fixed this.
> * A few pixel differences in rendering fonts, for vertical
>   flow and "AM" in the date picker.
> 
> TBR=ikilpatrick@chromium.org
> 
> Change-Id: If1d67fb4a9d496c564bfe6246cc57e46288c565b
> Bug: 1018587
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882259
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709800}

TBR=yosin@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,atotic@chromium.org,mstensho@chromium.org

Change-Id: I423af933c389570bbc6193fbc251da3d9528205e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1018587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882758Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709932}

WebVR had a different way of sending gamepad data to blink than WebXR.
Remove the code that built + sent the WebVR gamepad data.

Bug: 1017852
Change-Id: If4aa86b9a5837c7b6390fdc16404d04c3c34ded8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879991
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709931}

https://chromium.googlesource.com/devtools/devtools-frontend/+log/77f2a9d8d6..37fe72f23b

TBR=aerotwist@chromium.org

Change-Id: Ifbce02b2d1090127cf7922d989729cc54a4f0dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883631Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709930}

Bug: 1016730
Change-Id: Ib4ff92de9ee966a1c68d35e32ff368ef6008cbdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883633
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709929}

Removed the waiting on the frame deletion since nothing in the test actually
relies on the frames being deleted.

Bug: 1004786
Change-Id: Ief978db07f964c2837da93c5a9bed1768acc9e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881237Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709928}

https://android.googlesource.com/platform/external/perfetto.git/+log/2b0233b972a6..c2493796361f

git log 2b0233b972a6..c2493796361f --date=short --no-merges --format='%ad %ae %s'
2019-10-28 taylori@google.com Merge changes I747c37c5,If56568d7

Created with:
  gclient setdep -r src/third_party/perfetto@c2493796361f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I16cecb073afb5a6df10d6d6e71edbc4850e6edac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883775Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709927}

Using wpt-import in Chromium ad33ba0d.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ifba0f99832fe9f0189babe984efa6e06e0450b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882940Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709926}

Fixes crash in WebContentsViewAuraTest on Windows.

TEST=content_unittests.exe --gtest_filter=WebContentsViewAuraTest.*

Bug: 1014395
Change-Id: Ied84d4569ab20ac82da6d082dd1004fb08a43ef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862459
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709925}

In applying the fix for Issue 1002598, we changed behaviour by
transforming coordinates for the case where outer and outer-most
WebContents are the same, and this seems to cause Issue 1015298.
This CL makes it so we only transform when there are different
outer and outer-most WebContents.

Bug: 1015298
Change-Id: I390bf37ca72cdfb5a2596721046e2c9937496df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879597
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709924}

Bug: 1016809

Change-Id: If7ed31037b4db60a04b96f0b6c233d7e492659cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878647
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709923}

https://webrtc.googlesource.com/src.git/+log/3eae7e4e3cdf..5cb7807a3692

git log 3eae7e4e3cdf..5cb7807a3692 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 hta@webrtc.org Implement crypto stats on DTLS transport
2019-10-28 sprang@webrtc.org Revert "Use RtpSenderEgress directly instead of via RTPSender"
2019-10-28 sprang@webrtc.org Use RtpSenderEgress directly instead of via RTPSender

Created with:
  gclient setdep -r src/third_party/webrtc@5cb7807a3692

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:1018077
Change-Id: I1f2371ea818e6276a43b12b5b755786aa7556087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883773Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709922}

When StaticBitmapImage::SizeInBytes returned 0,
StaticBitmapImage::CopyToByteArray did not result in a no-op as
expected. With this CL we add a check to
StaticBitmapImage::CopyToByteArray to return early if the incoming byte
array has size 0.

R=jbroman@chromium.org

Bug: chromium:1017918
Change-Id: I79952218a483735815144000185a94f313a8e968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883627
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709921}

This CL changes behavior for the save-moment highlight animation: the
animation now does not appear when in sync paused/error states.

The previous behavior was visually jarring with too many moving pieces
(as well as buggy at the same time). The new behavior was chosen with UX
as the best option mergeable to M79.

Bug: 1016716
Change-Id: I706d5ff3533cbcd101b982e6db8e3cc2602adb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883511
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709920}

https://chromium.googlesource.com/catapult.git/+log/e44b5225dbfd..d6f6ff7083d1

git log e44b5225dbfd..d6f6ff7083d1 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 perezju@chromium.org [Telemetry] Stop doing metric computation.

Created with:
  gclient setdep -r src/third_party/catapult@d6f6ff7083d1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:981349
Change-Id: I9aec6e822dc2ec114b45c6b2f27f3323f9bf1e58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883774Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709919}

This patch calls the previously manually called destroy method on
BottomSheetContent. This is triggered when the sheet is hidden (and
not suppressed), regardless of whether the sheet has a custom
lifecycle.

Change-Id: I392fd98e384cfbdc73422959417e20b246da2f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879688Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709918}

When a RenderFrameHost is being swapped out, it will be in the process of being deleted.
Before any requests from accessibility should be serviced, we should
check if the RenderFrameHost is not being swapped out.
Otherwise, parts of the class instance, such as its RenderViewHost,
might have been destroyed, or the renderer associated with
the RenderFrameHost instance might not be able to
receive IPCs.

R=dmazzoni@chromium.org

Change-Id: I08a87cad7b789f0752adbcc1564b748456d5d338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881324Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709917}

When the overview mode ends, calculate a bit more accurately whether
the app list is about to be shown.

Bug: 1018346
Change-Id: Id269a90a58f2d7db9af494ea0fbd7b1ea91e715e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882318
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709916}

Bug: 1018108
Change-Id: Ib6e14fa2ff814ebaec419cf768b11633015c2298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879290Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709915}

Adjust the events to be more accurate. "WaitForSwap" starts when display
compositor thread starts issuing the swap buffers command. "Swap" starts
when the GPU thread starts running the swap buffers task.
"WaitForPresentation" starts when the swap buffers command has been
issued and ends at presentation time.

Bug: none
Change-Id: Ia1aa9f64f946c24b03b8c720b72ca35673f86e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876973Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709914}

Tbr: eugenebut@chromium.org
Bug: 987646
Change-Id: I10f44d136c205c6259a96cc5079b57bf720fab39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881232
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709913}

This CL adds a chrome://flags entry for the heavy ad intervention. There
is an additional option provided to enable the intervention without
mitigations for debugging purposes.

Bug: 1012293
Change-Id: I70dee3ec0f8d22bf4032bf03ac713e21320ff430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854169
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709912}

In order to remove the WebContextMenuData dependency from chrome/browser
we need to extract all the data types used in c/b from
web_context_menu_data.h and move them to different files under
third_party/blink/public/common.

WebContextMenuData::InputFieldType is converted to a strongly typed enum class
and moved to a different file under public/common so that chrome/browser does
not depend on public/web.

Bug: 1014517
Change-Id: If4f90dbd69943c5d14bb12594a1a0a46cdb15a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876088
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709911}

This class exists in the default bootclasspath in JDK8, but not in
JDK 11. This dep makes the annotation processor work when used with
JDK 11's javac.

Bug: 693079
Change-Id: Ic5258aa0fd1b438d7ba0dd393f95b3a2b78d5c7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882066
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709910}

It's not doing enough to justify a subclass anymore IMO.

Bug: None
Change-Id: I8cfc07e6c1f7eb3ca11f097db5fdcaf147522c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881718Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709909}

This allows them to process code targeting JDK11.

Bug: 693079
Change-Id: If638e78796d2f2098cb0c0f0fc0b89739b5d43e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882627
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709908}

Many flaky sync tests cannot be reproduced locally and even flake
occasionally on bots. Hence, let's be verbose when they do fail, and
print a detailed trace of the sync traffic as experienced by the
FakeServer.

This is achieved by leveraging gTest's ScopedTrace.

Such detailed log should be, in many cases, sufficient to understand
what caused the flake.

Bug: 1017645,1014086
Change-Id: Icd9bf9637cfb6dd7da789aa0adee5c7161339b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883651
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709907}

This reverts commit 5f4571dc.

Reason for revert: Another metric, TaskStartedNative, is logged incorrectly.

Original change's description:
> Fix crash when Background Memory metrics task is scheduled immediately.
> 
> It is scheduled with a random delay between 0ms and 59999ms. When it is
> exactly 0, the delayed task is actually executed as a regular task,
> and since it is scheduled just before the task that starts native,
> it runs without native, causing a crash.
> 
> Moving recordMetrics() to after native is initialized fixes the issue.
> 
> Bug: 1017130
> Change-Id: Ica5d0a125b93433bd2291a6c73ac30d3fd890aa8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880172
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709269}

TBR=hnakashima@chromium.org,mheikal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1017130
Change-Id: Ie5bef0866b02530232aeb383adfaae5feaf6511a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883044Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709906}