- 04 Jan, 2018 40 commits
-
-
Dominic Farolino authored
Bug: 694430 This addresses the WHATWG FETCH specification change outlined by Anne in the bug, to relax the Request constructor to not throw a TypeError when initializing a Request object with a cross-origin referrer R=yhirano@chromium.org Change-Id: I891d2b29b7c21cbeffd9645b9d1daadba63c2358 Reviewed-on: https://chromium-review.googlesource.com/719781 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#526951}
-
Dan Elphick authored
The scheduler is now responsible for choosing which BackgroundFetchJobController runs next. It round-robins through the list of job controllers launching at most one download from each at a time. Previously each JobController would get a new request from the DataManager as soon it completed one, meaning that there would be as many active downloads as there are JobControllers. The new scheduler limits downloads globally and so will prevent too many downloads from happening concurrently. BackgroundFetchScheduler gets requests from a RequestManager (implemented by BackgroundFetchDataManager) and delivers them to a Controller (implemented by BackgroundFetchJobController). Also eliminates MarkRequestAsStarted and related functions as we don't do anything with the info. Bug: 757760 Change-Id: I59f68347e93d278285c83351cbe4e1dd22b91b1b Reviewed-on: https://chromium-review.googlesource.com/776666 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#526950}
-
Darin Fisher authored
Changes SharedWorkerService to live as a member of StoragePartition. Bug: 612308 Change-Id: Ib7a115b031e806954f3dc1a17eda2c305b47c3a6 Reviewed-on: https://chromium-review.googlesource.com/847026 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#526949}
-
Gauthier Ambard authored
Bug: 798517 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie796750577450174de605f356ceaa09573952012 Reviewed-on: https://chromium-review.googlesource.com/849835Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526948}
-
Dominic Battre authored
Disable DeclarativeContentApiTest.{Dis,En}abledForSp{anning,split}Incognito for network_service_browser_tests due to flakiness TBR=jam@chromium.org Bug: 798969 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0f58b76ba43f2e17b2002ab0d767332f363a8832 Reviewed-on: https://chromium-review.googlesource.com/849834 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526947}
-
Peter Hanspers authored
Bug: 798687 Change-Id: Idfa075e10f121fd6a7e09ee56f628610f2332ec7 Reviewed-on: https://chromium-review.googlesource.com/848834 Commit-Queue: Peter Hanspers <peterhanspers@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526946}
-
Gauthier Ambard authored
The trailing edge of the text field should not be touching the trailing edge of the location bar. Bug: 797663 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I44671acf8ad81638c4eb4d1597be1748ea4988ec Reviewed-on: https://chromium-review.googlesource.com/848997 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526945}
-
Dominic Battre authored
TBR=paulirish@chromium.org Bug: 798957 Change-Id: Ib3f18197024b947d57359514c672310f42b273cc Reviewed-on: https://chromium-review.googlesource.com/848922Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526944}
-
Gauthier Ambard authored
This CL creates an AbstractPrimaryToolbar protocol and moves some of the methods from the LegacyToolbarCoordinator to it. It also split the uses of the toolbar coordinator in the BVC in three: - The PrimaryToolbarCoordinator, for the calls only related to the primary toolbar. - The LegacyToolbarCoordinator, for the calls which will be deleted once the old toolbar is removed. - The _toolbarCoordinator (current) for the calls which might be going to both toolbars or undecided yet. This separation makes things clearer in BVC. It will allow an easier transition to the adaptive toolbar as the responsibilities will be cleaner. It also moves the OmniboxFocuser and SideSwipeToolbarInteracting protocols to the toolbar/public folder as they are used by the AbstractPrimaryToolbar. Bug: 798418 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I18822be75c483af7f1b810b66c450f521f720b37 Reviewed-on: https://chromium-review.googlesource.com/846993 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#526943}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib781af0656c2813212eba6d6b68ac94f8ec8fc54 Reviewed-on: https://chromium-review.googlesource.com/848546 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526942}
-
Christian Dullweber authored
It is best practice to have UNSPECIFIED as first value in an enum for consistent behavior between proto2 and proto3. No one is sending these events yet, so changing the proto should be fine. Bug: 781765 Change-Id: I0b045b8654462f694620144a3f83817043c0e914 Reviewed-on: https://chromium-review.googlesource.com/848973Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#526941}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iacf5b86bf133f428abaf12d13aa9b945e4d665fd Reviewed-on: https://chromium-review.googlesource.com/848545 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526940}
-
Dominic Battré authored
This reverts commit 14a0def0. Reason for revert: Introduced flakiness in tests, see bug for details. Original change's description: > Properly propagate proxy auth details on sign-in screen > > This CL fixes sign-in behind an authenticated proxy. Two actual changes > were necessary in this context: > - SigninPartitionManager: copy auth data from the system request > context into new StoragePartitions > This makes SigninPartitionManager::StartSigninSession async, which > made small changes necessary in GaiaScreenHandler and > EnrollmentScreenHandler > - SigninScreenHandler: Don't reload gaia immediately when auth details > have been supplied. This was unnecessary (the URL Request will > continue) and actually harmful, as now that we're using a new > StoragePartition for each sign-in attempt, this discards auth data > before we can copy them. > > To support the browsertest, testserver.py gets an argument to redirect > CONNECT requests to localhost when proxying (in sign-in browsertests > without proxy, we use RuleBasedHostResolverProc::AddRule to achieve > this effect). > > Bug: 793524 > Test: browser_tests --gtest_filter=WebviewProxyAuthLoginTest.* && > unit_tests --gtest_filter=SigninPartitionManagerTest* > Manual test: > Setup: > Setup an proxy server with Basic authentication > Configure the device to use the proxy server. > Make sure the user adding screen is shown. > Test 1: > Expect proxy auth dialog. Enter correct proxy auth data. > Expect that sign-in screen is shown and sign-in works. > Test 2: > Expect proxy auth dialog. Enter incorrect proxy auth data. > Expect that proxy-auth dialog is shown again. > Test 3: > Expect proxy auth dialog. Press Cancel. > Expect that a network error dialog is shown. > Press "try to sign in again". > Expect proxy auth dialog. Enter correct proxy auth data. > Expect that sign-in screen is shown and sign-in works. > > Change-Id: I78b5988b5ca4c6eaaf4e6f9443e299499d6f0f08 > Reviewed-on: https://chromium-review.googlesource.com/837920 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526779} TBR=xiyuan@chromium.org,davidben@chromium.org,mmenke@chromium.org,pmarko@chromium.org Change-Id: Id979177c1b59af3903ee09b092c38b6b0c215f43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 793524 Reviewed-on: https://chromium-review.googlesource.com/848815Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526939}
-
Sam McNally authored
This reverts commit 62de24e0. Reason for revert: Test only flaked with network service enabled. Original change's description: > Disable ContinueWhereILeftOffTest.PostCloseAllBrowsers > > Test has been flaky. > > TBR=jochen@chromium.org,antrim@chromium.org > > Bug: 796308, 527045 > Change-Id: Ifd05e090d8067cd43d016c38d26d203e4ac337f8 > Reviewed-on: https://chromium-review.googlesource.com/836812 > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525349} TBR=antrim@chromium.org,rogerm@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 796308 Change-Id: I8960b4e9b1873e18e8bd496e7619594c82411137 Reviewed-on: https://chromium-review.googlesource.com/848557Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526938}
-
Christopher Lam authored
This CL shows the bookmark URL on selection and focus, and adds a tooltip to elided titles and URLs. It also extracts an 'elided-text' class into the shared styles. Bug: 768259 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I985a24fb47f02b81d2cb10466df5e5ecb5608f8e Reviewed-on: https://chromium-review.googlesource.com/846588Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#526937}
-
Dominic Battré authored
This reverts commit db757646. Reason for revert: Broke unittests, see bug for details. Original change's description: > Mac RenderTextHarfBuzz: Use hb_coretext_font_create(). > > The HarfBuzz roll in r513541 improved Mac UI font support in the > renderer by detecting UI fonts and invoking CTFontCreateUIFontForLanguage(). > > However, in chrome UI, there is already a CTFont wrapped in a gfx:: > PlatformFont for UI fonts. So creating a new CTFont for every hb_shape > call becomes unnecessary and expensive. > > hb_coretext_font_create() (after a hb_coretext_face_create()) allows > the steps requiring the call to CTFontCreateUIFontForLanguage() to > be skipped by associating the CTFont with the hb_font_t directly. > > Adds a new views_perftest target and LabelPerfTest.GetPreferredSize > to track. On a Late 2013 Mac Pro perf improves from 1390 runs/second > to 3300 runs/second. > > +250 runs/second of that comes from a related hotspot in gfx::internal:: > CreateSkiaTypeface() which was deriving a new CTFont unnecessarily > before sending it to gfx::CreateHarfBuzzFont(). > > Bug: 785522 > Change-Id: Iccf57fe3fc9a93cd4b9de1e79e81fb84d2ad88bb > Reviewed-on: https://chromium-review.googlesource.com/823743 > Commit-Queue: Trent Apted <tapted@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526920} TBR=msw@chromium.org,tapted@chromium.org,nednguyen@google.com Change-Id: I13cbdf3798ba6e3c374e92acfa1932cf9e8d5868 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785522 Reviewed-on: https://chromium-review.googlesource.com/848857Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#526936}
-
Noel Gordon authored
Using an SSE4.2-based crc32 improves the decoding rate of the PNG 140 corpus by 4% average, giving a total 40% performance increase when combined with adler32 SIMD code and inflate chunk copy code, see https://crbug.com/796178#c2 for details. Raw crc32 speed is 5x - 25x faster than the zlib default "BYFOUR" crc32, and gzip- and zlib-wrapped inflate performance improves by 69% and 50% for the snappy corpus (https://crbug.com/796178#c3 #4 for details). Add crc32 SIMD implementation and update the call-site in crc32.c to use the new crc32 code, using run-time detection of the SSE4.2 and PCLMUL support required by the crc32 SIMD code. Update BUILD.gn to compile the crc32 SIMD code for Intel devices, also update names.h with the new symbol defined by the crc32 SIMD code path. Bug: 796178 Change-Id: I1bb94b47c9a4934eed01ba3d4feda51d67c4bf85 Reviewed-on: https://chromium-review.googlesource.com/833820 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#526935}
-
Klaus Weidner authored
For some reason the window callback we request before entering WebVR is sometimes never fired if it's still pending when WebVR is entered. This may be related to VSync pausing or some other complicated interaction. This CL works around the issue in the simplest way possible for merging back to 64. This CL allows re-requesting of a window callback even if we already had one pending after exiting webVR, and just ignores any outstanding callback if it does happen to fire. Also ensure that a fresh pose gets requested if we defer a magic window VSync animation due to the current pose being stale. This was not the case when transitioning from WebVR to VR Browser magic window mode to 2D magic window mode. Bug: 794266 Change-Id: If40f21a5aa812104ba4e5a1f834491ea9940ce4b Reviewed-on: https://chromium-review.googlesource.com/847833Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#526934}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/67cd9b273f8f..f4f3f0fb29d4 $ git log 67cd9b273..f4f3f0fb2 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 fmalita Disable SkSG unit test for G3 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I595cfa73c6c9a3a0090b26fdb1d2958a5fc28ddc Reviewed-on: https://chromium-review.googlesource.com/849593Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526933}
-
Mohamad Ahmadi authored
Bug: 418827 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20fa5a45ed6a749d98cec691b6648798dfe68547 Reviewed-on: https://chromium-review.googlesource.com/835228Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#526932}
-
Sasha Bermeister authored
Remove non-mojo QuotaStatusCode and StorageType enums and replace them with their mojo equivalents. This CL was created by: * Find-and-replace blink::QuotaStatusCode and blink::StorageType with mojom::blink::* instead * Add a `using` statement to third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp * Replace type #includes with the mojom.h header instead * Fix small # of remaining compile and presubmit errors * Removing the QuotaStatusCode and StorageType enums and their typemap files TBR: jsbell@chromium.org,kinuko@chromium.org Bug: 781643 Change-Id: Ifc9e5ae4084f3fc78a0a1131c04a81ea5c2c4515 Reviewed-on: https://chromium-review.googlesource.com/849772 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526931}
-
Renee Wright authored
Is it clearer and faster to hard-code the camel case name of a property into its property class - since we already have that value at hand at generation time - than to construct it at runtime when it is needed. Slight increase in code size in favor of simplicity and speed. Bug: Change-Id: Ib8f0c3b6c1dd892b94bea5b08c3d43695131b098 Reviewed-on: https://chromium-review.googlesource.com/831806 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#526930}
-
Jiaquan He authored
This commit removes all SearchBoxModel references from chrome by passing in a raw search query from Ash. Bug: 733662 Change-Id: I1d2b479260cb59f8858d48b9850a5935477f4b7d Reviewed-on: https://chromium-review.googlesource.com/849618 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526929}
-
Zhuoyu Qian authored
As the comment in PaintLayerScrollableArea.h by ymalik@, remove Box() and update callers to use GetLayoutBox() instead. BUG= Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I23540f3057040f992bbeb78c817e27f490da327d Reviewed-on: https://chromium-review.googlesource.com/848484Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#526928}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/487a7520b5c9..67cd9b273f8f $ git log 487a7520b..67cd9b273 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 fmalita Build fix post c75e2401a82640c35b0b5f80a5684d0892904530 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I5e790b16f6aa0210b2d957cbbd8fe397deada1e6 Reviewed-on: https://chromium-review.googlesource.com/849773Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526927}
-
Eric Karl authored
We've moved to 100% on finch. Switching this to always on. Bug: 704716 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4211a8a0b5a09dd2f8a86726da9d63186fb4ce47 Reviewed-on: https://chromium-review.googlesource.com/847969Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526926}
-
Zhuoyu Qian authored
As the TODO in frame_parts.h, Convert FrameParts to a class, hide the member variables, add getters/setters for them. BUG= Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I897045b887842647e79cf9e8ff301b7faf8dcd90 Reviewed-on: https://chromium-review.googlesource.com/844499Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526925}
-
Victor Costan authored
Bug: 798868 Change-Id: Ifca3a9be15fdc396f60b205c830be4cae0541821 Reviewed-on: https://chromium-review.googlesource.com/849474Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#526924}
-
Renee Wright authored
These accessors are not needed in CSSUnresolvedProperty at this stage. We want to constrain the functionality of CSSUnresolvedProperty to the bare minimum so as to discourage its usage. It is useful to know that a property representation is strictly a resolved property; thus we do not want CSSUnresolvedProperty used except where absolutely necessary. If it turns out that these are needed on CSSUnresolvedProperty in future then they can be moved back. Change-Id: I4bb8c0714d5cfffe8f4b0d353ae0b0931e665f8f Reviewed-on: https://chromium-review.googlesource.com/831375Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#526923}
-
Justin Cohen authored
Bug: 795683 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iab78eeda08a1de8a56a662f8a0b2b4d4fe8696da Reviewed-on: https://chromium-review.googlesource.com/847429Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526922}
-
Darren Shen authored
This patch uses idlharness.js to test the CSSKeywordValue interface. Bug: 774887 Change-Id: I64bd459bcc199094fc0ce60c217110fc0f0cb17f Reviewed-on: https://chromium-review.googlesource.com/848117Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526921}
-
Trent Apted authored
The HarfBuzz roll in r513541 improved Mac UI font support in the renderer by detecting UI fonts and invoking CTFontCreateUIFontForLanguage(). However, in chrome UI, there is already a CTFont wrapped in a gfx:: PlatformFont for UI fonts. So creating a new CTFont for every hb_shape call becomes unnecessary and expensive. hb_coretext_font_create() (after a hb_coretext_face_create()) allows the steps requiring the call to CTFontCreateUIFontForLanguage() to be skipped by associating the CTFont with the hb_font_t directly. Adds a new views_perftest target and LabelPerfTest.GetPreferredSize to track. On a Late 2013 Mac Pro perf improves from 1390 runs/second to 3300 runs/second. +250 runs/second of that comes from a related hotspot in gfx::internal:: CreateSkiaTypeface() which was deriving a new CTFont unnecessarily before sending it to gfx::CreateHarfBuzzFont(). Bug: 785522 Change-Id: Iccf57fe3fc9a93cd4b9de1e79e81fb84d2ad88bb Reviewed-on: https://chromium-review.googlesource.com/823743 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#526920}
-
chrome-release-bot authored
TBR=mmoss@chromium.org Change-Id: I7e61970b4dbf9ad4a36af34c4112b69890d1bee8 Reviewed-on: https://chromium-review.googlesource.com/848540Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#526919}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/6df487ef1e61..47c8ea3fb265 $ git log 6df487ef1..47c8ea3fb --date=short --no-merges --format='%ad %ae %s' 2018-01-03 jmadill Vulkan: Fix looped clears. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Iaecbc475ea866e2d8db42fd28ae79b9be48dfcb3 Reviewed-on: https://chromium-review.googlesource.com/849703 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526918}
-
Tibor Goldschwendt authored
The snackbar provides the user with the functionality to apply a new background while in VR browsing mode. This change is based on vollick@'s https://chromium-review.googlesource.com/c/chromium/src/+/847732. Credit is due. Bug: 798531 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I60eae5fb37c6e9fea3192eb7e5f9b8bb0df6ee1d Reviewed-on: https://chromium-review.googlesource.com/849312 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#526917}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9fc53624a09f..487a7520b5c9 $ git log 9fc53624a..487a7520b --date=short --no-merges --format='%ad %ae %s' 2018-01-04 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 6df487ef1..47c8ea3fb (1 commit) 2018-01-03 fmalita [sksg] Refine invalidation logic 2018-01-03 benjaminwagner In iOS recipe, uninstall before install. 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ fc3463da0..6df487ef1 (1 commit) 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 36937a64f..fc3463da0 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ib8ebe7a6542bebcb571d4115c01a5b3131a21777 Reviewed-on: https://chromium-review.googlesource.com/849416Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526916}
-
Andrew Grieve authored
Downstream was updated. Bug: 792315 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d7ccf2494df803f831363ebea6bb63b075b5a72 Reviewed-on: https://chromium-review.googlesource.com/848079Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#526915}
-
Scott Violet authored
In mus ash::WindowManager is responsible for controlling NetworkConnect. This means NetworkStateNotifierTest shouldn't try to control it too. BUG=848272 TEST=test only change Change-Id: Ia0cefa0f59e4c25d85f2ebb62fea11c76280e4ab Reviewed-on: https://chromium-review.googlesource.com/849475Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526914}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f294c56d..0e59efcd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1aa5c67e8645172e721c4d1fbc6bb934a46ded26 Reviewed-on: https://chromium-review.googlesource.com/848041Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526913}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/cbd4410908e2..45da0f2d84c9 $ git log cbd441090..45da0f2d8 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 dsinclair Fold CXFA_FillData into CXFA_Fill 2018-01-03 dsinclair Fold CXFA_ImageData into CXFA_Image 2018-01-03 dsinclair Fold CXFA_LineData into CXFA_Line 2018-01-03 npm Remove unused methods from CPDF_VariableText 2018-01-03 dsinclair Fold CXFA_BindItemsData into CXFA_BindItems 2018-01-03 dsinclair Fold CXFA_BindData into CXFA_Bind 2018-01-03 dsinclair Convert CXFA_StrokeData to CXFA_Stroke 2018-01-03 dsinclair Fold CXFA_CaptionData into CXFA_Caption 2018-01-03 dsinclair Change CXFA_BoxData to CXFA_Box 2018-01-03 dsinclair Fold CXFA_OccurData into CXFA_Occur Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3bffcd6e6fff74192c64b3ad799fce821e0eb358 Reviewed-on: https://chromium-review.googlesource.com/849692 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526912}
-