- 29 Jul, 2020 40 commits
-
-
Elly Fong-Jones authored
If this is not done, when the button's visual state changes, its text color changes but its background does not. For prominent buttons the result is very hard to read. Bug: 1109798 Change-Id: Id00c1cc7d9ec7c5a71ac5e4f72949883497ab025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321056 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#792800}
-
Mohamed Amir Yosef authored
Before this CL: HttpPasswordStoreMigrator was conditionally run against only the profile store. After this CL: HttpPasswordStoreMigrator is run against both the profile and account stores. Bug: 1107741 Change-Id: Iadb17cc15884085f09dfbef78ed755d9b49869a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315895 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#792799}
-
Jian Li authored
This fixes the problem that the animation for the native view may stop at some circumstance. Bug: none Change-Id: I92370a803ca3031a0856c57a53996e41f91d5123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324102 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#792798}
-
David Tseng authored
This change is a speculative response to the bug below. The bug observes that touch exploration is broken on CFM's main UI. Assuming that observation is true, this change reverts back to sending mouse moves from js. This should be functionally the same as sending mouse moves from C++ in TouchExplorationController as an EventRewriter. R=dmazzoni@chromium.org Bug: b/161161531 Change-Id: I3ae0cfe421708e3630d2d5a0d99d402ec40fa7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316451 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792797}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idf0b46bf5298c5df40ee14e0b1ba71cd5a6d686c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326590Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792796}
-
Yuchen Liu authored
So that we can control it from the cloud. Bug: internal b/160753974 Test: Build Change-Id: I5b29df076727f7c0063836f9ff08cfd1107ad904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325169Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792795}
-
Nina Satragno authored
This is a reland of a0f7bda2 I changed the logic that verifies that frames have rendered so as to not rely on rendering that might slightly change depending on the platform, since on several mac bots the jpeg rendered *looked* the same but the binary was different. Original change's description: > [webui] Re-Enable cr-lottie tests > > It's not clear if these tests will still be flaky on the CI or not. We > made some changes that may have deflaked them. > > Bug: 1103865, 1021474b > Change-Id: Icfe7ed6637868fc29e30c0d182f985a6b38aa000 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311144 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Auto-Submit: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791463} Bug: 1103865 Bug: 1021474b Change-Id: I34406a02dcf1be4d1ff62304e6b824fecd7e8df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320075 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#792794}
-
Aaron Leventhal authored
The object at the point in the middle of the focused target isn't necessarily the same as the focused target. For example, the object in the middle of a 2-line link is often an object behind it. Bug: 1082489 Change-Id: If5aff8dc97a917a2465957dd509cabdd9b2c45cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303307 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792793}
-
Robert Ma authored
`wpt lint --ignore-glob` uses fnmatch to match patterns, which means 1. Patterns must match the full filename (we need a wildcard at the beginning). 2. Path separators are not treated specially (i.e. we need to use platform-dependent path separators). Furthermore, we need to ignore OWNERS files, too, which was forgotten in an earlier change. Add tests to prevent regressions. Fixed: 1103374 Change-Id: I62e6ea5ebef900c60b10a325f01683fa5ed836c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326110 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#792792}
-
Teresa Kang authored
- Move getImageData-cpu perf test to rendering benchmark - Remove repeated-draw and repeated-getImageData tests - Replace usages of Math.random with a counter to force different fill color for each frame, to keep the tests simple and reduce dependency Bug: 1077148 Change-Id: Ib7caed70f6a86122c74cee6045179162b3448874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316454Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#792791}
-
Hans Wennborg authored
This also updates the Clang version to 12.0.0. Ran `tools/clang/scripts/upload_revision.py 7e8d5a90f2c101388d3b0bbce8555e871c670232`. Bug: 1107461 Binary-Size: Being investigated async in crbug.com/1110413 Change-Id: Ie0dac66069bec3cf10bfe355b5044ebc7af22d88 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320674Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792790}
-
Mohamed Amir Yosef authored
This is a pure refactoring CL. Following up CLs will inject the account store when appropriate. Bug: 1107741 Change-Id: Ic3e31d3f412456c596f9ce97185e90b1b9e5d47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315151 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792789}
-
Randy Rossi authored
The ax_tree_id retrieved from the main frame can change since the main frame may be swapped by the webview due to navigation requests. This CL uses the cast web content's tab id to identify the tab from which the current main frame can be retrieved and (hence the ax tree id). Bug: NONE Test: Display assistant build with weather webview screen Change-Id: I0e8a23a79271a853652b2dcf09dfcf4403f94b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325030Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792788}
-
Nicolas Arciniega authored
This is a reland of 33f234e7 This change differs from the original change in that: - This one dynamically loads WinHttp functions that are not supported in Windows 7 and below (see WinHttpProxyResolverFunctions). - This change fixes a string copy issue in the unit tests. This change creates a functional proxy resolver for Windows that relies on WinHttp APIs. This is not in its final state, though. This CL represents the simplest, least-work way to implement this proxy resolution service. Work still to come includes: - Complete NetLogs - Better error reporting from WinHttp APIs - Proxy Delegate - Proxy retry info - Assurance that the proxy configs we're receiving are from the system The WindowsSystemProxyResolutionService is the object that external callers use to resolve a proxy. These callers can keep track of the status of this proxy resolution via a ProxyResolutionRequest, implemented here as a WindowsSystemProxyResolutionRequest. The request object is mainly intended to kick off a specific proxy resolution and report a result via a caller-provided callback. Both of these objects deal with a WindowsSystemProxyResolver. The WindowsSystemProxyResolver is a new class that does all the required interfacing with WinHttp APIs. It is a reference counted object created by the WindowsSystemProxyResolutionService. Once created, it is used for the lifetime of the WindowsSystemProxyResolutionService. Throughout that time, the Resolver indirectly keeps a WinHttp session handle open. Each WindowsSystemProxyResolutionRequest is given a reference to the new resolver. When the Request object attempts to resolve a proxy for a given URL, it'll call into the Resolver object. Under the hood, the Resolver object creates a handle for the proxy resolution and runs the async call to WinHttp. At any time, the Request object can choose to ignore a pending result from the Resolver (ex: shutdown). The Resolver object must be reference counted because async WinHttp calls call back directly into the Resolver object, so it needs to stay alive as long as we're waiting for an async response from WinHttp. Another new object is the WinHttpAPIWrapper, which is just a thin wrapper over WinHttp APIs which we use to enable easier testing and to simplify some interactions with WinHttp. A WinHttpAPIWrapper is owned by a WindowsSystemProxyResolver. The Resolver object is the only object that should interact with the Wrapper object in any meaningful way. Internally, the WinHttpAPIWrapper keeps track of the opened WinHttp session handle that we're using for the lifetime of the Resolver object. This feature is only supported in Windows 8 and above. Prior versions of Windows will not be able to instantiate the WindowsSystemProxyResolutionService. Loading the right functions for Windows 8+ is handled by the WinHttpProxyResolverFunctions singleton. This change includes tests for the WindowsSystemProxyResolver layer (by mocking out the WinHttpAPIWrapper) and the WindowsSystemProxyResolutionService (by mocking out the WindowsSystemProxyResolver). Bug: 1032820 Change-Id: I1075e5c918e5aa14f7317853e6a39103ad9383d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310672Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792787}
-
Avi Drissman authored
Move the Mac enterprise expiration to the end of the year; work is still being done. Bug: 1109825 Change-Id: I052bf14c52d61af6e1eb2caba08daa1309354c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323582 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792786}
-
Xiaocheng Hu authored
Bug: 1110331, 891944 Change-Id: Ic00ebc65743626d9004ba5548d216270578edfab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324655Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#792785}
-
Tom Anderson authored
BUG=1066670 R=nickdiego,sky Change-Id: I653195df827b88714d024bbaa5ce2e4299461deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317767 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#792784}
-
Xianzhu Wang authored
This simplifies selection paint invalidation, and enables us to simplify partial rect invalidation (crrev.com/c/2321051). Also use a dedicated display item client for the text selection in a LayoutText, so that we can repaint texts and selection separately. This will cause bigger raster invalidation rects for selection changes, but dedicated display item client makes paint much faster for incremental selection changes. This CL can get big progression for the perf tests added in crrev.com/c/2321233. Change-Id: I1ed573a4333fd7830fb3cbfda4bbdaf374d33fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319540 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#792783}
-
Sophey Dong authored
This removes copying the histogram name for every new option added. Bug:1079467 Change-Id: I54dae11cf34535f71146923c3e0f85f87c3bb2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324722Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#792782}
-
Mustaq Ahmed authored
This is not used anywhere. Change-Id: I3a4341cf268c51b5966b9d0b78a3f443ff5047d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318711Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#792781}
-
Tom Anderson authored
BUG=1066670 R=nickdiego CC=sky Change-Id: I1ee01119a58c231c9f23587a5dc4408e031aef23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316436 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
Bug: 1096278 Change-Id: I1fa22fb963cc225b95447cb9caea12f030bead90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324886Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#792779}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/e7415a5b8712..e5c11c069f53 $ git log e7415a5b8..e5c11c069 --date=short --no-merges --format='%ad %ae %s' 2020-07-29 bnc Make QuicPacketCreator::ExpansionOnNewFrameWithLastFrame() static. 2020-07-29 fayang Add a getstringifcomplete function to hpackdecoderstringbuffer to return string only when state is complete. used in error details, not protected. 2020-07-28 haoyuewang Internal QUICHE change 2020-07-28 dschinazi Deprecate quic_enable_version_draft_29 Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I55209f3d33c69a0c0e9266600fdee5b32cd31dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324976Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#792778}
-
Liquan (Max) Gu authored
Before: PRImpl#constructor depended on AddressEditor and CardEditor directly. After: PRImpl#constructor depends on PaymentUIsManager which depends on CardEditor and AddressEditor. Change: * Move mAddressEditor and mCardEditor instantiation into PaymentUIsManager. * Refactor CardEditor so that forTest observer is no longer set in its constructor. * Turn the test observer to static so that it can exist before there's a PRImpl, PaymentUIsManager instance, which is required by tests[1]. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java;l=211;drc=26503120e38dd3c6b2dfa17dfbc65465ac475534 PaymentUIsManager set the test observer only in tests. Bug: 1102522, 1107102 Binary-Size: Silence the "for-test" alert because PRImpl, Change-Id: I47ae3d37d015f8ebb734ede2c90d590015a3a163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324566 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#792777}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb118ddc8dea..8c02e882a3f2 2020-07-29 janscheffler@chromium.org Migrate `front_end/help` to `devtools_entrypoint` 2020-07-29 janscheffler@chromium.org Migrate `front_end/object_ui` to `devtools_entrypoint` 2020-07-29 janscheffler@chromium.org Migrate `front_end/quick_open` to `devtools_entrypoint` 2020-07-29 jacktfranklin@chromium.org Migrate from page.waitFor in e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I26345789c939cd8f44ecead4d319c36fcf260ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326271Reviewed-by:
-
Avi Drissman authored
Bug: 1105907 Change-Id: If5fa1f8b88459d536b6b9e1f5b1a64574b5a56c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325233 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#792775}
-
Yicheng Li authored
AuthDialogController is called by UserAuthenticationServiceProvider and is responsible for managing authentication dialogs and talking to chromeos::ExtendedAuthenticator. The authentication functionality is not implemented yet. AuthDialogController is exported publicly because AuthDialogClient (to be implemented) in Chrome needs to find it. Bug: b:156258540 Change-Id: I4a8904c25431b1267d01b7ecce0400fbe9f00569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298542Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792774}
-
Lei Zhang authored
The current suggestion no longer works as of https://crrev.com/732394. Bug: 646113 Change-Id: Iae40f884c4258fd3e3017963a85e38c6a82e4d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325710Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1093315, b/158458370 Change-Id: Id7ef567eee4f4cd39cfe449c41af8613886a176b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321229 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Avi Drissman authored
Bug: 1105907 Change-Id: Ife6a00a78fd9a013681c637d1cd853f65ae094d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325234Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792771}
-
Michael Chang authored
For getting the right value, the bash script needed proper quoting. Without it, defaultd did not give a correct value. Bug: 1109362 Change-Id: I80239c5e816ffe3702aa48190f1750c81cf40511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318000Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Michael Chang <donchan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792770}
-
Min Qin authored
listener is registered. If an extension registers an OnDeterminingFilename listener, download.filename will be ignored as the listeners will provide the filename. BUG=1106297 Change-Id: Id44f5c7043f0e899f33f53f80458a00b162e5c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318445 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
Evan Stade authored
Add UI thread checks for callbacks that are passed to the embedder. Bug: none Change-Id: I2cd643e406f056c112f1f77ab84e66ad8e96cd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326296 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Move mPaymentHandlerUI from PRImpl to PaymentUIsManager. Bug: 1102522 Change-Id: I7f74893ad5e92f2ea6d97636fab9e1cfe38c2e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317605 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#792767}
-
Nela Kaczmarek authored
This change refers to AffiliationService for Android, but creates a new more generic Affiliation Service. It provides base implementation and factory and renames existing affiliation_service.* to android_affiliation_service.* to avoid compilation conflicts. The main purpose of the class is to fetch and provide change_password_urls for requested origin or sites from the same FacetGroup. Bug: 1108279 Change-Id: I1a0df695831eed6eabf6c46efe0485a968ecd420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312716Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Peter Kasting authored
Returning the font's height is a saner default for TypographyProvider. Having Label track the user-set line height separately from the computed result simplifies GetLineHeight() callers and fixes at least one bug where the caller (reasonably) assumed GetLineHeight() would always be large enough for the font height. StyledLabel gets similar changes, but more simplifications since what used to be GetDefaultLineHeight() is now moved into GetLineHeight(), and GetDefaultFontList()/GetFontListForRange() have been combined into a sindly GetFontList(). These changes fix the layout of the DownloadItemViews, which also assumed that GetLineHeight() was large enough for the font height. Bug: 1109611 TBR: antrim Change-Id: I635a4bba3813a872b66123a5ed701bc4aebbedf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324496Reviewed-by:
-
Etienne Bergeron authored
This CL is fixing the trace events of the HandleVerifier for a non components build. For a static build, there are two instances of the HandleVerifier 1) chrome.exe!HandleVerifier 2) chrome.dll!HandleVerifier At chrome startup, chrome.exe!InstallVerifier set a global singleton which start tracking ScopedHandle objects. After the initialisation, chrome.dll is loaded. The call of chrome.dll::InstallVerifier() is fetching the singleton from 1) and is storing it as a global singleton into chrome.dll. Calls to the chrome.dll!VerifierTraits::StartTracking() and chrome.dll!VerifierTraits::StopTracking are forwarded to the chrome.exe!HandleVerifier instance. Since TraceLog is also part of base, there is also two instances in each module. There are two instances of categories array that specify which categories are enabled but only one is used by chrome tracing. A trace event executed in chrome.exe will never be enabled. This is explaining why trace events from chrome.exe!HandleVerifier are not emitted unless the build is a component build. To solve this issue, this CL is lifting the trace events before entering the code that forward the call to chrome.exe. This way trace events are using the right instance of TraceLog (e.g. chrome.dll). Bug: 1110507 Change-Id: I61ee1e18b849d32f90d2430759da6d1c8666c854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324873 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#792764}
-
Ella Ge authored
When a violation occurs with the flag on, the TWA will run the callback to the client app to "crash" (client app should throw a RuntimeException) If the client app knows how to handle the crash message, finish the activity. Bug: 1109609 Change-Id: I30c50861f80bee11f917a447800a3687f521fc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318532 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#792763}
-
Guillaume Jenkins authored
This reverts commit 21497283. Reason for revert: It seems the timeouts are still happening, see the builder page here: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests Original change's description: > Re-enable the RightClickMenuShowsCopyUrl test on mac. > > Test timeout on CQ seems to have mysteriously fixed itself. > > Bug:988323 > Fixed:988323 > > Change-Id: Ia96d8a687bc161cf74f67fbf819ffaf7bb896755 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325330 > Auto-Submit: Glen Robertson <glenrob@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792705} TBR=estade@chromium.org,glenrob@chromium.org Change-Id: I5de2c6b986703f81b43977072951f1923ce3bb8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 988323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326733Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#792762}
-
Lan Wei authored
Since we will not use this experimental feature to transfer user activation through post message to autoplay videos in a cross-origin subframe without any user activation. We will delete the transfer_user_activation function from all the transferable message classes, which indicated whether we want to transfer user activation through post message. We will also clean up the frame interfaces in browser/renderer in a follow-up CLs. Bug: 1067307 Change-Id: Iaa969632cb4132993512b28db97d648d6abffdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295984Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#792761}
-
