- 08 Jan, 2020 40 commits
-
-
Darwin Huang authored
Bug: 1033461, 1037786, 1038213, 1038863 Change-Id: I22b98c909e9af632818bed4e49f96b028f1dcf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990216Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729415}
-
Steven Bingler authored
Convert the initiator into a SiteForCookies object in order to be able to take advantage of the IsFirstParty() member function. This change allows us to replace the existing code which performs a similiar check. Change-Id: I942cd96b37c21bf47403e6507938b95cbe207890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990222Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#729414}
-
Eric Karl authored
During GLES2DecoderImpl::Initialize, we must call Destroy in any failure case. This used to be done manually, which lead to us missing it in a couple places. This CL adds a helper class DestroyOnFailure, which ensures we always call Destroy on exiting. Bug: 1039884 Change-Id: I135092f4194d6470239b3ff40ebca63be8d2fa67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989889 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#729413}
-
Alex Gough authored
This supported out of process profiling but this is now back in the browser, so this sandbox type is not needed. Also removes |g_use_localtime_override| from libc interceptions which was the only thing controlled by the kProfiling sandbox type. This global defaulted to true so it is safe to remove it from the compound checks that used it. BUG=772503 Change-Id: Id1639c595d10ef414be36fc1d62fd58864db002c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988916 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729412}
-
Andrew Grieve authored
apkbuilder.py was failing with: zipfile.BadZipfile: File is not a zip file Regressed in b2706770 NOTRY=true # Expediting. All relevant tryjobs have passed. Bug: 1039832 Fixed: 1039832 Change-Id: I0b5b0979bcf9d3f7924129034a62c28937c0424b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989494 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#729411}
-
Mikhail Khokhlov authored
The new message is not so confusing and gives concrete recommendations on how to fix the error. Bug: 1040118 Change-Id: Ic6bb80505da6118045a55f643ae9529630cb0d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991430 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#729410}
-
Xianzhu Wang authored
Remove TODO(crbug.com/919536) and add a setTimeout(0) (as requestAnimationFrame() used in runAfterLayoutAndPaint doesn't work in a hidden page). We used setTimeout before we changed the test in crrev.com/c/1395193/16/third_party/blink/web_tests/fast/webgl/webgl-composite-modes-tabswitching.html. Bug: 919536 Change-Id: I50ce99ad684c06eea58d9c8cedf71d21c649c0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991942Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729409}
-
Owen Min authored
Change-Id: I9a52f0d269b5d28592f48d13c8aba6d723562ac2 Bug: 1036503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978879Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729408}
-
Jiaqi Han authored
This CL removes the buildflag as component/exo target can be built when ozone is enabled. Bug: 138682668 Test: CQ Change-Id: I9cadbf54825ae53faa8b6beee84d9ca7dfbe8333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989378Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
-
Gabriel Charette authored
The TSAN log shows that the issue is that the test's WriteFDWrapper is using the |pipefds_| on |io_thread_| unsynchronized with the main thread closing the pipe from TearDown(). Joining the test's |io_thread_| solves the issue. R=fdoray@chromium.org Bug: 955440 Change-Id: Ifc4966518d2e6abce4d0a3cd8b301e3241a057f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990340 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#729406}
-
Mikel Astiz authored
This patch effectively relands the logic reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1864800 which caused crashes in the past (CHECK failures). In this new form, the underlying issue is addressed: for users that don't use GUID-based merging of bookmarks, local GUIDs are reassigned randomly to avoid GUID collisions in the local bookmark model. Bug: 978430,1004205 Change-Id: I812d1cfe1c12b766799e6c5ec238f95fd16139ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983231 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#729405}
-
Prabir Pradhan authored
Pointer Capture in Exo was initially implemented by using SetCapture() on the aura::Window. This delegates all input events (touch, keyboard, mouse, etc.) to the capture window, meaning that the user will not be able to interact with anything outside the window with any form of input. Rather than relying on SetCapture(), we set a pre-target handler that receives and consumes all mouse events when pointer capture is enabled. exo_unittests Bug: b/146164376 Test: manual testing on ARC++ P using ArcPointerCaptureTestApp.apk; Change-Id: I99bcda823ce662e39a91920af98ae09d715bbc38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966007 Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729404}
-
Mike West authored
As discussed in [1], cookies with empty names and empty values should be rejected. This patch removes the carveout made in https://crbug.com/601786, and adjusts unittests accordingly. This patch does not change the WPT expectations; we'll do that at the same time we change the spec. In the meantime, we'll check in local expectations matching the behavior we believe is correct. [1]: https://github.com/httpwg/http-extensions/issues/159#issuecomment-569233866 Bug: 1037996, 601786 Change-Id: I53319cee385efff019b313479184236c53b1d783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982549Reviewed-by:
-
Lambros Lambrou authored
Some tweaks to the MacOS permission wizard: * Reduced icon size in the dialog (without affecting the dock icon). This selects the 64x64 icon from remoting_host.icns. * Reduced vertical spacing between buttons and text. * Horizontally centered the "All Set" text within the area occupied by the instruction text. Currently, the window does not shrink when the text is replaced with shorter text (because resizing the window causes it to jump somewhere else). * Fixed incorrect vertical position of "OK" button on final page. Bug: 1032157 Change-Id: Iedc9a0640200bc2a4152b931f572d35fb3e76312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980973 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#729402}
-
Mia Glaese authored
This CL fixes the bug that TemplateURLObserver and TabmodelSelectorObserver are not added correctly. Before: Logo visibility is not updated with SearchProvider. Incognito state is not updated before toolbar is first shown. Bug: 1039587, 1039616 Change-Id: If0775117ac35a61c61f34d5de8e42ca91b895491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989000 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#729401}
-
Rob Buis authored
Skip global-interface-listing.html on linux_layout_tests_layout_ng_disabled bot since it needs to be updated frequently but people forget. Bug: 1034944 Change-Id: Iaff55bf2d3ab9a110137ff6d8e64b7325c3b684f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988359 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#729400}
-
Steven Bennetts authored
This adds some CHECKs to help investigate issue 1034017. It also includes some cleanup of ResourceBundle and updates some header comments to make it more clear that null might be returned. Bug: 1034017 Change-Id: I4b5717253b379c9d92aa8bd9bc9732df1ff880f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974950Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729399}
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the InstalledAppProviderTest unittests from junit to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). As these tests test AsyncTask functionality, I had to expose the code to run a nested Looper (NestedSystemMessageHandler) more broadly, and ended up doing some cleanup while I was there. Bug: 783819 Change-Id: Ie7ddcb696237702a9a59ae26895318f494d6f6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990330 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729398}
-
Mihai Sardarescu authored
As explained in the attached bug, the developer was running ChromeOS and Chrome linux in the same user data directory. This lead to the case where the primary account was an email even thought the account ID migration preference was set to "done". This lead to a new DCHECK in the migration code firing. Even thought this is not expected to happen in production code, this CL uses a new entry in the histogram to avoid strange migration scenarios. Bug: 1034512 Change-Id: I61e0aaadb93a7f7c6c3a09d3a009fa9f2bf2ee6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971838Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#729397}
-
John Abd-El-Malek authored
This will be helpful for new code for maintaining backward/forward compatibility. Bug: 1025603 Change-Id: Iac90914721a2ea266fd7af07258b0d422d05f3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988372 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
CredentialLeakDialogView::Accept nulls the controller and creates a new tab. During tab creation the framework may call some methods on the view to get its title or buttons. Previosuly that led to a crash. It doesn't matter what to return in those methods because the dialog is being destroyed anyway. Bug: 1039452,1036422 Change-Id: I985b7e79ac78431e216d3f27de001683846a29b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991563Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#729395}
-
Renato Silva authored
The initial focus on the OOBE 'Welcome' screen has been changed from the language button to the "Let's go" button as per UX request. Fixed: 992434 Change-Id: Iff2917c74c8463ebe1f3163bcb61e802cbbcf0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991442 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#729394}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e5d3c6595f7e..b84cdffeec6c git log e5d3c6595f7e..b84cdffeec6c --date=short --first-parent --format='%ad %ae %s' 2020-01-08 ericbinet@google.com Fix colored indexed point tests not using color in vertex buffer. Created with: gclient setdep -r src/third_party/angle@b84cdffeec6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I2679fd2b4cf52d80022c0658241e71c9652a9f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991588Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729393}
-
Takumi Fujimoto authored
When the MRP receives a media status update, it fills the media field with data cached in the CastSession object. However if the field is already present, we shouldn't overwrite it. Bug: 1037970 Change-Id: Id72e4d31d173a18dbacd438810392316db448a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982861 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#729392}
-
Ionel Popescu authored
This CL updates the colors for different states inside date/time picker: - for today state: #767676 border is used - for selected state: #0075FF background-color is used - for hover state: #0075FF with 30% bg background-color is used Bug: 1022747 Change-Id: I9f85a38494ea3b9447c7016665b866723c98da39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988990Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#729391}
-
Q. Alex Zhao authored
Allow iframes on a different domain than the top-level to get desktop media through the Hangouts services extension. This is based on the workaround found in issue 425344. Bug: 1039351 Change-Id: I57cb33dc93af81f7f971d2b69edc582dfc243792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989026Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Alex Zhao <qaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#729390}
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. If the byte length is larger then a RangeError is thrown to avoid problems in passing a wrongly cast size to the underlying stack. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=senorblanco@chromium.org Bug: chromium:1008840 Change-Id: I72e04c879eb436cd224b7fb8a48d2bc022c4c5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964494Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#729389}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 93f8b78c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6e1c0c52ee6337753493896eb4b4fea42dc4b462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991405Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729388}
-
Daniel Clark authored
This CL updates the <input type="color"> popup UI in three related aspects per design feedback: 1) The in-page control now updates immediately as the selected color is changed in the popup, instead of waiting for the popup to be dismissed. The page can watch for these 'live' changes via the input event. 2) The UI is simplified by removal of the submit and cancel buttons. The popup is now dismissed only by clicking outside of it or with the Enter or Escape keys. 3) A 'double-escape' model is introduced in which if a user has opened the popup and changed the value, hitting Escape once will reset the value back to what it was when the popup was opened. Hitting Escape once more, when the popup value matches the value when opened, will dismiss the popup. Bug: 1001571 Change-Id: Ifb918d5479efedb0e2fbe571d4239bc15cbcc723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978252Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Reviewed-by:
-
Hesen Zhang authored
- Change notification scheduler registar to be able passing browser context pointer so that the service calback can be injected into client's ctor. - Implemented BeforeShowNotification in the client code, completed display flow. Bug: 1013685 Change-Id: Ibfa0cdc43435b31657ac386db11a2069a6144a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984746 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729386}
-
David Bienvenu authored
This reverts commit 1b22208b. Reason for revert: <will apply fix> Original change's description: > sheriff: Revert "Use unoccluded desktop region to calculate root window occlusion." > > This reverts commit f34c7c2b. > > Reason for revert: > Likely culprit for frequent test flakes on win7 dbg bot. > Sample failing build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 > Sample failure stack: > [1744:6088:1218/071720.166:FATAL:native_window_occlusion_tracker_win.cc(420)] Check failed: FALSE. A root window did not get its occlusion state set > Backtrace: > base::debug::CollectStackTrace [0x6F2A256C+60] (o:\base\debug\stack_trace_win.cc:284) > base::debug::StackTrace::StackTrace [0x6EFAA18E+78] (o:\base\debug\stack_trace.cc:206) > base::debug::StackTrace::StackTrace [0x6EFAA102+34] (o:\base\debug\stack_trace.cc:203) > logging::LogMessage::~LogMessage [0x6EFE9AC0+144] (o:\base\logging.cc:628) > aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::ComputeNativeWindowOcclusionStatus [0x647E0ADC+1660] (o:\ui\aura\native_window_occlusion_tracker_win.cc:418) > base::internal::FunctorTraits<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),void>::Invoke<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),aura: [0x647F372C+28] (o:\base\bind_internal.h:498) > base::internal::InvokeHelper<0,void>::MakeItSo<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator *> [0x647F369F+79] (o:\base\bind_internal.h:598) > base::internal::Invoker<base::internal::BindState<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),base::internal::UnretainedWrapper<aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator> >, [0x647F35F5+85] (o:\base\bind_internal.h:671) > base::internal::Invoker<base::internal::BindState<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),base::internal::UnretainedWrapper<aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator> >, [0x647F3584+84] (o:\base\bind_internal.h:640) > base::OnceCallback<void ()>::Run [0x6EF62360+80] (o:\base\callback.h:99) > base::OneShotTimer::RunUserTask [0x6F1F8DB9+265] (o:\base\timer\timer.cc:265) > base::internal::TimerBase::RunScheduledTask [0x6F1F88D5+293] (o:\base\timer\timer.cc:227) > base::internal::BaseTimerTaskInternal::Run [0x6F1F875C+60] (o:\base\timer\timer.cc:50) > base::internal::FunctorTraits<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),void>::Invoke<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),base::internal::BaseTimerTaskInternal *> [0x6F1F9CAC+28] (o:\base\bind_internal.h:498) > base::internal::InvokeHelper<0,void>::MakeItSo<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),base::internal::BaseTimerTaskInternal *> [0x6F1F9C0F+79] (o:\base\bind_internal.h:598) > base::internal::Invoker<base::internal::BindState<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),base::internal::OwnedWrapper<base::internal::BaseTimerTaskInternal> >,void ()>::RunImpl<void (base::internal::BaseTimerTaskIntern [0x6F1F9B65+85] (o:\base\bind_internal.h:671) > base::internal::Invoker<base::internal::BindState<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),base::internal::OwnedWrapper<base::internal::BaseTimerTaskInternal> >,void ()>::RunOnce [0x6F1F9AF4+84] (o:\base\bind_internal.h:640) > base::OnceCallback<void ()>::Run [0x6EF62360+80] (o:\base\callback.h:99) > base::TaskAnnotator::RunTask [0x6F116BF7+1447] (o:\base\task\common\task_annotator.cc:144) > base::internal::TaskTracker::RunSkipOnShutdown [0x6F1A354D+61] (o:\base\task\thread_pool\task_tracker.cc:778) > base::internal::TaskTracker::RunTaskWithShutdownBehavior [0x6F1A2C1C+108] (o:\base\task\thread_pool\task_tracker.cc:796) > base::internal::TaskTracker::RunTask [0x6F1A2289+2521] (o:\base\task\thread_pool\task_tracker.cc:639) > base::internal::TaskTracker::RunAndPopNextTask [0x6F1A0FA6+598] (o:\base\task\thread_pool\task_tracker.cc:512) > base::internal::WorkerThread::RunWorker [0x6F1C47CE+2270] (o:\base\task\thread_pool\worker_thread.cc:321) > base::internal::WorkerThread::RunSharedCOMWorker [0x6F1C3E92+34] (o:\base\task\thread_pool\worker_thread.cc:261) > base::internal::WorkerThread::ThreadMain [0x6F1C3C3A+250] (o:\base\task\thread_pool\worker_thread.cc:213) > base::`anonymous namespace'::ThreadFunc [0x6F2CCF4D+301] (o:\base\threading\platform_thread_win.cc:112) > BaseThreadInitThunk [0x7740343D+18] > RtlInitializeExceptionChain [0x77919802+99] > RtlInitializeExceptionChain [0x779197D5+54] > Task trace: > Backtrace: > aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::ScheduleOcclusionCalculationIfNeeded [0x647DF4F2+290] (o:\ui\aura\native_window_occlusion_tracker_win.cc:433) > aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::ProcessEventHookCallback [0x647DFBB4+324] (o:\ui\aura\native_window_occlusion_tracker_win.cc:600) > > Original change's description: > > Use unoccluded desktop region to calculate root window occlusion. > > > > Bug: 1029842 > > Change-Id: I285c8dec077575ce246c476645e2ff4a3294124c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951775 > > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#725750} > > TBR=chrisha@chromium.org,fdoray@chromium.org,davidbienvenu@chromium.org > > Change-Id: I3de865e1e2bfbc0178f117ff5756394b52f1de88 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1029842 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974052 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725993} TBR=ellyjones@chromium.org,chrisha@chromium.org,fdoray@chromium.org,davidbienvenu@chromium.org Change-Id: I1d0f6c775e184c990272c8ea4453956e51f2b13b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974621Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42ca02723716..3624da9ce38b Created with: gclient setdep -r src-internal@3624da9ce38b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022512 Tbr: jbudorick@google.com Change-Id: I8810dbb9d050f939a3adaafddbdcd144f4e9e5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991721Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729384}
-
Tibor Goldschwendt authored
Bug: 1032327 Change-Id: I6709adfb764348cca75c06115613449d6ffaf095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983212 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729383}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6403f2fe61d2d3ae1e89832cbb5a817ee71528d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991587Reviewed-by:
-
Xing Liu authored
The current libsqlite4java.so read by Robolectric is a symlink. Someone with cipd permission needs to update the package after this change submitted. Bug: 1035701 Change-Id: Ic7f629fc48b0f4f3893d477f3651bcf03c1b0a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989860Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729381}
-
Sandro Maggi authored
This reverts commit 28ffd7d7. Reason for revert: This change breaks the "shadow" on the top border of the bottom sheet. Original change's description: > BottomSheet background color. > > This fixes the bottom sheet background color across the board to use > "default_bg_color_elev_3". Doing this here allows to keep the rounded > top. > > "default_bg_color_elev_3" is chosen as a standin for "default_bg_color" > which is not yet available. See also here: > * crbug/1002594 > * crrev/c/1798348 > > Light mode: https://screenshot.googleplex.com/d1T3vfBAxzn > Dark mode: https://screenshot.googleplex.com/xQAVqz7qNbg > > Bug: 1035985 > Bug: b/146412594 > Change-Id: I7c0652bcfc799cd233ce6c793459427461ad9af6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974150 > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Sandro Maggi <sandromaggi@google.com> > Cr-Commit-Position: refs/heads/master@{#726780} TBR=mdjones@google.com,mdjones@chromium.org,arbesser@google.com,sandromaggi@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/146412594 Bug: 1036757 Bug: b/147343555 Change-Id: Ief00f61c7088f1e4f1437fd8760c68c39ca1dc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991562Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#729380}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 148 histograms that show frequent access in the past 90 days. These are the 82% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-07-06. Change-Id: Ia839f2f9da8ba083b62b6b58596a37dc86e853be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991660 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#729379}
-
Ioana Pandele authored
This test has been flaking on multiple bots. While the failure is not locally reproducible, flushing the client might fix it. Bug:1036807 Change-Id: Ib6c0bd08e71406ffac371add2ca097ba3393608e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991440Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#729378}
-
Vladimir Levin authored
This patch ensures that we put the search ticks at the position where the locked roots are located. This is the only reliable spot that has to have up to date layout. Any element under such a root may have out of date (or non-existent) layout information. Bug: 1030018 R=chrishtr@chromium.org, rakina@chromium.org Change-Id: I079ef63ecdab41a1434baf9ad200b4b943496423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984358 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729377}
-
Lin Sun authored
This reverts commit 1cdb246f. Reason for revert: Potential performance regression in http://crbug.com/1032210 Original change's description: > Fixed WebGL flush bug for old Intel driver > > Add a workaround to do extra flush() before and after BindFrameBuffer > call if Intel graphics driver is older then 24.20.100.6286(August 30, > 2018). > > Verified this patch on Intel UHD Graphics 620 (23.20.16.4973) with the > attachment flush-bug.html from issue 1018028, which is provided by the > reporter to reproduce this bug. > > Bug: 1018028 > Change-Id: Iea220f5e5f2bbeeac87c92f761a44a36c5efe72b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912790 > Commit-Queue: Lin Sun <lin.sun@intel.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722827} Bug: 1018028, 1032210 Change-Id: I8a6759b08d5b3609e8e03ceeed02c180748a57a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987315 Commit-Queue: Lin Sun <lin.sun@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#729376}
-
